0
0
mirror of https://github.com/vim/vim.git synced 2025-09-30 04:44:14 -04:00

patch 8.1.0630: "wincmd p" does not work after using an autocmd window

Problem:   "wincmd p" does not work after using an autocmd window.
Solution:   Store "prevwin" in aco_save_T. (Christian Brabandt, closes #3690)
This commit is contained in:
Bram Moolenaar
2018-12-24 00:22:39 +01:00
parent 5d24a2257e
commit a42df5934b
4 changed files with 45 additions and 0 deletions

View File

@@ -9017,6 +9017,7 @@ aucmd_prepbuf(
aco->save_curwin = curwin; aco->save_curwin = curwin;
aco->save_curbuf = curbuf; aco->save_curbuf = curbuf;
aco->save_prevwin = prevwin;
if (win != NULL) if (win != NULL)
{ {
/* There is a window for "buf" in the current tab page, make it the /* There is a window for "buf" in the current tab page, make it the
@@ -9127,6 +9128,8 @@ win_found:
else else
/* Hmm, original window disappeared. Just use the first one. */ /* Hmm, original window disappeared. Just use the first one. */
curwin = firstwin; curwin = firstwin;
if (win_valid(aco->save_prevwin))
prevwin = aco->save_prevwin;
#ifdef FEAT_EVAL #ifdef FEAT_EVAL
vars_clear(&aucmd_win->w_vars->dv_hashtab); /* free all w: variables */ vars_clear(&aucmd_win->w_vars->dv_hashtab); /* free all w: variables */
hash_init(&aucmd_win->w_vars->dv_hashtab); /* re-use the hashtab */ hash_init(&aucmd_win->w_vars->dv_hashtab); /* re-use the hashtab */
@@ -9177,6 +9180,8 @@ win_found:
curwin = aco->save_curwin; curwin = aco->save_curwin;
curbuf = curwin->w_buffer; curbuf = curwin->w_buffer;
if (win_valid(aco->save_prevwin))
prevwin = aco->save_prevwin;
/* In case the autocommand move the cursor to a position that that /* In case the autocommand move the cursor to a position that that
* not exist in curbuf. */ * not exist in curbuf. */
check_cursor(); check_cursor();

View File

@@ -3252,6 +3252,7 @@ typedef struct
int use_aucmd_win; /* using aucmd_win */ int use_aucmd_win; /* using aucmd_win */
win_T *save_curwin; /* saved curwin */ win_T *save_curwin; /* saved curwin */
win_T *new_curwin; /* new curwin */ win_T *new_curwin; /* new curwin */
win_T *save_prevwin; /* saved prevwin */
bufref_T new_curbuf; /* new curbuf */ bufref_T new_curbuf; /* new curbuf */
char_u *globaldir; /* saved value of globaldir */ char_u *globaldir; /* saved value of globaldir */
} aco_save_T; } aco_save_T;

View File

@@ -578,4 +578,41 @@ func Test_winrestcmd()
only only
endfunc endfunc
function! Fun_RenewFile()
sleep 2
silent execute '!echo "1" > tmp.txt'
sp
wincmd p
edit! tmp.txt
endfunction
func Test_window_prevwin()
" Can we make this work on MS-Windows?
if !has('unix')
return
endif
set hidden autoread
call writefile(['2'], 'tmp.txt')
new tmp.txt
q
" Need to wait a bit for the timestamp to be older.
call Fun_RenewFile()
call assert_equal(2, winnr())
wincmd p
call assert_equal(1, winnr())
wincmd p
q
call Fun_RenewFile()
call assert_equal(2, winnr())
wincmd p
call assert_equal(1, winnr())
wincmd p
" reset
q
call delete('tmp.txt')
set hidden&vim autoread&vim
delfunc Fun_RenewFile
endfunc
" vim: shiftwidth=2 sts=2 expandtab " vim: shiftwidth=2 sts=2 expandtab

View File

@@ -799,6 +799,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
630,
/**/ /**/
629, 629,
/**/ /**/