aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-24 03:44:06 -04:00
Code Activity

patch 8.2.4248: no proper test for moving the window separator

Browse Source 
Problem:    No proper test for moving the window separator.
Solution:   Add a test.  Add comment in code. (closes #9656)
This commit is contained in:
zeertzjq
2022-01-29 10:59:53 +00:00
committed by Bram Moolenaar
parent 06f15416bb
commit a0c4e2f2d7
3 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/testdir/test_window_cmd.vim
View File

@@ -1424,6 +1424,12 @@ func Test_win_move_separator()
call assert_true(id->win_move_separator(-offset)) call assert_true(id->win_move_separator(-offset))
call assert_equal(w, winwidth(id)) call assert_equal(w, winwidth(id))
endfor endfor
" check win_move_separator from right window on right window is no-op
let w0 = winwidth(0)
call assert_true(win_move_separator(0, 1))
call assert_equal(w0, winwidth(0))
call assert_true(win_move_separator(0, -1))
call assert_equal(w0, winwidth(0))
" check that win_move_separator doesn't error with offsets beyond moving " check that win_move_separator doesn't error with offsets beyond moving
" possibility " possibility
call assert_true(win_move_separator(id, 5000)) call assert_true(win_move_separator(id, 5000))
@@ -1465,6 +1471,19 @@ func Test_win_move_statusline()
call assert_true(win_move_statusline(1, -offset)) call assert_true(win_move_statusline(1, -offset))
call assert_equal(h, winheight(1)) call assert_equal(h, winheight(1))
endfor endfor
" check win_move_statusline from bottom window on bottom window
let h0 = winheight(0)
for offset in range(5)
call assert_true(0->win_move_statusline(-offset))
call assert_equal(h0 - offset, winheight(0))
call assert_equal(1 + offset, &cmdheight)
call assert_true(win_move_statusline(0, offset))
call assert_equal(h0, winheight(0))
call assert_equal(1, &cmdheight)
endfor
call assert_true(win_move_statusline(0, 1))
call assert_equal(h0, winheight(0))
call assert_equal(1, &cmdheight)
" check win_move_statusline from bottom window on top window ID " check win_move_statusline from bottom window on top window ID
let id = win_getid(1) let id = win_getid(1)
for offset in range(5) for offset in range(5)

2
src/version.c
View File

@@ -750,6 +750,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
4248,
/**/ /**/
4247, 4247,
/**/ /**/

4
src/window.c
View File

@@ -6187,7 +6187,9 @@ win_drag_vsep_line(win_T *dragwin, int offset)
if (offset <= 0) // No room at all, quit. if (offset <= 0) // No room at all, quit.
return; return;
if (fr == NULL) if (fr == NULL)
return; // Safety check, should not happen. // This can happen when calling win_move_separator() on the rightmost
// window. Just don't do anything.
return;
// grow frame fr by offset lines // grow frame fr by offset lines
frame_new_width(fr, fr->fr_width + offset, left, FALSE); frame_new_width(fr, fr->fr_width + offset, left, FALSE);