0
0
mirror of https://github.com/vim/vim.git synced 2025-09-24 03:44:06 -04:00

patch 8.2.5102: interrupt not caught in test

Problem:    Interrupt not caught in test.
Solution:   Consider an exception thrown in the current try/catch when got_int
            is set.  Also catch early exit when not using try/catch.
This commit is contained in:
Bram Moolenaar
2022-06-15 20:49:35 +01:00
parent cf65d88ff8
commit 8bea171f15
5 changed files with 31 additions and 12 deletions

View File

@@ -1781,7 +1781,9 @@ ex_retab(exarg_T *eap)
if (vcol >= MAXCOL)
{
emsg(_(e_resulting_text_too_long));
// set got_int to break out of any loop
// when not inside a try/catch set got_int to break out of any
// loop
if (trylevel == 0)
got_int = TRUE;
break;
}

View File

@@ -201,6 +201,7 @@ func RunTheTest(test)
endtry
endif
au VimLeavePre * call EarlyExit(g:testfunc)
if a:test =~ 'Test_nocatch_'
" Function handles errors itself. This avoids skipping commands after the
" error.
@@ -212,9 +213,7 @@ func RunTheTest(test)
endif
else
try
au VimLeavePre * call EarlyExit(g:testfunc)
exe 'call ' . a:test
au! VimLeavePre
catch /^\cskipped/
call add(s:messages, ' Skipped')
call add(s:skipped, 'SKIPPED ' . a:test . ': ' . substitute(v:exception, '^\S*\s\+', '', ''))
@@ -222,6 +221,7 @@ func RunTheTest(test)
call add(v:errors, 'Caught exception in ' . a:test . ': ' . v:exception . ' @ ' . v:throwpoint)
endtry
endif
au! VimLeavePre
" In case 'insertmode' was set and something went wrong, make sure it is
" reset to avoid trouble with anything else.

View File

@@ -82,20 +82,34 @@ func Test_retab_error()
call assert_fails('ret 80000000000000000000', 'E475:')
endfunc
" FIXME: the try/catch does not catch the interrupt
func FIXME_Test_retab_endless()
new
call setline(1, "\t0\t")
let caught = 'no'
try
func RetabLoop()
while 1
set ts=4000
retab 4
endwhile
catch
endfunc
func Test_retab_endless()
" inside try/catch we catch the error message
new
call setline(1, "\t0\t")
let caught = 'no'
try
call RetabLoop()
catch /E1240:/
let caught = v:exception
endtry
call assert_notequal('no', caught)
call assert_match('E1240:', caught)
bwipe!
set tabstop&
endfunc
func Test_nocatch_retab_endless()
" not inside try/catch an interrupt is generated to get out of loops
new
call setline(1, "\t0\t")
call assert_fails('call RetabLoop()', ['E1240:', 'Interrupted'])
bwipe!
set tabstop&
endfunc

View File

@@ -742,6 +742,7 @@ theend:
suppress_errthrow = FALSE;
in_assert_fails = FALSE;
did_emsg = FALSE;
got_int = FALSE;
msg_col = 0;
need_wait_return = FALSE;
emsg_on_display = FALSE;

View File

@@ -734,6 +734,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
5102,
/**/
5101,
/**/