aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-27 04:14:06 -04:00
Code Activity

patch 8.2.4218: illegal memory access with bracketed paste in Ex mode

Browse Source 
Problem:    Illegal memory access with bracketed paste in Ex mode.
Solution:   Reserve space for the trailing NUL.
This commit is contained in:
Bram Moolenaar
2022-01-25 20:45:16 +00:00
parent 8d02ce1ed7
commit 806d037671
3 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/edit.c
View File

@@ -4452,7 +4452,8 @@ bracketed_paste(paste_mode_T mode, int drop, garray_T *gap)
break; break;
case PASTE_EX: case PASTE_EX:
if (gap != NULL && ga_grow(gap, idx) == OK) // add one for the NUL that is going to be appended
if (gap != NULL && ga_grow(gap, idx + 1) == OK)
{ {
mch_memmove((char *)gap->ga_data + gap->ga_len, mch_memmove((char *)gap->ga_data + gap->ga_len,
buf, (size_t)idx); buf, (size_t)idx);

3
src/testdir/test_paste.vim
View File

@@ -90,6 +90,9 @@ func Test_paste_ex_mode()
unlet! foo unlet! foo
call feedkeys("Qlet foo=\"\<Esc>[200~foo\<CR>bar\<Esc>[201~\"\<CR>vi\<CR>", 'xt') call feedkeys("Qlet foo=\"\<Esc>[200~foo\<CR>bar\<Esc>[201~\"\<CR>vi\<CR>", 'xt')
call assert_equal("foo\rbar", foo) call assert_equal("foo\rbar", foo)
" pasting more than 40 bytes
exe "norm Q\<PasteStart>0000000000000000000000000000000000000000000000000000000000000000000000\<C-C>"
endfunc endfunc
func Test_paste_onechar() func Test_paste_onechar()

2
src/version.c
View File

@@ -750,6 +750,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
4218,
/**/ /**/
4217, 4217,
/**/ /**/