aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-24 03:44:06 -04:00
Code Activity

patch 8.1.1010: Lua interface leaks memory

Browse Source 
Problem:    Lua interface leaks memory.
Solution:   Clear typeval after copying it.
This commit is contained in:
Bram Moolenaar
2019-03-16 16:38:41 +01:00
parent 1f271efbbb
commit 713bf9e996
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/if_lua.c
View File

@@ -844,10 +844,7 @@ luaV_list_add (lua_State *L)
lua_settop(L, 2); lua_settop(L, 2);
luaV_checktypval(L, 2, &v, "adding list item"); luaV_checktypval(L, 2, &v, "adding list item");
if (list_append_tv(l, &v) == FAIL) if (list_append_tv(l, &v) == FAIL)
{
clear_tv(&v);
luaL_error(L, "failed to add item to list"); luaL_error(L, "failed to add item to list");
}
clear_tv(&v); clear_tv(&v);
lua_settop(L, 1); lua_settop(L, 1);
return 1; return 1;
@@ -872,10 +869,7 @@ luaV_list_insert (lua_State *L)
lua_settop(L, 2); lua_settop(L, 2);
luaV_checktypval(L, 2, &v, "inserting list item"); luaV_checktypval(L, 2, &v, "inserting list item");
if (list_insert_tv(l, &v, li) == FAIL) if (list_insert_tv(l, &v, li) == FAIL)
{
clear_tv(&v);
luaL_error(L, "failed to add item to list"); luaL_error(L, "failed to add item to list");
}
clear_tv(&v); clear_tv(&v);
lua_settop(L, 1); lua_settop(L, 1);
return 1; return 1;
@@ -981,6 +975,7 @@ luaV_dict_newindex(lua_State *L)
char_u *key = (char_u *) luaL_checkstring(L, 2); char_u *key = (char_u *) luaL_checkstring(L, 2);
dictitem_T *di; dictitem_T *di;
typval_T v; typval_T v;
if (d->dv_lock) if (d->dv_lock)
luaL_error(L, "dict is locked"); luaL_error(L, "dict is locked");
if (key == NULL) if (key == NULL)
@@ -1104,6 +1099,7 @@ luaV_funcref_call(lua_State *L)
{ {
luaV_checktypval(L, i + 2, &v, "calling funcref"); luaV_checktypval(L, i + 2, &v, "calling funcref");
list_append_tv(f->args.vval.v_list, &v); list_append_tv(f->args.vval.v_list, &v);
clear_tv(&v);
} }
status = func_call(f->tv.vval.v_string, &f->args, status = func_call(f->tv.vval.v_string, &f->args,
NULL, f->self, &rettv); NULL, f->self, &rettv);
@@ -1571,6 +1567,7 @@ luaV_list(lua_State *L)
{ {
luaV_checktypval(L, -1, &v, "vim.list"); luaV_checktypval(L, -1, &v, "vim.list");
list_append_tv(l, &v); list_append_tv(l, &v);
clear_tv(&v);
} }
lua_pop(L, 1); /* value */ lua_pop(L, 1); /* value */
} while (notnil); } while (notnil);

2
src/version.c
View File

@@ -779,6 +779,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
1010,
/**/ /**/
1009, 1009,
/**/ /**/