aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-25 03:54:15 -04:00
Code Activity

patch 8.2.5006: asan warns for undefined behavior

Browse Source 
Problem:    Asan warns for undefined behavior.
Solution:   Cast the shifted value to unsigned.
This commit is contained in:
Bram Moolenaar
2022-05-22 22:07:52 +01:00
parent 5b529230f1
commit 68e64d2c17
4 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/eval.c
View File

@@ -3089,7 +3089,7 @@ eval5(char_u **arg, typval_T *rettv, evalarg_T *evalarg)
rettv->vval.v_number = 0; rettv->vval.v_number = 0;
else if (type == EXPR_LSHIFT) else if (type == EXPR_LSHIFT)
rettv->vval.v_number = rettv->vval.v_number =
rettv->vval.v_number << var2.vval.v_number; (uvarnumber_T)rettv->vval.v_number << var2.vval.v_number;
else else
rettv->vval.v_number = rettv->vval.v_number =
(uvarnumber_T)rettv->vval.v_number >> var2.vval.v_number; (uvarnumber_T)rettv->vval.v_number >> var2.vval.v_number;

2
src/version.c
View File

@@ -734,6 +734,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
5006,
/**/ /**/
5005, 5005,
/**/ /**/

2
src/vim9execute.c
View File

@@ -4091,7 +4091,7 @@ exec_instructions(ectx_T *ectx)
case EXPR_LSHIFT: if (arg2 > MAX_LSHIFT_BITS) case EXPR_LSHIFT: if (arg2 > MAX_LSHIFT_BITS)
res = 0; res = 0;
else else
res = arg1 << arg2; res = (uvarnumber_T)arg1 << arg2;
break; break;
case EXPR_RSHIFT: if (arg2 > MAX_LSHIFT_BITS) case EXPR_RSHIFT: if (arg2 > MAX_LSHIFT_BITS)
res = 0; res = 0;

3
src/vim9expr.c
View File

@@ -2716,7 +2716,8 @@ compile_expr5(char_u **arg, cctx_T *cctx, ppconst_T *ppconst)
if (tv2->vval.v_number > MAX_LSHIFT_BITS) if (tv2->vval.v_number > MAX_LSHIFT_BITS)
tv1->vval.v_number = 0; tv1->vval.v_number = 0;
else if (type == EXPR_LSHIFT) else if (type == EXPR_LSHIFT)
tv1->vval.v_number = tv1->vval.v_number << tv2->vval.v_number; tv1->vval.v_number =
(uvarnumber_T)tv1->vval.v_number << tv2->vval.v_number;
else else
tv1->vval.v_number = tv1->vval.v_number =
(uvarnumber_T)tv1->vval.v_number >> tv2->vval.v_number; (uvarnumber_T)tv1->vval.v_number >> tv2->vval.v_number;