aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-23 03:43:49 -04:00
Code Activity

patch 8.1.0644: finding next sign ID is inefficient

Browse Source 
Problem:    Finding next sign ID is inefficient.
Solution:   Add next_sign_id. (Yegappan Lakshmanan, closes #3717)
This commit is contained in:
Bram Moolenaar
2018-12-27 00:28:33 +01:00
parent 00b1e04165
commit 6436cd83f9
10 changed files with 86 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/ex_cmds.c
View File

@@ -7871,16 +7871,7 @@ sign_place(
return FAIL;
}
if (*sign_id == 0)
{
// Allocate a new sign id
int id = 1;
signlist_T *sign;
while ((sign = buf_getsign_with_id(buf, id, sign_group)) != NULL)
id++;
*sign_id = id;
}
*sign_id = sign_group_get_next_signid(buf, sign_group);
if (lnum > 0)
// ":sign place {id} line={lnum} name={name} file={fname}":
@@ -8193,7 +8184,7 @@ ex_sign(exarg_T *eap)
else if (idx == SIGNCMD_JUMP)
{
/* ":sign jump {id} file={fname}" */
if (lnum >= 0 || sign_name != NULL)
if (lnum >= 0 || sign_name != NULL || buf == NULL)
EMSG(_(e_invarg));
else if ((lnum = buf_findsign(buf, id, group)) > 0)
{ /* goto a sign ... */
@@ -8350,7 +8341,7 @@ sign_get_placed_in_buf(
return;
dict_add_list(d, "signs", l);
FOR_ALL_SIGNS_IN_BUF(buf)
FOR_ALL_SIGNS_IN_BUF(buf, sign)
{
if (!sign_in_group(sign, sign_group))
continue;