aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-29 04:34:16 -04:00
Code Activity

patch 9.0.2150: Using int for errbuflen in option funcs

Browse Source 
Problem:  Using int for errbuflen in option funcs
Solution: Use size_t for errbuflen in string option functions

Use size_t for errbuflen in string option functions

This started as size_t to int warning on Windows in
do_set_option_string().  Other option setting functions are using size_t
for errbuflen so I changed the type in the argument list and then chased
further compiler warnings into the string option functions in
optionstr.c changing ints to size_t as I went.

I also changed the type of os_errbuflen in optset_T to size_t and
updated related argument lists in optionstr.c, as well as updating
set_string_option() to also use size_t for errbuflen for consistency
with other string option setting functions.

closes: #13628

Signed-off-by: Mike Williams <mikew@globalgraphics.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Mike Williams
2023-12-05 15:36:06 +01:00
committed by Christian Brabandt
parent 5dd41d4b63
commit 620f011694
5 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/optionstr.c
View File

@@ -229,7 +229,7 @@ trigger_optionset_string(
#endif
static char *
illegal_char(char *errbuf, int errbuflen, int c)
illegal_char(char *errbuf, size_t errbuflen, int c)
{
if (errbuf == NULL)
return "";
@@ -527,7 +527,7 @@ set_string_option(
char_u *value,
int opt_flags, // OPT_LOCAL and/or OPT_GLOBAL
char *errbuf,
int errbuflen)
size_t errbuflen)
{
char_u *s;
char_u **varp;
@@ -726,7 +726,7 @@ did_set_option_listflag(
char_u *val,
char_u *flags,
char *errbuf,
int errbuflen)
size_t errbuflen)
{
char_u *s;
@@ -4354,7 +4354,7 @@ did_set_string_option(
char_u *oldval, // previous value of the option
char_u *value, // new value of the option
char *errbuf, // buffer for errors, or NULL
int errbuflen, // length of error buffer
size_t errbuflen, // length of error buffer
int opt_flags, // OPT_LOCAL and/or OPT_GLOBAL
set_op_T op, // OP_ADDING/OP_PREPENDING/OP_REMOVING
int *value_checked) // value was checked to be safe, no