From 2472ae81dff8c30f5d63db8ad2c937deae8be646 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Sat, 23 Feb 2019 15:04:17 +0100 Subject: [PATCH] patch 8.1.0978: blob not tested with Perl Problem: Blob not tested with Perl. Solution: Add more test coverage. Fixes a crash. (Dominique Pelle, closes #4037) --- src/if_perl.xs | 2 +- src/testdir/test_perl.vim | 7 +++++++ src/version.c | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/if_perl.xs b/src/if_perl.xs index 2655640755..099d386776 100644 --- a/src/if_perl.xs +++ b/src/if_perl.xs @@ -1570,7 +1570,7 @@ Blob(SV* sv) newsv = newSVpv("0z", 2); for (i = 0; i < len; i++) { - sprintf(buf, "%02X", s[i]); + sprintf(buf, "%02X", (unsigned char)(s[i])); sv_catpvn(newsv, buf, 2); } RETVAL = newsv; diff --git a/src/testdir/test_perl.vim b/src/testdir/test_perl.vim index 03c5fa0d10..e24c04f7ce 100644 --- a/src/testdir/test_perl.vim +++ b/src/testdir/test_perl.vim @@ -29,6 +29,13 @@ EOF call assert_equal('abc/def/', getline('$')) endfunc +funct Test_VIM_Blob() + call assert_equal('0z', perleval('VIM::Blob("")')) + call assert_equal('0z31326162', perleval('VIM::Blob("12ab")')) + call assert_equal('0z00010203', perleval('VIM::Blob("\x00\x01\x02\x03")')) + call assert_equal('0z8081FEFF', perleval('VIM::Blob("\x80\x81\xfe\xff")')) +endfunc + func Test_buffer_Delete() new call setline(1, ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h']) diff --git a/src/version.c b/src/version.c index 8d22ca90e6..850c27dcd4 100644 --- a/src/version.c +++ b/src/version.c @@ -779,6 +779,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 978, /**/ 977, /**/