mirror of
https://github.com/vim/vim.git
synced 2025-10-14 07:04:10 -04:00
patch 8.1.1007: using closure may consume a lot of memory
Problem: Using closure may consume a lot of memory. Solution: unreference items that are no longer needed. Add a test. (Ozaki Kiichi, closes #3961)
This commit is contained in:
144
src/testdir/test_memory_usage.vim
Normal file
144
src/testdir/test_memory_usage.vim
Normal file
@@ -0,0 +1,144 @@
|
||||
" Tests for memory usage.
|
||||
|
||||
if !has('terminal') || has('gui_running') || $ASAN_OPTIONS !=# ''
|
||||
" Skip tests on Travis CI ASAN build because it's difficult to estimate
|
||||
" memory usage.
|
||||
finish
|
||||
endif
|
||||
|
||||
source shared.vim
|
||||
|
||||
func s:pick_nr(str) abort
|
||||
return substitute(a:str, '[^0-9]', '', 'g') * 1
|
||||
endfunc
|
||||
|
||||
if has('win32')
|
||||
if !executable('wmic')
|
||||
finish
|
||||
endif
|
||||
func s:memory_usage(pid) abort
|
||||
let cmd = printf('wmic process where processid=%d get WorkingSetSize', a:pid)
|
||||
return s:pick_nr(system(cmd)) / 1024
|
||||
endfunc
|
||||
elseif has('unix')
|
||||
if !executable('ps')
|
||||
finish
|
||||
endif
|
||||
func s:memory_usage(pid) abort
|
||||
return s:pick_nr(system('ps -o rss= -p ' . a:pid))
|
||||
endfunc
|
||||
else
|
||||
finish
|
||||
endif
|
||||
|
||||
" Wait for memory usage to level off.
|
||||
func s:monitor_memory_usage(pid) abort
|
||||
let proc = {}
|
||||
let proc.pid = a:pid
|
||||
let proc.hist = []
|
||||
let proc.min = 0
|
||||
let proc.max = 0
|
||||
|
||||
func proc.op() abort
|
||||
" Check the last 200ms.
|
||||
let val = s:memory_usage(self.pid)
|
||||
if self.min > val
|
||||
let self.min = val
|
||||
elseif self.max < val
|
||||
let self.max = val
|
||||
endif
|
||||
call add(self.hist, val)
|
||||
if len(self.hist) < 20
|
||||
return 0
|
||||
endif
|
||||
let sample = remove(self.hist, 0)
|
||||
return len(uniq([sample] + self.hist)) == 1
|
||||
endfunc
|
||||
|
||||
call WaitFor({-> proc.op()}, 10000)
|
||||
return {'last': get(proc.hist, -1), 'min': proc.min, 'max': proc.max}
|
||||
endfunc
|
||||
|
||||
let s:term_vim = {}
|
||||
|
||||
func s:term_vim.start(...) abort
|
||||
let self.buf = term_start([GetVimProg()] + a:000)
|
||||
let self.job = term_getjob(self.buf)
|
||||
call WaitFor({-> job_status(self.job) ==# 'run'})
|
||||
let self.pid = job_info(self.job).process
|
||||
endfunc
|
||||
|
||||
func s:term_vim.stop() abort
|
||||
call term_sendkeys(self.buf, ":qall!\<CR>")
|
||||
call WaitFor({-> job_status(self.job) ==# 'dead'})
|
||||
exe self.buf . 'bwipe!'
|
||||
endfunc
|
||||
|
||||
func s:vim_new() abort
|
||||
return copy(s:term_vim)
|
||||
endfunc
|
||||
|
||||
func Test_memory_func_capture_vargs()
|
||||
" Case: if a local variable captures a:000, funccall object will be free
|
||||
" just after it finishes.
|
||||
let testfile = 'Xtest.vim'
|
||||
call writefile([
|
||||
\ 'func s:f(...)',
|
||||
\ ' let x = a:000',
|
||||
\ 'endfunc',
|
||||
\ 'for _ in range(10000)',
|
||||
\ ' call s:f(0)',
|
||||
\ 'endfor',
|
||||
\ ], testfile)
|
||||
|
||||
let vim = s:vim_new()
|
||||
call vim.start('--clean', '-c', 'set noswapfile', testfile)
|
||||
let before = s:monitor_memory_usage(vim.pid).last
|
||||
|
||||
call term_sendkeys(vim.buf, ":so %\<CR>")
|
||||
call WaitFor({-> term_getcursor(vim.buf)[0] == 1})
|
||||
let after = s:monitor_memory_usage(vim.pid)
|
||||
|
||||
" Estimate the limit of max usage as 2x initial usage.
|
||||
call assert_inrange(before, 2 * before, after.max)
|
||||
" In this case, garbase collecting is not needed.
|
||||
call assert_equal(after.last, after.max)
|
||||
|
||||
call vim.stop()
|
||||
call delete(testfile)
|
||||
endfunc
|
||||
|
||||
func Test_memory_func_capture_lvars()
|
||||
" Case: if a local variable captures l: dict, funccall object will not be
|
||||
" free until garbage collector runs, but after that memory usage doesn't
|
||||
" increase so much even when rerun Xtest.vim since system memory caches.
|
||||
let testfile = 'Xtest.vim'
|
||||
call writefile([
|
||||
\ 'func s:f()',
|
||||
\ ' let x = l:',
|
||||
\ 'endfunc',
|
||||
\ 'for _ in range(10000)',
|
||||
\ ' call s:f()',
|
||||
\ 'endfor',
|
||||
\ ], testfile)
|
||||
|
||||
let vim = s:vim_new()
|
||||
call vim.start('--clean', '-c', 'set noswapfile', testfile)
|
||||
let before = s:monitor_memory_usage(vim.pid).last
|
||||
|
||||
call term_sendkeys(vim.buf, ":so %\<CR>")
|
||||
call WaitFor({-> term_getcursor(vim.buf)[0] == 1})
|
||||
let after = s:monitor_memory_usage(vim.pid)
|
||||
|
||||
" Rerun Xtest.vim.
|
||||
for _ in range(3)
|
||||
call term_sendkeys(vim.buf, ":so %\<CR>")
|
||||
call WaitFor({-> term_getcursor(vim.buf)[0] == 1})
|
||||
let last = s:monitor_memory_usage(vim.pid).last
|
||||
endfor
|
||||
|
||||
call assert_inrange(before, after.max + (after.last - before), last)
|
||||
|
||||
call vim.stop()
|
||||
call delete(testfile)
|
||||
endfunc
|
Reference in New Issue
Block a user