aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-27 04:14:06 -04:00
Code Activity

patch 8.2.2795: Coverity warns for not using return value

Browse Source 
Problem:    Coverity warns for not using return value.
Solution:   Check the return value of compiling the substitute expression.
This commit is contained in:
Bram Moolenaar
2021-04-21 12:19:35 +02:00
parent 16678eb50f
commit 169502fb0b
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/version.c
View File

@@ -750,6 +750,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
2795,
/**/ /**/
2794, 2794,
/**/ /**/

8
src/vim9compile.c
View File

@@ -6511,7 +6511,7 @@ compile_assignment(char_u *arg, exarg_T *eap, cmdidx_T cmdidx, cctx_T *cctx)
{ {
// skip over the "=" and the expression // skip over the "=" and the expression
p = skipwhite(op + oplen); p = skipwhite(op + oplen);
compile_expr0(&p, cctx); (void)compile_expr0(&p, cctx);
} }
} }
else if (oplen > 0) else if (oplen > 0)
@@ -8525,6 +8525,7 @@ compile_substitute(char_u *arg, exarg_T *eap, cctx_T *cctx)
{ {
garray_T save_ga = cctx->ctx_instr; garray_T save_ga = cctx->ctx_instr;
char_u *end; char_u *end;
int expr_res;
int trailing_error; int trailing_error;
int instr_count; int instr_count;
isn_T *instr = NULL; isn_T *instr = NULL;
@@ -8538,13 +8539,14 @@ compile_substitute(char_u *arg, exarg_T *eap, cctx_T *cctx)
cctx->ctx_instr.ga_len = 0; cctx->ctx_instr.ga_len = 0;
cctx->ctx_instr.ga_maxlen = 0; cctx->ctx_instr.ga_maxlen = 0;
cctx->ctx_instr.ga_data = NULL; cctx->ctx_instr.ga_data = NULL;
compile_expr0(&cmd, cctx); expr_res = compile_expr0(&cmd, cctx);
if (end[-1] == NUL) if (end[-1] == NUL)
end[-1] = delimiter; end[-1] = delimiter;
cmd = skipwhite(cmd); cmd = skipwhite(cmd);
trailing_error = *cmd != delimiter && *cmd != NUL; trailing_error = *cmd != delimiter && *cmd != NUL;
if (trailing_error || ga_grow(&cctx->ctx_instr, 1) == FAIL) if (expr_res == FAIL || trailing_error
|| ga_grow(&cctx->ctx_instr, 1) == FAIL)
{ {
if (trailing_error) if (trailing_error)
semsg(_(e_trailing_arg), cmd); semsg(_(e_trailing_arg), cmd);