aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-07-04 23:07:33 -04:00
Code
vim/src/version.c

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

3053 lines
37 KiB
C
Raw Normal View History

patch 7.4.2293 Problem: Modelines in source code are inconsistant. Solution: Use the same line in most files. Add 'noet'. (Naruhiko Nishino)
2016-08-29 22:49:24 +02:00
/* vi:set ts=8 sts=4 sw=4 noet:
updated for version 7.0001
2004-06-13 20:20:40 +00:00
*
* VIM - Vi IMproved by Bram Moolenaar
*
* Do ":help uganda" in Vim to read copying and usage conditions.
* Do ":help credits" in Vim to see a list of people who contributed.
* See README.txt for an overview of the Vim source code.
*/
#include "vim.h"
/*
* Vim originated from Stevie version 3.6 (Fish disk 217) by GRWalter (Fred)
* It has been changed beyond recognition since then.
*
patch 8.2.5154: still mentioning version8, some cosmetic issues Problem: Still mentioning version8, some cosmetic issues. Solution: Prefer mentioning version9, cosmetic improvements.
2022-06-23 20:46:27 +01:00
* Differences between version 8.2 and 9.0 can be found with ":help version9".
patch 8.0.0001 Problem: Intro screen still mentions version7. (Paul) Solution: Change it to version8.
2016-09-12 16:23:34 +02:00
* Differences between version 7.4 and 8.x can be found with ":help version8".
* Differences between version 6.4 and 7.x can be found with ":help version7".
* Differences between version 5.8 and 6.x can be found with ":help version6".
updated for version 7.0001
2004-06-13 20:20:40 +00:00
* Differences between version 4.x and 5.x can be found with ":help version5".
* Differences between version 3.0 and 4.x can be found with ":help version4".
* All the remarks about older versions have been removed, they are not very
* interesting.
*/
#include "version.h"
updated for version 7.0098
2005-06-30 22:04:15 +00:00
char *Version = VIM_VERSION_SHORT;
static char *mediumVersion = VIM_VERSION_MEDIUM;
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#if defined(HAVE_DATE_TIME) || defined(PROTO)
# if (defined(VMS) && defined(VAXC)) || defined(PROTO)
char longVersion[sizeof(VIM_VERSION_LONG_DATE) + sizeof(__DATE__)
+ sizeof(__TIME__) + 3];
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
updated for version 7.0001
2004-06-13 20:20:40 +00:00
void
patch 8.1.0103: long version string cannot be translated Problem: Long version string cannot be translated. Solution: Build the string in init_longVersion().
2018-06-23 16:12:21 +02:00
init_longVersion(void)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
/*
* Construct the long version string. Necessary because
patch 8.1.0989: various small code ugliness Problem: Various small code ugliness. Solution: Remove pointless NULL checks. Fix function calls. Fix typos. (Dominique Pelle, closes #4060)
2019-03-02 10:13:42 +01:00
* VAX C can't concatenate strings in the preprocessor.
updated for version 7.0001
2004-06-13 20:20:40 +00:00
*/
strcpy(longVersion, VIM_VERSION_LONG_DATE);
patch 8.2.0910: Vim is not reproducibly buildable Problem: Vim is not reproducibly buildable. Solution: Use the $SOURCE_DATE_EPOCH environment variable in configure. (James McCoy, closes #513) Give a warning about using it.
2020-06-05 23:16:29 +02:00
#ifdef BUILD_DATE
strcat(longVersion, BUILD_DATE);
#else
updated for version 7.0001
2004-06-13 20:20:40 +00:00
strcat(longVersion, __DATE__);
strcat(longVersion, " ");
strcat(longVersion, __TIME__);
patch 8.2.0910: Vim is not reproducibly buildable Problem: Vim is not reproducibly buildable. Solution: Use the $SOURCE_DATE_EPOCH environment variable in configure. (James McCoy, closes #513) Give a warning about using it.
2020-06-05 23:16:29 +02:00
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
strcat(longVersion, ")");
}
patch 8.1.0103: long version string cannot be translated Problem: Long version string cannot be translated. Solution: Build the string in init_longVersion().
2018-06-23 16:12:21 +02:00
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# else
patch 8.2.3445: on Solaris longVersion may be declared twice Problem: On Solaris longVersion may be declared twice. (Vladimir Marek) Solution: Always declare longVersion in version.c
2021-09-17 20:45:30 +02:00
char *longVersion = NULL;
patch 8.1.0103: long version string cannot be translated Problem: Long version string cannot be translated. Solution: Build the string in init_longVersion().
2018-06-23 16:12:21 +02:00
void
init_longVersion(void)
{
patch 9.0.1246: code is indented more than necessary Problem: Code is indented more than necessary. Solution: Use an early return where it makes sense. (Yegappan Lakshmanan, closes #11887)
2023-01-26 12:00:00 +00:00
if (longVersion != NULL)
return;
patch 8.2.0910: Vim is not reproducibly buildable Problem: Vim is not reproducibly buildable. Solution: Use the $SOURCE_DATE_EPOCH environment variable in configure. (James McCoy, closes #513) Give a warning about using it.
2020-06-05 23:16:29 +02:00
#ifdef BUILD_DATE
patch 9.0.1246: code is indented more than necessary Problem: Code is indented more than necessary. Solution: Use an early return where it makes sense. (Yegappan Lakshmanan, closes #11887)
2023-01-26 12:00:00 +00:00
char *date_time = BUILD_DATE;
patch 8.2.0910: Vim is not reproducibly buildable Problem: Vim is not reproducibly buildable. Solution: Use the $SOURCE_DATE_EPOCH environment variable in configure. (James McCoy, closes #513) Give a warning about using it.
2020-06-05 23:16:29 +02:00
#else
patch 9.0.1246: code is indented more than necessary Problem: Code is indented more than necessary. Solution: Use an early return where it makes sense. (Yegappan Lakshmanan, closes #11887)
2023-01-26 12:00:00 +00:00
char *date_time = __DATE__ " " __TIME__;
patch 8.2.0910: Vim is not reproducibly buildable Problem: Vim is not reproducibly buildable. Solution: Use the $SOURCE_DATE_EPOCH environment variable in configure. (James McCoy, closes #513) Give a warning about using it.
2020-06-05 23:16:29 +02:00
#endif
patch 9.0.1246: code is indented more than necessary Problem: Code is indented more than necessary. Solution: Use an early return where it makes sense. (Yegappan Lakshmanan, closes #11887)
2023-01-26 12:00:00 +00:00
char *msg = _("%s (%s, compiled %s)");
size_t len = strlen(msg)
+ strlen(VIM_VERSION_LONG_ONLY)
+ strlen(VIM_VERSION_DATE_ONLY)
+ strlen(date_time);
patch 8.2.0573: using :version twice leaks memory Problem: using :version twice leaks memory Solution: Only initialize variables once. (Dominique Pelle, closes #5917)
2020-04-13 18:25:33 +02:00
patch 9.0.1246: code is indented more than necessary Problem: Code is indented more than necessary. Solution: Use an early return where it makes sense. (Yegappan Lakshmanan, closes #11887)
2023-01-26 12:00:00 +00:00
longVersion = alloc(len);
if (longVersion == NULL)
longVersion = VIM_VERSION_LONG;
else
vim_snprintf(longVersion, len, msg,
VIM_VERSION_LONG_ONLY, VIM_VERSION_DATE_ONLY, date_time);
patch 8.1.0103: long version string cannot be translated Problem: Long version string cannot be translated. Solution: Build the string in init_longVersion().
2018-06-23 16:12:21 +02:00
}
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# endif
#else
char *longVersion = VIM_VERSION_LONG;
patch 8.1.0106: build fails when HAVE_DATE_TIME is undefined Problem: Build fails when HAVE_DATE_TIME is undefined. Solution: Always define init_longVersion(). (Christian Brabandt, closes #3075)
2018-06-24 14:44:46 +02:00
void
init_longVersion(void)
{
// nothing to do
}
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
static char *(features[]) =
{
updated for version 7.4.011 Problem: Cannot find out if "acl" and "xpm" features are supported. Solution: Add "acl" and "xpm" to the list of features. (Ken Takata)
2013-08-30 16:35:44 +02:00
#ifdef HAVE_ACL
"+acl",
#else
"-acl",
#endif
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
#ifdef AMIGA // only for Amiga systems
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# ifdef FEAT_ARP
"+ARP",
# else
"-ARP",
# endif
#endif
#ifdef FEAT_ARABIC
"+arabic",
#else
"-arabic",
#endif
"+autocmd",
patch 8.1.0214: +autochdir feature not reported by has() or :version Problem: +autochdir feature not reported by has() or :version. Solution: Add the feature in the list.
2018-07-27 22:08:59 +02:00
#ifdef FEAT_AUTOCHDIR
"+autochdir",
#else
"-autochdir",
#endif
patch 8.0.1295: cannot automatically get a server name in a terminal Problem: Cannot automatically get a server name in a terminal. Solution: Add the --enable-autoservername flag to configure. (Cimbali, closes #2317)
2017-11-12 19:21:51 +01:00
#ifdef FEAT_AUTOSERVERNAME
"+autoservername",
#else
"-autoservername",
#endif
patch 8.0.1312: balloon_show() only works in terminal when compiled with GUI Problem: balloon_show() only works in terminal when compiled with the GUI. Solution: Add FEAT_BEVAL_GUI and refactor to move common code out of the GUI specific file.
2017-11-18 22:13:31 +01:00
#ifdef FEAT_BEVAL_GUI
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+balloon_eval",
#else
"-balloon_eval",
#endif
patch 8.0.1312: balloon_show() only works in terminal when compiled with GUI Problem: balloon_show() only works in terminal when compiled with the GUI. Solution: Add FEAT_BEVAL_GUI and refactor to move common code out of the GUI specific file.
2017-11-18 22:13:31 +01:00
#ifdef FEAT_BEVAL_TERM
patch 8.0.1309: cannot use 'balloonexpr' in a terminal Problem: Cannot use 'balloonexpr' in a terminal. Solution: Add 'balloonevalterm' and add code to handle mouse movements in a terminal. Initial implementation for Unix with GUI.
2017-11-18 18:52:04 +01:00
"+balloon_eval_term",
#else
"-balloon_eval_term",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_BROWSE
"+browse",
#else
"-browse",
#endif
"++builtin_terms",
#ifdef FEAT_BYTEOFF
"+byte_offset",
#else
"-byte_offset",
#endif
patch 7.4.1537 Problem: Too many feature flags for pipes, jobs and channels. Solution: Only use FEAT_JOB_CHANNEL.
2016-03-11 22:52:15 +01:00
#ifdef FEAT_JOB_CHANNEL
patch 7.4.1177 Problem: The +channel feature is not in :version output. (Tony Mechelynck) Solution: Add the feature string.
2016-01-25 20:15:45 +01:00
"+channel",
#else
"-channel",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+cindent",
#ifdef FEAT_CLIENTSERVER
"+clientserver",
#else
"-clientserver",
#endif
#ifdef FEAT_CLIPBOARD
"+clipboard",
#else
"-clipboard",
#endif
"+cmdline_compl",
"+cmdline_hist",
"+cmdline_info",
"+comments",
Add the conceal patch from Vince Negri.
2010-06-05 23:22:07 +02:00
#ifdef FEAT_CONCEAL
"+conceal",
#else
"-conceal",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_CRYPT
"+cryptv",
#else
"-cryptv",
#endif
#ifdef FEAT_CSCOPE
"+cscope",
#else
"-cscope",
#endif
Add the conceal patch from Vince Negri.
2010-06-05 23:22:07 +02:00
"+cursorbind",
updated for version 7.0188
2006-01-26 22:25:15 +00:00
#ifdef CURSOR_SHAPE
"+cursorshape",
#else
"-cursorshape",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#if defined(FEAT_CON_DIALOG) && defined(FEAT_GUI_DIALOG)
"+dialog_con_gui",
#else
# if defined(FEAT_CON_DIALOG)
"+dialog_con",
# else
# if defined(FEAT_GUI_DIALOG)
"+dialog_gui",
# else
"-dialog",
# endif
# endif
#endif
#ifdef FEAT_DIFF
"+diff",
#else
"-diff",
#endif
#ifdef FEAT_DIGRAPHS
"+digraphs",
#else
"-digraphs",
#endif
patch 8.1.0941: macros for MS-Windows are inconsistent Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and others. Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the GUI build. (Hirohito Higashi, closes #3932)
2019-02-17 17:44:42 +01:00
#ifdef FEAT_GUI_MSWIN
updated for version 7.4.393 Problem: Text drawing on newer MS-Windows systems is suboptimal. Some multi-byte characters are not displayed, even though the same font in Notepad can display them. (Srinath Avadhanula) Solution: Add the 'renderoptions' option to enable Direct-X drawing. (Taro Muraoka)
2014-08-06 14:52:30 +02:00
# ifdef FEAT_DIRECTX
"+directx",
# else
"-directx",
# endif
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_DND
"+dnd",
#else
"-dnd",
#endif
"-ebcdic",
#ifdef FEAT_EMACS_TAGS
"+emacs_tags",
#else
"-emacs_tags",
#endif
#ifdef FEAT_EVAL
"+eval",
#else
"-eval",
#endif
"+ex_extra",
#ifdef FEAT_SEARCH_EXTRA
"+extra_search",
#else
"-extra_search",
#endif
"-farsi",
"+file_in_path",
#ifdef FEAT_FIND_ID
"+find_in_path",
#else
"-find_in_path",
#endif
updated for version 7.2a
2008-06-24 21:56:24 +00:00
"+float",
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_FOLDING
"+folding",
#else
"-folding",
#endif
"-footer",
patch 9.0.0375: the footer feature is unused Problem: The footer feature is unused. Solution: Remove FEAT_FOOTER and code.
2022-09-04 12:29:28 +01:00
// only interesting on Unix systems
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#if !defined(USE_SYSTEM) && defined(UNIX)
"+fork()",
#endif
#ifdef FEAT_GETTEXT
# ifdef DYNAMIC_GETTEXT
"+gettext/dyn",
# else
"+gettext",
# endif
#else
"-gettext",
#endif
"-hangul_input",
#if (defined(HAVE_ICONV_H) && defined(USE_ICONV)) || defined(DYNAMIC_ICONV)
# ifdef DYNAMIC_ICONV
"+iconv/dyn",
# else
"+iconv",
# endif
#else
"-iconv",
#endif
"+insert_expand",
patch 8.2.0574: ipv6 feature not shown in :version output Problem: Ipv6 feature not shown in :version output. Solution: Add ipv6 in :version output. (Ozaki Kiichi, closes #5924)
2020-04-13 19:04:21 +02:00
#ifdef FEAT_IPV6
"+ipv6",
#else
"-ipv6",
#endif
patch 7.4.1537 Problem: Too many feature flags for pipes, jobs and channels. Solution: Only use FEAT_JOB_CHANNEL.
2016-03-11 22:52:15 +01:00
#ifdef FEAT_JOB_CHANNEL
patch 7.4.1274 Problem: Cannot run a job. Solution: Add job_start(), job_status() and job_stop(). Currently only works for Unix.
2016-02-07 14:27:38 +01:00
"+job",
#else
"-job",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+jumplist",
#ifdef FEAT_KEYMAP
"+keymap",
#else
"-keymap",
#endif
patch 7.4.2121 Problem: No easy way to check if lambda and closure are supported. Solution: Add the +lambda feature.
2016-07-29 22:50:35 +02:00
#ifdef FEAT_EVAL
"+lambda",
#else
"-lambda",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_LANGMAP
"+langmap",
#else
"-langmap",
#endif
#ifdef FEAT_LIBCALL
"+libcall",
#else
"-libcall",
#endif
#ifdef FEAT_LINEBREAK
"+linebreak",
#else
"-linebreak",
#endif
"+lispindent",
"+listcmds",
"+localmap",
Added Lua interfae. (Luis Carvalho)
2010-07-14 23:23:17 +02:00
#ifdef FEAT_LUA
# ifdef DYNAMIC_LUA
"+lua/dyn",
# else
"+lua",
# endif
#else
"-lua",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_MENU
"+menu",
#else
"-menu",
#endif
#ifdef FEAT_SESSION
"+mksession",
#else
"-mksession",
#endif
"+modify_fname",
"+mouse",
patch 8.1.2171: mouse support not always available Problem: Mouse support not always available. Solution: Enable mouse support also in tiny version. Do not define FEAT_MOUSE_XTERM on MS-Windows (didn't really work).
2019-10-17 23:00:07 +02:00
#ifdef FEAT_MOUSESHAPE
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+mouseshape",
patch 8.1.2171: mouse support not always available Problem: Mouse support not always available. Solution: Enable mouse support also in tiny version. Do not define FEAT_MOUSE_XTERM on MS-Windows (didn't really work).
2019-10-17 23:00:07 +02:00
#else
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"-mouseshape",
#endif
updated for version 7.3.705 Problem: Mouse features are not sorted properly. (Tony Mechelynck) Solution: Put the mouse features in alphabetical order.
2012-10-21 04:00:07 +02:00
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#if defined(UNIX) || defined(VMS)
# ifdef FEAT_MOUSE_DEC
"+mouse_dec",
# else
"-mouse_dec",
# endif
# ifdef FEAT_MOUSE_GPM
patch 8.2.4457: the GPM library can only be linked statically Problem: The GPM library can only be linked statically. Solution: Make it possible to load the GPM library dynamically. (Damien)
2022-02-23 18:07:38 +00:00
# ifdef DYNAMIC_GPM
"+mouse_gpm/dyn",
# else
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+mouse_gpm",
patch 8.2.4457: the GPM library can only be linked statically Problem: The GPM library can only be linked statically. Solution: Make it possible to load the GPM library dynamically. (Damien)
2022-02-23 18:07:38 +00:00
# endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# else
"-mouse_gpm",
# endif
# ifdef FEAT_MOUSE_JSB
"+mouse_jsbterm",
# else
"-mouse_jsbterm",
# endif
# ifdef FEAT_MOUSE_NET
"+mouse_netterm",
# else
"-mouse_netterm",
# endif
updated for version 7.3.705 Problem: Mouse features are not sorted properly. (Tony Mechelynck) Solution: Put the mouse features in alphabetical order.
2012-10-21 04:00:07 +02:00
#endif
#ifdef __QNX__
# ifdef FEAT_MOUSE_PTERM
"+mouse_pterm",
# else
"-mouse_pterm",
# endif
#endif
#if defined(UNIX) || defined(VMS)
"+mouse_sgr",
updated for version 7.2a
2008-06-24 21:56:24 +00:00
# ifdef FEAT_SYSMOUSE
"+mouse_sysmouse",
# else
"-mouse_sysmouse",
# endif
updated for version 7.3.343 Problem: No mouse support for urxvt. Solution: Implement urxvt mouse support, also for > 252 columns. (Yiding Jia)
2011-10-20 21:09:35 +02:00
# ifdef FEAT_MOUSE_URXVT
"+mouse_urxvt",
# else
"-mouse_urxvt",
# endif
updated for version 7.3.705 Problem: Mouse features are not sorted properly. (Tony Mechelynck) Solution: Put the mouse features in alphabetical order.
2012-10-21 04:00:07 +02:00
"+mouse_xterm",
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
updated for version 7.3.705 Problem: Mouse features are not sorted properly. (Tony Mechelynck) Solution: Put the mouse features in alphabetical order.
2012-10-21 04:00:07 +02:00
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_MBYTE_IME
# ifdef DYNAMIC_IME
"+multi_byte_ime/dyn",
# else
"+multi_byte_ime",
# endif
#else
"+multi_byte",
#endif
#ifdef FEAT_MULTI_LANG
"+multi_lang",
#else
"-multi_lang",
#endif
updated for version 7.0006
2004-07-05 15:58:32 +00:00
#ifdef FEAT_MZSCHEME
updated for version 7.0044
2005-01-25 22:07:05 +00:00
# ifdef DYNAMIC_MZSCHEME
"+mzscheme/dyn",
# else
updated for version 7.0006
2004-07-05 15:58:32 +00:00
"+mzscheme",
updated for version 7.0044
2005-01-25 22:07:05 +00:00
# endif
updated for version 7.0006
2004-07-05 15:58:32 +00:00
#else
"-mzscheme",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_NETBEANS_INTG
"+netbeans_intg",
#else
"-netbeans_intg",
#endif
patch 7.4.1976 Problem: Number variables are not 64 bits while they could be. Solution: Add the num64 feature. (Ken Takata)
2016-07-01 18:17:26 +02:00
"+num64",
patch 8.1.0941: macros for MS-Windows are inconsistent Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and others. Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the GUI build. (Hirohito Higashi, closes #3932)
2019-02-17 17:44:42 +01:00
#ifdef FEAT_GUI_MSWIN
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# ifdef FEAT_OLE
"+ole",
# else
"-ole",
# endif
#endif
patch 8.1.0202: :version always shows +packages Problem: :version always shows +packages. (Takuya Fujiwara) Solution: Add #ifdef (closes #3198) Also for has().
2018-07-22 05:08:11 +02:00
#ifdef FEAT_EVAL
patch 7.4.1384 Problem: It is not easy to use a set of plugins and their dependencies. Solution: Add packages, ":loadopt", 'packpath'.
2016-02-21 23:02:49 +01:00
"+packages",
patch 8.1.0202: :version always shows +packages Problem: :version always shows +packages. (Takuya Fujiwara) Solution: Add #ifdef (closes #3198) Also for has().
2018-07-22 05:08:11 +02:00
#else
"-packages",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+path_extra",
#ifdef FEAT_PERL
# ifdef DYNAMIC_PERL
"+perl/dyn",
# else
"+perl",
# endif
#else
"-perl",
#endif
Included patch for persistent undo. Lots of changes and added test.
2010-05-23 23:34:36 +02:00
#ifdef FEAT_PERSISTENT_UNDO
"+persistent_undo",
#else
"-persistent_undo",
#endif
patch 8.1.2371: FEAT_TEXT_PROP is a confusing name Problem: FEAT_TEXT_PROP is a confusing name. Solution: Use FEAT_PROP_POPUP. (Naruhiko Nishino, closes #5291)
2019-11-30 22:48:27 +01:00
#ifdef FEAT_PROP_POPUP
"+popupwin",
#else
"-popupwin",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_PRINTER
# ifdef FEAT_POSTSCRIPT
"+postscript",
# else
"-postscript",
# endif
"+printer",
#else
"-printer",
#endif
updated for version 7.0052
2005-02-26 23:04:13 +00:00
#ifdef FEAT_PROFILE
"+profile",
#else
"-profile",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_PYTHON
# ifdef DYNAMIC_PYTHON
"+python/dyn",
# else
"+python",
# endif
#else
"-python",
#endif
Added support for Python 3. (Roland Puntaier)
2010-07-17 21:19:38 +02:00
#ifdef FEAT_PYTHON3
# ifdef DYNAMIC_PYTHON3
patch 9.0.1776: No support for stable Python 3 ABI Problem: No support for stable Python 3 ABI Solution: Support Python 3 stable ABI Commits: 1) Support Python 3 stable ABI to allow mixed version interoperatbility Vim currently supports embedding Python for use with plugins, and the "dynamic" linking option allows the user to specify a locally installed version of Python by setting `pythonthreedll`. However, one caveat is that the Python 3 libs are not binary compatible across minor versions, and mixing versions can potentially be dangerous (e.g. let's say Vim was linked against the Python 3.10 SDK, but the user sets `pythonthreedll` to a 3.11 lib). Usually, nothing bad happens, but in theory this could lead to crashes, memory corruption, and other unpredictable behaviors. It's also difficult for the user to tell something is wrong because Vim has no way of reporting what Python 3 version Vim was linked with. For Vim installed via a package manager, this usually isn't an issue because all the dependencies would already be figured out. For prebuilt Vim binaries like MacVim (my motivation for working on this), AppImage, and Win32 installer this could potentially be an issue as usually a single binary is distributed. This is more tricky when a new Python version is released, as there's a chicken-and-egg issue with deciding what Python version to build against and hard to keep in sync when a new Python version just drops and we have a mix of users of different Python versions, and a user just blindly upgrading to a new Python could lead to bad interactions with Vim. Python 3 does have a solution for this problem: stable ABI / limited API (see https://docs.python.org/3/c-api/stable.html). The C SDK limits the API to a set of functions that are promised to be stable across versions. This pull request adds an ifdef config that allows us to turn it on when building Vim. Vim binaries built with this option should be safe to freely link with any Python 3 libraies without having the constraint of having to use the same minor version. Note: Python 2 has no such concept and this doesn't change how Python 2 integration works (not that there is going to be a new version of Python 2 that would cause compatibility issues in the future anyway). --- Technical details: ====== The stable ABI can be accessed when we compile with the Python 3 limited API (by defining `Py_LIMITED_API`). The Python 3 code (in `if_python3.c` and `if_py_both.h`) would now handle this and switch to limited API mode. Without it set, Vim will still use the full API as before so this is an opt-in change. The main difference is that `PyType_Object` is now an opaque struct that we can't directly create "static types" out of, and we have to create type objects as "heap types" instead. This is because the struct is not stable and changes from version to version (e.g. 3.8 added a `tp_vectorcall` field to it). I had to change all the types to be allocated on the heap instead with just a pointer to them. Other functions are also simply missing in limited API, or they are introduced too late (e.g. `PyUnicode_AsUTF8AndSize` in 3.10) to it that we need some other ways to do the same thing, so I had to abstract a few things into macros, and sometimes re-implement functions like `PyObject_NEW`. One caveat is that in limited API, `OutputType` (used for replacing `sys.stdout`) no longer inherits from `PyStdPrinter_Type` which I don't think has any real issue other than minor differences in how they convert to a string and missing a couple functions like `mode()` and `fileno()`. Also fixed an existing bug where `tp_basicsize` was set incorrectly for `BufferObject`, `TabListObject, `WinListObject`. Technically, there could be a small performance drop, there is a little more indirection with accessing type objects, and some APIs like `PyUnicode_AsUTF8AndSize` are missing, but in practice I didn't see any difference, and any well-written Python plugin should try to avoid excessing callbacks to the `vim` module in Python anyway. I only tested limited API mode down to Python 3.7, which seemes to compile and work fine. I haven't tried earlier Python versions. 2) Fix PyIter_Check on older Python vers / type##Ptr unused warning For PyIter_Check, older versions exposed them as either macros (used in full API), or a function (for use in limited API). A previous change exposed PyIter_Check to the dynamic build because Python just moved it to function-only in 3.10 anyway. Because of that, just make sure we always grab the function in dynamic builds in earlier versions since that's what Python eventually did anyway. 3) Move Py_LIMITED_API define to configure script Can now use --with-python-stable-abi flag to customize what stable ABI version to target. Can also use an env var to do so as well. 4) Show +python/dyn-stable in :version, and allow has() feature query Not sure if the "/dyn-stable" suffix would break things, or whether we should do it another way. Or just don't show it in version and rely on has() feature checking. 5) Documentation first draft. Still need to implement v:python3_version 6) Fix PyIter_Check build breaks when compiling against Python 3.8 7) Add CI coverage stable ABI on Linux/Windows / make configurable on Windows This adds configurable options for Windows make files (both MinGW and MSVC). CI will also now exercise both traditional full API and stable ABI for Linux and Windows in the matrix for coverage. Also added a "dynamic" option to Linux matrix as a drive-by change to make other scripting languages like Ruby / Perl testable under both static and dynamic builds. 8) Fix inaccuracy in Windows docs Python's own docs are confusing but you don't actually want to use `python3.dll` for the dynamic linkage. 9) Add generated autoconf file 10) Add v:python3_version support This variable indicates the version of Python3 that Vim was built against (PY_VERSION_HEX), and will be useful to check whether the Python library you are loading in dynamically actually fits it. When built with stable ABI, it will be the limited ABI version instead (`Py_LIMITED_API`), which indicates the minimum version of Python 3 the user should have, rather than the exact match. When stable ABI is used, we won't be exposing PY_VERSION_HEX in this var because it just doesn't seem necessary to do so (the whole point of stable ABI is the promise that it will work across versions), and I don't want to confuse the user with too many variables. Also, cleaned up some documentation, and added help tags. 11) Fix Python 3.7 compat issues Fix a couple issues when using limited API < 3.8 - Crash on exit: In Python 3.7, if a heap-allocated type is destroyed before all instances are, it would cause a crash later. This happens when we destroyed `OptionsType` before calling `Py_Finalize` when using the limited API. To make it worse, later versions changed the semantics and now each instance has a strong reference to its own type and the recommendation has changed to have each instance de-ref its own type and have its type in GC traversal. To avoid dealing with these cross-version variations, we just don't free the heap type. They are static types in non-limited-API anyway and are designed to last through the entirety of the app, and we also don't restart the Python runtime and therefore do not need it to have absolutely 0 leaks. See: - https://docs.python.org/3/whatsnew/3.8.html#changes-in-the-c-api - https://docs.python.org/3/whatsnew/3.9.html#changes-in-the-c-api - PyIter_Check: This function is not provided in limited APIs older than 3.8. Previously I was trying to mock it out using manual PyType_GetSlot() but it was brittle and also does not actually work properly for static types (it will generate a Python error). Just return false. It does mean using limited API < 3.8 is not recommended as you lose the functionality to handle iterators, but from playing with plugins I couldn't find it to be an issue. - Fix loading of PyIter_Check so it will be done when limited API < 3.8. Otherwise loading a 3.7 Python lib will fail even if limited API was specified to use it. 12) Make sure to only load `PyUnicode_AsUTF8AndSize` in needed in limited API We don't use this function unless limited API >= 3.10, but we were loading it regardless. Usually it's ok in Unix-like systems where Python just has a single lib that we load from, but in Windows where there is a separate python3.dll this would not work as the symbol would not have been exposed in this more limited DLL file. This makes it much clearer under what condition is this function needed. closes: #12032 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
2023-08-20 21:18:38 +02:00
# ifdef DYNAMIC_PYTHON3_STABLE_ABI
"+python3/dyn-stable",
# else
Added support for Python 3. (Roland Puntaier)
2010-07-17 21:19:38 +02:00
"+python3/dyn",
patch 9.0.1776: No support for stable Python 3 ABI Problem: No support for stable Python 3 ABI Solution: Support Python 3 stable ABI Commits: 1) Support Python 3 stable ABI to allow mixed version interoperatbility Vim currently supports embedding Python for use with plugins, and the "dynamic" linking option allows the user to specify a locally installed version of Python by setting `pythonthreedll`. However, one caveat is that the Python 3 libs are not binary compatible across minor versions, and mixing versions can potentially be dangerous (e.g. let's say Vim was linked against the Python 3.10 SDK, but the user sets `pythonthreedll` to a 3.11 lib). Usually, nothing bad happens, but in theory this could lead to crashes, memory corruption, and other unpredictable behaviors. It's also difficult for the user to tell something is wrong because Vim has no way of reporting what Python 3 version Vim was linked with. For Vim installed via a package manager, this usually isn't an issue because all the dependencies would already be figured out. For prebuilt Vim binaries like MacVim (my motivation for working on this), AppImage, and Win32 installer this could potentially be an issue as usually a single binary is distributed. This is more tricky when a new Python version is released, as there's a chicken-and-egg issue with deciding what Python version to build against and hard to keep in sync when a new Python version just drops and we have a mix of users of different Python versions, and a user just blindly upgrading to a new Python could lead to bad interactions with Vim. Python 3 does have a solution for this problem: stable ABI / limited API (see https://docs.python.org/3/c-api/stable.html). The C SDK limits the API to a set of functions that are promised to be stable across versions. This pull request adds an ifdef config that allows us to turn it on when building Vim. Vim binaries built with this option should be safe to freely link with any Python 3 libraies without having the constraint of having to use the same minor version. Note: Python 2 has no such concept and this doesn't change how Python 2 integration works (not that there is going to be a new version of Python 2 that would cause compatibility issues in the future anyway). --- Technical details: ====== The stable ABI can be accessed when we compile with the Python 3 limited API (by defining `Py_LIMITED_API`). The Python 3 code (in `if_python3.c` and `if_py_both.h`) would now handle this and switch to limited API mode. Without it set, Vim will still use the full API as before so this is an opt-in change. The main difference is that `PyType_Object` is now an opaque struct that we can't directly create "static types" out of, and we have to create type objects as "heap types" instead. This is because the struct is not stable and changes from version to version (e.g. 3.8 added a `tp_vectorcall` field to it). I had to change all the types to be allocated on the heap instead with just a pointer to them. Other functions are also simply missing in limited API, or they are introduced too late (e.g. `PyUnicode_AsUTF8AndSize` in 3.10) to it that we need some other ways to do the same thing, so I had to abstract a few things into macros, and sometimes re-implement functions like `PyObject_NEW`. One caveat is that in limited API, `OutputType` (used for replacing `sys.stdout`) no longer inherits from `PyStdPrinter_Type` which I don't think has any real issue other than minor differences in how they convert to a string and missing a couple functions like `mode()` and `fileno()`. Also fixed an existing bug where `tp_basicsize` was set incorrectly for `BufferObject`, `TabListObject, `WinListObject`. Technically, there could be a small performance drop, there is a little more indirection with accessing type objects, and some APIs like `PyUnicode_AsUTF8AndSize` are missing, but in practice I didn't see any difference, and any well-written Python plugin should try to avoid excessing callbacks to the `vim` module in Python anyway. I only tested limited API mode down to Python 3.7, which seemes to compile and work fine. I haven't tried earlier Python versions. 2) Fix PyIter_Check on older Python vers / type##Ptr unused warning For PyIter_Check, older versions exposed them as either macros (used in full API), or a function (for use in limited API). A previous change exposed PyIter_Check to the dynamic build because Python just moved it to function-only in 3.10 anyway. Because of that, just make sure we always grab the function in dynamic builds in earlier versions since that's what Python eventually did anyway. 3) Move Py_LIMITED_API define to configure script Can now use --with-python-stable-abi flag to customize what stable ABI version to target. Can also use an env var to do so as well. 4) Show +python/dyn-stable in :version, and allow has() feature query Not sure if the "/dyn-stable" suffix would break things, or whether we should do it another way. Or just don't show it in version and rely on has() feature checking. 5) Documentation first draft. Still need to implement v:python3_version 6) Fix PyIter_Check build breaks when compiling against Python 3.8 7) Add CI coverage stable ABI on Linux/Windows / make configurable on Windows This adds configurable options for Windows make files (both MinGW and MSVC). CI will also now exercise both traditional full API and stable ABI for Linux and Windows in the matrix for coverage. Also added a "dynamic" option to Linux matrix as a drive-by change to make other scripting languages like Ruby / Perl testable under both static and dynamic builds. 8) Fix inaccuracy in Windows docs Python's own docs are confusing but you don't actually want to use `python3.dll` for the dynamic linkage. 9) Add generated autoconf file 10) Add v:python3_version support This variable indicates the version of Python3 that Vim was built against (PY_VERSION_HEX), and will be useful to check whether the Python library you are loading in dynamically actually fits it. When built with stable ABI, it will be the limited ABI version instead (`Py_LIMITED_API`), which indicates the minimum version of Python 3 the user should have, rather than the exact match. When stable ABI is used, we won't be exposing PY_VERSION_HEX in this var because it just doesn't seem necessary to do so (the whole point of stable ABI is the promise that it will work across versions), and I don't want to confuse the user with too many variables. Also, cleaned up some documentation, and added help tags. 11) Fix Python 3.7 compat issues Fix a couple issues when using limited API < 3.8 - Crash on exit: In Python 3.7, if a heap-allocated type is destroyed before all instances are, it would cause a crash later. This happens when we destroyed `OptionsType` before calling `Py_Finalize` when using the limited API. To make it worse, later versions changed the semantics and now each instance has a strong reference to its own type and the recommendation has changed to have each instance de-ref its own type and have its type in GC traversal. To avoid dealing with these cross-version variations, we just don't free the heap type. They are static types in non-limited-API anyway and are designed to last through the entirety of the app, and we also don't restart the Python runtime and therefore do not need it to have absolutely 0 leaks. See: - https://docs.python.org/3/whatsnew/3.8.html#changes-in-the-c-api - https://docs.python.org/3/whatsnew/3.9.html#changes-in-the-c-api - PyIter_Check: This function is not provided in limited APIs older than 3.8. Previously I was trying to mock it out using manual PyType_GetSlot() but it was brittle and also does not actually work properly for static types (it will generate a Python error). Just return false. It does mean using limited API < 3.8 is not recommended as you lose the functionality to handle iterators, but from playing with plugins I couldn't find it to be an issue. - Fix loading of PyIter_Check so it will be done when limited API < 3.8. Otherwise loading a 3.7 Python lib will fail even if limited API was specified to use it. 12) Make sure to only load `PyUnicode_AsUTF8AndSize` in needed in limited API We don't use this function unless limited API >= 3.10, but we were loading it regardless. Usually it's ok in Unix-like systems where Python just has a single lib that we load from, but in Windows where there is a separate python3.dll this would not work as the symbol would not have been exposed in this more limited DLL file. This makes it much clearer under what condition is this function needed. closes: #12032 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
2023-08-20 21:18:38 +02:00
# endif
Added support for Python 3. (Roland Puntaier)
2010-07-17 21:19:38 +02:00
# else
"+python3",
# endif
#else
"-python3",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_QUICKFIX
"+quickfix",
#else
"-quickfix",
#endif
updated for version 7.0g01
2006-05-02 22:08:30 +00:00
#ifdef FEAT_RELTIME
"+reltime",
#else
"-reltime",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_RIGHTLEFT
"+rightleft",
#else
"-rightleft",
#endif
#ifdef FEAT_RUBY
# ifdef DYNAMIC_RUBY
"+ruby/dyn",
# else
"+ruby",
# endif
#else
"-ruby",
#endif
"+scrollbind",
#ifdef FEAT_SIGNS
"+signs",
#else
"-signs",
#endif
"+smartindent",
patch 8.2.3022: available encryption methods are not strong enough Problem: Available encryption methods are not strong enough. Solution: Add initial support for xchaha20. (Christian Brabandt, closes #8394)
2021-06-20 14:02:16 +02:00
#ifdef FEAT_SODIUM
patch 8.2.4354: dynamic loading of libsodium not handled properly Problem: Dynamic loading of libsodium not handled properly. Solution: Fix has() and :version. Show an error message when loading fails. Fix memory leaks. (Ken Takata, closes #9754)
2022-02-12 11:18:37 +00:00
# ifdef DYNAMIC_SODIUM
"+sodium/dyn",
# else
patch 8.2.3022: available encryption methods are not strong enough Problem: Available encryption methods are not strong enough. Solution: Add initial support for xchaha20. (Christian Brabandt, closes #8394)
2021-06-20 14:02:16 +02:00
"+sodium",
patch 8.2.4354: dynamic loading of libsodium not handled properly Problem: Dynamic loading of libsodium not handled properly. Solution: Fix has() and :version. Show an error message when loading fails. Fix memory leaks. (Ken Takata, closes #9754)
2022-02-12 11:18:37 +00:00
# endif
patch 8.2.3022: available encryption methods are not strong enough Problem: Available encryption methods are not strong enough. Solution: Add initial support for xchaha20. (Christian Brabandt, closes #8394)
2021-06-20 14:02:16 +02:00
#else
"-sodium",
#endif
patch 8.1.1502: cannot play any sound Problem: Cannot play any sound. Solution: Use libcanberra if available. Add sound functions.
2019-06-09 13:43:51 +02:00
#ifdef FEAT_SOUND
"+sound",
#else
"-sound",
#endif
#ifdef FEAT_SPELL
"+spell",
#else
"-spell",
#endif
updated for version 7.2-286
2009-11-11 13:22:11 +00:00
#ifdef STARTUPTIME
"+startuptime",
#else
"-startuptime",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_STL_OPT
"+statusline",
#else
"-statusline",
#endif
"-sun_workshop",
#ifdef FEAT_SYN_HL
"+syntax",
#else
"-syntax",
#endif
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// only interesting on Unix systems
patch 7.4.2048 Problem: There is still code and help for unsupported systems. Solution: Remove the code and text. (Hirohito Higashi)
2016-07-16 14:47:36 +02:00
#if defined(USE_SYSTEM) && defined(UNIX)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+system()",
#endif
"+tag_binary",
"-tag_old_static",
"-tag_any_white",
#ifdef FEAT_TCL
# ifdef DYNAMIC_TCL
"+tcl/dyn",
# else
"+tcl",
# endif
#else
"-tcl",
#endif
patch 7.4.1799 Problem: 'guicolors' is a confusing option name. Solution: Use 'termguicolors' instead. (Hirohito Higashi)
2016-04-29 22:59:22 +02:00
#ifdef FEAT_TERMGUICOLORS
"+termguicolors",
#else
"-termguicolors",
#endif
patch 8.0.0717: terminal feature precence unclear Problem: Terminal feature not included in :version output. Solution: Add +terminal or -terminal.
2017-07-15 20:05:54 +02:00
#ifdef FEAT_TERMINAL
"+terminal",
#else
"-terminal",
#endif
patch 7.4.2048 Problem: There is still code and help for unsupported systems. Solution: Remove the code and text. (Hirohito Higashi)
2016-07-16 14:47:36 +02:00
#if defined(UNIX)
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// only Unix can have terminfo instead of termcap
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# ifdef TERMINFO
"+terminfo",
# else
"-terminfo",
# endif
#endif
#ifdef FEAT_TERMRESPONSE
"+termresponse",
#else
"-termresponse",
#endif
"+textobjects",
patch 8.1.2371: FEAT_TEXT_PROP is a confusing name Problem: FEAT_TEXT_PROP is a confusing name. Solution: Use FEAT_PROP_POPUP. (Naruhiko Nishino, closes #5291)
2019-11-30 22:48:27 +01:00
#ifdef FEAT_PROP_POPUP
patch 8.1.0579: cannot attach properties to text Problem: Cannot attach properties to text. Solution: First part of adding text properties.
2018-12-13 22:20:09 +01:00
"+textprop",
#else
"-textprop",
#endif
#if !defined(UNIX)
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// unix always includes termcap support
patch 8.1.0579: cannot attach properties to text Problem: Cannot attach properties to text. Solution: First part of adding text properties.
2018-12-13 22:20:09 +01:00
# ifdef HAVE_TGETENT
"+tgetent",
# else
"-tgetent",
# endif
#endif
patch 7.4.1578 Problem: There is no way to invoke a function later or periodically. Solution: Add timer support.
2016-03-15 23:10:59 +01:00
#ifdef FEAT_TIMERS
"+timers",
#else
"-timers",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+title",
#ifdef FEAT_TOOLBAR
"+toolbar",
#else
"-toolbar",
#endif
"+user_commands",
patch 8.1.0105: all tab stops are the same Problem: All tab stops are the same. Solution: Add the variable tabstop feature. (Christian Brabandt, closes #2711)
2018-06-23 19:23:02 +02:00
#ifdef FEAT_VARTABS
"+vartabs",
#else
"-vartabs",
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
"+vertsplit",
patch 8.2.3979: Vim9: the feature is not mentioned in the right places Problem: Vim9: the feature is not mentioned in the right places. Solution: Add +vim9script to the help and :version output.
2022-01-02 12:06:33 +00:00
"+vim9script",
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_VIMINFO
"+viminfo",
#else
"-viminfo",
#endif
patch 8.2.3979: Vim9: the feature is not mentioned in the right places Problem: Vim9: the feature is not mentioned in the right places. Solution: Add +vim9script to the help and :version output.
2022-01-02 12:06:33 +00:00
"+virtualedit",
"+visual",
"+visualextra",
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+vreplace",
patch 8.1.0941: macros for MS-Windows are inconsistent Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and others. Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the GUI build. (Hirohito Higashi, closes #3932)
2019-02-17 17:44:42 +01:00
#ifdef MSWIN
patch 8.0.1531: cannot use 24 bit colors in MS-Windows console Problem: Cannot use 24 bit colors in MS-Windows console. Solution: Add support for vcon. (Nobuhiro Takasaki, Ken Takasaki, fixes #1270, fixes #2060)
2018-02-22 21:07:09 +01:00
# ifdef FEAT_VTP
"+vtp",
# else
"-vtp",
# endif
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+wildignore",
"+wildmenu",
"+windows",
#ifdef FEAT_WRITEBACKUP
"+writebackup",
#else
"-writebackup",
#endif
#if defined(UNIX) || defined(VMS)
# ifdef FEAT_X11
"+X11",
# else
"-X11",
# endif
#endif
patch 9.0.1962: No support for writing extended attributes Problem: No support for writing extended attributes Solution: Add extended attribute support for linux It's been a long standing issue, that if you write a file with extended attributes and backupcopy is set to no, the file will loose the extended attributes. So this patch adds support for retrieving the extended attributes and copying it to the new file. It currently only works on linux, mainly because I don't know the different APIs for other systems (BSD, MacOSX and Solaris). On linux, this should be supported since Kernel 2.4 or something, so this should be pretty safe to use now. Enable the extended attribute support with normal builds. I also added it explicitly to the :version output as well as make it able to check using `:echo has("xattr")`, to have users easily check that this is available. In contrast to the similar support for SELINUX and SMACK support (which also internally uses extended attributes), I have made this a FEAT_XATTR define, instead of the similar HAVE_XATTR. Add a test and change CI to include relevant packages so that CI can test that extended attributes are correctly written. closes: #306 closes: #13203 Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-09-30 12:49:18 +02:00
# ifdef FEAT_XATTR
"+xattr",
# else
"-xattr",
# endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_XFONTSET
"+xfontset",
#else
"-xfontset",
#endif
#ifdef FEAT_XIM
"+xim",
#else
"-xim",
#endif
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#if defined(MSWIN)
patch 7.4.2207 Problem: The +xpm feature is not sorted properly in :version output. Solution: Move it up. (Tony Mechelynck)
2016-08-13 16:39:56 +02:00
# ifdef FEAT_XPM_W32
"+xpm_w32",
# else
"-xpm_w32",
# endif
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#elif defined(HAVE_XPM)
patch 7.4.2207 Problem: The +xpm feature is not sorted properly in :version output. Solution: Move it up. (Tony Mechelynck)
2016-08-13 16:39:56 +02:00
"+xpm",
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#else
patch 7.4.2207 Problem: The +xpm feature is not sorted properly in :version output. Solution: Move it up. (Tony Mechelynck)
2016-08-13 16:39:56 +02:00
"-xpm",
#endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#if defined(UNIX) || defined(VMS)
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
# if defined(USE_XSMP_INTERACT)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+xsmp_interact",
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
# elif defined(USE_XSMP)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"+xsmp",
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
# else
updated for version 7.0001
2004-06-13 20:20:40 +00:00
"-xsmp",
# endif
# ifdef FEAT_XCLIPBOARD
"+xterm_clipboard",
# else
"-xterm_clipboard",
# endif
#endif
#ifdef FEAT_XTERM_SAVE
"+xterm_save",
#else
"-xterm_save",
#endif
NULL
};
static int included_patches[] =
{ /* Add new patch number below this line */
patch 9.1.0836: The vimtutor can be improved Problem: the vimtutor can be improved Solution: port and include the interactive vimtutor plugin from Neovim (by Felipe Morales) (Yegappan Lakshmanan) closes: #6414 Signed-off-by: Christian Brabandt <cb@256bit.org> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com>
2024-11-03 10:49:23 +01:00
/**/
836,
patch 9.1.0835: :setglobal doesn't work properly for 'ffu' and 'tsrfu' Problem: :setglobal doesn't work properly for 'ffu' and 'tsrfu' when the local value is set (after v9.1.0831) Solution: Check os_flags instead of buffer option variable (zeertzjq). closes: #15980 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-03 09:23:33 +01:00
/**/
835,
patch 9.1.0834: tests: 2html test fails Problem: tests: 2html test fails (after b256221e8377) Solution: Adjust testdir/samples/Test_tohtml_basic.c.html (Aliaksei Budavei) closes: #15981 Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-03 09:19:14 +01:00
/**/
834,
patch 9.1.0833: CI: recent ASAN changes do not work for indent tests Problem: CI: recent ASAN changes do not work for indent tests Solution: Move code to runtime/indent/testdir/runtest.vim (Aliaksei Budavei) closes: #15981 Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-03 09:15:35 +01:00
/**/
833,
patch 9.1.0832: :set doesn't work for 'cot' and 'bkc' after :setlocal Problem: :set doesn't work for 'cot' and 'bkc' after :setlocal. Solution: clear the local flags when using :set (zeertzjq). closes: #15981 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-03 09:10:50 +01:00
/**/
832,
patch 9.1.0831: 'findexpr' can't be used as lambad or Funcref Problem: 'findexpr' can't be used for lambads (Justin Keyes) Solution: Replace the findexpr option with the findfunc option (Yegappan Lakshmanan) related: #15905 closes: #15976 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-02 18:40:10 +01:00
/**/
831,
patch 9.1.0830: using wrong highlight group for spaces for popupmenu Problem: using wrong highlight group for spaces for popupmenu Solution: use original attribute instead of combined attributed (glepnir) closes: #15978 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-02 16:45:01 +01:00
/**/
830,
patch 9.1.0829: Vim source code uses a mix of tabs and spaces Problem: Vim source code uses a mix of tabs and spaces Solution: Expand tabs in sound.c, this is an experiment (Luca Saccarola) closes: #15969 Signed-off-by: Luca Saccarola <github.e41mv@aleeas.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-02 16:22:45 +01:00
/**/
829,
patch 9.1.0828: string_T struct could be used more often Problem: string_T struct could be used more often Solution: Refactor code and make use of string_T struct for key-value pairs, reformat overlong lines (John Marriott) closes: #15975 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-02 15:59:01 +01:00
/**/
828,
patch 9.1.0827: CI: tests can be improved Problem: CI: tests can be improved Solution: collect failed indent tests, raise timeout for search() functions when using ASAN/Valgrind (Aliaksei Budavei) ASan-instrumented Vim builds tend to run slower (x2) than non-instrumented Vim builds and occasionally make indent tests fail when "search*()" functions time out and give up further execution. Reference: https://github.com/google/sanitizers/wiki/AddressSanitizer closes: #15974 Co-authored-by: Christian Brabandt <cb@256bit.org> Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-02 15:51:14 +01:00
/**/
827,
patch 9.1.0826: filetype: sway files are not recognized Problem: filetype: sway files are not recognized Solution: detect '*.sw' files as sway filetype, include a filetype plugin (Riley Bruins) References: https://github.com/FuelLabs/sway. Comments taken from their syntax documentation. File extension taken from the same documentation/GitHub's own recognition of these file types closes: #15973 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-11-02 15:44:43 +01:00
/**/
826,
patch 9.1.0825: compile error for non-diff builds Problem: compile error for non-diff builds (after v9.1.0822) Solution: Add #ifdef FEAT_DIFF (John Marriott) Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-31 10:53:43 +01:00
/**/
825,
patch 9.1.0824: too many strlen() calls in register.c Problem: too many strlen() calls in register.c Solution: refactor code, add string_T struct to keep track of string lengths (John Marriott) closes: #15952 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-31 10:06:54 +01:00
/**/
824,
patch 9.1.0823: filetype: Zephyr overlay files not recognized Problem: filetype: Zephyr overlay files not recognized Solution: detect '*.overlay' files as dts filetype, include syntax tests for DTS files (Xudong Zheng) Reference: https://docs.zephyrproject.org/latest/build/dts/howtos.html closes: #15963 Signed-off-by: Xudong Zheng <7pkvm5aw@slicealias.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-31 09:32:25 +01:00
/**/
823,
patch 9.1.0822: topline might be changed in diff mode unexpectedly Problem: topline might be changed in diff mode unexpectedly (Jaehwang Jung) Solution: do not re-calculate topline, when using line() func in diff mode. fixes: #15812 closes: #15950 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-29 20:29:04 +01:00
/**/
822,
patch 9.1.0821: 'findexpr' completion doesn't set v:fname to cmdline argument Problem: 'findexpr' completion doesn't set v:fname to cmdline argument. Solution: Set v:fname to the cmdline argument as-is (zeertzjq). closes: #15934 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-28 22:05:26 +01:00
/**/
821,
patch 9.1.0820: tests: Mac OS tests are too flaky Problem: tests: Mac OS tests are too flaky Solution: Increase max test timeout to 25 minutes, allow up to 10 retries on Mac OS runners, refactor runtest.vim (Milly). closes: #15940 Co-authored-by: K.Takata <kentkt@csc.jp> Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-28 21:56:14 +01:00
/**/
820,
patch 9.1.0819: tests: using findexpr and imported func not tested Problem: tests: need a test for findexpr and vim9 imported func Solution: Add a test for 'findexpr' and Vim9 imported script (Yegappan Lakshmanan) closes: #15954 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-28 21:01:28 +01:00
/**/
819,
patch 9.1.0818: some global functions are only used in single files Problem: some global functions are only used in single files Solution: refactor code slightly and make some more functions static (Yegappan Lakshmanan) closes: #15951 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-27 21:54:11 +01:00
/**/
818,
patch 9.1.0817: termdebug: cannot evaluate expr in a popup Problem: termdebug: cannot evaluate expr in a popup Solution: enhance termdebug plugin and allow to evaluate expressions in a popup window, add a unit test (Peter Wolf). fixes: #15877 closes: #15933 Signed-off-by: Peter Wolf <pwolf2310@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-27 21:51:14 +01:00
/**/
817,
patch 9.1.0816: tests: not clear what tests cause asan failures Problem: tests: not clear what tests cause asan failures Solution: append testname to $ASAN_OPTIONS Mention what test causes ASAN failures by appending the testname to log_path in $ASAN_OPTIONS/$UBSAN_OPTIONS. This assumes 'log_path' is always the last sub-option in $ASAN_OPTIONS. While at it, also make the CI run with `-O0` instead of `-O1` when ASAN is enable since this causes line numbers to disappear. closes: #15927 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-27 21:15:50 +01:00
/**/
816,
patch 9.1.0815: "above" virtual text causes wrong 'colorcolumn' position Problem: "above" virtual text causes wrong 'colorcolumn' position. (@matrdr) Solution: Use the number of cells instead of bytes for vcol_off_tp. (zeertzjq) fixes: #15946 closes: #15948 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-27 19:23:34 +01:00
/**/
815,
patch 9.1.0814: mapset() may remove unrelated mapping Problem: mapset() may remove unrelated mapping whose {rhs} matches the restored mapping's {lhs}. Solution: only match by {lhs} when unmapping for mapset() (zeertzjq). closes: #15935 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-24 21:43:43 +02:00
/**/
814,
patch 9.1.0813: no error handling with setglobal and number types Problem: no error handling with setglobal and number types Solution: validate values when using :setglobal with number option types (Milly) closes: #15928 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-23 21:42:41 +02:00
/**/
813,
patch 9.1.0812: Coverity warns about dereferencing NULL ptr Problem: Coverity warns about dereferencing NULL ptr in check_colorcolumn() Solution: verify that wp is not null before accessing it related: #15914 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-23 21:32:31 +02:00
/**/
812,
patch 9.1.0811: :find expansion does not consider 'findexpr' Problem: :find expansion does not consider 'findexpr' Solution: Support expanding :find command argument using 'findexpr' (Yegappan Lakshmanan) closes: #15929 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-23 21:06:10 +02:00
/**/
811,
patch 9.1.0810: cannot easily adjust the |:find| command Problem: cannot easily adjust the |:find| command Solution: Add support for the 'findexpr' option (Yegappan Lakshmanan) closes: #15901 closes: #15905 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 23:42:20 +02:00
/**/
810,
patch 9.1.0809: filetype: petalinux config files not recognized Problem: filetype: petalinux config files not recognized Solution: detect 'project-spec/*.conf' files as bitbake filetype (Wu, Zhenyu) References: https://www.amd.com/en/products/software/adaptive-socs-and-fpgas/embedded-software/petalinux-sdk.html closes: #15926 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 23:21:49 +02:00
/**/
809,
patch 9.1.0808: Terminal scrollback doesn't shrink when decreasing 'termwinscroll' Problem: Terminal scrollback doesn't shrink when reducing 'termwinscroll' Solution: Check if option value was decreased (Milly). closes: #15904 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 23:17:45 +02:00
/**/
808,
patch 9.1.0807: tests: having 'nolist' in modelines isn't always desired Problem: tests: having 'nolist' in modelines isn't always desired Solution: remove 'nolist' from modeline (zeertzjq) closes: #15910 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 23:11:27 +02:00
/**/
807,
patch 9.1.0806: tests: no error check when setting global 'briopt' Problem: tests: no error check when setting global 'briopt' Solution: also parse and check global 'briopt' value (Milly) closes: #15911 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 22:59:39 +02:00
/**/
806,
patch 9.1.0805: tests: minor issues in gen_opt_test.vim Problem: tests: minor issues in gen_opt_test.vim Solution: fix restore value for 'undolevels', fix comment, fix wrong cpo value, add equality test for global-local options on switchback (Milly). closes: #15913 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 22:53:01 +02:00
/**/
805,
patch 9.1.0804: tests: no error check when setting global 'cc' Problem: tests: no error check when setting global 'cc' Solution: also parse and check global 'cc' value (Milly) closes: #15914 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 22:43:01 +02:00
/**/
804,
patch 9.1.0803: tests: no error check when setting global 'isk' Problem: tests: no error check when setting global 'isk' Solution: also parse and check global 'isk' value (Milly) closes: #15915 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 22:27:19 +02:00
/**/
803,
patch 9.1.0802: tests: no error check when setting global 'fdm' to empty value Problem: tests: no error check when setting global 'fdm' to empty value Solution: Also check global 'fdm' value for being empty (Milly). closes: #15916 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 22:11:51 +02:00
/**/
802,
patch 9.1.0801: tests: no error check when setting global 'termwinkey' Problem: tests: no error check when setting global 'termwinkey' Solution: Also validate when using setglobal (Milly). closes: #15917 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 22:07:52 +02:00
/**/
801,
patch 9.1.0800: tests: no error check when setting global 'termwinsize' Problem: tests: no error check when setting global 'termwinsize' Solution: Also validate when using setglobal (Milly). closes: #15918 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 22:01:46 +02:00
/**/
800,
patch 9.1.0799: tests: gettwinvar()/gettabwinvar() tests are not comprehensive Problem: tests: gettwinvar()/gettabwinvar() tests are not comprehensive Solution: Add more tests (Milly) closes: #15920 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-22 21:23:31 +02:00
/**/
799,
patch 9.1.0798: too many strlen() calls in cmdhist.c Problem: too many strlen() calls in cmdhist.c Solution: refactor code and remove strlen() calls (John Marriott) closes: #15888 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-21 22:37:07 +02:00
/**/
798,
patch 9.1.0797: testing of options can be further improved Problem: testing of options can be further improved Solution: split the generated option test into test_options_all.vim, add more test cases, save and restore values, fix use-after-free closes: #15894 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-21 22:20:51 +02:00
/**/
797,
patch 9.1.0796: filetype: libtool files are not recognized Problem: filetype: libtool files are not recognized Solution: detect '*.{lo,la,lai}' as sh filetype (Wu, Zhenyu) closes: #15751 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-21 22:09:32 +02:00
/**/
796,
patch 9.1.0795: filetype: Vivado memory info file are not recognized Problem: filetype: Vivado memory info file are not recognized Solution: detect '*.mmi' memory info file as xml filetype (Wu, Zhenyu) References: https://docs.amd.com/r/en-US/ug1580-updatemem/MMI-File-Syntax closes: #15906 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-21 20:54:13 +02:00
/**/
795,
patch 9.1.0794: tests: tests may fail on Windows environment Problem: tests: tests may fail on Windows environment Solution: use shellcmdflag=/D to skip executing autorun from the registry (Milly) closes: #15900 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-20 11:06:00 +02:00
/**/
794,
patch 9.1.0793: xxd: -e does add one extra space Problem: xxd: -e does add one extra space Solution: fix it, refactor and merge some code (Aapo Rantalainen) fixes: #15898 closes: #15899 Signed-off-by: Aapo Rantalainen <aapo.rantalainen@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-19 15:54:57 +02:00
/**/
793,
patch 9.1.0792: tests: Test_set_values() is not comprehensive enough Problem: tests: Test_set_values() is not comprehensive enough Solution: Add a lot more test cases (Milly) closes: #15892 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-18 19:58:04 +02:00
/**/
792,
patch 9.1.0791: tests: errors in gen_opt_test.vim are not shown Problem: tests: errors in gen_opt_test.vim are not shown Solution: update gen_opt_test.vim and write test.log, let the makefile output test.log (Milly) closes: #15887 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-17 21:05:31 +02:00
/**/
791,
patch 9.1.0790: Amiga: AmigaOS4 build should use default runtime (newlib) Problem: Amiga: AmigaOS4 build should use default runtime (newlib) Solution: Remove clib2 from compiler / linker flags (Ola Söder) closes: #15890 Signed-off-by: Ola Söder <rolfkopman@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-17 20:49:36 +02:00
/**/
790,
patch 9.1.0789: tests: ':resize + 5' has invalid space after '+' Problem: tests: ':resize + 5' has invalid space after '+' Solution: Correct the test (Milly) closes: #15884 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-16 20:03:44 +02:00
/**/
789,
patch 9.1.0788: <CSI>27;<mod>u is not decoded to literal Escape in kitty/foot Problem: <CSI>27;<mod>u is not decoded to literal Escape in kitty/foot Solution: disable XTerm modifyOtherKeys form 1 when the kitty protocol is enabled (Christian Fillion) References: - https://invisible-island.net/xterm/modified-keys.html - https://sw.kovidgoyal.net/kitty/keyboard-protocol/ - https://codeberg.org/dnkl/foot/src/commit/e891abdd6a6652bd46b28c1988700a7f30931210/kitty-keymap.h - https://github.com/kovidgoyal/kitty/blob/d31459b0926f2afddc317d76314e4afd0d07d473/kitty/key_encoding.c#L193 fixes: #15868 closes: #15881 Signed-off-by: Christian Fillion <contact@cfillion.ca> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-16 17:28:38 +02:00
/**/
788,
patch 9.1.0787: cursor position changed when using hidden terminal Problem: cursor position changed when using hidden terminal and BufFilePost autocommand (Mizuno Jan Yuta) Solution: Save and restore cursor position fixes: #15854 closes: #15876 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-15 20:31:14 +02:00
/**/
787,
patch 9.1.0786: tests: quickfix update test does not test location list Problem: tests: quickfix update test does not test location list (after: v9.1.0.785) Solution: update Test_quickfix_buffer_contents to test with location lists (Yegappan Lakshmanan) closes: #15879 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-15 20:26:45 +02:00
/**/
786,
patch 9.1.0785: cannot preserve error position when setting quickfix list Problem: cannot preserve error position when setting quickfix lists Solution: Add the 'u' action for setqflist()/setloclist() and try to keep the closes target position (Jeremy Fleischman) fixes: #15839 closes: #15841 Signed-off-by: Jeremy Fleischman <jeremyfleischman@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-14 20:46:27 +02:00
/**/
785,
patch 9.1.0784: there are several problems with python 3.13 Problem: there are several problems with python 3.13 Solution: fix the problems in the python3 interface (Boris Staletic) This commit does the following things: 1) Since python 3.13.0b1, all statically defined objects are "immortal". Besides never getting garbage collected, this also affects reference counting: - Immportal objects have a reference count of 2^32-1. - Reference counting is a no-op. All this is considered implementation details by cpython, so documentation is next to non-existent. Relevant CPython source code: https://github.com/python/cpython/blob/v3.13.0/Include/object.h#L62-L107 https://github.com/python/cpython/blob/v3.13.0/Include/object.h#L389-L391 2) Opt-out of ANSI-painted python stack traces 3) Make python error message severity more consistent fixes: #15838 closes: #15842 Signed-off-by: Boris Staletic <boris.staletic@protonmail.com> Signed-off-by: puremourning <puremourning@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-14 20:28:39 +02:00
/**/
784,
patch 9.1.0783: 'spell' option setting has problems Problem: 'spell' option setting has problems Solution: correctly check for comma for 'spellfile' option, remove unnecessary checks, refactor slightly (Milly) closes: #15873 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-14 20:21:48 +02:00
/**/
783,
patch 9.1.0782: tests: using wrong neomuttlog file name Problem: tests: using wrong neomuttlog file name Solution: use correct file name related: #15858 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-14 19:56:38 +02:00
/**/
782,
patch 9.1.0781: tests: test_filetype fails Problem: tests: test_filetype fails (clason) (after v9.1.0779) Solution: Use correct filename for neomuttlog filetype related: #15845 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-13 20:28:21 +02:00
/**/
781,
patch 9.1.0780: MS-Windows: incorrect Win32 error checking Problem: MS-Windows: incorrect Win32 error checking Solution: fix wrong order of error handling and perform some minor refactoring (Nir Lichtman) In the function that adjusts the process privileges there is a mistake in which GetLastError is called after CloseHandle, though clearly the last error check is meant for the privileges related call before hand and the current state appears like a mistake. So fix this problem, and also perform the following: - Remove the static variable done since the PlatformId is only called during initialization - Fix incorrect parameter passed to the Win32 API privileges function closes: #15845 Signed-off-by: Nir Lichtman <nir@lichtman.org> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-13 19:44:07 +02:00
/**/
780,
patch 9.1.0779: filetype: neomuttlog files are not recognized Problem: filetype: neomuttlog files are not recognized Solution: detect '*.neomuttdebug' file as neomuttlog filetype, include neomuttlog syntax script (Richard Russon) closes: #15858 Co-authored-by: AvidSeeker <avidseeker7@protonmail.com> Signed-off-by: Richard Russon <rich@flatcap.org> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-13 19:40:43 +02:00
/**/
779,
patch 9.1.0778: filetype: lf config files are not recognized Problem: filetype: lf config files are not recognized Solution: detect lfrc files as lf filetype, include a syntax script for lf files (Andis Spriņķis). References: - https://github.com/gokcehan/lf closes: #15859 Signed-off-by: Andis Spriņķis <spr.andis@protonmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-13 19:29:56 +02:00
/**/
778,
patch 9.1.0777: filetype: Some upstream php files are not recognized Problem: filetype: Some upstream php files are not recognized Solution: Detect more config files from the PHP source distribution as filetype ini (nisbet-hubbard). closes: #15840 Signed-off-by: nisbet-hubbard <87453615+nisbet-hubbard@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-12 17:19:58 +02:00
/**/
777,
patch 9.1.0776: test_strftime may fail because of missing TZ data Problem: test_strftime may fail because of missing TZ data Solution: Use GMT offsets to validate timezone differences (James McCoy) Some systems only provide timezones that follow the geographical region naming (e.g. America/New_York) by default and require an additional install for other names (like EST). The GMT+<offset> format must always be honored, so use that to generate distinct data for the test. closes: #15848 Signed-off-by: James McCoy <jamessan@jamessan.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-12 11:36:58 +02:00
/**/
776,
patch 9.1.0775: tests: not enough tests for setting options Problem: tests: not enough tests for setting options Solution: Add more comprehensive tests to test_options (Milly). closes: #15856 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-12 11:26:06 +02:00
/**/
775,
patch 9.1.0774: "shellcmdline" doesn't work with getcompletion() Problem: "shellcmdline" doesn't work with getcompletion(). Solution: Use set_context_for_wildcard_arg() (zeertzjq). closes: #15834 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-10 19:14:13 +02:00
/**/
774,
patch 9.1.0773: filetype: some Apache files are not recognized Problem: filetype: some Apache files are not recognized Solution: Detect more config files from the Apache source distribution as filetype apache (nisbet-hubbard) closes: #15810 Signed-off-by: nisbet-hubbard <87453615+nisbet-hubbard@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-10 19:09:28 +02:00
/**/
773,
patch 9.1.0772: some missing changes from v9.1.0771 Problem: some missing changes from v9.1.0771 Solution: use correct highlighting attribute and adjust comments (glepnir) closes: #15836 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-09 20:19:25 +02:00
/**/
772,
patch 9.1.0771: completion attribute hl_group is confusing Problem: Currently completion attribute hl_group is combined with all items, which is redundant and confusing with kind_hlgroup Solution: Renamed to abbr_hlgroup and combine it only with the abbr item (glepnir). closes: #15818 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-08 22:26:44 +02:00
/**/
771,
patch 9.1.0770: current command line completion is a bit limited Problem: current command completion is a bit limited Solution: Add the shellcmdline completion type and getmdcomplpat() function (Ruslan Russkikh). closes: #15823 Signed-off-by: Ruslan Russkikh <dvrussk@yandex.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-08 22:21:05 +02:00
/**/
770,
patch 9.1.0769: filetype: MLIR files are not recognized Problem: filetype: MLIR files are not recognized Solution: Detect '*.mlir' files as mlir filetype, include a mlir filetype plugin (Wu, Zhenyu) closes: #15826 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-08 21:58:35 +02:00
/**/
769,
patch 9.1.0768: MS-Windows: incorrect cursor position when restoring screen Problem: MS-Windows: incorrect cursor position when restoring screen (after v9.1.0664) Solution: Restore the VTP command for switching screens back to termcap_mode_end() (William Bresler) Patch 9.1.0664 moved the VTP command for switching back to the main screen buffer from termcap_mode_end() to mch_exit_c(). However, the saved cursor position from the main screen continued to be restored in termcap_mode_end(). This failed if the cursor position was beyond the console window height, since the alternate screen buffer is always the same size as the console window. This patch restores the VTP command for switching back to the main screen buffer to termcap_mode_end(). In order to preserve the effect of patch 9.1.0664, the VTP command for switching back to the main screen buffer in mch_exit_c() is issued only if termcap mode was not active while exiting Vim. See issue 15775 for a fuller description, with screen shots of the problem. fixes: #15775 closes: #15829 Signed-off-by: William Bresler <wbresler@gmail.com> Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-08 21:30:48 +02:00
/**/
768,
patch 9.1.0767: A condition is always true in ex_getln.c Problem: A cmdlen == 0 condition is always true as ccline.cmdlen == 0 was already checked above (after v9.1.0766). Solution: Remove the condition and the variable. (zeertzjq) closes: #15830 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-08 21:04:19 +02:00
/**/
767,
patch 9.1.0766: too many strlen() calls in ex_getln.c Problem: too many strlen() calls in ex_getln.c Solution: refactor the code to reduce the number of strlen() calls (John Marriott) closes: #15809 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-07 21:40:39 +02:00
/**/
766,
patch 9.1.0765: No test for patches 6.2.418 and 7.3.489 Problem: No test for patches 6.2.418 and 7.3.489 Solution: Add a test. Fix some whitespace problems in test_mapping.vim. Document the behavior (zeertzjq). closes: #15815 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-07 21:05:06 +02:00
/**/
765,
patch 9.1.0764: [security]: use-after-free when closing a buffer Problem: [security]: use-after-free when closing a buffer Solution: When splitting the window and editing a new buffer, check whether the newly to be edited buffer has been marked for deletion and abort in this case Github Advisory: https://github.com/vim/vim/security/advisories/GHSA-rj48-v4mq-j4vg Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-06 17:31:10 +02:00
/**/
764,
patch 9.1.0763: tests: cannot run single syntax tests Problem: tests: cannot run single syntax tests Solution: Support running a subset of syntax tests (Aliaksei Budavei) Two methods of assembling a subset of test filenames for selection are provided: * Filename and filetype Make targets will be generated, and multiple such targets can be passed before the mandated trailing "test" target, e.g. "make html markdown test". * Filenames and their parts can be specified as a regular expression that is assigned to a "VIM_SYNTAX_TEST_FILTER" environment variable, and used with the test Make target, e.g. "VIM_SYNTAX_TEST_FILTER=html\\\|markdown make test". (This variable will be ignored and the whole suite will be run when Make is GNU Make and a parent Makefile is used.) Methods can be used alone or together, with the Make targets having the higher precedence. Neither method will influence the order of test execution. closes: #15670 Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-06 16:57:33 +02:00
/**/
763,
patch 9.1.0762: 'cedit', 'termwinkey' and 'wildchar' may not be parsed correctly Problem: 'cedit', 'termwinkey' and 'wildchar' may not be parsed correctly Solution: improve string_to_key() function in option.c (Milly) - Problem: `^@` raises an error. Solution: Store as `<Nul>`. - Problem: `<t_xx` does not raise an error. Solution: Raise an error if closing `>` is missing. - Problem: Single `<` or `^` raises an error. It is inconvenient for users. Solution: They are stored as a single character. closes: #15811 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-06 16:47:02 +02:00
/**/
762,
patch 9.1.0761: :cd completion fails on Windows with backslash in path Problem: :cd completion fails on Windows with backslash in path Solution: switch no_bslash argument to FALSE in file_pat_to_reg_pat() Note: only fixes the problem on Windows. For Unix, we still need to escape backslashes since those are taken as regex atoms (and could be invalid regex atoms). fixes: #15643 closes: #15808 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-06 16:34:20 +02:00
/**/
761,
patch 9.1.0760: tests: no error reported, if gen_opt_test.vim fails Problem: tests: no error reported, if gen_opt_test.vim fails Solution: Make Vim exit with return code 1 in case of any error (Milly) closes: #15795 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-06 16:27:28 +02:00
/**/
760,
patch 9.1.0759: screenpos() may return invalid position Problem: screenpos() may return invalid position after switching buffers (Greg Hurrell) Solution: reset w_leftcol if wrapping has been set after copying wrap option fixes: #15792 closes: #15803 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-05 17:30:22 +02:00
/**/
759,
patch 9.1.0758: it's possible to set an invalid key to 'wildcharm' Problem: it's possible to set an invalid key to 'wildcharm' Solution: error out, if the 'wildcharm' value is an invalid key (Milly) closes: #15787 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-04 20:41:14 +02:00
/**/
758,
patch 9.1.0757: tests: messages files contains ANSI escape sequences Problem: tests: messages files contains ANSI escape sequences Solution: filter those out in runtests.vim Also, since we are setting $LC_ALL, we don't need to set $LANG and $LANGUAGE since those are overridden by $LC_ALL anyhow. closes: #15788 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-03 16:38:52 +02:00
/**/
757,
patch 9.1.0756: missing change from patch v9.1.0754 Problem: missing change from patch v9.1.0754 Solution: use correct width for the actual item in pum_redraw() (glepnir) closes: #15786 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-03 11:01:19 +02:00
/**/
756,
patch 9.1.0755: quickfix list does not handle hardlinks well Problem: quickfix list does not handle hardlinks well Solution: store original file name with quickfix entry (Austin Chang) Quickfix list shows entries with duplicate name if the file is opened with the path of hard links. The major cause is that qflist assumed that the filename passed into `qf_add_entry` matches the filename opened with the buffer. This patch handles this case by introduce a `qf_fname` into `qfline_S` structure. It stores the filename from `qf_add_entry` for each quickfix line. closes: #15687 Signed-off-by: Austin Chang <austin880625@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-03 10:50:05 +02:00
/**/
755,
patch 9.1.0754: fixed order of items in insert-mode completion menu Problem: fixed order of items in insert-mode completion menu Solution: Introduce the 'completeitemalign' option with default value "abbr,kind,menu" (glepnir). Adding an new option `completeitemalign` abbr is `cia` to custom the complete-item order in popupmenu. closes: #14006 closes: #15760 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-01 20:32:12 +02:00
/**/
754,
patch 9.1.0753: Wrong display when typing in diff mode with 'smoothscroll' Problem: Wrong display when typing in diff mode with 'smoothscroll'. Solution: Use adjust_plines_for_skipcol() (zeertzjq). closes: #15776 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-01 19:35:47 +02:00
/**/
753,
patch 9.1.0752: can set 'cedit' to an invalid value Problem: can set cedit to an invalid value Solution: Check that the value is a valid key name (Milly) closes: #15778 Signed-off-by: Milly <milly.ca@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-10-01 19:30:20 +02:00
/**/
752,
patch 9.1.0751: Error callback for term_start() not used Problem: Error callback for term_start() not used (darkseid-is) Solution: attach pipe to stderr if an error callback exists fixes: #15665 closes: #15729 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-30 21:29:43 +02:00
/**/
751,
patch 9.1.0750: there are some Win9x legacy references Problem: there are some Win9x legacy references Solution: Remove those mentions (Nir Lichtman) closes: #15730 Signed-off-by: Nir Lichtman <nir@lichtman.org> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-30 19:42:28 +02:00
/**/
750,
patch 9.1.0749: filetype: http files not recognized Problem: filetype: http files not recognized Solution: detect '*.http' as http filetype, include http filetype plugin (Riley Bruins) Based on the specification found [here](https://github.com/JetBrains/http-request-in-editor-spec/blob/master/spec.md) closes: #15762 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-30 19:34:04 +02:00
/**/
749,
patch 9.1.0748: :keep* commmands are sometimes misidentified as :k Problem: The :keep{alt,jumps,marks,patterns} commmands are sometimes misidentified as :k. Solution: Make sure one_letter_cmd() only returns true for :k and not other :keep* commands (Doug Kearns). This currently manifests as missing completion for :keep* commands and incorrect results from fullcommand(). E.g., fullcommand("keepmarks") returns "k" rather than "keepmarks". The correct command, however, is executed as command modifiers are handled specially in do_one_cmd() rather than using find_ex_command(). Fix exists(':k') so that it returns 2 for a full match. closes: #15742 Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-29 17:17:41 +02:00
/**/
748,
patch 9.1.0747: various typos in repo found Problem: various typos in repo found Solution: Fix typos (zeertzjq) closes: #15749 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-29 10:37:47 +02:00
/**/
747,
patch 9.1.0746: tests: Test_halfpage_longline() fails on large terminals Problem: Test_halfpage_longline() fails on large terminals (lazypingu) Solution: Use a window with known width (zeertzjq). fixes: #15755 closes: #15756 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-29 10:14:32 +02:00
/**/
746,
patch 9.1.0745: filetype: bun and deno history files not recognized Problem: filetype: bun and deno history files not recognized Solution: detect '.bun_repl_history' and 'deno_history.txt' as javascript filetype (Wu, Zhenyu) closes: #15761 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-29 10:03:19 +02:00
/**/
745,
patch 9.1.0744: filetype: notmuch configs are not recognised Problem: filetype: notmuch configs are not recognised Solution: Detect more notmuch profile configuration files as dosini filetype (Julio B) Reference: https://notmuchmail.org/doc/latest/man1/notmuch-config.html#configuration closes: #15744 Signed-off-by: Julio B <julio.bacel@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-26 16:22:34 +02:00
/**/
744,
patch 9.1.0743: diff mode does not handle overlapping diffs correctly Problem: diff mode does not handle overlapping diffs correctly Solution: correct the logic to handle overlapping blocks (Yukihiro Nakadaira) Vim merges overlapped diff blocks and it doesn't work expectedly in some situation. closes: #15735 Signed-off-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-26 16:19:42 +02:00
/**/
743,
patch 9.1.0742: getcmdprompt() implementation can be improved Problem: getcmdprompt() implementation can be improved Solution: Improve and simplify it (h-east) closes: #15743 Signed-off-by: h-east <h.east.727@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-26 16:01:57 +02:00
/**/
742,
patch 9.1.0741: No way to get prompt for input()/confirm() Problem: No way to get prompt for input()/confirm() Solution: add getcmdprompt() function (Shougo Matsushita) (Shougo Matsushita) closes: #15667 Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-23 20:34:47 +02:00
/**/
741,
patch 9.1.0740: incorrect internal diff with empty file Problem: incorrect internal diff with an empty file Solution: Set pointer to NULL, instead of using an empty line file (Yukihiro Nakadaira) When using internal diff, empty file is read as one empty line file. So result differs from external diff. closes: #15719 Signed-off-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-22 11:26:13 +02:00
/**/
740,
patch 9.1.0739: [security]: use-after-free in ex_getln.c Problem: [security]: use-after-free in ex_getln.c Solution: free pointer p a bit later (John Marriott) closes: #15712 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-21 11:39:02 +02:00
/**/
739,
patch 9.1.0738: filetype: rapid files are not recognized Problem: filetype: rapid files are not recognized Solution: detect '*.sysx' and '*.modx' as rapid filetype (KnoP-01) closes: #15669 Signed-off-by: KnoP-01 <knosowski@graeffrobotics.de> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-20 22:19:45 +02:00
/**/
738,
patch 9.1.0737: tests: screendump tests may require a bit more time Problem: Asynchronous terminal jobs occassionally require more time to complete and redraw the window Solution: increase the sleep value from 10 to 50 milliseconds (Aliaksei Budavei) closes: #15695 Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-19 19:43:14 +02:00
/**/
737,
patch 9.1.0736: Unicode tables are outdated Problem: Unicode tables are outdated Solution: Update Unicode tables to v16 closes: #15693 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-17 20:24:56 +02:00
/**/
736,
patch 9.1.0735: filetype: salt files are not recognized Problem: filetype: salt files are not recognized Solution: Detect '*.sls' files as filetype salt, include a syntax script (Gregory Anders) closes: #15689 Signed-off-by: Gregory Anders <greg@gpanders.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-17 20:16:37 +02:00
/**/
735,
patch 9.1.0734: filetype: jinja files are not recognized Problem: filetype: jinja files are not recognized Solution: detect '*.jinja' files a jinja filetype, include jinja syntax script (Gregory Anders) related: #15689 Signed-off-by: Gregory Anders <greg@gpanders.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-17 20:12:47 +02:00
/**/
734,
patch 9.1.0733: keyword completion does not work with fuzzy Problem: keyword completion does not work with fuzzy (egesip) Solution: handle ctrl_x_mode_normal() specifically (glepnir) fixes: #15412 closes: #15424 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-15 20:06:28 +02:00
/**/
733,
patch 9.1.0732: xxd: cannot use -b and -i together Problem: xxd: cannot use -b and -i together (Irgendwer) Solution: implement the missing changes (Andre Chang) fixes: #15362 closes: #15661 Signed-off-by: Andre Chang <andre@augmentcode.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-15 20:03:05 +02:00
/**/
732,
patch 9.1.0731: inconsistent case sensitive extension matching Problem: inconsistent case sensitive extension matching Solution: unify case sensitive extension matching (Evgeni Chasnovski). There are different approaches of how extensions are matched with respect to case sensitivity. In particular, '\c' flag is used in pattern whereas in most places case sensitive matching is guarded behind `has("fname_case")` condition. Replace all instances of '\c' with an explicit case sensitive pattern variants guarded by `has("fname_case")`. Strictly speaking, this is a breaking change because only two (most common and prevailingly tested) variants are now matched: upper first letter and upper all letters. closes: #15672 Signed-off-by: Evgeni Chasnovski <evgeni.chasnovski@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-15 19:23:25 +02:00
/**/
731,
patch 9.1.0730: Crash with cursor-screenline and narrow window Problem: Crash with cursor-screenline and narrow window (elig0n) Solution: Don't set right_col when width2 is 0 (zeertzjq). fixes: #15677 closes: #15678 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-14 10:40:29 +02:00
/**/
730,
patch 9.1.0729: Wrong cursor-screenline when resizing window Problem: Wrong cursor-screenline when resizing window Solution: Invalidate saved left_col and right_col when width1 or width2 change. closes: #15679 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-14 10:37:17 +02:00
/**/
729,
patch 9.1.0728: [security]: heap-use-after-free in garbage collection with location list user data Problem: heap-use-after-free in garbage collection with location list user data. Solution: Mark user data as in use when no other window is referencing the location list (zeertzjq) fixes: neovim/neovim#30371 closes: #15683 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-14 10:32:31 +02:00
/**/
728,
patch 9.1.0727: too many strlen() calls in option.c Problem: too many strlen() calls in option.c Solution: refactor the code to reduce the number of strlen() calls (John Marriott) closes: #15604 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-10 21:25:14 +02:00
/**/
727,
patch 9.1.0726: not using correct python3 API with dynamic linking Problem: not using correct python3 API with dynamic linking Solution: Use stable IncRef / DecRef in Python 3 dynamic bindings (Yee Cheng Chin) Previously, we were using the Py_DECREF macros even when using dynamic linking of Python 3. This caused issues because Python's headers contain references to internal APIs like `_Py_Dealloc` and in v8.1.2201 and v8.2.1225 we simply hacked around the issue by manually copying the Python header implementation to Vim and linking in the private APIs. This is fragile and prone to break. In fact, the Py_DECREF implementation is different in newer versions of Python meaning that this could potentially cause memory issues. Instead, simply use the API versions (`Py_DECREF` and `Py_INCREF`) which are functions exposed by the Python library. They could be slightly slower since they require a function call instead of a macro, but are much more reliable and we should only be calling these when the Python Vim plugins are crossing the language boundary anyway which are always going to be slow. Note that this only affects dynamically linked Python builds that are not using stable ABI. Also see #15648 closes: #15653 Signed-off-by: Yee Cheng Chin <ychin.git@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-10 20:56:13 +02:00
/**/
726,
patch 9.1.0725: filetype: swiftinterface files are not recognized Problem: filetype: swiftinterface files are not recognized Solution: Detect '*.swiftinterface' files as swift filetype (LosFarmosCTL) closes: #15658 Signed-off-by: LosFarmosCTL <80157503+LosFarmosCTL@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-10 20:44:59 +02:00
/**/
725,
patch 9.1.0724: if_python: link error with python 3.13 and stable ABI Problem: if_python: link error with python 3.13 and stable ABI (zdohnal) Solution: Use the correct stable APIs Py_IncRef and Py_DecRef instead (Yee Cheng Chin) This fixes #15460 properly. There was an attempt to fix it in v9.1.0668, but it did it by manually copy and pasting definitions from Python 3.13 headers, which is problematic as it makes Vim dependent on low-level implementation details which are subject to change. That change also pulls in dependencies to private APIs (`_Py_IncRef`) which is a very bad idea as the next version of Python could very well remove that. The core issue was simply that `Py_INCREF` and similar functions are not part of the stable API. We are supposed to be using `Py_IncRef` instead which performs null-check (similar to `Py_XINCREF`) and is available as a linkable function. We simply need to call it instead of the macro. We simply remap `Py_INCREF` (and friends) to the function version in stable API similar to how we mapped other functions. related #15460 closes: #15648 Signed-off-by: Yee Cheng Chin <ychin.git@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-09 19:55:24 +02:00
/**/
724,
patch 9.1.0723: if_python: dynamic linking fails with python3 >= 3.13 Problem: if_python: dynamic linking fails with python3 >= 3.13 when using non-stable ABI (zdohnal) Solution: do not try to import the privat python symbol _PyObject_NextNotImplemented (Yee Cheng Chin) Vim is importing a private Python symbol `_PyObject_NextNotImplemented` because it used to be required as part of the `PyIter_Check()` macro in an abstraction breaking way. Python eventually fixed the issue and in 3.13 it removed the private symbol export, which broke Vim. Simply remove importing this private symbol in newer Python versions as it's no longer needed for PyIter_Check to work. fixes: #15457 closes: #15649 Signed-off-by: Yee Cheng Chin <ychin.git@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-09 19:46:17 +02:00
/**/
723,
patch 9.1.0722: crash with large id in text_prop interface Problem: crash with large id in text_prop interface prop_add()/prop_add_list() (cposture) Solution: Error out if the id is > INT_MAX or <= INT_MIN fixes: #15637 closes: #15638 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-08 20:05:23 +02:00
/**/
722,
patch 9.1.0721: tests: test_mksession does not consider XDG_CONFIG_HOME Problem: tests: test_mksession does not consider XDG_CONFIG_HOME Solution: allow to match $HOME/.vim/ and $HOME/.config/vim for &viewdir (John M Devin) closes: #15639 Signed-off-by: John M Devin <john.m.devin@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-08 20:00:38 +02:00
/**/
721,
patch 9.1.0720: Wrong breakindentopt=list:-1 with multibyte or TABs Problem: Wrong breakindentopt=list:-1 with multibyte chars or TABs in text matched by 'formatlistpat' (John M Devin) Solution: Use the width of the match text (zeertzjq) fixes: #15634 closes: #15635 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-07 11:23:54 +02:00
/**/
720,
patch 9.1.0719: Resetting cell widths can make 'listchars' or 'fillchars' invalid Problem: Resetting cell widths can make 'listchars' or 'fillchars' invalid. Solution: Check for conflicts when resetting cell widths (zeertzjq). closes: #15629 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-06 16:24:41 +02:00
/**/
719,
patch 9.1.0718: hard to know the users personal Vim Runtime Directory Problem: hard to guess the Vim Runtime Directory Solution: Set the $MYVIMDIR environment variable to the users personal runtime directory (e.g. ~/.vim on Linux) closes: #15576 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-05 17:46:19 +02:00
/**/
718,
patch 9.1.0717: Unnecessary nextcmd NULL checks in parse_command_modifiers() Problem: Unnecessary nextcmd NULL checks in parse_command_modifiers(). Solution: Remove them (zeertzjq) Every place parse_command_modifiers() is called, nextcmd is NULL, and after it's set to non-NULL the function returns very soon. Even if one day nextcmd may be non-NULL, the NULL checks may still be wrong as the correct behavior may be overriding nextcmd. closes: #15620 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-05 17:26:30 +02:00
/**/
717,
patch 9.1.0716: resetting setcellwidth() doesn't update the screen Problem: resetting setcellwidth() doesn't update the screen Solution: Redraw after clearing the cellwidth table (Ken Takata) closes: #15628 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-05 17:19:34 +02:00
/**/
716,
patch 9.1.0715: Not correctly parsing color names (after v9.1.0709) Problem: Not correctly parsing color names (chdiza, after v9.1.0709) Solution: Revert part of the patch that compares the color names and fall-back to the macro STRICMP fixes: #15617 closes: #15619 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-04 22:10:34 +02:00
/**/
715,
patch 9.1.0714: tests: GuiEnter_Turkish test may fail Problem: tests: GuiEnter_Turkish test may fail Solution: the message will be translated if the Turkish message file is installed. Use gettext() to get the expected message (Ken Takata) closes: #15615 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-03 23:01:55 +02:00
/**/
714,
patch 9.1.0713: Newline causes E749 in Ex mode Problem: Newline causes E749 in Ex mode (after 9.1.0573). Solution: Don't execute empty command followed by a newline. closes: #15614 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-03 22:58:30 +02:00
/**/
713,
patch 9.1.0712: tests: missing dependency of Test_gettext_makefile Problem: tests: missing dependency of Test_gettext_makefile Solution: Check that xgettext binary is available, else skip the test (James McCoy) closes: #15612 Signed-off-by: James McCoy <jamessan@jamessan.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-03 22:50:38 +02:00
/**/
712,
patch 9.1.0711: tests: test_xxd may file when using different xxd Problem: tests: test_xxd may file when using different xxd Solution: Make Test_xxd_color_0 agnostic to xxd's path, similar to Test_xxd_color_1 by filtering out shell command prompt in screen dump file (James McCoy) If an alternative xxd path is provided, e.g., the system installed xxd, then the screen dump fails due to the difference in path. From test_xxd.vim: Found errors in Test_xxd_color2(): Run 1, 15:17:03 - 15:17:04: command line..script /tmp/autopkgtest-lxc.1auv5tlk/downtmp/autopkgtest_tmp/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_xxd_color2[36]..VerifyScreenDump line 67: See dump file difference: call term_dumpdiff("testdir/failed/Test_xxd_color_0.dump", "testdir/dumps/Test_xxd_color_0.dump"); difference in line 1: "|$+0&#ffffff0| |/|u|s|r|/|b|i|n|/|x@1|d| |-|R| |n|e|v|e|r| @1|<| |X@1|D|f|i|l|e|_|c|o|l|o|r|s| @33" related: #15612 Signed-off-by: James McCoy <jamessan@jamessan.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-03 22:46:31 +02:00
/**/
711,
patch 9.1.0710: popup window may hide part of Command line Problem: when a popup window covers the command line, the command line is not completely cleared on popup_hide() (yu3s) Solution: Check if the popup window covers the command line and if it does, set the clear_cmdline flag. fixes: #15608 closes: #15610 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-03 18:20:13 +02:00
/**/
710,
patch 9.1.0709: GUIEnter event not found in Turkish locale Problem: GUIEnter not found in Turkish locale (James McCoy, after v9.1.0256, the issue was there before, but v9.1.0256 made it more apparent) Solution: explicitly compare autocommand events by ASCII value and ignoring locale, because according to the documentation, events are case insensitive (:h autocommand-events) fixes: #15574 closes: #15603 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-02 09:59:18 +02:00
/**/
709,
patch 9.1.0708: Recursive window update does not account for reset skipcol Problem: Window is updated with potentially invalid skipcol in recursive window update path. I.e. cursor outside of visible range in large line that does not fit. Solution: Make sure it is valid (Luuk van Baal). closes: #15605 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-09-01 10:33:56 +02:00
/**/
708,
patch 9.1.0707: [security]: invalid cursor position may cause a crash Problem: [security]: invalid cursor position may cause a crash (after v9.1.0038) Solution: Set cursor to the last character in a line, if it would otherwise point to beyond the line; no tests added, as it is unclear how to reproduce this. Github Advisory: https://github.com/vim/vim/security/advisories/GHSA-4ghr-c62x-cqfh Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-31 17:58:16 +02:00
/**/
707,
patch 9.1.0706: tests: test_gettext fails when using shadow dir Problem: tests: test_gettext fails when using shadow dir Solution: Link the ru_RU directory into the shadow testdir (James McCoy) Link the ru_RU directory into shadow testdir When the ru_RU locale is present, but the build is using a shadowdir, then test_gettext_cp1251.vim and test_gettext_utf8.vim fail: From test_gettext_cp1251.vim: Executed Test_gettext() in 0.000848 seconds Executed 1 test in 0.007010 seconds 1 FAILED: Found errors in Test_gettext(): command line..script /home/runner/work/vim/vim/src/shadow/testdir/runtest.vim[607]..function RunTheTest[57]..Test_gettext line 9: Expected '������: ' but got 'ERROR: ' From test_gettext_utf8.vim: Executed Test_gettext() in 0.000908 seconds Executed 1 test in 0.007339 seconds 1 FAILED: Found errors in Test_gettext(): command line..script /home/runner/work/vim/vim/src/shadow/testdir/runtest.vim[607]..function RunTheTest[57]..Test_gettext line 9: Expected '������: ' but got 'ERROR: ' This is because it's unable to load the translations from the ru_RU test directory, since it wasn't symlinked into the shadow directory. closes: #15591 Signed-off-by: James McCoy <jamessan@jamessan.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-31 17:10:26 +02:00
/**/
706,
patch 9.1.0705: Sorting of fuzzy filename completion is not stable Problem: Sorting of fuzzy filename completion is not stable Solution: Compare indexes when scores are equal. Fix some typos. (zeertzjq) closes: #15593 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-31 17:05:39 +02:00
/**/
705,
patch 9.1.0704: inserting with a count is inefficient Problem: inserting with a count is inefficient Solution: Disable calculation of the cursor position and topline, if a count has been used (Ken Takata) Optimize insertion when using :normal 10000ix. This patch optimizes the insertion with a large count (e.g. `:normal 10000ix`). It seems that calculation of the cursor position for a long line is slow and it takes O(n^2). Disable the calculation if not needed. Before: ``` $ time ./vim --clean -c 'normal 10000ix' -cq! real 0m1.879s user 0m1.328s sys 0m0.139s $ time ./vim --clean -c 'normal 20000ix' -cq! real 0m5.574s user 0m5.421s sys 0m0.093s $ time ./vim --clean -c 'normal 40000ix' -cq! real 0m23.588s user 0m23.187s sys 0m0.140s ``` After: ``` $ time ./vim --clean -c 'normal 10000ix' -cq! real 0m0.187s user 0m0.046s sys 0m0.093s $ time ./vim --clean -c 'normal 20000ix' -cq! real 0m0.217s user 0m0.046s sys 0m0.108s $ time ./vim --clean -c 'normal 40000ix' -cq! real 0m0.278s user 0m0.093s sys 0m0.140s $ time ./vim --clean -c 'normal 80000ix' -cq! real 0m0.494s user 0m0.311s sys 0m0.140s $ time ./vim --clean -c 'normal 160000ix' -cq! real 0m1.302s user 0m1.140s sys 0m0.094s ``` closes: #15588 Signed-off-by: K.Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-31 16:35:06 +02:00
/**/
704,
patch 9.1.0703: crash with 2byte encoding and glob2regpat() Problem: possible crash with 2-byte encoding and glob2regpat() (after v9.1.0700, v9.1.0702) Solution: include both bytes for a multi-byte character for an escaped character closes: #15590 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-29 22:12:05 +02:00
/**/
703,
patch 9.1.0702: Patch 9.1.0700 broke CI Problem: Patch 9.1.0700 broke CI Solution: Revert for now Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-28 23:46:53 +02:00
/**/
702,
patch 9.1.0701: crash with NFA regex engine when searching for composing chars Problem: crash with NFA regex engine when searching for composing chars (SuyueGuo) Solution: When there is no composing character, break out of the loop and check that out1 state is not null fixes: #15583 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-28 23:17:52 +02:00
/**/
701,
patch 9.1.0700: crash with 2byte encoding and glob2regpat() Problem: possible crash with 2byte encoding and glob2regpat() Solution: Skip over character, if it is multi-byte character Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-28 22:08:35 +02:00
/**/
700,
patch 9.1.0699: "dvgo" is not always an inclusive motion Problem: "dvgo" is not always an inclusive motion (Iain King-Speir) Solution: initialize the inclusive flag to false fixes: #15580 closes: #15582 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-28 20:39:24 +02:00
/**/
699,
patch 9.1.0698: tests: "Untitled" file not removed when running Test_crash1_3 alone Problem: tests: "Untitled" file not removed when running Test_crash1_3 alone with TEST_FILTER (after v9.1.0695) Solution: Use a TearDown function instead of another test. (zeertzjq) closes: #15578 closes: #15577 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-26 18:45:37 +02:00
/**/
698,
patch 9.1.0697: [security]: heap-buffer-overflow in ins_typebuf Problem: heap-buffer-overflow in ins_typebuf (SuyueGuo) Solution: When flushing the typeahead buffer, validate that there is enough space left Github Advisory: https://github.com/vim/vim/security/advisories/GHSA-4ghr-c62x-cqfh Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-25 21:33:03 +02:00
/**/
697,
patch 9.1.0696: installing runtime files fails when using SHADOWDIR Problem: installing runtime files fails when using SHADOWDIR Solution: revert part of v9.1.0609, since runtime/doc/Makefile's default value for VIMPROG does not work if vim was built in a SHADOWDIR. (James McCoy) closes: #15575 Signed-off-by: James McCoy <jamessan@jamessan.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-25 20:22:11 +02:00
/**/
696,
patch 9.1.0695: tests: test_crash leaves Untitled file around Problem: tests: test_crash leaves Untitled file around Solution: cleanup at the end of the test_crash.vim test file Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-24 17:34:19 +02:00
/**/
695,
patch 9.1.0694: matchparen is slow on a long line Problem: The matchparen plugin is slow on a long line. Solution: Don't use a regexp to get char at and before cursor. (zeertzjq) Example: ```vim call setline(1, repeat(' foobar', 100000)) runtime plugin/matchparen.vim normal! $hhhhhhhh ``` closes: #15568 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-24 16:32:24 +02:00
/**/
694,
patch 9.1.0693: Configure doesn't show result when not using python3 stable abi Problem: Configure doesn't show result when not using python3 stable abi (after v9.1.0691) Solution: Add back AC_MSG_RESULT() (Ken Takata) related: #15555 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-24 16:27:50 +02:00
/**/
693,
patch 9.1.0692: Wrong patlen value in ex_substitute() Problem: Wrong patlen value in ex_substitute() (after 9.1.0426). Solution: Compute patlen after finding end separator. (zeertzjq) Add a more explicit test. The test already passes as the only case where a overlarge patlen value matters was fixed by patch 9.1.0689. closes: #15565 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-24 11:33:39 +02:00
/**/
692,
patch 9.1.0691: python3: stable-abi may cause segfault on Python 3.11 Problem: python3: stable-abi may cause segfault on Python 3.11 (Audrius Kažukauskas, after v9.1.0668) Solution: do not enable the stable Python ABI by default, only when used with --with-python3-stable-abi argument is given related: #15543 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-23 18:39:08 +02:00
/**/
691,
patch 9.1.0690: cannot set special highlight kind in popupmenu Problem: cannot set special highlight kind in popupmenu Solution: add kind_hlgroup item to complete function (glepnir) closes: #15561 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-23 18:31:06 +02:00
/**/
690,
patch 9.1.0689: [security]: buffer-overflow in do_search() with 'rightleft' Problem: buffer-overflow in do_search() with 'rightleft' (SuyueGuo) Solution: after reversing the text (which allocates a new buffer), re-calculate the text length Github Advisory: https://github.com/vim/vim/security/advisories/GHSA-v2x2-cjcg-f9jm Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-22 21:40:14 +02:00
/**/
689,
patch 9.1.0688: Vim9: dereferences NULL pointer in check_type_is_value() Problem: Vim9: dereferences NULL pointer in check_type_is_value() (Suyue Guo) Solution: Verify that the pointer is not Null fixes: #15540 closes: #15545 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-22 21:25:18 +02:00
/**/
688,
patch 9.1.0687: Makefile may not install desktop files Problem: Makefile may not install desktop files Solution: Check for "$(DESTDIR)$(DATADIR)" instead of just "$DESTDIR", which is usually not defined, add uninstall rules for the icons and the desktop files closes: #15528 fixes: #15546 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-22 21:20:15 +02:00
/**/
687,
patch 9.1.0686: zip-plugin has problems with special characters Problem: zip-plugin has problems with special characters (user202729) Solution: escape '*?[\' on Unix and handle those chars a bit differently on MS-Windows, add a test, check before overwriting files runtime(zip): small fixes for zip plugin This does the following: - verify the unzip plugin is executable when loading the autoload plugin - handle extracting file names with '[*?\' in its name correctly by escaping those characters for the unzip command (and handle those characters a bit differently on MS-Windows, since the quoting is different) - verify, that the extract plugin is not overwriting a file (could cause a hang, because unzip asking for confirmation) - add a test zip file which contains those special file names fixes: #15505 closes: #15519 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-20 22:41:52 +02:00
/**/
686,
patch 9.1.0685: too many strlen() calls in usercmd.c Problem: too many strlen() calls in usercmd.c Solution: refactor code to reduce the number or strlen() calls (John Marriott) closes: #15516 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-20 20:57:23 +02:00
/**/
685,
patch 9.1.0684: completion is inserted on Enter with "noselect" Problem: completion is inserted on Enter with "noselect" (Carman Fu) Solution: check noselect before update compl_shown_match (glepnir) fixes: #15526 closes: #15530 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-20 19:58:44 +02:00
/**/
684,
patch 9.1.0683: mode() returns wrong value with <Cmd> mapping Problem: mode() returns wrong value with <Cmd> mapping Solution: Change decision priority of VIsual_active and move visual mode a bit further down (kuuote) closes: #15533 Signed-off-by: kuuote <znmxodq1@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-20 19:53:17 +02:00
/**/
683,
patch 9.1.0682: Vim9: Segfault with uninitialized funcref Problem: Vim9: Segfault with uninitialized funcref (Daniel Viberg) Solution: Check the Funcref for being Null before trying to access it (Ernie Rael) fixes: #15523 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-19 21:45:23 +02:00
/**/
682,
patch 9.1.0681: tests: Analyzing failed screendumps is hard Problem: tests: Analyzing failed screendumps is hard Solution: Facilitate the viewing of rendered screendumps under src/ add some documentation on how to use the viewdumps.vim script (Aliaksei Budavei) With the submitted "viewdumps.vim" script, a few manual steps in typical workflows (see below) can be automated. The updated "README.txt" contains additional information. ============================================================ Reviewing LOCAL failed screendump tests can be arranged as follows: 1) Run tests and generate screendumps: ------------------------------------------------------------ cd /path/to/fork/src/testdir make ------------------------------------------------------------ 2) Examine the screendumps from the "failed" directory: ------------------------------------------------------------ ../vim -u NONE -S viewdumps.vim ------------------------------------------------------------ ============================================================ Reviewing UPLOADED failed screendump tests can be arranged as follows (it can be further locally scripted): 1) Fetch an artifact with failed screendumps from "github.com/vim/vim/actions/runs/A_ID/artifacts/B_ID". 2) Extract the archived files: ------------------------------------------------------------ unzip /tmp/failed-tests.zip -d /tmp ------------------------------------------------------------ 3) Set up the "dumps" directory. Create a symlink to "/path/to/fork/dirs/dumps" in the extracted directories so that term_dumpdiff() can be used. (The lookup algorithm resolves "dumps" for every loaded filename. So, with "/tmp/src/testdir/failed/*.dump" files passed as script arguments, the algorithm will make the files in "/tmp/src/testdir/dumps" queried.) ------------------------------------------------------------ cd /path/to/fork ln -s $(pwd)/src/testdir/dumps /tmp/src/testdir/dumps ------------------------------------------------------------ 4) Examine the extracted screendumps: ------------------------------------------------------------ ./src/vim -u NONE -S src/testdir/viewdumps.vim \ /tmp/src/testdir/failed/*.dump ------------------------------------------------------------ 5) Clean up: ------------------------------------------------------------ unlink /tmp/src/testdir/dumps rm -rf /tmp/src ------------------------------------------------------------ ============================================================ Reviewing SUBMITTED FOR PULL REQUEST screendump tests can be arranged as follows (it can be further locally scripted): 1) List the fetched changeset and write the changed "dumps" filenames to "/tmp/filelist": ------------------------------------------------------------ cd /path/to/fork git switch prs/1234 git diff-index --relative=src/testdir/dumps/ \ --name-only prs/1234~1 > /tmp/filelist ------------------------------------------------------------ 2) Reconcile relative filepaths, and copy next-to-be-updated "dumps" files in the "failed" directory (note the missing new screendumps, if any): ------------------------------------------------------------ git switch master cd src/testdir/dumps test -d ../failed || mkdir ../failed cp -t ../failed $(cat /tmp/filelist) ------------------------------------------------------------ 3) Remember about the introduced INVERTED relation between "dumps" and "failed", i.e. the files to be committed are in "dumps" already and their previous versions are in "failed"; therefore, copy the missing new screendumps from "dumps" to "failed" (otherwise these won't be shown): ------------------------------------------------------------ git switch prs/1234 cp -t ../failed foo_10.dump foo_11.dump foo_12.dump ------------------------------------------------------------ 4) Examine the screendumps from the "failed" directory (new screendumps will be shown with no difference between their versions): ------------------------------------------------------------ cd .. ../vim -u NONE -S viewdumps.vim ------------------------------------------------------------ closes: #15515 Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-19 21:33:26 +02:00
/**/
681,
patch 9.1.0680: VMS does not have defined uintptr_t Problem: VMS does not have defined uintptr_t Solution: Add type definitions (Zoltan Arpadffy) closes: #15520 Signed-off-by: Zoltan Arpadffy <zoltan.arpadffy@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-18 16:59:20 +02:00
/**/
680,
patch 9.1.0679: Rename from w_closing to w_locked is incomplete Problem: Rename from w_closing to w_locked is incomplete (after 9.1.0678). Solution: Rename remaining occurrences of w_closing to w_locked and update comments (zeertzjq). closes: #15504 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-16 21:11:31 +02:00
/**/
679,
patch 9.1.0678: [security]: use-after-free in alist_add() Problem: [security]: use-after-free in alist_add() (SuyueGuo) Solution: Lock the current window, so that the reference to the argument list remains valid. This fixes CVE-2024-43374 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-15 22:15:28 +02:00
/**/
678,
patch 9.1.0677: :keepp does not retain the substitute pattern Problem: :keeppatterns does not retain the substitute pattern for a :s command Solution: preserve the last substitute pattern when used with the :keeppatterns command modifier (Gregory Anders) closes: #15497 Signed-off-by: Gregory Anders <greg@gpanders.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-15 22:04:22 +02:00
/**/
677,
patch 9.1.0676: style issues with man pages Problem: style issues with man pages Solution: update man pages and test_xxd.vim, since it uses the xxd man page (RestorerZ) closes: #15489 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-15 21:39:33 +02:00
/**/
676,
patch 9.1.0675: Patch v9.1.0674 causes problems Problem: Patch v9.1.0674 causes problems Solution: Revert it for now Revert "patch 9.1.0674: Vim9: compiling abstract method fails because of missing return" This reverts commit 7477861e0d1d4bb168a65585c49c66e57b3ec636. Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-14 22:52:03 +02:00
/**/
675,
patch 9.1.0674: Vim9: compiling abstract method fails because of missing return Problem: Vim9: compiling abstract method fails because of missing return (Aliaksei Budavei) Solution: don't require a return statement for an abstract method when compiling (Ernie Rael) fixes: #15432 closes: #15441 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-14 14:53:55 +02:00
/**/
674,
patch 9.1.0673: Vim9: too recursive func calls when calling super-class method Problem: Vim9: too recursive func calls when calling super-class method with non-overriden super-call methods. (Aliaksei Budavei) Solution: use interface method, when super is to be used (Ernie Rael) When compiling "super.Func()" force class context to class that defines function that is doing "super.Func()". ISN_METHODCALL arg "cmf_is_super" for specific ufunc. fixes: #15448 fixes: #15463 (2) super.method may not execute in context of defining class closes: #15477 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-13 23:27:22 +02:00
/**/
673,
patch 9.1.0672: marker folds may get corrupted on undo Problem: marker folds may get corrupted on undo (Yousef Mohammed) Solution: when adjusting folds, make sure that line1 is the lower limit and line2 is the upper line limit. In particular, line2 should not be able to get smaller than line1. fixes: #15455 closes: #15466 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-11 20:12:41 +02:00
/**/
672,
Problem: crash with WinNewPre autocommand Problem: crash with WinNewPre autocommand, because window structures are not yet safe to use Solution: Don't trigger WinNewPre on :tabnew Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-11 20:09:17 +02:00
/**/
671,
patch 9.1.0670: po file encoding fails on *BSD during make Problem: po file encoding fails on *BSD during make Solution: instead of using `$<` make use of variable `$?` which should be equivalent when the rule is dependent on only a single file (RestorerZ). closes: #15471 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-11 20:03:35 +02:00
/**/
670,
patch 9.1.0669: if_python: stable python ABI not used by default Problem: stable python ABI not used by default Solution: Enable stable python ABI v3.8 when building with python3/dyn by default, update the default Python3 version to 3.8 for MS-Windows (Ken Takata) closes: #15470 related: #15457 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-11 18:41:41 +02:00
/**/
669,
patch 9.1.0668: build-error with python3.12 and stable ABI Problem: build-error with python3.12 and stable ABI (zdohnal) Solution: Add type casts, define Py_INCREF for Python3.12 and higher (Ken Takata) fixes: #15460 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-10 09:44:20 +02:00
/**/
668,
patch 9.1.0667: Some other options reset curswant unnecessarily when set Problem: Some other options reset curswant unnecessarily when set. (Andrew Haust) Solution: Don't reset curswant when setting 'comments', 'commentstring' or 'define' (zeertzjq) fixes: #15462 closes: #15467 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-10 09:35:20 +02:00
/**/
667,
patch 9.1.0666: assert_equal() doesn't show multibyte string correctly Problem: assert_equal() doesn't show multibyte string correctly Solution: Properly advance over a multibyte char. (zeertzjq) closes: #15456 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-09 19:52:10 +02:00
/**/
666,
patch 9.1.0665: Locked variable can be changed in a :for loop Problem: Locked variable can be changed in a :for loop. Solution: Always do a full permission check on the first loop iteration where ASSIGN_DECL is not set (zeertzjq). related: #12470 fixes: #15450 closes: #15454 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-08 21:05:57 +02:00
/**/
665,
patch 9.1.0664: MS-Windows: console vim did not switch back to main screen on exit Problem: MS-Windows: console vim did not switch back to main screen on exit Solution: switch back to main screen on exit (Ken Takata) `vim.exe --cmd quit` quitted without switching back to the main screen buffer and the alternate screen buffer was kept shown. Restore the main screen buffer even when termcap mode has not been started. closes: #15443 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-07 21:18:24 +02:00
/**/
664,
patch 9.1.0663: tests: zip test still resets 'shellslash' option Problem: tests: zip test still resets 'shellslash' option Solution: Remove resetting the 'shellslash' option, the zip plugin should now be able to handle this options closes: #15434 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-05 21:08:42 +02:00
/**/
663,
patch 9.1.0662: filecopy() may return wrong value when readlink() fails Problem: filecopy() may return wrong value when readlink() fails. Solution: Set ret to -1 so that 0 is returned when readlink() fails. (zeertzjq) closes: #15438 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-06 19:51:09 +02:00
/**/
662,
patch 9.1.0661: the zip plugin is not tested. Problem: the zip plugin is not tested. Solution: include tests (Damien) closes: #15411 Signed-off-by: Damien <141588647+xrandomname@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-05 20:24:11 +02:00
/**/
661,
patch 9.1.0660: MS-Windows: Shift-Insert does work on old conhost Problem: MS-Windows: Shift-Insert does not work on old conhost (Nick Jensen, after 9.0.1146) Solution: handle Shift-Insert specifically (Christian Plewright) fixes: #15326 closes: #15430 Signed-off-by: Christopher Plewright <chris@createng.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-04 19:57:44 +02:00
/**/
660,
patch 9.1.0659: MS-Windows: MSVC Makefile is a bit hard to read Problem: MS-Windows: MSVC Makefile is a bit hard to read (after v9.1.0657) Solution: indent the if/else statements to improve readability (Ken Takata) closes: #15428 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-04 18:31:48 +02:00
/**/
659,
patch 9.1.0658: Coverity warns about dereferencing NULL pointer. Problem: Coverity warns about dereferencing NULL pointer. Solution: Bail out if vim_strrchr() returns NULL. (zeertzjq) ________________________________________________________________________________________________________ *** CID 1616019: (NULL_RETURNS) /src/help.c: 834 in fix_help_buffer() 828 continue; 829 t2 = gettail(f2); 830 e2 = vim_strrchr(t2, '.'); 831 if (e1 - f1 != e2 - f2 832 || fnamencmp(f1, f2, e1 - f1) != 0) 833 continue; >>> CID 1616019: (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "(char_u *)e2" when calling "vim_fnamecmp". 834 if (fnamecmp(e1, ".txt") == 0 835 && fnamecmp(e2, fname + 4) == 0) 836 // use .abx instead of .txt 837 VIM_CLEAR(fnames[i1]); 838 } 839 } /src/help.c: 816 in fix_help_buffer() 810 // the same directory. 811 for (i1 = 0; i1 < fcount; ++i1) 812 { 813 f1 = fnames[i1]; 814 t1 = gettail(f1); 815 e1 = vim_strrchr(t1, '.'); >>> CID 1616019: (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "(char_u *)e1" when calling "vim_fnamecmp". 816 if (fnamecmp(e1, ".txt") != 0 817 && fnamecmp(e1, fname + 4) != 0) 818 { 819 // Not .txt and not .abx, remove it. 820 VIM_CLEAR(fnames[i1]); 821 continue; closes: #15420 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-03 14:52:00 +02:00
/**/
658,
patch 9.1.0657: MS-Windows: MSVC build time can be optimized Problem: MS-Windows: MSVC build time can be optimized Solution: Stop using Powershell, show detected version, read _MSC_VER and _MSC_FULL_VER in a single cl execution. (Ken Takata) closes: #15421 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-03 14:40:35 +02:00
/**/
657,
patch 9.1.0656: MS-Windows: MSVC Makefile CPU handling can be improved Problem: MS-Windows: MSVC Makefile CPU handling can be improved Solution: Update Makefile and also remove some old code (Ken Takata) * The variable `ASSEMBLY_ARCHITECTURE` was originally used to generate the manifest file. However, this was removed in v7.0.198. Remove `ASSEMBLY_ARCHITECTURE` and use `CPU` instead. * `/arch:AVX512` is available starting from Visual C++ 2017. * ARM64 was not considered when validating CPUNR. Skip the validation for ARM64 for now. * Remove old code for VC6/7 and Win9x. closes: #15422 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-03 14:34:33 +02:00
/**/
656,
patch 9.1.0655: filetype: goaccess config file not recognized Problem: filetype: goaccess config file not recognized Solution: detect 'goaccess.conf' as goaccess filetype, also include a basic syntax and ftplugin (Adam Monsen) Add syntax highlighting for GoAccess configuration file. GoAccess is a real-time web log analyzer and interactive viewer that runs in a terminal in *nix systems or through your browser. GoAccess home page: https://goaccess.io closes: #15414 Signed-off-by: Adam Monsen <haircut@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-02 19:54:15 +02:00
/**/
655,
patch 9.1.0654: completion does not respect completeslash with fuzzy Problem: completion does not respect completeslash with fuzzy (egesip) Solution: Change path separator on Windows, depending on 'completeslash' option value (glepnir) fixes: #15392 closes: #15418 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-02 19:14:38 +02:00
/**/
654,
patch 9.1.0653: Patch v9.1.0648 not completely right Problem: Patch v9.1.0648 not completely right (zeertzjq) Solution: Remove always true condition closes: #15415 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-02 19:06:41 +02:00
/**/
653,
patch 9.1.0652: too many strlen() calls in syntax.c Problem: too many strlen() calls in syntax.c Solution: refactor code to reduce the number or strlen() calls, get rid of un-used SYN_NAMELEN macro (John Marriott) closes: #15368 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-01 23:01:25 +02:00
/**/
652,
patch 9.1.0651: ex: trailing dot is optional for :g and :insert/:append Problem: ex: trailing dot is optional for :g and :insert/:append Solution: don't break out early, when the next command is empty. (Mohamed Akram) The terminating period is optional for the last command in a global command list. closes: #15407 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-01 22:53:01 +02:00
/**/
651,
patch 9.1.0650: Coverity warning in cstrncmp() Problem: Coverity warning in cstrncmp() (after v9.1.0645) Solution: Change the type of n2 to int. (zeertzjq) ________________________________________________________________________________________________________ *** CID 1615684: Integer handling issues (INTEGER_OVERFLOW) /src/regexp.c: 1757 in cstrncmp() 1751 n1 -= mb_ptr2len(s1); 1752 MB_PTR_ADV(p); 1753 n2++; 1754 } 1755 // count the number of bytes to advance the same number of chars for s2 1756 p = s2; >>> CID 1615684: Integer handling issues (INTEGER_OVERFLOW) >>> Expression "n2--", which is equal to 18446744073709551615, where "n2" is known to be equal to 0, underflows the type that receives it, an unsigned integer 64 bits wide. 1757 while (n2-- > 0 && *p != NUL) 1758 MB_PTR_ADV(p); 1759 1760 n2 = p - s2; 1761 1762 result = MB_STRNICMP2(s1, s2, *n, n2); closes: #15409 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-01 22:48:53 +02:00
/**/
650,
patch 9.1.0649: Wrong comment for "len" argument of call_simple_func() Problem: Wrong comment for "len" argument of call_simple_func(). Solution: Remove the "or -1 to use strlen()". Also change its type to size_t to remove one cast. (zeertzjq) closes: #15410 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-01 22:46:54 +02:00
/**/
649,
patch 9.1.0648: [security] double-free in dialog_changed() Problem: [security] double-free in dialog_changed() (SuyueGuo) Solution: Only clear pointer b_sfname pointer, if it is different than the b_ffname pointer. Don't try to free b_fname, set it to NULL instead. fixes: #15403 Github Advisory: https://github.com/vim/vim/security/advisories/GHSA-46pw-v7qw-xc2f Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-01 22:10:28 +02:00
/**/
648,
patch 9.1.0647: [security] use-after-free in tagstack_clear_entry Problem: [security] use-after-free in tagstack_clear_entry (Suyue Guo ) Solution: Instead of manually calling vim_free() on each of the tagstack entries, let's use tagstack_clear_entry(), which will also free the stack, but using the VIM_CLEAR macro, which prevents a use-after-free by setting those pointers to NULL This addresses CVE-2024-41957 Github advisory: https://github.com/vim/vim/security/advisories/GHSA-f9cr-gv85-hcr4 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-01 20:16:51 +02:00
/**/
647,
patch 9.1.0646: Vim9: imported function may not be found Problem: Vim9: imported function may not be found Solution: Try to find the function by name (Ernie Rael) fixes: #15381 closes: #15382 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-31 22:18:11 +02:00
/**/
646,
patch 9.1.0645: regex: wrong match when searching multi-byte char case-insensitive Problem: regex: wrong match when searching multi-byte char case-insensitive (diffsetter) Solution: Apply proper case-folding for characters and search-string This patch does the following 4 things: 1) When the regexp engine compares two utf-8 codepoints case insensitive it may match an adjacent character, because it assumes it can step over as many bytes as the pattern contains. This however is not necessarily true because of case-folding, a multi-byte UTF-8 character can be considered equal to some single-byte value. Let's consider the pattern 'ſ' and the string 's'. When comparing and ignoring case, the single character 's' matches, and since it matches Vim will try to step over the match (by the amount of bytes of the pattern), assuming that since it matches, the length of both strings is the same. However in that case, it should only step over the single byte value 's' by 1 byte and try to start matching after it again. So for the backtracking engine we need to ensure: * we try to match the correct length for the pattern and the text * in case of a match, we step over it correctly There is one tricky thing for the backtracing engine. We also need to calculate correctly the number of bytes to compare the 2 different utf-8 strings s1 and s2. So we will count the number of characters in s1 that the byte len specified. Then we count the number of bytes to step over the same number of characters in string s2 and then we can correctly compare the 2 utf-8 strings. 2) A similar thing can happen for the NFA engine, when skipping to the next character to test for a match. We are skipping over the regstart pointer, however we do not consider the case that because of case-folding we may need to adjust the number of bytes to skip over. So this needs to be adjusted in find_match_text() as well. 3) A related issue turned out, when prog->match_text is actually empty. In that case we should try to find the next match and skip this condition. 4) When comparing characters using collections, we must also apply case folding to each character in the collection and not just to the current character from the search string. This doesn't apply to the NFA engine, because internally it converts collections to branches [abc] -> a\|b\|c fixes: #14294 closes: #14756 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-30 20:39:18 +02:00
/**/
645,
patch 9.1.0644: Unnecessary STRLEN() when applying mapping Problem: Unnecessary STRLEN() when applying mapping. (after v9.1.0642) Solution: Use m_keylen and vim_strnsave(). (zeertzjq) closes: #15394 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-30 19:17:56 +02:00
/**/
644,
patch 9.1.0643: terminal: cursor may end up on invalid position Problem: terminal: cursor may end up on invalid position after reducing the scrollback lines (user202729) Solution: After reducing the scrollback size, check the cursor position, making sure it does not end up on an invalid line fixes: #15351 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-29 21:19:51 +02:00
/**/
643,
patch 9.1.0642: Check that mapping rhs starts with lhs fails if not simplified Problem: Check that mapping rhs starts with lhs doesn't work if lhs is not simplified. Solution: Keep track of the mapblock containing the alternative lhs and also compare with it (zeertzjq). fixes: #15376 closes: #15384 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-29 21:10:07 +02:00
/**/
642,
patch 9.1.0641: MS-Windows: OLE enabled in console version Problem: MS-Windows: OLE enabled in console version, may cause hang (Linda_pp) Solution: Disable OLE for console version (Ken Takata) If VIMDLL was enabled, a message box for registering OLE might be shown even if Vim was executed in a console. (See #15372) Enabling OLE in a console is not so useful. Disable it. fixes: #15372 closes: #15385 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-29 20:57:19 +02:00
/**/
641,
patch 9.1.0640: Mingw: Makefile can be improved Problem: Mingw: Makefile can be improved Solution: Reduce nesting level, directly check if the '-Wl,--entry' option is required (Ken Takata) closes: #15386 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-29 20:43:21 +02:00
/**/
640,
patch 9.1.0639: channel timeout may wrap around Problem: channel timeout may wrap around Solution: Correct timeout calculation when GetTickCount() wraps around (Ken Takata) closes: #15390 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-29 20:39:12 +02:00
/**/
639,
patch 9.1.0638: E1510 may happen when formatting a message for smsg() Problem: E1510 may happen when formatting a message (after 9.1.0181). Solution: Only give E1510 when using typval. (zeertzjq) closes: #15391 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-29 20:28:14 +02:00
/**/
638,
patch 9.1.0637: MS-Windows: Style issues in MSVC Makefile Problem: MS-Windows: Style issues in MSVC Makefile Solution: Fix style issues, simplify logic (Ken Takata) * Add space around the operators for consistency. * Remove unnecessary ren command. Use the /Fe option to create install.exe directly. * Remove unnecessary mkdir auto command. src/auto should always exist. closes: #15389 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-29 19:52:03 +02:00
/**/
637,
patch 9.1.0636: filetype: ziggy files are not recognized Problem: filetype: ziggy files are not recognized Solution: detect '*.ziggy' files as ziggy filetype, detect '*.ziggy-schema' files as ziggy-schema filetype (EliSauder) References: https://ziggy-lang.io/ fixes: #15355 closes: #15367 Signed-off-by: EliSauder <24995216+EliSauder@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-28 21:32:38 +02:00
/**/
636,
patch 9.1.0635: filetype: SuperHTML template files not recognized Problem: filetype: SuperHTML template files not recognized Solution: Update the filetype detection code to detect '*.shtml' either as HTML (Server Side Includes) or SuperHTML (template files) (EliSauder) related: #15355 related: #15367 Signed-off-by: EliSauder <24995216+EliSauder@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-28 21:28:11 +02:00
/**/
635,
patch 9.1.0634: Ctrl-P not working by default Problem: Ctrl-P not working by default (Jesse Pavel, after v9.1.0598) Solution: Revert part of v9.1.0598 and set cur_match_pos correctly according to compl_dir_forward() fixes: #15370 closes: #15379 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-28 21:16:48 +02:00
/**/
634,
patch 9.1.0633: Compilation warnings with `-Wunused-parameter` Problem: Compilation warnings with `-Wunused-parameter` Solution: Add the `UNUSED` macro where needed, and remove some superfluous ones (Dominique Pellé) Change fixes these kind of warnings when building without the channel feature: ``` eval.c:6122:15: warning: unused parameter ‘tv’ [-Wunused-parameter] typval_T *tv, ^ eval.c:6123:14: warning: unused parameter ‘tofree’ [-Wunused-parameter] char_u **tofree, ^ eval.c:6124:13: warning: unused parameter ‘numbuf’ [-Wunused-parameter] char_u *numbuf, ^ eval.c:6125:10: warning: unused parameter ‘composite_val’ [-Wunused-parameter] int composite_val) ``` closes: #15378 Signed-off-by: Dominique Pellé <dominique.pelle@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-28 21:12:20 +02:00
/**/
633,
patch 9.1.0632: MS-Windows: Compiler Warnings Problem: MS-Windows: Compiler Warnings Solution: Fix the warnings (Ken Takata) * Unused variable. * Conversion from size_t to int. closes: #15369 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-28 17:08:15 +02:00
/**/
632,
patch 9.1.0631: wrong completion list displayed with non-existing dir + fuzzy completion Problem: wrong completion list displayed with non-existing dir + fuzzy completion (kawarimidoll) Solution: clear list of matches, if leader did not use fuzzy match (glepnir) fixes: #15357 closes: #15365 Signed-off-by: glepnir <glephunter@gmail.com>
2024-07-27 16:25:45 +02:00
/**/
631,
patch 9.1.0630: MS-Windows: build fails with VIMDLL and mzscheme Problem: MS-Windows: build fails with VIMDLL and mzscheme Solution: define scheme_register_tls_space() inside gvim.exe and refer to it from the dll (Ken Takata). `scheme_register_tls_space()` doesn't support a thread-local variable in a DLL: https://docs.racket-lang.org/inside/im_memoryalloc.html#%28cpp._scheme_register_tls_space%29 closes: #15363 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-27 13:25:34 +02:00
/**/
630,
patch 9.1.0629: Rename of pum hl_group is incomplete Problem: Rename of pum hl_group is incomplete in source. Solution: Also rename the test function. Rename to user_hlattr in code to avoid confusion with pum_extra. Add test with matched text highlighting (zeertzjq). closes: #15348 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-27 13:21:49 +02:00
/**/
629,
patch 9.1.0628: MinGW: coverage files are not cleaned up Problem: MinGW: coverage files are not cleaned up Solution: Adjust clean rule to remove the coverage files (Ken Takata) closes: #15361 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-27 13:14:35 +02:00
/**/
628,
patch 9.1.0627: MinGW: build-error when COVERAGE is enabled Problem: MinGW: build-error when COVERAGE is enabled (after v9.1.0621) Solution: Fix regressions in v9.1.0621 and v9.1.0622 (Ken Takata) * Fix build error when COVERAGE=yes. * Fix if_lua with USE_GC_SECTIONS=yes. related: #15361 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-27 13:11:27 +02:00
/**/
627,
patch 9.1.0626: Vim9: need more tests with null objects Problem: Vim9: need more tests with null objects (after v9.1.0620) Solution: add one more test with null_object (Ernie Rael) closes: #15360 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 19:40:29 +02:00
/**/
626,
patch 9.1.0625: tests: test output all translated messages for all translations Problem: tests: test output all translated messages for all translations Solution: Redirect the output of check.vim to /dev/null, it's not that useful. closes: #15354 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 19:21:03 +02:00
/**/
625,
patch 9.1.0624: ex command modifiers not found Problem: ex command modifiers are not found (Ingo Karkat, after v9.1.0352) Solution: partly revert patch v9.1.0352, ignore :{ and :} when expanding ex commands The issue is, that the :keepmarks command can be abbreviated to :kee or :keep or :keepm but not to e.g. :ke (because that would be the :exe command :k with register e). This basically means, we need `:kee` sorted before `:keepalt` but at the same time `:keepmarks` sorted after the `:keepalt` command in the cmdmod_info_tab table. Due to this, the binary search may not work correctly, so let's revert that part of patch v9.1.0352. fixes: #15305 closes: #15336 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 19:13:55 +02:00
/**/
624,
patch 9.1.0623: Mingw: errors when trying to delete non-existing files Problem: Mingw: warnings when trying to delete non-existing files Solution: Use "rm -f" instead of "rm" to suppress errors for non-existing files (Ken Takata) closes: #15350 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 19:02:11 +02:00
/**/
623,
patch 9.1.0622: MS-Windows: mingw-build can be optimized Problem: MS-Windows: mingw-build can be optimized Solution: use --gc-sections to reduce the size of the executable (Ken Takata) Use the --gc-sections linker option and the -ffunction-sections compiler option to reduce the size of the executable files. To make these work, the -fno-asynchronous-unwind-tables compiler option is also needed. This is enabled by default and can be disabled by `USE_GC_SECTIONS=no`. Note: A similar feature has been already used in MSVC. (The /OPT linker option.) related: #15350 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 18:51:20 +02:00
/**/
622,
patch 9.1.0621: MS-Windows: startup code can be improved Problem: MS-Windows: startup code can be improved Solution: Re-work and optimize win32 startup code (Ken Takata) * Revise the code and reduce #ifdefs. * For VIMDLL, stop using the default CRT startup code to reduce the file size. The file size becomes ~130 KB -> ~34 KB on MSVC. * Update comments. Make them consistent between os_w32dll.c and os_w32exe.c. closes: #15352 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 18:46:54 +02:00
/**/
621,
patch 9.1.0620: Vim9: segfauls with null objects Problem: Vim9: segfauls with null objects (after v9.1.0219) Solution: Check object pointer being NULL (Ernie Rael) fixes: #15338 closes: #15349 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 18:37:02 +02:00
/**/
620,
patch 9.1.0619: tests: test_popup fails Problem: tests: test_popup fails (after v9.1.0618) Solution: Correct test, move combining extra attributes to pum_compute_text_attrs() (glepnir) closes: #15353 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-26 18:15:27 +02:00
/**/
619,
patch 9.1.0618: cannot mark deprecated attributes in completion menu Problem: cannot mark deprecated attributes in completion menu Solution: add hl_group to the Dictionary of supported completion fields (glepnir) closes: #15314 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-25 21:39:08 +02:00
/**/
618,
patch 9.1.0617: Cursor moves beyond first line of folded end of buffer Problem: Cursor moves beyond start of a folded range at the end of a buffer. Solution: Move cursor to start of fold when going beyond end of buffer. Check that cursor moved to detect FAIL in outer cursor function. (Luuk van Baal) closes: #15344 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-25 21:24:32 +02:00
/**/
617,
patch 9.1.0616: filetype: Make syntax highlighting off for MS Makefiles Problem: filetype: Make syntax highlighting off for MS Makefiles Solution: Try to detect MS Makefiles and adjust syntax rules to it. (Ken Takata) Highlighting of variable expansion in Microsoft Makefile can be broken. E.g.: https://github.com/vim/vim/blob/2979cfc2627d76a9c09cad46a1647dcd4aa73f5f/src/Make_mvc.mak#L1331 Don't use backslash as escape characters if `make_microsoft` is set. Also fix that `make_no_comments` was not considered if `make_microsoft` was set. Also add description for `make_microsoft` and `make_no_comments` to the documentation and include a very simple filetype test closes: #15341 Signed-off-by: Christian Brabandt <cb@256bit.org> Signed-off-by: Ken Takata <kentkt@csc.jp>
2024-07-25 21:07:13 +02:00
/**/
616,
patch 9.1.0615: Unnecessary STRLEN() in make_percent_swname() Problem: Unnecessary STRLEN() in make_percent_swname() Solution: Pass the end of "dir" to make_percent_swname() (zeertzjq) closes: #15340 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-25 20:58:42 +02:00
/**/
615,
patch 9.1.0614: tests: screendump tests fail due to recent syntax changes Problem: Vim syntax file changes to :set command highlighting render some test dump files invalid. (zeertzjq, after commit ddbb6fe) Solution: Regenerate the affected dump files (Doug Kearns) closes: #15342 Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-25 20:43:50 +02:00
/**/
614,
patch 9.1.0613: tests: termdebug test may fail and leave file around Problem: tests: termdebug test may fail and leave temp file around (Dominique Pellé) Solution: only run balloon_show() if the function exists, validate termdebug is running using the g: termdebug_is_running var, use defer to delete temporary files fixes: #15334 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-24 21:37:39 +02:00
/**/
613,
patch 9.1.0612: filetype: deno.lock file not recognized Problem: filetype: deno.lock file not recognized Solution: detect 'deno.lock' as json filetype (カワリミ人形) Reference: https://docs.deno.com/runtime/manual/basics/modules/integrity_checking/#caching-and-lock-files closes: #15333 Signed-off-by: カワリミ人形 <kawarimidoll+git@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-24 20:10:58 +02:00
/**/
612,
patch 9.1.0611: ambiguous mappings not correctly resolved with modifyOtherKeys Problem: ambiguous mappings not correctly resolved with modifyOtherKeys Solution: Check for termcode when an upper case mapping is received and does not match (Oleg Goncharov) Fix for mapping processing when capital leters are represented with terminal codes. Problem: there are two mappings and 1) the first mapping is substring of the second, 2) the first non-matching letter is capital, 3) capital letters are represented with termcodes "ESC[27;2;<ascii code>~" in given system then first mapping is applied instead of second. Example: :map B b :map BBB blimp! and then BBB -> bbb instead of BBB -> blimp! Solution: force termcodes check if capital letter does not match. closes: #15251 Signed-off-by: Oleg Goncharov <goncharovoi@yandex.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-23 20:34:15 +02:00
/**/
611,
patch 9.1.0610: filetype: OpenGL Shading Language files are not detected Problem: filetype: OpenGL Shading Language files are not detected Solution: detect various file extensions as GLSL filetype, include indent and syntax script, do no longer recognize '*.comp' as Mason filetype (Gregory Anders) closes: #15317 Signed-off-by: Gregory Anders <greg@gpanders.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-22 20:33:48 +02:00
/**/
610,
patch 9.1.0609: outdated comments in Makefile Problem: outdated comments in Makefile Solution: update outdated comments, update rule for vimtags (Shane Harper) related: commit b81109192f Here are the changes and the reasons for them: - Delete the comment preceding the assignment to VIMPROG. Since b81109192f there's no need for VIMPROG to be set to something else when this is executed from src/Makefile. (The comment was wrong anyway; VIMPROG was being set to "$$BUILD_DIR/$(VIMTARGET)".) ``` # Set to $(VIMTARGET) when executed from src/Makefile. VIMPROG = ../../src/vim ``` - Delete "`and installed`" in the following comment; The vimtags rule doesn't require that Vim has been installed. ``` # Use Vim to generate the tags file. Can only be used when Vim has been # compiled and installed. Supports multiple languages. vimtags: $(DOCS) ``` - With commit b81109192f there is no longer a need to set VIMPROG here: ``` -@BUILD_DIR="`pwd`"; cd $(HELPSOURCE); if test -z "$(CROSS_COMPILING)"; then \ $(MAKE) VIMPROG="$$BUILD_DIR/$(VIMTARGET)" vimtags; fi ``` The new code below will use the same vim executable as the old code: ``` -@cd $(HELPSOURCE); if test -z "$(CROSS_COMPILING)"; then \ $(MAKE) vimtags; fi ``` - Delete the following comment which was related to setting VIMPROG as it no longer has any value: ``` # We can assume Vim was build, but it may not have been installed, # thus use the executable in the current directory. ``` Note: this comment used to be (unnecessarily) echoed to the terminal (because it was indented) when making installrtbase. closes: #15320 Signed-off-by: Shane Harper <shane@shaneharper.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-22 20:09:26 +02:00
/**/
609,
patch 9.1.0608: Coverity warns about a few potential issues Problem: Coverity warns about a few potential issues Solution: Fix those issues (see details below) 1) Fix overflow warning in highlight.c This happens because we are comparing int with long and assign a potential long value to an int, which could cause an overflow. So add some casts to ensure the value fits into an int. 2) Fix Overflow warning in shift_line(). This happens because we are performing a division/modulo operation of a long type by an int type and assign the result to an int, which could then overflow. So before performing the operation, trim the long to value to at most max int value, so that it can't overflow. 3) Fix overflow warning in syn_list_cluster in syntax.c This is essential the same issue as 1) 4) not checking the return value of vim_mkdir() in spellfile.c Creating the spell directory could fail. Handle this case and return early in this case. 5) qsort() may deref a NULL pointer when fuzzy match does not return a result. Fix this by checking that the accessed growarray fuzzy_indices actually contains data. If not we can silently skip the qsort() and related logic. closes: #15284 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-20 13:26:44 +02:00
/**/
608,
patch 9.1.0607: termdebug: uses inconsistent style Problem: termdebug: uses inconsistent style Solution: termdebug: deprecate numeric values for v:true/false, fix white space style in the plugin (Ubaldo Tiberi) closes: #15304 Signed-off-by: Ubaldo Tiberi <ubaldo.tiberi@google.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-20 12:00:44 +02:00
/**/
607,
patch 9.1.0606: tests: generated files may cause failure in test_codestyle Problem: tests: generated files may cause failure in test_codestyle Solution: Exclude OLE-related generated files from style checks. (Ken Takata) Some OLE-related auto-generated files may contain space errors: https://ci.appveyor.com/project/chrisbra/vim-win32-installer/builds/50248542/job/w45ve9yd6qmmws8t#L11475 ``` From test_codestyle.vim: Found errors in Test_source_files(): command line..script C:/projects/vim-win32-installer/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_source_files[8]..<SNR>8_PerformCheck[11]..<SNR>8_ReportError line 2: ../dlldata.c line 2: trailing white space command line..script C:/projects/vim-win32-installer/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_source_files[8]..<SNR>8_PerformCheck[11]..<SNR>8_ReportError line 2: ../iid_ole.c line 12: trailing white space command line..script C:/projects/vim-win32-installer/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_source_files[6]..<SNR>8_PerformCheck[11]..<SNR>8_ReportError line 2: ../if_ole.h line 60: space before Tab command line..script C:/projects/vim-win32-installer/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_source_files[8]..<SNR>8_PerformCheck[11]..<SNR>8_ReportError line 2: ../if_ole.h line 10: trailing white space ``` Exclude them from style checking. closes: #15309 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-20 11:55:13 +02:00
/**/
606,
patch 9.1.0605: internal error with fuzzy completion Problem: internal error with fuzzy completion (techntools) Solution: only fuzzy complete the pattern after directory separator (glepnir) fixes: #15287 closes: #15291 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-19 16:45:05 +02:00
/**/
605,
patch 9.1.0604: popup_filter during Press Enter prompt seems to hang Problem: popup_filter during Press Enter prompt seems to hang Solution: Return early, when need_wait_return is set (Ernie Rael) fixes: #15300 closes: #15301 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-19 16:37:09 +02:00
/**/
604,
patch 9.1.0603: filetype: use correct extension for Dracula Problem: pattern detection for Dracula language uses "*lvs" and "*lpe". as there is no dot, those are not treated as extensions which they should (judging by 'runtime/syntax/dracula.vim' and common sense). Solution: use "*.lvs" and "*.lpe" patterns (Evgeni Chasnovski) closes: #15303 Signed-off-by: Evgeni Chasnovski <evgeni.chasnovski@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-19 15:59:29 +02:00
/**/
603,
patch 9.1.0602: filetype: Prolog detection can be improved Problem: filetype: Prolog detection can be improved Solution: update the prolog detection regex (igna_martinoli) related: #10835 related: #15206 closes: #15253 Co-authored-by: clason <c.clason@uni-graz.at> Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: igna_martinoli <ignamartinoli@protonmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-18 21:34:36 +02:00
/**/
602,
patch 9.1.0601: Wrong cursor position with 'breakindent' when wide char doesn't fit Problem: Wrong cursor position with 'breakindent' when a double-width character doesn't fit in a screen line (mikoto2000) Solution: Include the width of the 'breakindent' properly. (zeertzjq) fixes: #15289 closes: #15290 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-18 21:13:31 +02:00
/**/
601,
patch 9.1.0600: Unused function and unused error constants Problem: unused function typval_compare_class() and error constants Solution: remove function typval_compare_class() and ifdef out unused error constants (Dominique Pellé) closes: #15299 Signed-off-by: Dominique Pellé <dominique.pelle@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-18 20:40:28 +02:00
/**/
600,
patch 9.1.0599: Termdebug: still get E1023 when specifying arguments Problem: Termdebug: still get E1023 when specifying arguments and using a prompt buffer. Solution: Use empty() instead of len(). Add a test. Fix wrong order of arguments to assert_equal() in Test_termdebug_basic(). (zeertzjq) closes: #15288 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-18 20:35:42 +02:00
/**/
599,
patch 9.1.0598: fuzzy completion does not work with default completion Problem: fuzzy completion does not work with default completion Solution: Make it work (glepnir) closes: #15193 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-17 20:32:54 +02:00
/**/
598,
patch 9.1.0597: KeyInputPre cannot get the (unmapped typed) key Problem: KeyInputPre cannot get the (unmapped typed) key (after v9.1.0563) Solution: Add the "typedchar" property to the v:event dict (Shougo Matsushita) closes: #15231 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-17 20:25:22 +02:00
/**/
597,
patch 9.1.0596: filetype: devscripts config files are not recognized Problem: filetype: Debian devscripts config files are not recognized Solution: detect devscripts.conf and .devscripts files as sh filetype (sourced by /bin/sh) closes: #15227 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-17 20:18:10 +02:00
/**/
596,
patch 9.1.0595: make errors out with the po Makefile Problem: make errors out with the po Makefile (yanivshlom, after v9.1.0558) Solution: Set variables differently (RestorerZ) fixes: #15275 closes: #15282 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-17 19:28:25 +02:00
/**/
595,
patch 9.1.0594: Unnecessary redraw when setting 'winfixbuf' Problem: Unnecessary redraw when setting 'winfixbuf'. Solution: Remove P_RWIN flag. (zeertzjq) closes: #15283 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-17 19:25:38 +02:00
/**/
594,
patch 9.1.0593: filetype: Asymptote files are not recognized Problem: filetype: Asymptote files are not recognized Solution: detect '*.asy' files as asy filetype, include ftplugin and syntax plugin (AvidSeeker). Reference: https://asymptote.sourceforge.io/ closes: #15252 Signed-off-by: AvidSeeker <avidseeker7@protonmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-16 21:39:07 +02:00
/**/
593,
patch 9.1.0592: runtime: filetype: Mediawiki files are not recognized Problem: filetype: Mediawiki files are not recognized Solution: detect "*.mw" and "*.wiki" as mediawiki filetype, include basic syntax and filetype plugins. (AvidSeeker) closes: #15266 Signed-off-by: AvidSeeker <avidseeker7@protonmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-16 21:10:50 +02:00
/**/
592,
patch 9.1.0591: filetype: *.wl files are not recognized Problem: filetype: *.wl files are not recognized Solution: Detect '*.wl' files as Mathematica package files (Jonas Dujava) closes: #15269 Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com> Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-16 20:37:41 +02:00
/**/
591,
patch 9.1.0590: Vim9: crash when accessing getregionpos() return value Problem: Vim9: crash when accessing getregionpos() return value. Solution: Correct the return type (zeertzjq). fixes: #15272 closes: #15273 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-16 20:34:16 +02:00
/**/
590,
patch 9.1.0589: vi: d{motion} and cw work differently than expected Problem: vi: d{motion} and cw command work differently than expected Solution: add new cpo-z flag to make the behaviour configurable There are two special vi compatible behaviours (or should I say bugs?): 1): cw behaves differently than dw. That is, because cw is special cased by Vim and is effectively aliased to ce. POSIX behaviour is documented here: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/vi.html#tag_20_152_13_81 2): d{motion} may make the whole delete operation linewise, if the start and end of the motion are on different lines and there are only blanks before the start and after the end of the motion. Did not find a related POSIX link that requires this behaviour. Both behaviours can be considered inconsistent, but we cannot easily change it, because it would be a backward incompatible change and also incompatible to how classic vi behaved. So let's add the new cpo flag "z", which when not included fixes both behaviours and make them more consistent to what users would expect. This has been requested several times: https://groups.google.com/d/msg/vim_use/aaBqT6ECkA4/ALf4odKzEDgJ https://groups.google.com/d/msg/vim_dev/Dpn3xtUF16I/T6JcOPKN6usJ http://www.reddit.com/r/vim/comments/26nut8/why_does_cw_work_like_ce/ https://groups.google.com/d/msg/vim_use/vunNWLFWfQg/MmJh_ZGaAgAJ https://github.com/vim/vim/issues/4390 So in summary, if you want to have the w motion work more consistent, remove the 'z' from the cpo settings. related: #4390 closes: #15263 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-15 20:51:11 +02:00
/**/
589,
patch 9.1.0588: The maze program no longer compiles on newer clang Problem: The maze program no longer compiles on newer clang Solution: Use ANSI C function definition for main() (Mohamed Akram) Implicit int is an error in newer versions of clang. closes: #15247 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-15 20:23:36 +02:00
/**/
588,
patch 9.1.0587: tests: Test_gui_lowlevel_keyevent is still flaky Problem: tests: Test_gui_lowlevel_keyevent is still flaky (after v9.1.0571) Solution: skip generating key event for Ctrl-C, remove the test_is_flaky variable again (Ken Takata) v9.1.0571 was not enough. Ctrl-C interruption may occur before the preceding events are processed. Exclude Ctrl-C to avoid the flakiness. closes: #15224 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-15 19:52:25 +02:00
/**/
587,
patch 9.1.0586: ocaml runtime files are outdated Problem: ocaml runtime files are outdated Solution: sync those files with the upstream repo, detect a few more ocaml files (Yinzuo Jiang) closes: #15260 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-14 17:02:33 +02:00
/**/
586,
patch 9.1.0585: tests: test_cpoptions leaves swapfiles around Problem: tests: test_cpoptions leaves swapfiles around Solution: Use :bw! instead of :close! Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-14 16:03:41 +02:00
/**/
585,
patch 9.1.0584: Warning about redeclaring f_id() non-static Problem: Warning about redeclaring f_id() non-static Solution: Declare f_id() static (John Marriott) closes: #15257 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-14 11:12:51 +02:00
/**/
584,
patch 9.1.0583: filetype: *.pdf_tex files are not recognized Problem: filetype: *.pdf_tex files are not recognized Solution: Detect '*.pdf_tex' files as tex filetype (Jonas Dujava) Those files are generated by inkscape, when exporting, see e.g. https://inkscape.org/doc/inkscape-man.html closes: #15250 Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-14 10:26:19 +02:00
/**/
583,
patch 9.1.0582: Printed line doesn't overwrite colon when pressing Enter in Ex mode Problem: Printed line no longer overwrites colon when pressing Enter in Ex mode (after 9.1.0573). Solution: Restore the behavior of pressing Enter in Ex mode. (zeertzjq) closes: #15258 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-14 10:22:54 +02:00
/**/
582,
patch 9.1.0581: Various lines are indented inconsistently Problem: style: Various lines are indented inconsistently Solution: Retab these lines and correct some comments. (zeertzjq) closes: #15259 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-14 10:20:20 +02:00
/**/
581,
patch 9.1.0580: :lmap mapping for keypad key not applied when typed in Select mode Problem: An :lmap mapping for a printable keypad key is not applied when typing it in Select mode. Solution: Change keypad key to ASCII after setting vgetc_char. (zeertzjq) closes: #15245 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-13 19:06:44 +02:00
/**/
580,
patch 9.1.0579: Ex command is still executed after giving E1247 Problem: Ex command is still executed after giving E1247. Solution: Indicate the error properly and set cmd to NULL. (zeertzjq) closes: #15241 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-13 19:04:10 +02:00
/**/
579,
patch 9.1.0578: no tests for :Tohtml Problem: no tests for :Tohtml Solution: Add two basic tests (Yinzuo Jiang) closes: #15240 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-13 19:02:10 +02:00
/**/
578,
patch 9.1.0577: Unnecessary checks for v:sizeoflong in test_put.vim Problem: Unnecessary checks for v:sizeoflong in test_put.vim. They are no longer necessary as patch 8.2.3661 has changed the count to be within 32-bit integer limit. Solution: Remove the checks (zeertzjq). closes: #15239 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-13 18:59:47 +02:00
/**/
577,
patch 9.1.0576: tests: still an issue with test_gettext_make Problem: tests: still an issue with test_gettext_make (after v9.1.0570) Solution: Compare the getenv() output against v:null to verify that $GETTEXT_PATH was set or not (Ken Takata) closes: #15236 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-13 18:56:25 +02:00
/**/
576,
patch 9.1.0575: Wrong comments in alt_tabpage() Problem: Wrong comments in alt_tabpage() (after v9.1.0572) Solution: Correct the comments (zeertzjq). closes: #15235 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-13 18:53:54 +02:00
/**/
575,
patch 9.1.0574: ex: wrong handling of commands after bar Problem: ex: wrong handling of commands after bar Solution: for :append, :insert and :change use the text after the bar as input for those commands. This is what POSIX requests. (Mohamed Akram) See the POSIX Spec: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/ex.html#tag_20_40_13_03 Section 12.c closes: #15229 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-13 18:49:55 +02:00
/**/
574,
patch 9.1.0573: ex: no implicit print for single addresses Problem: ex: no implicit print for single addresses Solution: explicitly print even during single addresses, as requested by POSIX (Mohamed Akram) See the POSIX behaviour here: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/ex.html#tag_20_40_13_03 Section 6b closes: #15230 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-12 20:17:55 +02:00
/**/
573,
patch 9.1.0572: cannot specify tab page closing behaviour Problem: cannot specify tab page closing behaviour (Gianluca Pacchiella) Solution: Add the 'tabclose' option (LemonBoy). fixes: #5967 closes: #15204 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-12 19:30:58 +02:00
/**/
572,
patch 9.1.0571: tests: Test_gui_lowlevel_keyevent is flaky Problem: tests: Test_gui_lowlevel_keyevent is flaky Solution: mark as flaky (Ken Takata) Test_gui_lowlevel_keyevent is failing on vim-win32-installer recently. Mark it as flaky for now. closes: #15223 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-12 07:48:32 +02:00
/**/
571,
patch 9.1.0570: tests: test_gettext_make can be improved Problem: tests: test_gettext_make can be improved (after v9.1.0559) Solution: Improve the test (Ken Takata) * Remove unnecessary comment. * Check the gettext feature. * Check whether %GETTEXT_PATH% is set. * Check the return code of the make command. * Use heredoc. closes: #15221 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-12 07:35:36 +02:00
/**/
570,
patch 9.1.0569: fnamemodify() treats ".." and "../" differently Problem: fnamemodify() treats ".." and "../" differently. Solution: Expand ".." properly like how "/.." is treated in 8.2.3388. (zeertzjq) closes: #15218 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-12 07:29:14 +02:00
/**/
569,
patch 9.1.0568: Cannot expand paths from 'cdpath' setting Problem: Cannot expand paths from 'cdpath' setting (Daniel Hahler) Solution: Implement 'cdpath' completion, add the new 'dir_in_path' completion type (LemonBoy) fixes #374 closes: #15205 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 22:35:53 +02:00
/**/
568,
patch 9.1.0567: Cannot use relative paths as findfile() stop directories Problem: Cannot use relative paths as findfile() stop directories. Solution: Change a relative path to an absolute path. (zeertzjq) related: #15200 closes: #15202 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 22:24:15 +02:00
/**/
567,
patch 9.1.0566: Stop dir in findfile() doesn't work properly w/o trailing slash Problem: Stop directory in findfile() doesn't work properly without a trailing slash. Solution: Always use fnamencmp(), not fnamecmp(). related: #15200 related: #15202 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 22:22:26 +02:00
/**/
566,
patch 9.1.0565: Stop directory doesn't work properly in 'tags' Problem: Stop directory doesn't work properly in 'tags'. (Jesse Pavel) Solution: Also move the stop directory forward by one byte. (zeertzjq) This doesn't support relative stop directories yet, as they are not supported in other places like findfile() either. fixes: #15200 related: #15202 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 22:19:46 +02:00
/**/
565,
patch 9.1.0564: id() can be faster Problem: id() can be made faster Solution: don't use printf(), use clever shift of pointer (Ernie Rael) closes: #15207 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 22:10:45 +02:00
/**/
564,
patch 9.1.0563: Cannot process any Key event Problem: Cannot process any Key event Solution: Add the KeyInputPre autocmd (Shougo Matsushita) closes: #15182 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Co-authored-by: K.Takata <kentkt@csc.jp> Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 22:05:12 +02:00
/**/
563,
patch 9.1.0562: tests: inconsistency in test_findfile.vim Problem: tests: inconsistency in test_findfile.vim, it saves and restores 'shellslash', but doesn't actually set it Solution: Set shellslash explicitly (zeertzjq) closes: #15217 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 21:48:09 +02:00
/**/
562,
patch 9.1.0561: netbeans: variable used un-initialized (Coverity) Problem: netbeans: variable used un-initialized (Coverity) (after v9.1.0557) Solution: properly initialize exarg_T struct for use with netbeans The actual exarg.cmdidx doesn't really matter, but let's use something, that is not affected by the recent changes (going through the buffer list) and use CMD_USER. closes: #15211 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 21:41:23 +02:00
/**/
561,
patch 9.1.0560: bindtextdomain() does not indicate an error Problem: bindtextdomain() does not indicate an error (after v9.1.509) Solution: return false on failure (OOM). (Chris van Willegen) closes: #15116 Signed-off-by: Christ van Willegen <cvwillegen@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 21:36:21 +02:00
/**/
560,
patch 9.1.0559: translation of vim scripts can be improved Problem: translation of vim scripts can be improved (after v9.1.0509) Solution: improve documentation, add tests, include missing libraries for the Windows CI (RestorerZ) closes: #15100 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-11 21:14:15 +02:00
/**/
559,
patch 9.1.0558: filetype: prolog detection can be improved Problem: filetype: prolog detection can be improved Solution: Improved the Prolog file detection regex and added tests for all cases. (igna_martinoli) fixes: #10835 closes: #15206 Signed-off-by: igna_martinoli <ignamartinoli@protonmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-10 21:25:04 +02:00
/**/
558,
patch 9.1.0557: moving in the buffer list doesn't work as documented Problem: moving in the buffer list doesn't work as documented (SenileFelineS) Solution: Skip non-help buffers, when run from normal buffers, else only move from help buffers to the next help buffer (LemonBoy) As explained in the help section for :bnext and :bprev the commands should jump from help buffers to help buffers (and from regular ones to regular ones). fixes: #4478 closes: #15198 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-10 20:20:48 +02:00
/**/
557,
patch 9.1.0556: :bwipe doesn't remove file from jumplist of other tabpages Problem: :bwipe doesn't remove file from jumplist and tagstack of other tabpages. Time complexity of mark_forget_file() is O(n^2) when removing all entries (after v9.1.0554) Solution: Use FOR_ALL_TAB_WINDOWS(). Start the loops over the arrays from the end instead of the start (zeertzjq) closes: #15199 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-10 19:36:36 +02:00
/**/
556,
patch 9.1.0555: filetype: angular ft detection is still problematic Problem: filetype: angular ft detection is still problematic (after 9.1.0551) Solution: detect htmlangular filetype only by inspecting the content, do not try to determine it from a generic name like '*.component.html' For the reasons mentioned here: https://github.com/vim/vim/pull/13594#issuecomment-1834465890 related: #15190 related: #13594 related: #13604 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-10 19:23:39 +02:00
/**/
555,
patch 9.1.0554: :bw leaves jumplist and tagstack data around Problem: :bw leaves jumplist and tagstack data around (Paul "Joey" Clark) Solution: Wipe jumplist and tagstack references to the wiped buffer (LemonBoy) As documented the :bwipeout command brutally deletes all the references to the buffer, so let's make it delete all the entries in the jump list and tag stack referring to the wiped-out buffer. fixes: #8201 closes: #15185 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 20:03:24 +02:00
/**/
554,
patch 9.1.0553: filetype: *.mcmeta files are not recognized Problem: filetype: *.mcmeta files are not recognized Solution: Detect '*.mcmeta' files as json filetype (Tomodachi94) "pack.mcmeta" was added to the JSON tests because that is the most common filename with that extension. There are currently 34,000 instances of this file extension on GitHub: https://github.com/search?q=path%3A*.mcmeta&type=code&p=2 .zip files with this extension have downloads in the millions on sites like CurseForge: https://www.curseforge.com/minecraft/search?page=1&pageSize=20&sortBy=relevancy&class=texture-packs Further reading about the file extension: https://minecraft.wiki/w/Tutorials/Creating_a_resource_pack#Creating_a_.MCMETA_file closes: #15189 Signed-off-by: Tomodachi94 <tomodachi94@protonmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 19:55:16 +02:00
/**/
553,
patch 9.1.0552: No test for antlr4 filetype Problem: No test for antlr4 filetype (after 9.1.0550) Solution: Add a simple filename test related: #15191 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 19:52:20 +02:00
/**/
552,
patch 9.1.0551: filetype: htmlangular files are not properly detected Problem: filetype: htmlangular files are not properly detected Solution: Use the new htmlangular filetype for angular files, because since angular v17, those are no longer valid HTML files. (Dennis van den Berg) Since Angular 17, the new Control Flow Syntax is not valid HTML. This PR adds a new filetype detection for the HTML templates of Angular. It first checks the filename. The Angular convention is to use *.component.html for the template. However, this is not mandatory. If the filename does not match, it will check the contents of the file if it contains: - One of the Control-Flow blocks: @if, @for, @switch, @defer - A structural directive: *ngIf, *ngFor, *ngSwitch, *ngTemplateOutlet - Builtin Angular elements: ng-template or ng-content - String interpolation: {{ something }} This enables the Angular LSP to attach only to htmlangular filetypes, as well as language parsers, such as tree-sitter. closes: #15190 Signed-off-by: Dennis van den Berg <dennis.vandenberg@nedap.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 19:25:33 +02:00
/**/
551,
patch 9.1.0550: filetype: antlr4 files are not recognized Problem: filetype: antlr4 files are not recognized Solution: Detect '*.g4' as antlr4 filetype, include a simple antlr4 syntax and filetype plugin (Yinzuo Jiang) closes: #15191 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 19:11:18 +02:00
/**/
550,
patch 9.1.0549: fuzzycollect regex based completion not working as expected Problem: fuzzycollect regex based completion not working as expected Solution: Revert Patch v9.1.0503 (glepnir) closes: #15192 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 18:51:29 +02:00
/**/
549,
patch 9.1.0548: it's not possible to get a unique id for some vars Problem: it's not possible to get a unique id for some vars Solution: Add the id() Vim script function, which returns a unique identifier for object, dict, list, job, blob or channel variables (Ernie Rael) fixes: #14374 closes: #15145 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 18:39:52 +02:00
/**/
548,
patch 9.1.0547: No way to get the arity of a Vim function Problem: No way to get the arity of a Vim function (Austin Ziegler) Solution: Enhance get() Vim script function to return the function argument info using get(func, "arity") (LemonBoy) fixes: #15097 closes: #15109 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-09 18:24:59 +02:00
/**/
547,
patch 9.1.0546: vim-tiny fails on CTRL-X/CTRL-A Problem: vim-tiny fails on CTRL-X/CTRL-A (Rob Foehl, after 9.1.0172) Solution: Move #ifdefs, so that after changing the line in del_bytes, the cached textlen value is invalidated closes: #15178 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-08 21:12:55 +02:00
/**/
546,
patch 9.1.0545: MSVC conversion warning Problem: MSVC conversion warning (LemonBoy, after 9.1.0522) Solution: Use size_t instead of int, fix style of casts (Ernie Rael) related: #15082 closes: #15187 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-08 20:42:45 +02:00
/**/
545,
patch 9.1.0544: filetype: ldapconf files are not recognized Problem: filetype: ldapconf files are not recognized Solution: Detect '.ldaprc', 'ldap.conf' and 'ldaprc' files as ldapconf filetype, include a simple ldapconf ftplugin file (Riley Bruins) [Specification](https://www.openldap.org/software//man.cgi?query=ldap.conf&sektion=5&apropos=0&manpath=OpenLDAP+2.4-Release) closes: #15176 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-07 21:20:22 +02:00
/**/
544,
patch 9.1.0543: Behavior of CursorMovedC is strange Problem: Behavior of CursorMovedC is strange. Solution: Also trigger when the cmdline has changed. (zeertzjq) fixes: #15069 closes: #15071 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-07 20:48:25 +02:00
/**/
543,
patch 9.1.0542: Vim9: confusing string() output for object functions Problem: Vim9: confusing string() output for object functions Solution: improve the output for object functions (Ernie Rael) fixes: #15129 closes: #15143 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-07 20:41:44 +02:00
/**/
542,
patch 9.1.0541: failing test with Vim configured without channel Problem: failing test with Vim configured without channel Solution: In the test Test_null_values() verify that the 'channel' and 'job' feature is present in Vim. (Dominique Pellé) Test `Test_null_values` was failing when vim is configured without channel because the test uses function `null_channel()` (which requires the `+channel` feature) and using `null_job()` which requires the `+job` feature. But was reproducible when vim is configured with: ``` ./configure --with-features=huge --enable-gui=none --disable-channel ``` Only check `null_channel()` when the `+channel` feature is available. Only check `null_job()` when the `+job` feature is available. closes: #15177 Signed-off-by: Dominique Pellé <dominique.pelle@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-07 20:37:12 +02:00
/**/
541,
patch 9.1.0540: Unused assignment in sign_define_cmd() Problem: Unused assignment in sign_define_cmd() Solution: Remove the assignment. Also document the "priority" flag of sign_define(). (zeertzjq) closes: #15169 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-07 20:33:46 +02:00
/**/
540,
patch 9.1.0539: Not enough tests for what v9.1.0535 fixed Problem: Not enough tests for what v9.1.0535 fixed Solution: Add another test for ex-mode This comes from: https://groups.google.com/g/vim_dev/c/F5-tDqoafz8/m/GqKF-uQsLD0J related: #15120 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-07 19:44:16 +02:00
/**/
539,
patch 9.1.0538: not possible to assign priority when defining a sign Problem: not possible to assign priority when defining a sign (Mathias Fußenegger) Solution: Add the priority argument for the :sign-define ex command and the sign_define() function (LemonBoy) Use the specified value instead of the default one (SIGN_DEF_PRIO) when no priority is explicitly specified in sign_place or :sign place. fixes: #8334 closes: #15124 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-06 18:04:09 +02:00
/**/
538,
patch 9.1.0537: signed number detection for CTRL-X/A can be improved Problem: signed number detection for CTRL-X/A can be improved (Chris Patuzzo) Solution: Add the new "blank" value for the 'nrformat' setting. This will make Vim assume a signed number only if there is a blank in front of the sign. (distobs) fixes: #15033 closes: #15110 Signed-off-by: distobs <cuppotatocake@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-06 17:50:09 +02:00
/**/
537,
patch 9.1.0536: filetype: zone files are not recognized Problem: filetype: zone files are not recognized (rpdprd) Solution: Detect '*.zone' files as bindzone filetype fixes: #14222 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-06 17:39:18 +02:00
/**/
536,
patch 9.1.0535: newline escape wrong in ex mode Problem: newline escape wrong in ex mode (Konrad Schwarz) Solution: partly revert patch 7.3.014, remove backslash in front of a newline when not in prompt mode in ex line mode (Mohamed Akram) This fixes newline escaping to allow passing multiple commands to ":global", multiple lines to shell commands, and ending lines in append mode with backslashes. This should fix a POSIX/(traditional) VI incompatiblity. This reverts a previous incorrect attempt at patch v7.3.014 to fix append mode which removed half of trailing backslashes which lead to, eg. the following two commands being parsed as having a different number of backslashes: ``` !echo foo\\\ ``` ``` !echo foo\\ \ ``` fixes: #6135 fixes: #7244 closes: #15120 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-06 17:12:09 +02:00
/**/
535,
patch 9.1.0534: completion wrong with fuzzy when cycling back to original Problem: completion wrong with fuzzy when cycling back to original (Quan Nguyen) Solution: reset show_match_ok when cp_score is zero (glepnir) fixes: #15095 closes: #15105 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-06 16:09:19 +02:00
/**/
534,
patch 9.1.0533: Vim9: need more tests for nested objects equality Problem: Vim9: need more tests for nested objects equality Solution: Add more tests (Ernie Rael) related: #15070 related: #15081 related: #15085 closes: #15153 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-06 11:44:37 +02:00
/**/
533,
patch 9.1.0532: filetype: Cedar files not recognized Problem: filetype: Cedar files not recognized Solution: Detect '*.cedar' files as cedar filetype (Riley Bruins) References: https://github.com/cedar-policy closes: #15148 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-05 21:14:26 +02:00
/**/
532,
patch 9.1.0531: resource leak in mch_get_random() Problem: resource leak in mch_get_random() (after v9.1.0518) Solution: close file descriptor after reading successfully from /dev/urandom Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-05 09:54:30 +02:00
/**/
531,
patch 9.1.0530: xxd: MSVC warning about non-ASCII character Problem: xxd: MSVC warning about non-ASCII character Solution: Specify source-charset:utf-8 in Makefile (Ken Takata) xxd.c has non-ASCII-character comments. This causes the following warning on MSVC: ``` warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss. ``` Add the `/source-charset:utf-8` option to avoid this. closes: #15119 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 19:35:48 +02:00
/**/
530,
patch 9.1.0529: silent! causes following try/catch to not work Problem: silent! causes following try/catch to not work (Malcolm Rowe) Solution: consider emsg_silent in handle_did_throw() and do not abort evaluation flow for :silent! (LemonBoy) The silent! flag causes the evaluation not to be aborted in case of uncaught exceptions, adjust handle_did_throw to take this detail into account. Fixes the long-standing todo.txt item: ``` Problem that a previous silent ":throw" causes a following try/catch not to work. (ZyX, 2013 Sep 28) With examples: (Malcolm Rowe, 2015 Dec 24) Also see #8487 for an example. ``` fixes: #538 closes: #15128 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 19:23:16 +02:00
/**/
529,
patch 9.1.0528: spell completion message still wrong in translations Problem: spell completion message still wrong in translations (after 9.1.0512) Solution: Update translation files with the new message (Kyle Kovacs) closes: #15113 Signed-off-by: Kyle Kovacs <kkovacs@diconfiberoptics.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 17:51:09 +02:00
/**/
528,
patch 9.1.0527: inconsistent parameter in Makefiles for Vim executable Problem: inconsistent parameter in Makefiles for Vim executable Solution: consistently use $VIMPROG across all Makefiles (RestorerZ) closes: #15099 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 17:47:16 +02:00
/**/
527,
patch 9.1.0526: Unwanted cursor movement with pagescroll at start of buffer Problem: Cursor is moved to bottom of window trying to pagescroll when already at the start of the buffer (Asheq Imran, after v9.1.0357) Solution: Don't move cursor when buffer content did not move. (Luuk van Baal) closes: #15139 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 17:35:56 +02:00
/**/
526,
patch 9.1.0525: Right release selects immediately when pum is truncated. Problem: Right release selects immediately when pum is truncated. Solution: Use pum_height instead of pum_size when checking click row. Don't place it above mouse row when there is more space below. (zeertzjq) fixes: #15101 closes: #15102 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 17:26:37 +02:00
/**/
525,
patch 9.1.0524: the recursive parameter in the *_equal functions can be removed Problem: the recursive parameter in the *_equal functions can be removed Solution: Remove the recursive parameter in dict_equal(), list_equal() object_equal and tv_equal(). Use a comparison of the static var recursive_cnt == 0 to determine whether or not tv_equal() has been called recursively (Yinzuo Jiang). closes: #15070 Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 17:20:53 +02:00
/**/
524,
patch 9.1.0523: Vim9: cannot downcast an object Problem: Vim9: cannot downcast an object (Ernie Rael) Solution: Fix class downcasting issue (LemonBoy). When casting an object from one class to another the target type may be a subclass (downcast) or superclass (upcast) of the source one. Upcasts require a runtime type check to be emitted. Add a disassembly test. fixes: #13244 closes: #15079 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 17:03:17 +02:00
/**/
523,
patch 9.1.0522: Vim9: string(object) hangs for recursive references Problem: Vim9: string(object) hangs for recursive references Solution: Handle recursive objects specifically, add a hang test and a compare test (Ernie Rael) fixes: #15080 closes: #15082 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 16:50:11 +02:00
/**/
522,
patch 9.1.0521: if_py: _PyObject_CallFunction_SizeT is dropped in Python 3.13 Problem: if_py: _PyObject_CallFunction_SizeT is dropped in Python 3.13 Solution: define PyObject_CallFunction for Python >= 3.13 (Yaakov Selkowitz) references: python/cpython#105051 closes: #15088 Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 16:36:05 +02:00
/**/
521,
patch 9.1.0520: Vim9: incorrect type checking for modifying lists Problem: Vim9: incorrect type checking for modifying lists Solution: Correctly assign the member declared types and generate typechecks, add disassembly test (LemonBoy) fixes: #15090 closes: #15094 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 13:43:12 +02:00
/**/
520,
patch 9.1.0519: MS-Windows: libvterm compilation can be optimized Problem: MS-Windows: libvterm compilation can be optimized Solution: Enable batch inference for libvterm (Ken Takata) Enable batch inference for libvterm by using $(OBJDIR)/libvterm as the object directory. This should make the compilation process a bit faster. closes: #15118 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 13:31:25 +02:00
/**/
519,
patch 9.1.0518: initialize the random buffer can be improved Problem: initialize the random buffer can be improved Solution: refactor init_srand() function, move machine-specific parts to os_mswin and os_unix, implement a fallback for Windows 10 and later (LemonBoy) closes: #15125 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 13:20:49 +02:00
/**/
518,
patch 9.1.0517: MS-Windows: too long lines in Make_mvc.mak Problem: MS-Windows: too long lines in Make_mvc.mak Solution: Wrap long lines in Make_mvc.mak (Ken Takata) closes: #15133 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-07-04 11:51:30 +02:00
/**/
517,
patch 9.1.0516: need more tests for nested dicts and list comparision Problem: need more tests for nested dicts and list comparision Solution: Add tests for comparing deeply nested List/Dict values (Yegappan Lakshmanan) closes: #15081 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-23 10:00:04 +02:00
/**/
516,
patch 9.1.0515: Vim9: segfault in object_equal() Problem: Vim9: segfault in object_equal() Solution: test for object pointer being NULL, before dereferencing them (Ernie Rael) closes: #15085 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-23 09:54:45 +02:00
/**/
515,
patch 9.1.0514: Vim9: issue with comparing objects recursively Problem: Vim9: issue with comparing objects recursively (Yinzuo Jiang) Solution: only set recursive == TRUE, when called from tv_equal(), not from typeval_compare_object(), refactor code into object_equal() function (LemonBoy) The recursive flag in tv_equal should be set only when the caller is tv_equal, meaning that the comparison depth is > 1. The comparison predicates for other object types are all following this rule, except for the object one, and that may cause some weird issues like causing the max depth limit not to be initialized in some cases. closes: #15076 Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-22 17:25:07 +02:00
/**/
514,
patch 9.1.0513: Vim9: segfault with object comparison Problem: Vim9: segfault with object comparisons Solution: increment recusive_cnt before calling typval_compare_object() (Ernie Rael) closes: #15073 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-22 11:12:00 +02:00
/**/
513,
patch 9.1.0512: Mode message for spell completion doesn't match allowed keys Problem: Mode message for spell completion doesn't match allowed keys (Kyle Kovacs) Solution: Show "^S" instead of "s". (zeertzjq) This matches the code in vim_is_ctrl_x_key(): case CTRL_X_SPELL: return (c == Ctrl_S || c == Ctrl_P || c == Ctrl_N); fixes: neovim/neovim#29431 closes: #15065 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-21 07:55:07 +02:00
/**/
512,
patch 9.1.0511: CursorMovedC triggered wrongly with setcmdpos() Problem: CursorMovedC triggered wrongly with setcmdpos() (after v9.1.0507) Solution: Remove the premature triggering. Also don't trigger when cursor didn't move. (zeertzjq) closes: #15064 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-21 07:51:40 +02:00
/**/
511,
patch 9.1.0510: CI: test_gettext fails on MacOS14 + MSVC Win Problem: CI: test_gettext fails on MacOS14 + MSVC Win (after v9.1.0509) Solution: Skip the test for now related: #12447 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-21 07:31:04 +02:00
/**/
510,
patch 9.1.0509: not possible to translate Vim script messages Problem: not possible to translate Vim script messages (RestorerZ) Solution: implement bindtextdomain() and gettext() to support Vim script message translations (Christ van Willegen) fixes: #11637 closes: #12447 Signed-off-by: Christ van Willegen <cvwillegen@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-20 23:41:59 +02:00
/**/
509,
patch 9.1.0508: termdebug plugin can be further improved Problem: termdebug plugin can be further improved Solution: add sanity-check, timeout config, change vars to bool update docs, add more tests (Ubaldo Tiberi) fixes: #15061 closes: #15057 Signed-off-by: Ubaldo Tiberi <ubaldo.tiberi@google.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-20 22:17:34 +02:00
/**/
508,
patch 9.1.0507: hard to detect cursor movement in the command line Problem: hard to detect cursor movement in the command line Solution: Add the CursorMovedC autocommand (Shougo Matsushita) closes: #15040 Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-20 22:05:16 +02:00
/**/
507,
patch 9.1.0506: filetype: .envrc & .prettierignore not recognized Problem: filetype: .envrc & .prettierignore not recognized Solution: Detect '.envrc' as shell and '.prettierignore' as gitignore filetype (Tyler Miller) Support ft detection for `.envrc` files used by direnv, and `.prettierignore` files used by prettier. closes: #15053 resolves: neovim/neovim#29405 Signed-off-by: Tyler Miller <tmillr@proton.me> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-20 20:31:32 +02:00
/**/
506,
patch 9.1.0505: filetype: Faust files are not recognized Problem: filetype: Faust files are not recognized Solution: Detect '*.lib' files as Faust filetype, add detection for '*.dsp' files (Faust or Make), remove '*.lib' from Cobol filetype (PowerUser64) closes: #14894 Signed-off-by: PowerUser64 <blake@blakenorth.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-19 20:32:11 +02:00
/**/
505,
patch 9.1.0504: inner-tag textobject confused about ">" in attributes Problem: inner-tag textobject confused about ">" in attributes Solution: Skip over quoted '>' when determining the start position fixes: #15043 closes: #15049 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-19 20:26:51 +02:00
/**/
504,
patch 9.1.0503: cannot use fuzzy keyword completion Problem: cannot use fuzzy keyword completion (Maxim Kim) Solution: add the "fuzzycollect" value for the 'completeopt' setting, to gather matches using fuzzy logic (glepnir) fixes: #14912 closes: #14976 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-19 20:20:48 +02:00
/**/
503,
patch 9.1.0502: MS-Windows: too much legacy code Problem: MS-Windows: too much legacy code Solution: Clean up old code (Ken Takata) * Remove very old codes for Cygwin version of GCC. Nowadays Cygwin GCC cannot be used for building Win32 Vim. (The `-mno-cygwin` option was removed in Cygwin GCC4.) * Remove old codes for old versions of MinGW. Remove `__MINGW32__` as much as possible. * Adjust makefile. closes: #15044 Signed-off-by: K.Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-19 19:56:03 +02:00
/**/
502,
patch 9.1.0501: too complicated mapping restore in termdebug Problem: too complicated mapping restore in termdebug Solution: simplify unmapping logic, add a few more tests (Ubaldo Tiberi) closes: #15046 Signed-off-by: Ubaldo Tiberi <ubaldo.tiberi@google.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-19 19:50:32 +02:00
/**/
501,
patch 9.1.0500: cannot switch buffer in a popup Problem: cannot switch buffer in a popup (Yggdroot) Solution: add popup_setbuf() function fixes: #15006 closes: #15026 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-18 20:50:58 +02:00
/**/
500,
patch 9.1.0499: MS-Windows: doesn't handle symlinks properly Problem: MS-Windows: doesn't handle symlinks properly (Timothy Madden) Solution: Implement lstat() on MS-Windows (author) lstat() differs from stat() in how it handles symbolic links, the former doesn't resolve the symlink while the latter does so. Implement a simple yet effective fallback using Win32 APIs. fixes #14933 closes: #15014 Co-authored-by: K.Takata <kentkt@csc.jp> Signed-off-by: LemonBoy <thatlemon@gmail.com> Signed-off-by: K.Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-18 20:43:51 +02:00
/**/
499,
patch 9.1.0498: getcmdcompltype() interferes with cmdline completion Problem: getcmdcompltype() interferes with cmdline completion. Solution: Don't set expand context when it's already set. (zeertzjq) closes: #15036 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-18 20:31:08 +02:00
/**/
498,
patch 9.1.0497: termdebug can be further improved Problem: termdebug can be further improved Solution: refactor save/restore, update docs, add a new save/restore test (Ubaldo Tiberi) closes: #15032 Signed-off-by: Ubaldo Tiberi <ubaldo.tiberi@google.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-18 20:18:20 +02:00
/**/
497,
patch 9.1.0496: matched text is highlighted case-sensitively Problem: matched text is highlighted case-sensitively Solution: use MB_STRNICMP, update highlighting when the base changes (glepnir) fixes: #15021 closes: #15023 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-17 18:35:25 +02:00
/**/
496,
patch 9.1.0495: Matched text isn't highlighted in cmdline pum Problem: Matched text isn't highlighted in cmdline pum. Solution: Use cmdline completion pattern in cmdline mode. (zeertzjq) closes: #15029 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-17 18:25:32 +02:00
/**/
495,
patch 9.1.0494: Wrong matched text highlighted in pum with 'rightleft' Problem: Wrong matched text highlighted in pum with 'rightleft'. Solution: Match using the original text instead of the reversed text. (zeertzjq) closes: #15020 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-16 16:51:25 +02:00
/**/
494,
patch 9.1.0493: Test for patch 9.1.0489 doesn't fail without the fix Problem: Test for patch 9.1.0489 doesn't fail without the fix. Solution: Use "!" flag of feedkeys() so that ex_normal_busy is not set and ins_compl_check_keys() is not skipped (zeertzjq). closes: #15018 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-16 08:44:05 +02:00
/**/
493,
patch 9.1.0492: filetype: Vim-script files not detected by shebang line Problem: Vim-script files may not be recognised Solution: Add shebang line detection (Doug Kearns) closes: #15012 Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-16 08:32:15 +02:00
/**/
492,
patch 9.1.0491: Cmdline pum doesn't work properly with 'rightleft' Problem: Cmdline pum doesn't work properly with 'rightleft'. Solution: Don't use curwin->w_p_rl in cmdline mode in pum_redraw(). Use a static variable since pum_may_redraw() may be called in any mode. Also correct position of other popups with 'rightleft'. (zeertzjq) closes: #15005 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-15 15:37:11 +02:00
/**/
491,
patch 9.1.0490: minor style problems with patch 9.1.0487 Problem: minor style problems with patch 9.1.0487 Solution: use shown_compl instead of after_first_compl variable (glepnir) closes: #15008 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org> fix(completion): use exist shown_compl instead after_first_compl
2024-06-15 15:32:22 +02:00
/**/
490,
patch 9.1.0489: default completion may break with fuzzy Problem: default completion may break with fuzzy Solution: check that completion_match_array is not null (glepnir) closes: #15010 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-15 15:13:05 +02:00
/**/
489,
patch 9.1.0488: Wrong padding for pum "kind" with 'rightleft' Problem: Wrong padding for pum "kind" with 'rightleft'. Solution: Fix off-by-one error (zeertzjq). The screen_fill() above is end-exclusive, and - With 'rightleft' it fills `pum_col - pum_base_width - n + 1` to `col`, so the next `col` should be `pum_col - pum_base_width - n`. - With 'norightleft' it fills `col` to `pum_col - pum_base_width + n - 1`, so the next `col` should be `pum_col - pum_base_width + n`. closes: #15004 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-15 15:08:27 +02:00
/**/
488,
patch 9.1.0487: completed item not update on fuzzy completion Problem: completed item not update on fuzzy completion Solution: reset compl_shown_match when at original match position (glepnir) closes: #14955 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-14 21:11:56 +02:00
/**/
487,
patch 9.1.0486: filetype: Snakemake files are not recognized Problem: filetype: Snakemake files are not recognized Solution: Detect '*.smk' and Snakefile files as snakemake filetype (Riley Bruins) See: https://snakemake.readthedocs.io/en/stable/snakefiles/deployment.html#distribution-and-reproducibility closes: #14992 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-14 20:47:05 +02:00
/**/
486,
patch 9.1.0485: Matched text shouldn't be highlighted in "kind" and "menu" Problem: Matched text shouldn't be highlighted in "kind" and "menu". Solution: Pass hlf_T instead of the attribute. Fix indent. (zeertzjq) closes: #14996 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-14 20:24:22 +02:00
/**/
485,
patch 9.1.0484: Sorting of completeopt+=fuzzy is not stable Problem: Sorting of completeopt+=fuzzy is not stable. Solution: Compare original indexes when scores are the same. (zeertzjq) closes: #14988 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-14 20:04:42 +02:00
/**/
484,
patch 9.1.0483: glob() not sufficiently tested Problem: glob() not sufficiently tested Solution: Add more tests for directory containing [] chars related: #14991 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-13 21:20:20 +02:00
/**/
483,
patch 9.1.0482: termdebug plugin needs more love Problem: termdebug plugin needs more love Solution: start with some more Vim9 refactoring to improve maintenance and readability (Ubaldo Tiberi) List of Changes and the Reasoning Behind Them: 1) Introduction of InitScriptVariables() Function: Reasoning: This function has been introduced to ensure that when you open and close Termdebug, and then open it again, there are no leftover script variable values from the previous session. Leftover values could potentially cause issues. The goal is for each Termdebug session to be independent of previous sessions. At startup, all script variables are initialized. The only exception is g:termdebug_loaded located at the very beginning of the script to prevent sourcing the script twice. The variables are declared at script level and defined in InitScriptVariables(). 2) More Descriptive Variable Names: Reasoning: The names of variables have been made more comprehensive. Almost every Termdebug buffer now has a variable to indicate its name and another variable to indicate its number, improving code readability and maintainability. Due to the latest discussion around the &mousemodel option save/restore mechanism, perhaps some other variables shall be prepended with saved_. 3) Consistent Naming for GDB Terminal Buffers: Reasoning: The name of the GDB terminal buffer now matches the name of the GDB program being used, e.g., 'gdb', 'mygdb', 'arm-eabi-none-gdb', etc. This ensures clarity and consistency in identifying buffers. 4) Other minor improvements: Moved EchoErr() on top, added another test, some refactoring, mainly changed several 0 and 1 to true and false closes: #14980 Signed-off-by: Ubaldo Tiberi <ubaldo.tiberi@volvo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-13 19:23:07 +02:00
/**/
482,
patch 9.1.0481: Vim9: term_getjob() throws an exception on error Problem: Vim9: term_getjob() throws an exception on error Solution: Return null_job instead, when there is no job (Ernie Rael) closes: #14984 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-13 17:24:54 +02:00
/**/
481,
patch 9.1.0480: fuzzy string matching executed when not needed Problem: fuzzy string matching executed when not needed Solution: when no leader is available, can skip fuzzy logic, so return early (glepnir) closes: #14986 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-13 17:21:24 +02:00
/**/
480,
patch 9.1.0479: fuzzy_match_str_with_pos() does unnecessary list operations Problem: fuzzy_match_str_with_pos() does unnecessary list operations. Solution: Use fuzzy_match() directly (zeertzjq). closes: #14987 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-13 17:14:27 +02:00
/**/
479,
patch 9.1.0478: potential deref of NULL pointer in fuzzy_match_str_with_pos Problem: potential deref of NULL pointer in fuzzy_match_str_with_pos() on cleanup (after v9.1.0476) Solution: Only free the pointer if it is non-NULL (glepnir) closes: #14973 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-12 20:31:13 +02:00
/**/
478,
patch 9.1.0477: block_editing errors out when using <enter> Problem: block_editing errors out when using <enter> (Ali Rizvi-Santiago, after v9.1.0274) Solution: Change ins_len from size_t to int so that the test if ins_len is negative actually works properly Add a test, so that this doesn't regress. fixes: #14960 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-11 20:30:14 +02:00
/**/
477,
patch 9.1.0476: Cannot see matched text in popup menu Problem: Cannot see matched text in popup menu Solution: Introduce 2 new highlighting groups: PmenuMatch and PmenuMatchSel (glepnir) ping @habamax, @neutaaaaan @romainl because vim/colorschemes may need some updates, @lifepillar for updating vim-colortemplate closes: #14694 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-11 19:37:04 +02:00
/**/
476,
patch 9.1.0475: cmod_split modifier is always reset in term_start() Problem: cmod_split modifier is always reset in term_start() Solution: only clear the WSP_VERT flag, if it is not already in cmdmod.cmod_split (Yegappan Lakshmanan) closes: #14961 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-11 19:18:12 +02:00
/**/
475,
patch 9.1.0474: CI: Test_ColonEight() fails on github runners Problem: CI: Test_ColonEight() fails on github runners (Ken Takata) Solution: Run the test for files on the C: drive, where dos shortnames are still enabled, refactor the tests to use a single setup function for the preparation fixes: #14954 closes: #14958 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-10 21:06:55 +02:00
/**/
474,
patch 9.1.0473: term_start() does not clear vertical modifier Problem: term_start() does not clear vertical modifier Solution: Clear the flag after splitting the window (Yegappan Lakshmanan) closes: #14953 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-10 18:16:34 +02:00
/**/
473,
patch 9.1.0472: Inconsistencies between functions for option flags Problem: Inconsistencies between functions for option flags. Solution: Consistently use "unsigned int" as return type and rename get_bkc_value() to get_bkc_flags() (zeertzjq). closes: #14925 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-09 18:24:05 +02:00
/**/
472,
patch 9.1.0471: Crash when using autocmd_get() after removing event inside autocmd Problem: Crash when using autocmd_get() after removing event inside autocmd (Sergey Vlasov) Solution: Check that the pattern is NULL (zeertzjq). fixes: #14937 closes: #14939 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-09 16:44:33 +02:00
/**/
471,
patch 9.1.0470: tests: Test_ColonEight_MultiByte() fails sporadically Problem: tests: Test_ColonEight_MultiByte() fails on MS-Windows Solution: mark test as flaky This single line change should have happened as part of v9.1.469 (and I mentioned it in the Commit message), but forgot to actually include the change :facepalm Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-05 20:34:55 +02:00
/**/
470,
patch 9.1.0469: Cannot have buffer-local value for 'completeopt' Problem: Cannot have buffer-local value for 'completeopt' (Nick Jensen). Solution: Make 'completeopt' global-local (zeertzjq). Also for some reason test Test_ColonEight_MultiByte seems to be failing sporadically now. Let's mark it as flaky. fixes: #5487 closes: #14922 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-05 20:27:06 +02:00
/**/
469,
patch 9.1.0468: GvimExt does not consult HKEY_CURRENT_USER Problem: GvimExt does not consult HKEY_CURRENT_USER Solution: Make GvimExt first consult HKEY_CURRENT_USER and then fall back to HKEY_LOCAL_MACHINE to find gvim (David Wagner) fixes: #14904 closes: #14917 Signed-off-by: David Wagner <dwagner@rydia.us> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-05 20:01:19 +02:00
/**/
468,
patch 9.1.0467: typos in some comments Problem: typos in some comments (after v9.1.0466) Solution: fix comments (zeertzjq) closes: #14919 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-05 19:53:32 +02:00
/**/
467,
patch 9.1.0466: Missing comments for fuzzy completion Problem: Missing comments for fuzzy completion (after 9.1.0463) Solution: Add more comments, adjust indentation slightly (glepnir) closes: #14910 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-04 22:01:21 +02:00
/**/
466,
patch 9.1.0465: missing filecopy() function Problem: missing filecopy() function Solution: implement filecopy() Vim script function (Shougo Matsushita) closes: #12346 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-03 22:59:27 +02:00
/**/
465,
patch 9.1.0464: no whitespace padding in commentstring option in ftplugins Problem: no whitespace padding in commentstring option in ftplugins Solution: Change default to include whitespace padding, update existing filetype plugins with the new default value (Riley Bruins) closes: #14843 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-03 20:40:45 +02:00
/**/
464,
patch 9.1.0463: no fuzzy-matching support for insert-completion Problem: no fuzzy-matching support for insert-completion Solution: enable insert-mode completion with fuzzy-matching using :set completopt+=fuzzy (glepnir). closes: #14878 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-03 19:32:39 +02:00
/**/
463,
patch 9.1.0462: eval5() and eval7 are too complex Problem: eval5() and eval7 are too complex Solution: Refactor eval5() and eval7() in eval.c (Yegappan Lakshmanan) closes: #14900 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-03 18:52:22 +02:00
/**/
462,
patch 9.1.0461: too many strlen() calls in drawline.c Problem: too many strlen() calls in drawline.c Solution: Refactor code to avoid strlen() (John Marriott) closes: #14890 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-02 19:44:11 +02:00
/**/
461,
patch 9.1.0460: filetype: lintstagedrc files are not recognized Problem: filetype: lintstagedrc files are not recognized Solution: recognize '.lintstagedrc' files as json filetype (İlyas Akın) see: https://github.com/lint-staged/lint-staged closes: #14897 Signed-off-by: İlyas Akın <ilyas.akin@kuika.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-02 16:57:00 +02:00
/**/
460,
patch 9.1.0459: Vim9: import autoload does not work with symlink Problem: Vim9: import autoload does not work with symlink (Olivier Dormond) Solution: set sn_autoload_prefix in check_script_symlink (nwounkn) fixes: #14775 closes: #14885 Signed-off-by: nwounkn <nwounkn@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-02 16:10:07 +02:00
/**/
459,
patch 9.1.0458: Coverity complains about division by zero Problem: Coverity complains about division by zero Solution: Check explicitly for sw_val being zero Shouldn't happen, since tabstop value should always be larger than zero. So just add this as a safety measure. Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-02 16:04:43 +02:00
/**/
458,
patch 9.1.0457: tests: test_gui fails on Wayland v:windowid is set in GUI buils with Wayland Problem: tests: test_gui fails on Wayland (after: 9.1.0064, Gary Johnson) Solution: drop the "empty($WAYLAND_DISPLAY)" condition in the test fixes: #14886 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-01 20:55:09 +02:00
/**/
457,
patch 9.1.0456: Left shift is incorrect with vartabstop and shiftwidth=0 Problem: Left shift is incorrect with vartabstop and shiftwidth=0 Solution: make tabstop_at() function aware of shift direction (Gary Johnson) The problem was that with 'vartabstop' set and 'shiftwidth' equal 0, left shifts using << were shifting the line to the wrong column. The tabstop to the right of the first character in the line was being used as the shift amount instead of the tabstop to the left of that first character. The reason was that the tabstop_at() function always returned the value of the tabstop to the right of the given column and was not accounting for the direction of the shift. The solution was to make tabstop_at() aware of the direction of the shift and to choose the tabtop accordingly. A test was added to check this behavior and make sure it doesn't regress. While at it, also fix a few indentation/alignment issues. fixes: #14864 closes: #14887 Signed-off-by: Gary Johnson <garyjohn@spocom.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-01 20:51:33 +02:00
/**/
456,
patch 9.1.0455: MS-Windows: compiler warning for size_t to int conversion Problem: MS-Windows: compiler warning for size_t to int conversion Solution: Add a few type casts to resolve warning on Windows (Mike Williams) closes: #14884 Signed-off-by: Mike Williams <mrmrdubya@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-06-01 11:33:40 +02:00
/**/
455,
patch 9.1.0454: minor issues in test_filetype with rasi test Problem: minor issues in test_filetype with rasi test (after 9.1.0453) Solution: re-sort test_filetype, fix wrong syntax.txt help tags Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-31 12:26:12 +02:00
/**/
454,
patch 9.1.0453: filetype: rasi files are not recognized Problem: filetype: rasi files are not recognized Solution: regonize '*.rasi' files as rasi filetype, include a filetype and syntax plugin (Pierrick Guillaume) ported from: https://github.com/Fymyte/rasi.vim closes: #14821 Signed-off-by: Pierrick Guillaume <pierguill@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-31 12:00:49 +02:00
/**/
453,
patch 9.1.0452: Configure checks for libelf unnecessarily Problem: Configure checks for libelf unnecessarily Solution: Remove configure check (youcai) closes: #14879 Signed-off-by: youcai <omegacoleman@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-30 19:31:36 +02:00
/**/
452,
patch 9.1.0451: No test for escaping '<' with shellescape() Problem: No test for escaping '<' with shellescape() Solution: Add a test. Use memcpy() in code to make it easier to understand. Fix a typo (zeertzjq). closes: #14876 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-30 19:27:25 +02:00
/**/
451,
patch 9.1.0450: evalc. code too complex Problem: eval.c code too complex Solution: refactor eval6() and eval9() functions into several smaller functions (Yegappan Lakshmanan) closes: #14875 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-30 07:50:08 +02:00
/**/
450,
patch 9.1.0449: MS-Windows: Compiler warnings Problem: MS-Windows: Compiler warnings Solution: Resolve size_t to int warnings closes: #14874 A couple of warnings in ex_docmd.c have been resolved by modifying their function argument types, followed by some changes in various function call sites. This also allowed removal of some casts to cope with size_t/int conversion. Signed-off-by: Mike Williams <mrmrdubya@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-30 07:46:30 +02:00
/**/
449,
patch 9.1.0448: compiler warning in eval.c Problem: compiler warning in eval.c (after v9.1.0429) Solution: refactor code (Yegappan Lakshmanan) fixes: #14847 closes: #14867 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-29 07:51:50 +02:00
/**/
448,
patch 9.1.0447: completion may be wrong when deleting all chars Problem: completion may be wrong when deleting all chars Solution: reset compl_shown_match closes: #14854 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-27 15:11:01 +02:00
/**/
447,
patch 9.1.0446: getregionpos() inconsistent for partly-selected multibyte char Problem: getregionpos() behaves inconsistently for a partly-selected multibyte char. Solution: Always use column of the first byte for a partly-selected multibyte char (zeertzjq). closes: #14851 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-26 18:42:18 +02:00
/**/
446,
patch 9.1.0445: Coverity warning after 9.1.0440 Problem: Coverity warning after 9.1.0440 Solution: Fix Coverity warning, add a test and reduce the calls to clear_tv() (Yegappan Lakshmanan). closes: #14845 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-25 20:23:54 +02:00
/**/
445,
patch 9.1.0444: Not enough tests for getregion() with multibyte chars Problem: Not enough tests for getregion() with multibyte chars. Solution: Add a few more tests (zeertzjq). closes: #14844 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-25 10:25:36 +02:00
/**/
444,
patch 9.1.0443: Can't use blockwise selection with width for getregion() Problem: Can't use a blockwise selection with a width for getregion(). Solution: Add support for blockwise selection with width like the return value of getregtype() or the "regtype" value of TextYankPost (zeertzjq). closes: #14842 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-24 19:07:12 +02:00
/**/
443,
patch 9.1.0442: hare runtime files outdated Problem: hare runtime files outdated Solution: runtime(hare): update hare.vim to match upstream (Amelia Clarke) closes: #14836 Signed-off-by: Amelia Clarke <selene@perilune.dev> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-24 08:05:00 +02:00
/**/
442,
patch 9.1.0441: getregionpos() can't properly indicate positions beyond eol Problem: getregionpos() can't properly indicate positions beyond eol. Solution: Add an "eol" flag that enables handling positions beyond end of line like getpos() does (zeertzjq). Also fix the problem that a position still has the coladd beyond the end of the line when its column has been clamped. In the last test case with TABs at the end of the line the old behavior is obviously wrong. I decided to gate this behind a flag because returning positions that don't correspond to actual characters in the line may lead to mistakes for callers that want to calculate the length of the selected text, so the behavior is only enabled if the caller wants it. closes: #14838 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-24 07:48:51 +02:00
/**/
441,
patch 9.1.0440: function get_lval() is too long Problem: function get_lval() is too long Solution: factor out the get_lval_subscript() function (Yegappan Lakshmanan) closes: #14839 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-24 07:44:10 +02:00
/**/
440,
patch 9.1.0439: Cannot filter the history Problem: Cannot filter the history Solution: Implement :filter :history closes: #14835 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-24 07:39:34 +02:00
/**/
439,
patch 9.1.0438: Wrong Ex command executed when :g uses '?' as delimiter Problem: Wrong Ex command executed when :g uses '?' as delimiter and pattern contains escaped '?'. Solution: Don't use "*newp" when it's not allocated (zeertzjq). closes: #14837 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-24 07:37:36 +02:00
/**/
438,
patch 9.1.0437: Motif requires non-const char pointer for XPM data Problem: Motif requires non-const char pointer for XPM data shared with GTK (Tony Mechelynck, after v9.1.0432) Solution: Cast non-const to const char pointer for GTK (Drew Vogel). closes: #14834 Signed-off-by: Drew Vogel <dvogel@github> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-23 17:49:39 +02:00
/**/
437,
patch 9.1.0436: Crash when using '?' as separator for :s Problem: Crash when using '?' as separator for :s and pattern contains escaped '?'s (after 9.1.0409). Solution: Always compute startplen. (zeertzjq). related: neovim/neovim#28935 closes: 14832 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-23 17:41:26 +02:00
/**/
436,
patch 9.1.0435: filetype: cygport files are not recognized Problem: filetype: cygport files are not recognized Solution: Recognize '*.cygport' files as sh filetype (Ken Takata) https://cygwin.github.io/cygport/cygport_in.html closes: #14833 Signed-off-by: K.Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-23 17:31:26 +02:00
/**/
435,
patch 9.1.0434: make errors trying to access autoload/zig Problem: make errors trying to access autoload/zig Solution: Remove autoload/zig from Makefile, adjust Filelist (Derek Schrock) Commit d1d9316c6 removed autoload/zig/ files and install/uninstall target of the Makefile fail since the directory doesn't exist any longer. closes: #14828 Signed-off-by: Derek Schrock <dereks@lifeofadishwasher.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-23 17:26:51 +02:00
/**/
434,
patch 9.1.0433: Wrong yanking with exclusive selection and ve=all Problem: Wrong yanking with exclusive selection and virtualedit=all, and integer overflow when using getregion() on it. Solution: Set coladd when decreasing column and 'virtualedit' is active. Add more tests for getregion() with 'virtualedit' (zeertzjq). closes: #14830 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-23 07:47:55 +02:00
/**/
433,
patch 9.1.0432: Ancient XPM preprocessor hack may cause build errors Problem: Ancient XPM preprocessor hack may cause build errors. Solution: Simplify XPM includes and get rid of complicated #ifdef magic (Drew Vogel). closes: #14816 Signed-off-by: Drew Vogel <dvogel@github> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-22 16:51:53 +02:00
/**/
432,
patch 9.1.0431: eval.c is too long Problem: eval.c is too long Solution: Move garbage collection code to new gc.c file (Yegappan Lakshmanan) closes: #14824 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-22 16:45:04 +02:00
/**/
431,
patch 9.1.0430: getregionpos() doesn't handle one char selection Problem: getregionpos() doesn't handle one char selection. Solution: Handle startspaces differently when is_oneChar is set. Also add a test for an exclusive charwise selection with multibyte chars (zeertzjq) closes: #14825 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-22 16:42:44 +02:00
/**/
430,
patch 9.1.0429: Coverity complains about eval.c refactor Problem: Coverity complains about eval.c refactor (after v9.1.0422) Solution: Check that buf is not used un-initialized, add explicit conditions for save and restore of copyID Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-21 18:39:10 +02:00
/**/
429,
patch 9.1.0428: Tag guessing leaves wrong search history with very short names Problem: Tag guessing leaves wrong search history with very short names (after 9.1.0426). Solution: Use the correct variable for pattern length (zeertzjq). closes: #14817 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-21 17:19:58 +02:00
/**/
428,
patch 9.1.0427: tests: some issues with termdebug mapping test Problem: tests: some issues with termdebug mapping test Solution: Use assert_{true,false} if suitable, change order of expected and actual arguments in assert() calls. (Ken Takata) closes: #14818 related: 7fbbd7f Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-21 17:14:56 +02:00
/**/
427,
patch 9.1.0426: too many strlen() calls in search.c Problem: too many strlen() calls in search.c Solution: refactor code and remove more strlen() calls, use explicit variable to remember strlen (John Marriott) closes: #14796 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-20 19:18:26 +02:00
/**/
426,
patch 9.1.0425: filetype: purescript files are not recognized Problem: filetype: purescript files are not recognized Solution: recognize '*.purs' files as purescript filetype, include basic purescript filetype plugin (Riley Bruins) Reference: https://github.com/purescript/documentation/blob/master/language/Syntax.md#comments closes: #14813 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-20 14:21:53 +02:00
/**/
425,
patch 9.1.0424: filetype: slint files are not recognized Problem: filetype: slint files are not recognized Solution: Detect '*.slint' files as slint filetype, include basic sling filetype plugin (Riley Bruins) closes: #14808 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-20 14:20:09 +02:00
/**/
424,
patch 9.1.0423: getregionpos() wrong with blockwise mode and multibyte Problem: getregionpos() wrong with blockwise mode and multibyte. Solution: Use textcol and textlen instead of start_vcol and end_vcol. Handle coladd properly (zeertzjq). Also remove unnecessary buflist_findnr() in add_regionpos_range(), as getregionpos() has already switched buffer. closes: #14805 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-20 14:00:31 +02:00
/**/
423,
patch 9.1.0422: function echo_string_core() is too long Problem: function echo_string_core() is too long Solution: Refactor into several smaller functions (Yegappan Lakshmanan) closes: #14804 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-20 13:57:11 +02:00
/**/
422,
patch 9.1.0421: filetype: hyprlang files are not recognized Problem: filetype: hyprlang files are not recognized Solution: recognize 'hypr{land,paper,idle,lock}.conf' files as 'hyprlang' filetype, add hyprlang ftplugin (Riley Bruins) closes: #14803 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-19 11:26:44 +02:00
/**/
421,
patch 9.1.0420: :browse oldfiles prompts even with single entry Problem: :browse oldfiles prompts even with single entry Solution: Do not prompt, but edit the file directly, also when using :filter /pat/ browse oldfiles closes: #14794 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-19 09:11:09 +02:00
/**/
420,
patch 9.1.0419: eval.c not sufficiently tested Problem: eval.c not sufficiently tested Solution: Add a few more additional tests for eval.c, (Yegappan Lakshmanan) closes: #14799 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-19 09:06:50 +02:00
/**/
419,
patch 9.1.0418: Cannot move to previous/next rare word Problem: Cannot move to previous/next rare word (Colin Kennedy) Solution: Add the ]r and [r motions (Christ van Willegen) fixes: #14773 closes: #14780 Signed-off-by: Christ van Willegen - van Noort <github.com@vanwillegen-vannoort.nl> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-17 18:49:27 +02:00
/**/
418,
patch 9.1.0417: if_py: find_module has been removed in Python 3.12.0a7 Problem: if_py: find_module has been removed in Python 3.12.0a7 (@Ghost-LZW) Solution: Do not include find_module for Python >= 3.12.0a7 fixes: #14776 closes: #14781 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-17 18:30:01 +02:00
/**/
417,
patch 9.1.0416: some screen dump tests can be improved Problem: some screen dump tests can be improved (after 9.1.0414) Solution: Make sure screen state changes properly and is captured in the screen dumps (Luuk van Baal) closes: #14788 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-17 18:25:13 +02:00
/**/
416,
patch 9.1.0415: Some functions are not tested Problem: Some functions are not tested Solution: Add a few more tests, fix a few minor problems (Yegappan Lakshmanan) closes: #14789 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-17 18:20:43 +02:00
/**/
415,
patch 9.1.0414: Unable to leave long line with 'smoothscroll' and 'scrolloff' Problem: Unable to leave long line with 'smoothscroll' and 'scrolloff'. Corrupted screen near the end of a long line with 'scrolloff'. (Ernie Rael, after 9.1.0280) Solution: Only correct cursor in case scroll_cursor_bot() was not itself called to make the cursor visible. Avoid adjusting for 'scrolloff' beyond the text line height (Luuk van Baal) fixes: #14726 closes: #14783 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-16 20:44:09 +02:00
/**/
414,
patch 9.1.0413: smoothscroll may cause infinite loop Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, verify that win_linetabsize does not overflow fixes: #14750 closes: #14772 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-15 21:35:36 +02:00
/**/
413,
patch 9.1.0412: typo in regexp_bt.c in DEBUG code Problem: typo in regexp_bt.c in DEBUG code, causing compile error (@kfleong7, after v9.1.0409) Solution: Replace bulen by buflen Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-14 11:19:47 +02:00
/**/
412,
patch 9.1.0411: too long functions in eval.c Problem: too long functions in eval.c Solution: refactor functions (Yegappan Lakshmanan) closes: #14755 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-12 09:24:35 +02:00
/**/
411,
patch 9.1.0410: warning about uninitialized variable Problem: warning about uninitialized variable (Tony Mechelynck, after 9.1.0409) Solution: initialize variable (John Marriott) closes: #14754 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-12 09:01:38 +02:00
/**/
410,
patch 9.1.0409: too many strlen() calls in the regexp engine Problem: too many strlen() calls in the regexp engine Solution: refactor code to retrieve strlen differently, make use of bsearch() for getting the character class (John Marriott) closes: #14648 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-12 00:07:17 +02:00
/**/
409,
patch 9.1.0408: configure fails on Fedora when including perl Problem: configure fails on Fedora when including perl (chesheer-smile) Solution: Filter out -spec=<path> from $LIBS and $LDFLAGS to avoid linking relocation errors for unrelated autoconf tests. closes: #14526 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-11 20:18:21 +02:00
/**/
408,
patch 9.1.0407: Stuck with long line and half-page scrolling Problem: No scrolling happens with half-page scrolling with line filling entire window when 'smoothscroll' is disabled. (Mathias Rav, after v9.1.0285) Solution: Adjust amount to move cursor by so that it is moved the same number of lines as was scrolled, even when scrolling different number of lines than requested with 'nosmoothscroll'. fixes: #14743 closes: #14746 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-11 11:27:52 +02:00
/**/
407,
patch 9.1.0406: Divide by zero with getmousepos() and 'smoothscroll' Problem: Divide by zero with getmousepos() and 'smoothscroll'. Solution: Don't compute skip_lines when width1 is zero. (zeertzjq) closes: #14747 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-11 11:23:37 +02:00
/**/
406,
patch 9.1.0405: tests: xxd buffer overflow fails on 32-bit Problem: tests: xxd buffer overflow fails on 32-bit Solution: Skip test on 32-bit architecture Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-10 20:00:33 +02:00
/**/
405,
patch 9.1.0404: [security] xxd: buffer-overflow with specific flags Problem: [security] xxd: buffer-overflow with specific flags Solution: Correctly calculate the required buffer space (Lennard Hofmann) xxd writes each output line into a global buffer before printing. The maximum size of that buffer was not calculated correctly. This command was crashing in AddressSanitizer: $ xxd -Ralways -g1 -c256 -d -o 9223372036854775808 /etc/passwd This prints a line of 6680 bytes but the buffer only had room for 6549 bytes. If the output from "-b" was colored, the line could be even longer. closes: #14738 Co-authored-by: K.Takata <kentkt@csc.jp> Signed-off-by: Lennard Hofmann <lennard.hofmann@web.de> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-10 14:17:26 +02:00
/**/
404,
patch 9.1.0403: Vim9: not able to import file from start dir Problem: Vim9: not able to import file from start dir (Danielle McLean) Solution: Allow to import from start directory (Yegappan Lakshmanan) fixes: #13313 closes: #14740 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-10 13:10:54 +02:00
/**/
403,
patch 9.1.0402: filetype: mdd files detected as zsh filetype Problem: filetype: mdd files detected as zsh filetype Solution: detect '*.mdd' files as sh filetype, add links to reference documentation (Wu, Zhenyu) closes: #14741 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-10 12:11:56 +02:00
/**/
402,
patch 9.1.0401: filetype: zsh module files are not recognized Problem: filetype: zsh module files are not recognized Solution: Detect '*.mdh' and '*.epro' as C filetype, '*.mdd' as zsh filetype, determine zsh-modules '*.pro' from from it's content (Wu, Zhenyu) closes: #14737 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-09 20:35:13 +02:00
/**/
401,
patch 9.1.0400: Vim9: confusing error message for unknown type Problem: Vim9: confusing error message for unknown type (Doug Kearns) Solution: For an unknown type, display only the type name in the error message (Yegappan Lakshmanan) fixes: #13153 closes: #14736 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-09 09:12:31 +02:00
/**/
400,
patch 9.1.0399: block_editing errors out when using del Problem: block_editing errors out when using del (@Jamarley) Solution: Change ins_len from size_t to int and properly check that it doesn't become negative There is a check in os.c that verifies that `ins_len` does not become negative: ``` if (pre_textlen >= 0 && (ins_len = len - pre_textlen - offset) > 0) ``` However this only works, if ins_len can actually become negative and unfortunately, ins_len has been declared as `size_t` so instead of becoming negative it will wrap around and be very large. So let's define it as integer, after which the condition above properly catches this condition. fixes: #14734 closes: #14735 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-08 22:17:19 +02:00
/**/
399,
patch 9.1.0398: Vim9: imported vars are not properly type checked Problem: Vim9: imported vars are not properly type checked Solution: Check the imported variable type properly (Yegappan Lakshmanan) closes: #14729 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-08 20:24:33 +02:00
/**/
398,
patch 9.1.0397: Wrong display with 'smoothscroll' when changing quickfix list Problem: Wrong display with 'smoothscroll' when changing quickfix list. Solution: Reset w_skipcol when replacing quickfix list (zeertzjq). closes: #14730 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-08 20:22:40 +02:00
/**/
397,
patch 9.1.0396: filetype: jj files are not recognized Problem: jj files are not recognized Solution: recognize '*.jjdescription' files as jj filetype (Gregory Anders) See: https://github.com/martinvonz/jj closes: #14733 Signed-off-by: Gregory Anders <greg@gpanders.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-08 20:17:43 +02:00
/**/
396,
patch 9.1.0395: getregionpos() may leak memory on error Problem: regionpos may leak memory on error, coverity complains about dereferencing Null pointer Solution: free all list pointers (after v9.1.394), return early if buflist_findnr() returns NULL closes: #14731 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-08 19:50:26 +02:00
/**/
395,
patch 9.1.0394: Cannot get a list of positions describing a region Problem: Cannot get a list of positions describing a region (Justin M. Keyes, after v9.1.0120) Solution: Add the getregionpos() function (Shougo Matsushita) fixes: #14609 closes: #14617 Co-authored-by: Justin M. Keyes <justinkz@gmail.com> Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-07 20:49:24 +02:00
/**/
394,
patch 9.1.0393: 'viewdir' not respecting $XDG_CONFIG_HOME Problem: 'viewdir' not respecting $XDG_CONFIG_HOME (Danilo Rezende, after v9.1.327) Solution: adjust 'viewdir' option when enabling XDG config mode fixes: #14680 closes: #14708 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-04 09:48:15 +02:00
/**/
393,
patch 9.1.0392: tests: Vim9 debug tests may be flaky Problem: tests: Vim9 debug tests may be flaky (Shane-XB-Qian) Solution: Give a few more lines so that line-wrapping won't cause a hit-enter prompt The two tests Run_Test_debug_running_out_of_lines() and Run_Test_debug_with_lambda() test debugging of Vim script functions. Depending from what file-path the tests are run, it may cause line wrapping to occur on the following output: Entering Debug mode. Type "cont" to continue. command line..script /home/chrisbra/code/vim-upstream/src/testdir/XdebugFunc[15]..function <SNR>9_Crash and if the window is too small, this will cause a hit-enter prompt and so the WaitForAssert() fails, causing failure of the following tests. So increase the (internal) Vim window by a few more lines, so that even if line-wrapping occurs, no hit-enter prompts happens and so the tests can finish. fixes: #14596 closes: #14691 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-04 09:38:59 +02:00
/**/
392,
patch 9.1.0391: Vim9: could improve testing Problem: Vim9: could improve testing (Ernie Rael) Solution: Support defcompile for test_override() to improve testing (Yegappan Lakshmanan) fixes: #14553 closes: #14712 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-03 18:24:07 +02:00
/**/
391,
patch 9.1.0390: filetype: inko files are not recognized Problem: filetype: inko files are not recognized Solution: Detect '*.inko' as ink filetype (Yorick Peterse) See: - https://github.com/inko-lang/inko.vim - https://inko-lang.org/ closes: #14699 Signed-off-by: Yorick Peterse <git@yorickpeterse.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-02 13:11:44 +02:00
/**/
390,
patch 9.1.0389: filetype: templ files are not recognized Problem: filetype: templ files are not recognized Solution: Detect '*.templ' files as filetype templ (Tristan Knight) See: - https://github.com/a-h/templ - https://templ.guide/ closes: #14697 Signed-off-by: tris203 <admin@snappeh.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-02 13:08:25 +02:00
/**/
389,
patch 9.1.0388: cursor() and getregion() don't handle v:maxcol well Problem: cursor() and getregion() don't handle v:maxcol well. Solution: Add special handling for v:maxcol like setpos() does. (zeertzjq) closes: #14698 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-02 13:06:24 +02:00
/**/
388,
patch 9.1.0387: Vim9: null value tests not sufficient Problem: Vim9: null value tests not sufficient Solution: Add a more comprehensive test for null values (Yegappan Lakshmanan) closes: #14701 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-02 13:02:36 +02:00
/**/
387,
patch 9.1.0386: filetype: stylus files not recognized Problem: filetype: stylus files not recognized Solution: Detect '*.styl' and '*.stylus' as stylus filetype, include indent, filetype and syntax plugin (Philip H) closes: #14656 Signed-off-by: Philip H <47042125+pheiduck@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-01 18:42:11 +02:00
/**/
386,
patch 9.1.0385: Vim9: crash with null_class and null_object Problem: Vim9: crash with null_class and null_object (Aliaksei Budavei) Solution: Handle null_class and null_object correctly (Yegappan Lakshmanan) fixes: #14678 closes: #14681 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-05-01 11:44:17 +02:00
/**/
385,
patch 9.1.0384: tests: vt420 terminfo entry may not be found Problem: tests: vt420 terminfo entry may not be found (Shane-XB-Qian) Solution: check existence of terminfo vt420 and infocmp command related: #14595 closes: #14677 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-30 20:45:09 +02:00
/**/
384,
patch 9.1.0383: filetype: .out files recognized as tex files Problem: filetype: .out files recognized as tex files Solution: Do not set an explicit filetype until it is clear what this should be (shane.xb.qian) closes: #14670 Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-30 20:35:53 +02:00
/**/
383,
patch 9.1.0382: filetype: Kbuild files are not recognized Problem: Kbuild files are not recognized. Solution: Detect Kbuild files as make files. (Bruno Belanyi) closes: #14676 Signed-off-by: Bruno Belanyi <bruno@belanyi.fr> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-30 20:16:01 +02:00
/**/
382,
patch 9.1.0381: cbuffer and similar commands don't accept a range Problem: cbuffer and similar quickfix and locationlist commands don't accept a range, even so it is documented they should (ilan-schemoul, after 8.1.1241) Solution: Define ex commands with ADDR_LINES instead of ADDR_OTHER fixes: #14638 closes: #14657 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-29 20:36:49 +02:00
/**/
381,
patch 9.1.0380: Calculating line height for unnecessary amount of lines Problem: Calculating line height for unnecessary amount of lines with half-page scrolling (zhscn, after 9.1.0280) Solution: Replace "limit_winheight" argument with higher resolution "max" argument to which to limit the calculated line height in plines_m_win() to (Luuk van Baal) fixes: #14650 closes: #14652 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-28 16:24:02 +02:00
/**/
380,
patch 9.1.0379: There are a few typos Problem: There are a few typos Solution: Fix them (zeertzjq) closes: #14655 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-28 16:20:55 +02:00
/**/
379,
patch 9.1.0378: Vim9: no comments allowed after class vars Problem: Vim9: no comments allowed after class vars (Christian Robinson, after 9.1.376) Solution: Allow trailing comments after class vars (Yegappan Lakshmanan) closes: #14651 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-28 09:54:09 +02:00
/**/
378,
patch 9.1.0377: Formatting text wrong when 'breakindent' is set Problem: formatting text wrong when 'breakindent' is set (Gary Johnson) Solution: temporarily disable 'breakindent' option when formatting text, so that the breakindent is not wrongly taken into account for the line length fixes: #14630 closes: #14637 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-27 11:55:08 +02:00
/**/
377,
patch 9.1.0376: Vim9: Trailing commands after class/enum keywords ignored Problem: Vim9: Trailing commands after class/enum keywords ignored Solution: Remove EX_TRLBAR keyword from command definition (Yegappan Lakshmanan) closes: #14649 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-27 11:36:12 +02:00
/**/
376,
patch 9.1.0375: tests: 1-second delay after Test_BufEnter_botline() Problem: tests: 1-second delay after Test_BufEnter_botline() (after v9.1.0374) Solution: Wipe the created buffers (zeertzjq). closes: #14647 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-27 11:33:24 +02:00
/**/
375,
patch 9.1.0374: wrong botline in BufEnter Problem: When :edit an existing buffer, line('w$') may return a wrong result. Solution: Reset w_valid in curwin_init() (Jaehwang Jung) `do_ecmd()` reinitializes the current window (`curwin_init()`) whose `w_valid` field may have `VALID_BOTLINE` set. Resetting `w_botline` without marking it as invalid makes subsequent `validate_botline()` calls a no-op, thus resulting in wrong `line('w$')` value. closes: #14642 Signed-off-by: Jaehwang Jung <tomtomjhj@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-26 18:48:48 +02:00
/**/
374,
patch 9.1.0373: ops.c code uses too many strlen() calls Problem: ops.c code uses too many strlen() calls Solution: Refactor code and remove more strlen() calls (John Marriott) closes: #14598 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-25 21:39:18 +02:00
/**/
373,
patch 9.1.0372: Calling CLEAR_FIELD() on the same struct twice Problem: Calling CLEAR_FIELD() on the same struct twice. Solution: Remove the second CLEAR_FIELD(). Move the assignment of cookie.sourceing_lnum (zeertzjq). closes: #14627 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-25 21:34:10 +02:00
/**/
372,
patch 9.1.0371: Vim9: compile_def_function() still too long Problem: Vim9: compile_def_function() still too long Solution: Refactor the code into separate functions (Yegappan Lakshmanan) closes: #14632 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-25 21:30:56 +02:00
/**/
371,
patch 9.1.0370: MS-Windows: patch number is zero in installer Problem: MS-Windows: patch number is zero in installer (jonathan-b-wiebe) Solution: Set VIM_VERSION_PATCHLEVEL, fix a few typos in the installer (RestorerZ) fixes: #14629 closes: #14635 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-25 21:25:19 +02:00
/**/
370,
patch 9.1.0369: Vim9: problem when importing autoloaded scripts Problem: Vim9: problem when importing autoloaded scripts Solution: In `:def` handle storing to vim9 autoload export (Ernie Rael) Problem occurs when `import autoload ./.../autoload/...`. The autoload in the specified path causes the use of an autoload_prefix which combines with the `import autoload` to create trouble. In `generate_store_var()` `case dest_script` use ISN_STOREEXPORT, when needed, instead of ISN_STORES. When executing ISN_STOREEXPORT, check for autoload_prefix. fixes: #14606 closes: #14615 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com>
2024-04-24 20:07:50 +02:00
/**/
369,
patch 9.1.0368: MS-Windows: Hard to define the Vim Patchlevel with leading zeroes Problem: MS-Windows: Hard to define the Vim Patchlevel with leading zeroes for the installer Solution: re-define VIM_VERSION_PATCHLEVEL_STR with leading zeroes, interpret Patchlevel as decimal in Make_mvc.mak (RestorerZ) closes: #14471 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-23 20:33:38 +02:00
/**/
368,
patch 9.1.0367: compile_def_function is too long Problem: compile_def_function is too long Solution: Move out the code to compile the body of a function (Yegappan Lakshmanan) closes: #14622 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-23 20:14:46 +02:00
/**/
367,
patch 9.1.0366: filetype: ondir files are not recognized Problem: filetype: ondir files are not recognized Solution: Detect '.ondirrc' as ondir filetype (Jon Parise) closes: #14604 Signed-off-by: Jon Parise <jon@indelible.org> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-22 21:07:41 +02:00
/**/
366,
patch 9.1.0365: Crash when typing many keys with D- modifier Problem: Crash when typing many keys with D- modifier (after 9.1.0227). Solution: Don't treat a 0x80 byte inside a special sequence as the start of a special sequence (zeertzjq). closes: #14613 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-22 21:04:29 +02:00
/**/
365,
patch 9.1.0364: tests: test_vim9_builtin is a bit slow Problem: tests: test_vim9_builtin is a bit slow Solution: source tests from a buffer instead of writing and sourcing a file (Yegappan Lakshmanan) closes: #14614 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-22 20:58:24 +02:00
/**/
364,
patch 9.1.0363: tests: test_winfixbuf is a bit slow Problem: tests: test_winfixbuf is a bit slow Solution: use defer if possible, reset hidden option, use --not-a-term when starting Vim using system() (Yegappan Lakshmanan) closes: #14611 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-21 19:50:21 +02:00
/**/
363,
patch 9.1.0362: expanding rc config files does not work well Problem: expanding rc config files does not work well (Michał Sieroń, after v9.1.0327) Solution: initialize chartab option, required to expand evironment variables fixes: #14597 Co-authored-by: author Signed-off-by: author Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-21 14:52:20 +02:00
/**/
362,
patch 9.1.0361: Vim9: vim9type.c is too complicated Problem: Vim9: vim9type.c is too complicated Solution: Refactor a few functions in vim9type.c (Yegappan Lakshmanan) closes: #14605 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-21 14:48:57 +02:00
/**/
361,
patch 9.1.0360: Vim9: does not handle autoloaded variables well Problem: Vim9: does not handle autoloaded variables well Solution: Better handle script-level exported variable references from autoload files (Ernie Rael). fixes: #14591 closes: #14607 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-21 14:45:48 +02:00
/**/
360,
patch 9.1.0359: MS-Windows: relative import in a script sourced from a buffer doesn't work Problem: MS-Windows: Relative import in a script sourced from a buffer doesn't work (Ernie Rael) Solution: Set a filename, so that we are not trying to use script-relative filename (Yegappan Lakshmanan) When a script is sourced from a buffer, the file name is set to ":source buffer=". In MS-Windows, the ":" is a path separator character (used after a drive letter). This results in the code trying to use the ":" prefix to import the script on MS-Windows. To fix this, when importing a script from a script sourced from a buffer with nofile, don't use a script relative path name. fixes #14588 closes: #14603 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-20 18:31:21 +02:00
/**/
359,
patch 9.1.0358: wrong drawing in GUI with setcellwidth() Problem: wrong drawing in GUI with setcellwidth() (after v9.1.0344) Solution: move gui.in_use condition (h-east) closes: #14600 Signed-off-by: h-east <h.east.727@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-20 17:57:19 +02:00
/**/
358,
patch 9.1.0357: Page scrolling should place cursor at window boundaries Problem: Page scrolling does not always place the cursor at the top or bottom of the window (Mathias Rav) Solution: Place the cursor at the top or bottom of the window. (Luuk van Baal) fixes: #14585 closes: #14586 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-20 17:38:20 +02:00
/**/
357,
patch 9.1.0356: MS-Windows: --remote may change working directory Problem: MS-Windows: --remote may change working directory when 'shellslash' is set Solution: normalize directory separators on MS-Windows fixes: #14549 closes: #14587 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-19 15:22:33 +02:00
/**/
356,
patch 9.1.0355: filetype: flake.lock files are not recognized Problem: filetype: flake.lock files are not recognized Solution: Detect 'flake.lock' as json filetype (Riley Bruins) closes: #14589 Signed-off-by: Riley Bruins <ribru17@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-19 15:13:38 +02:00
/**/
355,
patch 9.1.0354: runtime(uci): No support for uci file types Problem: runtime(uci): No support for uci file types (Wu, Zhenyu) Solution: include basic uci ftplugin and syntax plugins (Colin Caine) closes: #14575 Co-authored-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Colin Caine <complaints@cmcaine.co.uk> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 23:53:02 +02:00
/**/
354,
patch 9.1.0353: tests: Test_autoload_import_relative_compiled fails on Windows Problem: tests: Test_autoload_import_relative_compiled fails on Windows Solution: Disable on Windows for now, add missing :bw for clean-up (Ernie Rael) closes: #14579 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 22:53:33 +02:00
/**/
353,
patch 9.1.0352: Finding cmd modifiers and cmdline-specials is inefficient Problem: Finding cmd modifiers and cmdline-specials is inefficient Solution: Use binary search to find ex command modifiers and cmdline-special characters and reduce the number of strlen() (John Marriott) closes: #14534 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 22:46:56 +02:00
/**/
352,
patch 9.1.0351: No test that completing a partial mapping clears 'showcmd' Problem: No test that completing a partial mapping clears 'showcmd'. Solution: Complete partial mappings in Test_showcmd_part_map() instead of using :echo. Adjust some comments (zeertzjq). closes: #14580 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 22:09:37 +02:00
/**/
351,
patch 9.1.0350: tests: test_vim9_dissamble may fail Problem: tests: test_vim9_dissamble may fail Solution: Instead of hard-coding the lambda number, accept just any number (Julio B) closes: #14581 Signed-off-by: Julio B <julio.bacel@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 22:05:12 +02:00
/**/
350,
patch 9.1.0349: Vim9: need static type for typealias Problem: Vim9: need static type for typealias Solution: Refactor the typval2type() function and add a static type for typealias (Yegappan Lakshmanan) closes: #14582 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 21:33:27 +02:00
/**/
349,
patch 9.1.0348: X11 does not ignore smooth scroll event Problem: X11 does not ignore smooth scroll event (laniakea64) Solution: Correctly ignore unwanted smooth scroll events on X11 (lilydjwg) fixes #14578 closes: #14583 Signed-off-by: lilydjwg <lilydjwg@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 21:22:57 +02:00
/**/
348,
patch 9.1.0347: A few typos in test_xdg when testing gvimrc Problem: A few typos in test_xdg when testing gvimrc Solution: Fix them (Diego Viola) closes: #14584 Signed-off-by: Diego Viola <diego.viola@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-18 20:54:06 +02:00
/**/
347,
patch 9.1.0346: Patch v9.1.0338 fixed sourcing a script with import Problem: Patch v9.1.0338 fixed sourcing a script with import Solution: Add test `import './file.vim' and verify it works with `:source` so it does not regress (Ernie Rael) closes: #14577 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-17 22:36:32 +02:00
/**/
346,
patch 9.1.0345: Problem: gvimrc not sourced from XDG_CONFIG_HOME Problem: gvimrc not sourced from XDG_CONFIG_HOME (after v9.1.0327) Solution: Also try to source from ~/.config/vim/gvimrc and $XDG_CONFIG_HOME/vim/gvimrc (Maxim Kim) fixes: #14567 closes: #14568 Signed-off-by: Maxim Kim <habamax@haba-debian.habamax> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-17 22:29:06 +02:00
/**/
345,
patch 9.1.0344: Cursor wrong after using setcellwidth() in terminal Problem: Cursor wrong after using setcellwidth() in terminal (mikoto2000) Solution: output additional spaces, so the behaviour matches the GUI (mikoto2000) fixes: #14539 closes: #14540 Signed-off-by: mikoto2000 <mikoto2000@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org> Fix CUI `setcellwidths` characters draw behavior to same GUI behavior.
2024-04-17 22:06:54 +02:00
/**/
344,
patch 9.1.0343: 'showcmd' wrong for partial mapping with multibyte Problem: 'showcmd' is wrong for partial mapping with multibyte char, and isn't very readable with modifyOtherKeys. Solution: Decode multibyte char and merge modifiers into the char. (zeertzjq) This improves the following situations: - Multibyte chars whose individual bytes are considered unprintable are now shown properly in 'showcmd' area. - Ctrl-W with modifyOtherKeys now shows ^W in 'showcmd' area. The following situation may still need improvement: - If the char is a special key or has modifiers that cannot be merged into it, internal keycodes are shown in 'showcmd' area like before. This applies to keys typed in Normal mode commands as well, and it's hard to decide how to make it more readable due to the limited space taken by 'showcmd', so I'll leave it for later. closes: #14572 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-17 21:28:54 +02:00
/**/
343,
patch 9.1.0342: tests: test_taglist fails when 'helplang' contains non-english Problem: tests: test_taglist fails when 'helplang' contains non-english Solution: Allow 1 or 2 tagfiles for now (Julio B) related: #14312 closes: #14566 Signed-off-by: Julio B <julio.bacel@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 22:55:04 +02:00
/**/
342,
patch 9.1.0341: Problem: a few memory leaks are found Problem: a few memory leaks are found (LuMingYinDetect ) Solution: properly free the memory Fixes the following problems: - Memory leak in f_maplist() fixes: #14486 - Memory leak in option.c fixes: #14485 - Memory leak in f_resolve() fixes: #14484 - Memory leak in f_autocmd_get() related: #14474 - Memory leak in dict_extend_func() fixes: #14477 fixes: #14238 closes: #14517 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 22:44:31 +02:00
/**/
341,
patch 9.1.0340: Problem: Error with matchaddpos() and empty list Problem: Error with matchaddpos() and empty list (@rickhow) Solution: Return early for an empty list fixes: #14525 closes: #14563 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 22:23:17 +02:00
/**/
340,
patch 9.1.0339: tests: xdg test uses screen dumps Problem: tests: xdg test uses screen dumps Solution: Convert screen dump to normal test (Yegappan Lakshmanan) closes: #14564 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 22:18:15 +02:00
/**/
339,
patch 9.1.0338: Vim9: import through symlinks not correctly handled Problem: Vim9: import through symlinks not correctly handled Solution: Check for script being a symlink but only once (Ernie Rael) closes: #14565 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 22:11:56 +02:00
/**/
338,
patch 9.1.0337: Missing entry for XDG vimrc file in :version Problem: Missing entry for XDG vimrc file in :version Solution: Add 4th user vimrc entry to :version output (Diego Viola) related: #14182 closes: #14569 Signed-off-by: Diego Viola <diego.viola@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 20:58:45 +02:00
/**/
337,
patch 9.1.0336: tests: typo in test_xdg Problem: tests: typo in test_xdg Solution: fix typo (Diego Viola) closes: #14562 Signed-off-by: Diego Viola <diego.viola@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-15 20:08:38 +02:00
/**/
336,
patch 9.1.0335: String interpolation fails for List type Problem: String interpolation fails for List type Solution: use implicit string(list) for string interpolation and :put = (Yegappan Lakshmanan) related: #14529 closes: #14556 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-15 19:19:52 +02:00
/**/
335,
patch 9.1.0334: No test for highlight behavior with 'ambiwidth' Problem: No test for highlight behavior with 'ambiwidth'. Solution: Add a screendump test for 'ambiwidth' with 'cursorline'. (zeertzjq) closes: #14554 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-15 19:14:38 +02:00
/**/
334,
patch 9.1.0333: tests: test_xdg fails on the appimage repo Problem: tests: test_xdg fails on the appimage repo Solution: compare only the last 30 right characters of $MYVIMRC Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-15 19:11:15 +02:00
/**/
333,
patch 9.1.0332: tests: some assert_equal() calls have wrong order of args Problem: tests: some assert_equal() calls have wrong order of args Solution: Correct the order (zeertzjq). closes: #14555 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-15 19:01:04 +02:00
/**/
332,
patch 9.1.0331: make install does not install all files Problem: make install does not install all files (Nick Jensen) Solution: Adjust the Makefile rule to install and uninstall cargo and rust directories (Matt Hammerly) fixes: #14551 closes: #14552 closes: #14557 Signed-off-by: Matt Hammerly <hammerly.matt@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-15 18:54:38 +02:00
/**/
331,
patch 9.1.0330: v9.1.0327 contains an unrelated change Problem: v9.1.0327 contains an unrelated change Solution: Revert back $USR_VIMRC_FILE to $HOME instead of ~ Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 23:45:02 +02:00
/**/
330,
patch 9.1.0329: String interpolation fails for Dict type Problem: String interpolation fails for Dict type Solution: Support Dict data type properly, also support :put =Dict (without having to convert it to string() first) (Yegappan Lakshmanan) fixes: #14529 closes: #14541 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 23:21:02 +02:00
/**/
329,
patch 9.1.0328: CI fails with t_?? test Problem: CI fails with t_?? test Solution: use assert_match instead of assert_equal and test only until t_xo, depending on system there may be several more termcap codes coming Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 23:14:50 +02:00
/**/
328,
patch 9.1.0327: No support for using $XDG_CONFIG_HOME Problem: No support for using $XDG_CONFIG_HOME Solution: optionally source $XDG_CONFIG_HOME/vim/vimrc (Luca Saccarola) fixes: #2034 closes: #14182 Signed-off-by: Luca Saccarola <github.e41mv@aleeas.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 22:53:22 +02:00
/**/
327,
patch 9.1.0326: filetype: some requirements files are not recognized Problem: filetype: some requirements files are not recognized Solution: Detect '*-requirements.txt', 'constraints.txt', 'requirements.in', 'requirements/*.txt' and 'requires/*.txt' as requirements filetype, include pip compiler, include requirements filetype and syntax plugin (Wu, Zhenyu, @raimon49) closes: #14379 Co-authored-by: raimon <raimon49@hotmail.com> Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 20:38:24 +02:00
/**/
326,
patch 9.1.0325: filetype: CMakeCache.txt files not recognized Problem: filetype: CMakeCache.txt files not recognized Solution: Detect 'CMakeCache.txt' files as cmakecache filetype, include basic syntax script for cmakecache (Wu, Zhenyu, @bfrg) closes: #14384 Co-authored-by: bfrg <bfrg@users.noreply.github.com> Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 20:34:22 +02:00
/**/
325,
patch 9.1.0324: filetype: some json files are not recognized Problem: filetype: some json files are not recognized Solution: Detect '.jscsrc' and '.vsconfig' as jsonc filetype (Wu, Zhenyu) See: - https://github.com/microsoft/PowerToys/blob/main/.vsconfig - https://jscs-dev.github.io/ closes: #14452 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 20:29:43 +02:00
/**/
324,
patch 9.1.0323: filetype: cabal config files may not be recognized Problem: filetype: cabal config files may not be recognized Solution: Change filetype pattern to '*/{,.}cabal/config' (Wu Zhenyu) closes: #14498 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 20:22:19 +02:00
/**/
323,
patch 9.1.0322: filetype: some mail tools not recognized Problem: filetype: some mail tools not recognized Solution: Detect '.mbsncrc' as conf, '.msmtprc' as msmtp and '.notmuch-config' as ini filetype (Shane-XB-Qian) closes: #14533 Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 20:14:33 +02:00
/**/
322,
patch 9.1.0321: Garbled output on serial terminals with XON/XOFF flow control Problem: When used terminal with XON/XOFF flow control, vim tries to still make CTRL-S mapping available, which results in severe screen corruption, especially on large redraws, and even spurious inputs (John Tsiombikas) Solution: Disallow CTRL-S mapping if such terminal is recognized. Don't remove IXON from the bitmask inversion. (Anton Sharonov) *** When started like this: TERM=vt420 vim :set termcap shows "t_xon=y" map <C-S> :echo "abc"<CR> does nothing (after <C-S> output freezes and subsequent <C-Q> unfreezes it) *** When started like this: TERM=xterm vim :set termcap shows "t_xon=" map <C-S> :echo "abc"<CR> works (after <C-S> one see "abc" string echo-ed) fixes: #12674 closes: #14542 Signed-off-by: Anton Sharonov <anton.sharonov@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 20:02:24 +02:00
/**/
321,
patch 9.1.0320: Wrong cursor position after using setcellwidths() Problem: Wrong cursor position after using setcellwidths(). Solution: Invalidate cursor position in addition to redrawing. (zeertzjq) closes: #14545 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 18:52:49 +02:00
/**/
320,
patch 9.1.0319: Using heredoc in string not tested with :execute Problem: Using heredoc in string not tested with :execute. Solution: Test with both :execute and execute() (zeertzjq). closes: #14546 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-14 18:49:56 +02:00
/**/
319,
patch 9.1.0318: filetype: translate shell config files are not recognized Problem: filetype: translate shell config files are not recognized Solution: Detect 'init.trans', 'translate-shell' and '.trans' files as clojure (Wu, Zhenyu) See: https://github.com/soimort/translate-shell/wiki/Configuration closes: #14499 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-13 18:28:28 +02:00
/**/
318,
patch 9.1.0317: filetype: matplotlibrc files are not recognized Problem: filetype: matplotlibrc files are not recognized Solution: Detect 'matplotlibrc' file as yaml filetype (Wu, Zhenyu) See: https://matplotlib.org/stable/users/explain/customizing.html#the-matplotlibrc-file closes: #14501 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-13 18:25:38 +02:00
/**/
317,
patch 9.1.0316: filetype: some sh and confini files not recognized Problem: filetype: some sh and confini files not recognized Solution: Detect neofetch, '.xprofile', XDG-User-Dirs files, paru and makepkg config files (Wu, Zhenyu) See: - https://github.com/dylanaraps/neofetch/wiki/Customizing-Info#config-file-location - https://www.freedesktop.org/wiki/Software/xdg-user-dirs/ closes: #14505 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-13 18:19:20 +02:00
/**/
316,
patch 9.1.0315: filetype: a few more dosini files are not recognized Problem: filetype: a few more dosini files are not recognized Solution: Detect wakatime, reply config files, flatpak, nfs config files and a few more python tools as dosini (or toml) (Wu, Zhenyu) Refer: - https://packaging.python.org/en/latest/specifications/pypirc/ - https://jorisroovers.com/gitlint/latest/configuration/ - https://pylint.pycqa.org/en/latest/user_guide/usage/run.html#command-line-options - https://docs.bpython-interpreter.org/en/latest/configuration.html - https://mypy.readthedocs.io/en/stable/config_file.html#the-mypy-configuration-file - https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file - https://github.com/wakatime/wakatime-cli?tab=readme-ov-file#usage - https://metacpan.org/dist/Reply/view/bin/reply#-cfg-~/.replyrc close: #14512 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-13 18:13:42 +02:00
/**/
315,
patch 9.1.0314: Vim9: Can define a class in a function Problem: Vim9: Can define a class in a function (Doug Kearns) Solution: Give an error for a class defined in a function, slightly reword some public error messages (Yegappan Lakshmanan) fixes: #13184 fixes: #13326 closes: #14537 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-13 17:58:09 +02:00
/**/
314,
patch 9.1.0313: Crash when using heredoc with comment in command block Problem: Crash when using heredoc with comment in command block. Solution: Handle a newline more like the end of the line, fix coverity warning (zeertzjq). closes: #14535 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-13 17:52:26 +02:00
/**/
313,
patch 9.1.0312: heredocs are not supported for :commands Problem: heredocs are not supported for :commands (@balki) Solution: Add heredoc support (Yegappan Lakshmanan) fixes: #14491 closes: #14528 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-12 18:48:35 +02:00
/**/
312,
patch 9.1.0311: filetype: Some config files are not recognized Problem: Some config files are not recognized Solution: Add some patterns for chktex, ripgreprc and ctags config files. See: https://www.nongnu.org/chktex/ See: https://github.com/BurntSushi/ripgrep/blob/master/GUIDE.md#configuration-file See: https://docs.ctags.io/en/latest/option-file.html#order-of-loading-option-files closes: #14506 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-12 18:46:05 +02:00
/**/
311,
patch 9.1.0310: Filler lines not checked properly in get_scroll_overlap() Problem: Filler lines not checked properly in get_scroll_overlap(). Solution: Add missing parentheses (zeertzjq). The missing parentheses causes the second argument to diff_check_fill() to always be 0 as it is the result of a comparison between a positive integer and -1 (the value of BACKWARD), in which case diff_check_fill() always returns 0 instead of the number of filler lines above a line. It's very hard to add a test for this, because this mistake at most leads to 2 screen lines of difference in scrolling behavior, and in cases where it may indeed lead to a difference in behavior, neither behavior achieves complete symmetry between CTRL-F and CTRL-B. closes: #14527 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-12 18:38:38 +02:00
/**/
310,
patch 9.1.0309: crash when 'textwidth' > MAX_INT Problem: crash when 'textwidth' > MAX_INT (after vv9.1.0055) (Zoltan Balogh) Solution: limit textwidth to MAX_INT fixes: #14482 closes: #14489 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-11 22:54:44 +02:00
/**/
309,
patch 9.1.0308: configure: msgfmt hardcoded Problem: configure: msgfmt hardcoded (after v9.1.0173) Solution: use $MSGFMT instead of msgfmt in configure script, regenerate the configure script (Vladimír Marek) fixes: #14515 Signed-off-by: Vladimír Marek <vlmarek13@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-11 21:54:34 +02:00
/**/
308,
patch 9.1.0307: filetype: texdoc config files is not recognized Problem: filetype: texdoc config files is not recognized Solution: Detect 'texdoc.cnf' as conf filetype (Wu, Zhenyu) See: https://github.com/TeX-Live/texdoc/blob/master/texdoc.cnf closes: #14507 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-11 20:53:33 +02:00
/**/
307,
patch 9.1.0306: filetype: x11vnc config file is not recognized Problem: filetype: x11vnc config file is not recognized Solution: Detect '.x11vncrc' as conf filetype (Wu, Zhenyu) See: https://linux.die.net/man/1/x11vnc closes: #14511 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-11 20:47:45 +02:00
/**/
306,
patch 9.1.0305: filetype: some history files are not recognized Problem: filetype: some history files are not recognized Solution: Add some history patterns to filetype.vim (Wu, Zhenyu) closes: #14513 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-11 20:43:00 +02:00
/**/
305,
patch 9.1.0304: filetype: cgdb config file is not recognized Problem: filetype: cgdb config file is not recognized Solution: Detect cgdbrc files as cgdbrc filetype (Wu, Zhenyu) closes: #14458 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 22:52:40 +02:00
/**/
304,
patch 9.1.0303: filetype: some protocol buffer files not recognized Problem: filetype: some protocol buffer files not recognized Solution: Detect '*.textproto', '*.textpb', '*.txtpb' as pbtxt files (Bruno Belanyi) See: https://protobuf.dev/reference/protobuf/textformat-spec/#text-format-files closes: #14463 Signed-off-by: Bruno BELANYI <bruno@belanyi.fr> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 22:34:42 +02:00
/**/
303,
patch 9.1.0302: filetype: blueprint files are not recognized Problem: filetype: blueprint files are not recognized Solution: Detect '*.bp' files as blueprint files, add a minimal filetype plugin (Bruno Belanyi) See: https://source.android.com/docs/setup/build closes: #14488 Signed-off-by: Bruno BELANYI <bruno@belanyi.fr> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 22:28:28 +02:00
/**/
302,
patch 9.1.0301: Vim9: heredoc start may be recognized in string Problem: Vim9: heredoc start may be recognized in string. Solution: Don't skip to closing bracket for invalid list assignment. (zeertzjq) closes: #14472 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 17:37:47 +02:00
/**/
301,
patch 9.1.0300: Missing test for what patch v9.1.0285 fixes Problem: Missing test for what patch v9.1.0285 fixes Solution: Add a test for cursor movement at buffer boundaries. (Luuk van Baal) closes: #14470 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 17:33:43 +02:00
/**/
300,
patch 9.1.0299: Vim9: return type not set for a lambda assigned to script var Problem: Vim9: return type not set for a lambda assigned to script var (Ernie Rael) Solution: Correctly determine the return type (Yegappan Lakshmanan) fixes: #14445 closes: #14473 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 17:18:19 +02:00
/**/
299,
patch 9.1.0298: MS-Windows: GETTEXT_PATH hard-coded in src/po/Make_mvc.mak Problem: MS-Windows: GETTEXT_PATH hard-coded in src/po/Make_mvc.mak Solution: Add IFNDEF/ENDIF around the definition of GETTEXT_PATH (Cthulhux) It makes no sense to enforce modifying Vim source files just because your build stuff is not where it's expected. My change is supposed to add support for a locally-defined %GETTEXT_PATH%. closes: #14480 Signed-off-by: Cthulhux <github@tuxproject.de> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 16:34:49 +02:00
/**/
298,
patch 9.1.0297: Patch 9.1.0296 causes too many issues Problem: Patch 9.1.0296 causes too many issues (Tony Mechelynck, @chdiza, CI) Solution: Back out the change for now Revert "patch 9.1.0296: regexp: engines do not handle case-folding well" This reverts commit 7a27c108e0509f3255ebdcb6558e896c223e4d23 it causes issues with syntax highlighting and breaks the FreeBSD and MacOS CI. It needs more work. fixes: #14487 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-10 16:18:15 +02:00
/**/
297,
patch 9.1.0296: regexp: engines do not handle case-folding well Problem: Regex engines do not handle case-folding well Solution: Correctly calculate byte length of characters to skip When the regexp engine compares two utf-8 codepoints case insensitively it may match an adjacent character, because it assumes it can step over as many bytes as the pattern contains. This however is not necessarily true because of case-folding, a multi-byte UTF-8 character can be considered equal to some single-byte value. Let's consider the pattern 'ſ' and the string 's'. When comparing and ignoring case, the single character 's' matches, and since it matches Vim will try to step over the match (by the amount of bytes of the pattern), assuming that since it matches, the length of both strings is the same. However in that case, it should only step over the single byte value 's' so by 1 byte and try to start matching after it again. So for the backtracking engine we need to ensure: - we try to match the correct length for the pattern and the text - in case of a match, we step over it correctly The same thing can happen for the NFA engine, when skipping to the next character to test for a match. We are skipping over the regstart pointer, however we do not consider the case that because of case-folding we may need to adjust the number of bytes to skip over. So this needs to be adjusted in find_match_text() as well. A related issue turned out, when prog->match_text is actually empty. In that case we should try to find the next match and skip this condition. fixes: #14294 closes: #14433 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:53:19 +02:00
/**/
296,
patch 9.1.0295: filetype: pip config files are not recognized Problem: filetype: pip config files are not recognized Solution: detect pip.conf as dosini filetype (Wu, Zhenyu) closes: #14448 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:49:19 +02:00
/**/
295,
patch 9.1.0294: Text height function does not respect it's argument Problem: plines_m_win() does not take into account it's "limit_winheight" argument for filler lines below the last line of the buffer. (after v9.1.0280) Solution: Check window height when "limit_winheight" is TRUE. (Luuk van Baal) closes: #14449 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:43:49 +02:00
/**/
294,
patch 9.1.0293: filetype: lxqt config files are not recognized Problem: filetype: lxqt config files are not recognized Solution: Detect {lxqt,screengrab}/*.conf files as dosini, fix failing filetype test for */tex/latex/**.cfg (Wu, Zhenyu) closes: #14450 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:39:53 +02:00
/**/
293,
patch 9.1.0292: filetype: XDG mimeapps.list file is not recognized Problem: filetype: XDG mimeapps.list file is not recognized Solution: Detect mimeapps.list as dosini filetype (Wu, Zhenyu) Refer: https://wiki.archlinux.org/title/XDG_MIME_Applications#Format closes: #14451 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:25:41 +02:00
/**/
292,
patch 9.1.0291: filetype: libreoffice config files are not recognized Problem: filetype: libreoffice config files are not recognized Solution: Detect Libreoffice config fils as xml/dosini (Wu, Zhenyu) closes: #14453 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:20:55 +02:00
/**/
291,
patch 9.1.0290: filetype: xilinx files are not recognized Problem: filetype: xilinx files are not recognized Solution: Add a few xilinx specific file patterns, inspect lpr files for being xml/pascal (Wu, Zhenyu) closes: #14454 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:14:37 +02:00
/**/
290,
patch 9.1.0289: filetype: some TeX files are not recognized Problem: filetype: some TeX files are not recognized Solution: Add more patterns for TeX files and inspect a few more files for being TeX files (Wu, Zhenyu) closes: #14456 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:09:30 +02:00
/**/
289,
patch 9.1.0288: MS-Windows: compiler warning for size_t to int conversion Problem: MS-Windows: compiler warning for size_t to int conversion (after v9.1.0282) Solution: Use size_t instead of int in highlight_set_termgui_attr (Mike Williams) closes: #14457 Signed-off-by: Mike Williams <mrmrdubya@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 22:04:54 +02:00
/**/
288,
patch 9.1.0287: Vim9: comment may be treated as heredoc start Problem: Vim9: comment may be treated as heredoc start. (Ernie Rael) Solution: Use skip_var_list() instead of find_name_end(). (zeertzjq) fixes: #14444 closes: #14446 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 21:47:10 +02:00
/**/
287,
patch 9.1.0286: Vim9: E1027 with defcompile for abstract methods Problem: Vim9: E1027 with defcompile for abstract methods with non-void return types, but still compiles it (zzzyxwvut) Solution: Don't compile abstract methods (Yegappan Lakshmanan) fixes: #14443 closes: #14447 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 21:39:27 +02:00
/**/
286,
patch 9.1.0285: Still problems with cursor position for CTRL-D/U Problem: Problems with cursor position when scrolling half a page. Solution: Rework the cursor logic. (Luuk van Baal) closes: #14455 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 21:30:19 +02:00
/**/
285,
patch 9.1.0284: make testclean is not able to delete failed screendumps Problem: make testclean is not able to delete failed screendumps. Solution: Remove the "failed" directory when necessary. (Julio B) Patch 8.1.1080 changed the way that failed screendumps are saved, but the "rm -rf *.failed" clean command was not ported correctly. closes: #14468 Signed-off-by: Julio B <julio.bacel@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 21:22:41 +02:00
/**/
284,
patch 9.1.0282: Several small issues in doc and tests Problem: Wrong doc style for pandoc syntax description, Test_diff_eob_halfpage() may fail depending on screen size, using braces in highlight.c when not necessary Solution: Fix pandoc documentation, make sure the window for the test has 7 lines, remove the braces. Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-09 08:06:52 +02:00
/**/
283,
patch 9.1.0282: Finding highlighting attributes is inefficient Problem: Finding highlighting attributes is inefficient Solution: Use binary search to find highlighting attributes and color names (John Marriott) closes: #14426 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 23:28:12 +02:00
/**/
282,
patch 9.1.0281: CI: fails Test_compiler_completion Problem: CI: fails Test_compiler_completion Solution: Add pandoc compiler Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 22:54:16 +02:00
/**/
281,
patch 9.1.0280: several issues with 'smoothscroll' support Problem: Logic to make sure cursor is in visible part of the screen after scrolling the text with 'smoothscroll' is scattered, asymmetric and contains bugs. Solution: Adjust and create helper function for 'smoothscroll' cursor logic. (Luuk van Baal) closes: #14410 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 22:27:41 +02:00
/**/
280,
patch 9.1.0279: filetype: roc files are not recognized Problem: filetype: roc files are not recognized Solution: Detect '*.roc' files as roc filetype, add a basic filetype plugin (nat-418) closes: #14416 Signed-off-by: nat-418 <93013864+nat-418@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 22:23:22 +02:00
/**/
279,
patch 9.1.0278: filetype: zathurarc files not recognized Problem: filetype: zathurarc files not recognized Solution: Detect '.zathurarc' files as zathurarc filetype, add zathurarc filetype (Wu, Zhenyu) closes: #14380 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 22:19:06 +02:00
/**/
278,
patch 9.1.0277: Cannot highlight the Command-line Problem: Cannot highlight the Command-line Solution: Add the MsgArea highlighting group (Shougo Matsushita) closes: #14327 Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 22:11:50 +02:00
/**/
277,
patch 9.1.0276: No pandoc syntax support Problem: No pandoc syntax support Solution: Add pandoc syntax and compiler plugins (Wu, Zhenyu, Konfekt) closes: #14389 Co-authored-by: Konfekt <Konfekt@users.noreply.github.com> Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 20:53:19 +02:00
/**/
276,
patch 9.1.0275: filetype: R history files are not recognized Problem: filetype: R history files are not recognized Solution: Detect '.Rhistory' files as r filetype (Wu, Zhenyu) closes: #14440 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-08 20:26:29 +02:00
/**/
275,
patch 9.1.0274: MS-Windows: a few compiler warnings Problem: MS-Windows: a few compiler warnings Solution: Change variable types to resolve compiler warnings (Mike Williams) Windows compiles were reporting a few size_t to signed integer conversion warnings that can be resolved by changing the variable declarations to be size_t to start with. closes: #14429 Signed-off-by: Mike Williams <mrmrdubya@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-07 18:26:22 +02:00
/**/
274,
patch 9.1.0273: filetype: keymap files are not recognized Problem: filetype: keymap files are not recognized Solution: Detect '*.keymap' files as Device Tree Files (0xadk) closes: #14434 Signed-off-by: 0xadk <0xadk@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-07 18:22:41 +02:00
/**/
273,
patch 9.1.0272: autocmd may change cwd after :tcd and :lcd Problem: Autocommand may change currect directory after :tcd and :lcd. Solution: Also clear tp_localdir and w_localdir when using aucmd_win. (zeertzjq) closes: #14435 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-07 18:16:10 +02:00
/**/
272,
patch 9.1.0271: CI sound test aborts with undefined variable Problem: CI sound test aborts with undefined variable Solution: initialize g:result in test_sound.vim closes: #14424 Signed-off-by: Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-05 20:15:48 +02:00
/**/
271,
patch 9.1.0270: a few minor issues to fix The following is a collection of some small fixes: - Problem: Vim9: funcref pointer pt leaks, when function is not found Solution: Free funcref pointer in case of error (fixes: #14254) - Problem: memory leak of crypt state pointer allocation fails Solution: free crypt state pointer properly (fixes: #14253) - Problem: Vim9: Leaking memory when compiling dict fails Solution: Free the memory in case of error (fixes: #14252) - Problem: Coverity complains about derefencing obj_members pointer (after v9.1.0261) Solution: Verify that obj_members ptr is non-null before accessing it References: https://scan5.scan.coverity.com/#/project-view/41242/10101?selectedIssue=1596133 closes: #14412 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-05 20:12:19 +02:00
/**/
270,
patch 9.1.0269: Test for TextChanged is still flaky with ASAN Problem: Test for TextChanged is still flaky with ASAN. Solution: Don't index the result of readfile(). (zeertzjq) It turns out that with ASAN the file may become empty during a write even if it's non-empty both before and after the write, in which case indexing the result of readfile() will error, so use join() instead. Also don't delete the file halfway the test, just in case it may cause errors on the next read. closes: #14421 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-05 20:07:39 +02:00
/**/
269,
patch 9.1.0268: Two tests in test_filechanged.vim are slow Problem: Two tests in test_filechanged.vim are slow. Solution: Sleep for shorter if the +nanotime feature is available. (zeertzjq) closes: #14418 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-05 20:05:11 +02:00
/**/
268,
patch 9.1.0267: File name entered in GUI dialog is ignored Problem: File name entered in GUI dialog is ignored (after v9.1.0265) Solution: Only set file name to "Untitled" if GUI dialog didn't set it. (zeertzjq) closes: #14417 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-05 20:02:55 +02:00
/**/
267,
patch 9.1.0266: filetype: earthfile files are not recognized Problem: filetype: earthfile files are not recognized Solution: Detect 'Earthfile' as earthfile (Gaëtan Lehmann) closes: #14408 Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-05 19:52:38 +02:00
/**/
266,
patch 9.1.0265: console dialog cannot save unnamed buffers Problem: console dialog cannot save unnamed buffers Solution: set bufname before save (glepnir). Define dialog_con_gui to test for GUI+Console dialog support, use it to skip the test when the GUI feature has been defined. Note: The dialog_changed() function will also try to call the browse_save_fname() function, when FEAT_BROWSE is defined (which is only defined in a GUI build of Vim). This will eventually lead to a call of do_browse(), which causes an error message if a GUI is not currently running (see the TODO: in do_browse()) and will then lead to a failure in Test_goto_buf_with_onfirm(). Therefore, we must disable the Test_goto_buf_with_onfirm(), when the dialog_con_gui feature is enabled (which basically means dialog feature for GUI and Console builds, in contrast to the dialog_con and dialog_gui feature). (Previously this wasn't a problem, because the test aborted in the YES case for the :confirm :b XgotoConf case and did therefore not run into the browse function call) closes: #14398 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-04 22:23:29 +02:00
/**/
265,
patch 9.1.0264: libgpm may delete some signal handlers Problem: libgpm may delete some signal handlers Solution: restore these signal handlers after calling gpm (Julio B) When 'mouse' is set, vim is trying to detect mouse support on startup. Eventually, vim resorts to using libgpm as the final method of mouse detection. This library may delete some signals handlers that were initially set up by vim. This is how: - mch_setmouse() calls gpm_open() - Gpm_Open is executed, which returns early on line 210 [1] - Keep in mind that lines 353-373 [2] are skipped, so gpm_saved_suspend_hook and gpm_saved_winch_hook are empty - Finally, Gpm_Close is called, which will reset [3] SIGWINCH and SIGTSTP to an empty sigaction. [1] https://github.com/telmich/gpm/blob/e82d1a653ca94aa4ed12441424da6ce780b1e530/src/lib/liblow.c#L210 [2] https://github.com/telmich/gpm/blob/e82d1a653ca94aa4ed12441424da6ce780b1e530/src/lib/liblow.c#L353-L373 [3] https://github.com/telmich/gpm/blob/e82d1a653ca94aa4ed12441424da6ce780b1e530/src/lib/liblow.c#L419-L424 fixes: #12154 closes: #14401 Signed-off-by: Julio B <julio.bacel@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-04 21:55:10 +02:00
/**/
264,
patch 9.1.0263: Vim9: Problem with lambda blocks in enums and classes Problem: Vim9: Problem with lambda blocks in enums and classes (Aliaksei Budavei) Solution: Support evaluating lambda blocks from a string, skip over comments (Yegappan Lakshmanan) fixes: #14350 closes: #14405 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-04 21:42:07 +02:00
/**/
263,
patch 9.1.0262: Test for TextChanged is flaky with ASAN Problem: Test for TextChanged is flaky with ASAN. Solution: Wait for the file to be non-empty. (zeertzjq) closes: #14404 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-04 21:33:36 +02:00
/**/
262,
patch 9.1.0261: Vim9: protected class and funcrefs accessible outside the class Problem: Vim9: protected class and funcrefs accessible outside the class (Aliaksei Budavei) Solution: Check if class and object funcrefs are protected (Yegappan) closes: #14407 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-04 19:35:59 +02:00
/**/
261,
patch 9.1.0260: Problems with "zb" and scrolling to new topline with 'smoothscroll' Problem: "zb" does not reveal filler lines at the start of a buffer. Scrolled cursor position with 'smoothscroll' is unpredictable, and may reset skipcol later if it is not visible (after v9.1.258) Solution: Replace confusing for loop that reaches final control value too early with while loop. Set "w_curswant" accordingly so cursor will be placed in visible part of topline. (Luuk van Baal) closes: #14394 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-03 22:50:40 +02:00
/**/
260,
patch 9.1.0259: Normal mode TextChanged isn't tested properly Problem: Normal mode TextChanged isn't tested properly. Solution: Combine Test_Changed_ChangedI() and Test_Changed_ChangedI_2() and also run it on Windows. Fix a typo in main.c. (zeertzjq) closes: #14396 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-03 22:38:07 +02:00
/**/
259,
patch 9.1.0258: half-page scrolling broke backward compatibility Problem: Support for 'smoothscroll' in (half-)page scrolling broke backward compatibility and can be made to work better. (after v9.1.215) Solution: Restore the previous cursor and end-of-buffer behavior for half-page scrolling and improve 'smoothscroll' support. (Luuk van Baal) fixes: #14338 closes: #14377 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-02 20:49:45 +02:00
/**/
258,
patch 9.1.0257: Vim9: :call may not find imported class members Problem: Vim9: :call may not find imported class members (mityu) Solution: Set the typval of an imported lval variable correctly (Yegappan Lakshmanan) fixes: #14334 closes: #14386 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-02 20:41:04 +02:00
/**/
257,
patch 9.1.0256: Finding autocmd events is inefficient Problem: Finding autocmd events is inefficient Solution: Use binary search to find events, cache last found events, avoid use of strlen(), add SessionWritePost autocmd, fix test_codestyle and avoid endless loop (John Marriott) closes: #14287 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-02 20:26:01 +02:00
/**/
256,
patch 9.1.0255: Vim9: no indication of script nr in stack trace of classes Problem: Vim9: no indication of script nr in stack trace of classes Solution: Prefix the class name with the script name in the stack trace. (Ernie Rael) fixes: #14376 closes: #14390 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-02 19:05:39 +02:00
/**/
255,
patch 9.1.0254: [security]: Heap buffer overflow when calling complete_add() in 'cfu' Problem: [security]: Heap buffer overflow when calling complete_add() in the first call of 'completefunc' Solution: Call check_cursor() after calling 'completefunc' (zeertzjq) closes: #14391 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-02 19:01:14 +02:00
/**/
254,
patch 9.1.0253: filetype: typespec files are not recognized Problem: filetype: typespec files are not recognized Solution: Detect '*.tsp' files as typespec (Hilmar Wiegand) Specs is at https://typespec.io/ closes: #14392 Signed-off-by: Hilmar Wiegand <me@hwgnd.de> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-02 18:54:54 +02:00
/**/
253,
patch 9.1.0252: Vim9: segfault with static in super class Problem: Vim9: segfault with static in super class (Ernie Rael) Solution: When initializing lhs, use the correct class where a class variable is defined (Yegappan Lakshmanan) fixes: #14352 closes: #14372 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-01 14:50:41 +02:00
/**/
252,
patch 9.1.0251: Filetype test fails Problem: Filetype test fails. Solution: Move detection by name before detection by extension. Improve TextChanged test and remove wrong test and fix a typo in a comment (zeertzjq). closes: #14373 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-01 14:46:20 +02:00
/**/
251,
patch 9.1.0250: filetype: ldscripts cannot be recognized Problem: filetype: ldscripts cannot be recognized Solution: Detect '*/ldscripts/*' as ld (Wu, Zhenyu) closes: #14371 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:57:16 +02:00
/**/
250,
patch 9.1.0249: filetype: rock_manifest and config.ld files are not recognized Problem: filetype: rock_manifest and config.ld files are not recognized Solution: Detect 'rock_manifest' and 'config.ld' as lua (Wu, Zhenyu) closes: #14370 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:54:12 +02:00
/**/
249,
patch 9.1.0248: filetype: yarn lock files are not recognized Problem: filetype: yarn lock files are not recognized Solution: Detect 'yarn.lock' files as yaml (Wu, Zhenyu) closes: #14369 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:51:19 +02:00
/**/
248,
patch 9.1.0247: filetype: bundle config files are not recognized Problem: filetype: bundle config files are not recognized Solution: Detect '*/.bundle/config' as yaml (Wu, Zhenyu) closes: #14368 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:48:35 +02:00
/**/
247,
patch 9.1.0246: filetype: fontconfig files are not recognized Problem: filetype: fontconfig files are not recognized Solution: detect 'fonts.conf' as xml (Wu, Zhenyu) closes: #14367 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:45:11 +02:00
/**/
246,
patch 9.1.0245: filetype: zsh theme, history and zunit files are not recognized Problem: filetype: zsh theme, history and zunit files are not recognized. Solution: Detect '.zsh_history', '*.zsh-theme' and '*.zunit' as zsh (Wu, Zhenyu) closes: #14366 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:42:39 +02:00
/**/
245,
patch 9.1.0244: filetype: bash history files are not recognized Problem: filetype: bash history files are not recognized Solution: detect .bash-history and .bash_history files as bash (Wu, Zhenyu) closes: #14365 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:22:51 +02:00
/**/
244,
patch 9.1.0243: filetype: netrw history file is not recognized Problem: filetype: netrw history file is not recognized Solution: Detect .netrwhist as vim files (Wu, Zhenyu) closes: #14364 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:20:14 +02:00
/**/
243,
patch 9.1.0242: filetype: octave history files are not recognized Problem: filetype: octave history files are not recognized Solution: Detect octave/history files as octave (Wu, Zhenyu) closes: #14363 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:18:10 +02:00
/**/
242,
patch 9.1.0241: filetype: mysql history files are not recognized Problem: filetype: mysql history files are not recognized Solution: Detect .mysql_history as mysql (Wu, Zhenyu) closes: #14362 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:15:49 +02:00
/**/
241,
patch 9.1.0240: filetype: some python tools config files are not recognized Problem: filetype: some python tools config files are not recognized Solution: Detect config files for setuptools, pudb, coverage as dosini (Wu, Zhenyu) closes: #14361 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:12:36 +02:00
/**/
240,
patch 9.1.0239: filetype: gnuplot history files are not recognised Problem: filetype: gnuplot history files are not recognised Solution: detect .gnuplot_history files as gnuplot (Wu, Zhenyu) closes: #14360 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:10:18 +02:00
/**/
239,
patch 9.1.0238: filetype: jupyterlab and sublime config are not recognized Problem: filetype: jupyterlab and sublime config are not recognized Solution: Detect jupyterlab and sublime config files as json (Wu, Zhenyu) closes: #14359 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:08:07 +02:00
/**/
238,
patch 9.1.0237: filetype: mplstyle files are not recognized Problem: filetype: mplstyle files are not recognized Solution: Detect '*.mplstyle' files as yaml (Wu, Zhenyu) closes: #14358 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:05:44 +02:00
/**/
237,
patch 9.1.0236: filetype: texlua files are not recognized Problem: filetype: texlua files are not recognized Solution: Add '*.tlu' pattern for texlua files (Wu, Zhenyu) Reference: https://github.com/TeX-Live/texdoc/tree/master/script closes: #14357 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 19:02:26 +02:00
/**/
236,
patch 9.1.0235: filetype: supertux files are not recognized Problem: filetype: supertux files are not recognized Solution: Supertux uses lisp to store hotkeys in config and game stage information, so add a pattern for supertux files. (Wu, Zhenyu) Reference: https://github.com/SuperTux/supertux/wiki/S-Expression closes: #14356 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 18:58:34 +02:00
/**/
235,
patch 9.1.0234: filetype: support for Intel HEX files is lacking Problem: filetype: support for Intel HEX files is lacking Solution: Add more file extensions that are typical for Intel HEX files (Wu, Zhenyu) Reference: https://en.wikipedia.org/wiki/Intel_HEX closes: #14355 Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 18:54:55 +02:00
/**/
234,
patch 9.1.0233: Vim9: string() output of enum is problematic Problem: Vim9: string() output of enum is problematic Solution: Make string() output for an enum consistent with that of a regular object (Yegappan Lakshmanan). closes: #14343 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 18:45:35 +02:00
/**/
233,
patch 9.1.0232: Conceal test fails when rightleft feature is disabled Problem: Conceal test fails when rightleft feature is disabled. Solution: Skip test if rightleft feature is missing (Julio B). closes: #14342 Signed-off-by: Julio B <julio.bacel@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 18:43:51 +02:00
/**/
232,
patch 9.1.0231: Filetype may be undetected when SwapExists sets ft in other buf Problem: Filetype may be undetected when a SwapExists autocommand sets filetype in another buffer. Solution: Make filetype detection state buffer-specific. Also fix a similar problem for 'modified' (zeertzjq). closes: #14344 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 18:41:27 +02:00
/**/
231,
patch 9.1.0230: TextChanged autocommand not triggered under some circumstances Problem: TextChanged autocommand not triggered under some circumstances (Sergey Vlasov) Solution: Trigger TextChanged when TextChangedI has not been triggered fixes: #14332 closes: #14339 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 18:38:09 +02:00
/**/
230,
patch 9.1.0229: Error E877 is not translated Problem: Error E877 is not translated (RestorerZ) Solution: Declare the error with N_ to mark it as translatable, add _() around the error message in regexp_nfa.c fixes: #14333 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-31 17:52:56 +02:00
/**/
229,
patch 9.1.0228: Two unrelated things are tested by a single test Problem: Two unrelated things are tested by a single test. Solution: Split it into two, restoring the old Test_brace_single_line(). Add missing cleanup to some tests. (zeertzjq) closes: #14323 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-29 10:23:19 +01:00
/**/
228,
patch 9.1.0227: Recording may still be wrong in Select mode Problem: Recording may still be wrong in Select mode (after 8.2.3993). Solution: Make sure a character isn't split between two buffer blocks. (zeertzjq) closes: #14326 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-29 10:11:42 +01:00
/**/
227,
patch 9.1.0226: Not able to assign enum values to an enum static variable Problem: Not able to assign enum values to an enum static variable (zzzyxwvut) Solution: Make it work (Yegappan Lakshmanan) related: #14224 closes: #14329 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-29 10:08:23 +01:00
/**/
226,
patch 9.1.0225: test_matchparen not run in CI Problem: test_matchparen not run in CI Solution: add test_matchparen.res to NEW_TESTS_RES in Makefile, update changed highlighting dump from v9.1.61 closes: #14322 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 17:10:44 +01:00
/**/
225,
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text Problem: If a line has "right" & "below" virtual text properties, where the "below" property may be stored first due to lack of ordering between them, then the line height is calculated to be 1 more and causes the cursor to far over the line. Solution: Remove some unnecessary setting of a `next_right_goes_below = TRUE` flag for "below" and "above" text properties. (Dylan Thacker-Smith) I modified a regression test I recently added to cover this case, leveraging the fact that "after", "right" & "below" text properties are being stored in the reverse of the order they are added in. The previous version of this regression test was crafted to workaround this issue so it can be addressed by this separate patch. closes: #14317 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 12:01:14 +01:00
/**/
224,
patch 9.1.0223: code duplication in loop to add active text properties Problem: There are two dense conditions with duplication that needs to be kept in sync between the while loop break condition and the condition to skip certain text properties. Solution: Refactor the loop by moving while loop conditions into the body of the while loop so they can be shared with skip conditions. `break` and an `active` variable are used to handle the outcome of these merged conditions. (Dylan Thacker-Smith) closes: #14307 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 11:49:46 +01:00
/**/
223,
patch 9.1.0222: missing 'below' virt text if truncation precedes after/right text Problem: When a line is truncated just before 'after'/'right' virtual text and the line also has 'below' virtual text, then the 'below' virtual text would not be displayed, depending on the order these text properties were added. Solution: In the loop to make text properties active, skip instead of break for 'after'/'right' virtual text properties that are ignored due to truncation, so following 'below' text properties can still be made active. Similarly, a loop is needed to determine if a text property follows at the end of the screen. (Dylan Thacker-Smith) related: #14307 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 11:47:32 +01:00
/**/
222,
patch 9.1.0221: lines following virt text (that fills the window) might be truncated Problem: The if branch to set `text_prop_follows` was both checking if it was at the end of the buffer text line or if it was at the end of the screen line, but the former being true skipped a guard condition in the latter to only consider 'below' virtual text to follow. `text_prop_follows` being improperly set caused it to skip a conditional block to break at the end as well as one to move `ptr` to the end of the text line, while repeated for each following line of the window. Solution: Move the check for whether 'below' virtual text should follow so it is also used when at the end of the buffer text line. (Dylan Thacker-Smith) fixes: #12213 related: #14307 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 11:40:41 +01:00
/**/
221,
patch 9.1.0220: Few typos in source and test files Problem: Typos in code and tests. Solution: Fix typos (zeertzjq). closes: #14321 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 11:37:26 +01:00
/**/
220,
patch 9.1.0219: Vim9: No enum support Problem: No enum support Solution: Implement enums for Vim9 script (Yegappan Lakshmanan) closes: #14224 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 10:36:42 +01:00
/**/
219,
patch 9.1.0218: Unnecessary multiplications in backspace code Problem: Unnecessary multiplications in backspace code, as "col / ts * ts" is the same as "col - col % ts". Solution: Change "col / ts * ts" to "col - col % ts". Adjust the loop and the comments ins_bs() to be easier to understand. Update tests to reset 'smarttab' properly. (zeertzjq) closes: #14308 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 10:30:08 +01:00
/**/
218,
/**/
217,
patch 9.1.0216: Error on exit with EXITFREE and 'winfixbuf' Problem: Error on exit with EXITFREE and 'winfixbuf'. Solution: Handle DT_FREE before checking for 'winfixbuf'. (zeertzjq) closes: #14314 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 10:11:57 +01:00
/**/
216,
patch 9.1.0215: Half-page scrolling does not support smooth-scrolling Problem: Page-wise scrolling with Ctrl-D/Ctrl-U implements it's own logic to change the topline and cursor. More logic than necessary for scrolling with Ctrl-F/Ctrl-B was removed in patch 9.1.0211. Solution: Re-use the logic from Ctrl-E/Ctrl-Y/Ctrl-F/Ctrl-B while staying backward compatible as much as possible. Restore some of the logic that determined how many lines will be scrolled (Luuk van Baal) closes: #14316 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 10:07:29 +01:00
/**/
215,
patch 9.1.0214: Duplicate condition in win_lbr_chartabsize() Problem: Duplicate condition in win_lbr_chartabsize(). Solution: Remove the duplicate condition, as it's already checked above. (zeertzjq) closes: #14320 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 10:04:25 +01:00
/**/
214,
patch 9.1.0213: CI: MS-Windows fails in test_winfixbuf Problem: CI: MS-Windows fails in test_winfixbuf (after v9.1.208) Solution: Instead of skipping the test, write the file so it exists on disk, to verify that MS-Windows short filename expansion is successful. (Sean Dewar) related: #14286 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-28 09:48:34 +01:00
/**/
213,
patch 9.1.0212: CI: MS-Windows fails in test_winfixbuf Problem: CI: MS-Windows fails in test_winfixbuf (after v9.1.208) Solution: Skip Ms-Windows for now, fix style related: #14286 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-27 10:44:14 +01:00
/**/
212,
patch 9.1.0211: page-wise scrolling does not support smooth-scrolling Problem: Page-wise scrolling with Ctrl-F/Ctrl-B implements it's own logic to change the topline and cursor. In doing so, skipcol is not handled properly for 'smoothscroll', and virtual lines. Solution: Re-use the logic from Ctrl-E/Ctrl-Y while staying backward compatible as much as possible. closes: #14268 Signed-off-by: Luuk van Baal <luukvbaal@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-26 18:46:45 +01:00
/**/
211,
patch 9.1.0210: Motif: leaking memory when mui_mch_dialog() fails Problem: Motif: leaking memory when mui_mch_dialog() fails (LuMingYinDetect) Solution: When allocating the label using the XmStringCreateLtoR() function fails, before returning also free the allocated buttons pointer. fixes: #14247 closes: #14280 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-26 18:44:48 +01:00
/**/
210,
patch 9.1.0209: leaking memory in exe_newdict() on error Problem: leaking memory in exe_newdict() on error (LuMingYinDetect) Solution: free allocated dict if GA_GROW_FALIS() fixes: #14255 closes: #14281 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-26 18:42:52 +01:00
/**/
209,
patch 9.1.0208: winfixbuf does not allow to re-edit current buffer Problem: winfixbuf does not allow to re-edit current buffer (Tim Pope, after v9.1.0147) Solution: Explicitly allow :e even when 'winfixbuf' is set, since it just re-loads the current buffer (Colin Kennedy) fixes: #14237 closes: #14286 Signed-off-by: Colin Kennedy <colinvfx@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-26 18:29:30 +01:00
/**/
208,
patch 9.1.0207: No autocommand when writing session file Problem: No autocommand when writing session file Solution: Add SessionWritePost autocommand (Colin Kennedy) fixes: ##14242 closes: #14288 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Colin Kennedy <colinvfx@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-26 18:20:16 +01:00
/**/
207,
patch 9.1.0206: unused display_text_first boolean var in win_line() Problem: unused display_text_first boolean var in win_line() Solution: Remove unused display_text_first boolean variable (Dylan Thacker-Smith) The only place it is used, uses its initial constant value, then the following conditionally values set to the variable are unused. Specifically, it was commit 234c3fab28c14846b962c90097496b27ee1b4df8 that changed the use of display_text_first such that it doesn't have any effect. closes: #14305 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-26 18:05:01 +01:00
/**/
206,
patch 9.1.0205: Cannot use modifiers before :-Ntabmove Problem: Cannot use modifiers before :-Ntabmove. Solution: Check backwards from the command instead of checking from the start of the command line. Slightly adjust docs to make them more consistent (zeertzjq). closes: #14289 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-25 16:41:06 +01:00
/**/
205,
patch 9.1.0204: Backspace inserts spaces with virtual text and 'smarttab' Problem: Backspace inserts spaces with virtual text and 'smarttab'. Solution: Ignore virtual text and wrapping when backspacing. (zeertzjq) related: neovim/neovim#28005 closes: #14296 Co-authored-by: VanaIgr <vanaigranov@gmail.com> Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-25 16:34:51 +01:00
/**/
204,
patch 9.1.0203: build-error on GNU/Hurd Problem: build-error on GNU HURD Solution: Define _XOPEN_SOURCE like for Android and Cygwin (James McCoy) strptime() requires _XOPEN_SOURCE to be defined for its declaration to be visible. This is already done for non-Android Linux and Cygwin, but also needs to be exposed for GNU/Hurd. closes: #14285 Signed-off-by: James McCoy <jamessan@jamessan.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-25 16:22:23 +01:00
/**/
203,
patch 9.1.0202: leaking memory in add_user() on failure Problem: leaking memory in add_user() (LuMingYinDetect) Solution: free user_copy pointer instead of the user ptr add_user() is called with a user pointer and the user pointer comes from these functions: - return value from the getpwent() function (Unix). - return value from the getpwnam() function (Unix). - return value from the NetUserEnum() function (MS Windows). For the first 2 callers, the man page for those functions directly says, one should not free the returned pointer (since it comes from static memory). For the third caller (on MS Windows), the returned buffer is already freed directly after calling the add_user() function in NetApiBufferFree(), so this would lead to a double free(). This all indicates, the user ptr is wrongly freed in the add_user() function and the intention was to free the user_copy pointer instead in case of an error. So let's just use that now. fixes: #14250 closes: #14260 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-24 09:50:03 +01:00
/**/
202,
patch 9.1.0201: gM not working correctly with virt text Problem: `gM` would include outer virtual text and its padding when getting the line length used to calculate the middle of the line, putting the cursor much closer to virtual text lines. Solution: Exclude outer virtual text in getting the line length for `gM`, so that virtual text doesn't influence where the cursor is moved to (Dylan Thacker-Smith). closes: #14262 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-24 09:46:56 +01:00
/**/
201,
patch 9.1.0200: `gj`/`gk` not skipping over outer virtual text lines Problem: `gj`/`gk` was updating the desired cursor virtual column to the outer virtual text, even though the actual cursor position was moved to not be on the virtual text, leading the need to do an extra `gj`/`gk` to move past each virtual text line. (rickhowe) Solution: Exclude the outer virtual text when getting the line length for moving the cursor with `gj`/`gk`, so that no extra movement is needed to skip over virtual text lines. (Dylan Thacker-Smith) fixes: #12028 related: #14262 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-24 09:43:25 +01:00
/**/
200,
patch 9.1.0199: Not enough tests for the slice() function Problem: Not enough tests for the slice() function. Solution: Test with multibyte chars, and in both Legacy and Vim9 script. Update docs to be clearer about how it treats composing chars. (zeertzjq) closes: #14275 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-23 08:23:48 +01:00
/**/
199,
patch 9.1.0198: Vim9: compound operators broken for lambdas in an object Problem: Vim9: compound operators broken for lambdas in an object (girishji) Solution: When using an object from the outer scope, use the LOADOUTER instruction to load the object (Yegappan Lakshmanan). fixes: #14236 closes: #14266 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-22 19:56:17 +01:00
/**/
198,
patch 9.1.0197: Vim9: problem evaluating negated boolean logic Problem: Vim9: problem evaluating negated boolean logic (lxhillwind) Solution: Don't clear the first value on short circuit evaluation (Yegappan Lakshmanan) fixes: #14265 closes: #14269 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-22 19:37:29 +01:00
/**/
197,
patch 9.1.0196: filetype: support for gnuplot files is lacking Problem: filetype: support for gnuplot files is lacking Solution: Also detect *.gnuplot files (RobbiZ98) closes: #14243 Signed-off-by: RobbiZ98 <113035863+RobbiZ98@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-21 20:24:51 +01:00
/**/
196,
patch 9.1.0195: memleak with ex_drop, NULL dereference Problem: memleak with ex_drop(), NULL dereference (zeertzjq) Solution: revert back to ex_rewind(), use curbuf instead of buf fixes: #14246 closes: #14251 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-21 20:19:00 +01:00
/**/
195,
patch 9.1.0194: gcc complains about uninitialized var Problem: gcc complains about uninitialized var (Tony Mechelynck) Solution: initialize to NULL Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-21 20:12:59 +01:00
/**/
194,
patch 9.1.0193: May leak memory in completion when ga_grow() fails Problem: May leak memory in completion when ga_grow() fails. Solution: Free "wca" when ga_grow() fails (zeertzjq). fixes: #14248 closes: #14249 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-21 07:11:58 +01:00
/**/
193,
patch 9.1.0192: drop: don't rewind when editing the same file Problem: :drop tries to :rewind the argumentlist, which results in E37 (after v9.1.0046) Solution: instead of calling ex_rewind(), call open_buffer() only when re-using the initial empty buffer fixes: #14219 closes: #14220 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-20 20:19:47 +01:00
/**/
192,
patch 9.1.0191: Installer does not remove all files Problem: Installer does not remove all files Solution: Update installer and delete all files on uninstall update Sodium library dependency, update Readme (RestorerZ) closes: #14214 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-20 20:15:51 +01:00
/**/
191,
patch 9.1.0190: complete_info() returns wrong order of items Problem: complete_info() returns wrong order of items (after v9.0.2018) Solution: Revert Patch v9.0.2018 (Girish Palya) bug fix: complete_info() gives wrong results 1) complete_info() reverses list of items during <c-p> 2) 'selected' item index is wrong during <c-p> 3) number of items returnd can be wrong Solution: - Decouple 'cp_number' from 'selected' index since they need not be correlated - Do not iterate the list backwards - Add targeted tests Regression introduced by https://github.com/vim/vim/commit/69fb5afb3bc9da24c2fb0eafb0027ba9c6502fc2 Following are unnecessary commits to patch problems from above: https://github.com/vim/vim/commit/fef66301665027f1801a18d796f74584666f41ef https://github.com/vim/vim/commit/daef8c74375141974d61b85199b383017644978c All the tests from above commits are retained though. fixes: #14204 closes: #14241 Signed-off-by: Girish Palya <girishji@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-20 20:07:29 +01:00
/**/
190,
patch 9.1.0189: Memory leak with "above" virttext and 'relativenumber' Problem: Memory leak with "above" virtual text and 'relativenumber'. Solution: Free "text_props" and "text_prop_idxs" before returning. Also fix off-by-one error causing line number to be drawn beyond end of window (zeertzjq). fixes: #14239 closes: #14241 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-20 19:49:20 +01:00
/**/
189,
patch 9.1.0188: filetype: no support for Vento files Problem: Vento files are not recognized. Solution: Recognize *.vto files as filetype "vento" (wrapperup) Vento is a templating engine https://vento.js.org/ closes: #14229 Signed-off-by: wrapperup <wrapperup4@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-19 18:06:22 +01:00
/**/
188,
patch 9.1.0187: filetype: no support for Dafny files Problem: Dafny files are not recognized. Solution: Recognize *.dfy files as filetype "dafny" (zeertzjq). Ref: https://dafny.org/ Ref: https://github.com/mlr-msft/vim-loves-dafny closes: #14226 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-18 19:21:48 +01:00
/**/
187,
patch 9.1.0186: cursor pos wrong on mouse click after eol with 'rl', 've' and conceal Problem: Wrong cursor position when clicking after end of line with 'rightleft', 'virtualedit' and conceal. Solution: Set values in ScreenCols[] also with SLF_RIGHTLEFT. Also fix off-by-one cursor position with 'colorcolumn' (zeertzjq). closes: #14218 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-17 19:44:30 +01:00
/**/
186,
patch 9.1.0185: 'wincolor' hl missing with 'rightleft', "below" virttext, 'nowrap' Problem: 'wincolor' highlight missing with 'rightleft', "below" virtual text and 'nowrap'. Solution: Handle 'rightleft' in draw_screen_line() (zeertzjq). closes: #14216 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-17 10:01:47 +01:00
/**/
185,
patch 9.1.0184: Cursor pos wrong when clicking with conceal and wrap Problem: Cursor position wrong when clicking with conceal and wrap. Solution: Use the virtual column of the last char for ScreenCols[] in boguscols. Remove use of MAXCOL in ScreenCols[]. Rename third argument of wlv_screen_line() to "clear_end" as that's clearer what it does (zeertzjq). related: 14192 closes: #14200 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-16 15:03:33 +01:00
/**/
184,
patch 9.1.0183: Wrong display or screenpos() result when toggling diff mode Problem: Wrong display or screenpos() result when toggling diff mode. Solution: Reset w_skipcol when disabling 'wrap'. Reset w_leftcol when enabling 'wrap' (zeertzjq). fixes: #14210 closes: #14211 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-16 09:40:22 +01:00
/**/
183,
patch 9.1.0182: Can define function with invalid name inside 'formatexpr' Problem: Can define function with invalid name inside 'formatexpr'. Solution: Use goto instead of checking for did_emsg later. (zeertzjq) closes: #14209 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-16 09:39:06 +01:00
/**/
182,
patch 9.1.0181: no overflow check for string formatting Problem: no overflow check for string formatting Solution: Check message formatting function for overflow. (Chris van Willegen) closes: #13799 Signed-off-by: Christ van Willegen <cvwillegen@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-14 18:30:41 +01:00
/**/
181,
patch 9.1.0180: Cursor pos wrong when double-width chars are concealed Problem: Cursor pos wrong when double-width chars are concealed. Solution: Advance one more virtual column for a double-width char. Run some tests with both 'wrap' and 'nowrap' (zeertzjq). closes: #14197 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-14 18:22:17 +01:00
/**/
180,
patch 9.1.0179: 'wincolor' highlight missing with "below" virtual text Problem: 'wincolor' highlight missing with "below" virtual text. Solution: Subtract n_attr_skip from n_attr. Combine 'wincolor' with other highlights when 'nowrap' is set. (zeertzjq) closes: #14196 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-14 18:16:56 +01:00
/**/
179,
patch 9.1.0178: E1513 might be confusing Problem: E1513 might be confusing (Christoph Thoma) Solution: reword error message, fix test to not depend on the actual message fixes: #14189 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-13 20:59:27 +01:00
/**/
178,
patch 9.1.0177: Coverity reports dead code Problem: Coverity reports dead code. Solution: Remove the dead code. Also fix a mistake in ml_get_pos_len() and update some comments (zeertzjq). closes: #14189 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-13 20:42:26 +01:00
/**/
177,
patch 9.1.0176: Cursor column wrong with 'virtualedit' and conceal Problem: Cursor column wrong with 'virtualedit' and conceal. Solution: Correct cursor column at end of line if never reached. (zeertzjq) closes: #14190 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-13 20:38:26 +01:00
/**/
176,
patch 9.1.0175: wrong window positions with 'winfix{width,height}' Problem: winframe functions incorrectly recompute window positions if the altframe wasn't adjacent to the closed frame, which is possible if adjacent windows had 'winfix{width,height}' set. Solution: recompute for windows within the parent of the altframe and closed frame. Skip this (as before) if the altframe was top/left, but only if adjacent to the closed frame, as positions won't change in that case. Also correct the return value documentation for win_screenpos. (Sean Dewar) The issue revealed itself after removing the win_comp_pos call below winframe_restore in win_splitmove. Similarly, wrong positions could result from windows closed in other tabpages, as win_free_mem uses winframe_remove (at least until it is entered later, where enter_tabpage calls win_comp_pos). NOTE: As win_comp_pos handles only curtab, it's possible via other means for positions in non-current tabpages to be wrong (e.g: after changing 'laststatus', 'showtabline', etc.). Given enter_tabpage recomputes it, maybe it's intentional as an optimization? Should probably be documented in win_screenpos then, but I won't address that here. closes: #14191 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-13 20:17:24 +01:00
/**/
175,
patch 9.1.0174: 'cursorline' and 'wincolor' hl missing with conceal and wrap Problem: 'cursorline' and 'wincolor' highlight missing with concealed and wrapped lines. Solution: Apply 'cursorline' and 'wincolor' highlight to boguscols. (zeertzjq) Since 'cursorline' and 'wincolor' highlight apply after the end of the line, it is more consistent to have them also apply to boguscols. Assigning MAXCOL to values in ScreenCols[] make mouse click behave the same with 'cursorline' and 'nocursorline', but such behavior may be incorrect, as it puts the cursor on the next screen line. That may be fixed in a future PR. closes: #14192 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-13 20:06:34 +01:00
/**/
174,
patch 9.1.0173: msgfmt ver. 0.22 forcibly converts text to UTF-8 Problem: msgfmt ver. 0.22 forcibly converts text to UTF-8 Solution: use '--no-convert' if msgfmt supports it. Add a configure check for the msgfmt version (RestorerZ). closes: #14163 Co-authored-by: Christian Brabandt <cb@256bit.org> Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-12 22:11:36 +01:00
/**/
173,
patch 9.1.0172: More code can use ml_get_buf_len() instead of STRLEN() Problem: More code can use ml_get_buf_len() instead of STRLEN(). Solution: Change more STRLEN() calls to ml_get_buf_len(). Also do not set ml_line_textlen in ml_replace_len() if "has_props" is set, because "len_arg" also includes the size of text properties in that case. (zeertzjq) closes: #14183 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-12 21:50:32 +01:00
/**/
172,
patch 9.1.0171: Small split-move related improvements Problem: small improvements can be made to split-move related functions. Solution: apply them (Sean Dewar): - Improve some doc comments (frame_flatten should still work for non-current tabpages, despite the topframe check, which looks benign, though I'm unsure if it's still needed; see #2467). - f_win_splitmove should check_split_disallowed on wp, not targetwin, as that's what win_splitmove checks (though it's probably unnecessary to check b_locked_split at all; see #14109, which I hope to get around to finishing at some point). - Make winframe_restore restore window positions for the altframe, which winframe_remove changes. This doesn't affect the prior behaviour, as we called win_comp_pos after, but as win_comp_pos only works for curtab, and winframe_remove supports non-current tabpages, we should undo it. Regardless, this should mean we don't need win_comp_pos anymore; adjust tests to check that window positions remain unchanged. I'm not sure win_comp_pos is needed after last_status anyway if it doesn't steal rows from another frame to make room for a new statusline, which shouldn't be the case after winframe_remove? To be safe, I'll leave it as is. closes: #14185 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-12 21:11:39 +01:00
/**/
171,
patch 9.1.0170: Re-allow curwin == prevwin, but document it instead Problem: more places exist where curwin == prevwin, and it may even be expected in some cases. Solution: revert v9.1.0001, but document that it's possible instead. (Sean Dewar) I've had a change of heart for the following reasons: - A quick 'n dirty [GitHub code search](https://github.com/search?q=%2F%28winnr%5C%28%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%7Cwinnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5C%29%29%2F&type=code) reveals some cases where it's expected in the wild. Particularly, it made me aware `winnr() == winnr('#')` is possible when curwin is changed temporarily during the evaluation of a &statusline expression item (`%{...}`), and is used to show something different on the statusline belonging to the previous window; that behaviour wasn't changed in v9.1.0001, but it means curwin == prevwin makes sense in some cases. - The definition and call sites of back_to_prevwin imply some expectation that prevwin == wp (== curwin) is possible, as it's used to skip entering the prevwin in that case. - Prior to v9.1.0001, `:wincmd p` would not beep in the case that was patched in v9.1.0001, but now does. That resulted in #14047 being opened, as it affected the CtrlP plugin. I find it odd that `:wincmd p` had cases where it wouldn't beep despite doing nothing, but it may be preferable to keep things that way (or instead also beep if curwin == prevwin, if that's preferred). - After more digging, I found cases in win_free_mem, enter_tabpage, aucmd_restbuf and qf_open_new_cwindow where curwin == prevwin is possible (many of them from autocommands). Others probably exist too, especially in places where curwin is changed temporarily. fixes: #14047 closes: #14186 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-12 20:46:12 +01:00
/**/
170,
patch 9.1.0169: current window number returned by tabpagewinnr may be outdated Problem: current window number returned by tabpagewinnr may be outdated when called from win_execute for the original tabpage. Solution: update the original tabpage's tp_curwin in switch_win; use {un}use_tabpage instead. Don't do it in restore_win to ensure tp_curwin of the temporarily visited tabpage is unchanged from switch_win visiting it, as before. (Sean Dewar) Maybe restore_win should only restore tp_curwin if `curtab == switchwin->sw_curtab`, in case the user changed tabpages from within win_execute, but not doing that is consistent with the old behaviour. related: #14186 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-12 20:42:25 +01:00
/**/
169,
patch 9.1.0168: too many STRLEN() calls Problem: too many STRLEN() calls Solution: Make use of ml_get_len() calls instead (John Marriott) closes: #14123 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-11 22:04:45 +01:00
/**/
168,
patch 9.1.0167: Changing buffer in another window causes it to show matchparen Problem: Changing buffer in another window using win_execute() causes it to show matchparen (after 9.0.0969). Solution: Delay highlighting with SafeState in BufWinEnter. (zeertzjq) closes: #14177 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-11 21:38:58 +01:00
/**/
167,
patch 9.1.0166: Internal error with blockwise getregion() in another buffer Problem: Internal error with blockwise getregion() in another buffer Solution: Also change curwin->w_buffer when changing curbuf (zeertzjq) closes: #14179 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-11 21:36:42 +01:00
/**/
166,
patch 9.1.0165: Vim9: Importing an autoload imported script fails Problem: Vim9: Importing an autoload imported script fails (Song-Tianxiang) Solution: Return the script ID in this case (Yegappan Lakshmanan) fixes: #14171 closes: #14174 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-10 19:22:38 +01:00
/**/
165,
patch 9.1.0164: Internal error when passing invalid position to getregion() Problem: Internal error or crash when passing invalid position to getregion(). Solution: Give an error for invalid position (zeertzjq). closes: #14172 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-10 15:46:58 +01:00
/**/
164,
patch 9.1.0163: Calling STRLEN() to compute ml_line_textlen when not needed Problem: Calling STRLEN() to compute ml_line_textlen when not needed. Solution: Use 0 when STRLEN() will be required and call STRLEN() later. (zeertzjq) closes: #14155 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-10 08:55:42 +01:00
/**/
163,
patch 9.1.0162: problem with writing extended attributes on failure Problem: problem with writing extended attributes on failure Solution: Change return type to ssize_t and check listxattr's return value correctly on failure (Paul Tagliamonte) The existing logic will return when the listxattr call returns with the errno set to ENOTSUP (or a size of 0 bytes), without checking to see if listxattr actually failed. listxattr can fail with at least E2BIG, ENOTSUP, ERANGE, or anything that `stat(2)` can fail with (in my case; ENOENT from stat). The returned size is stored to a size_t, but the return type is a ssize_t. On failure, listxattr returns -1, which will get translated to size_t's MAX. If the listxattr call failed with anything other than ENOTSUP, this triggers a request for size_t MAX bytes. This means that, if the listxattr call fails with anything other than ENOTSUP on save, vim will error with `E342: Out of memory! (allocating 18446744073709551615 bytes)` (keen observers will note 18446744073709551615 is 0xffffffffffffffff) In reality, this is likely masking a different (usually filesystem?) error -- but at least it's an error being pushed to the user now, and we don't try to allocate size_t MAX bytes. I've opted to change the type that we store listxattr to from size_t to ssize_t, to match listxattr(2)'s signature, and to check for the -1 return value. Additionally, I've removed the errno check -- if we get a listxattr failure for any reason, we may as well bail without trying; it's not like we can even recover. closes: #14169 Signed-off-by: Paul Tagliamonte <paultag@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-10 08:35:10 +01:00
/**/
162,
patch 9.1.0161: expand() removes slash after env variable that ends with colon Problem: expand() removes a slash after an environment variable that ends with a colon on Windows. Solution: Check the correct char for a colon (zeertzjq) closes: #14161 Note: Vim still removes the path-separator at the end, if another path separator follows directly after it, e.g. on: ``` echo $FOO='/usr/' echo expand('$FOO/bar') == '/usr/bar' ``` see: ,----[ misc1.c:1630 ] | // if var[] ends in a path separator and tail[] starts | // with it, skip a character | if (after_pathsep(dst, dst + c) | #if defined(BACKSLASH_IN_FILENAME) || defined(AMIGA) | && (dst == save_dst || dst[-1] != ':') | #endif | && vim_ispathsep(*tail)) | ++tail; `---- Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-09 17:44:46 +01:00
/**/
161,
patch 9.1.0160: Vim9: Add support for using a class type of itself in an object method Problem: Add support for using a class type of itself in an object method (thinca) Solution: Vim9: Add support for using a class type of itself in an object method (Yegappan Lakshmanan) fixes: #12369 closes: #14165 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-09 15:44:19 +01:00
/**/
160,
patch 9.1.0159: Crash in WinClosed after BufUnload closes other windows Problem: Crash in WinClosed after BufUnload closes other windows Solution: Don't trigger WinClosed if the buffer is NULL (zeertzjq) Now win_close_othertab() doesn't trigger any autocommands if the buffer is NULL, so remove the autocmd blocking above (which was added not long ago in patch v9.0.0550) for consistency. Also remove an unreachable close_last_window_tabpage() above: - It is only reached if only_one_window() returns TRUE and last_window() returns FALSE. - If only_one_window() returns TRUE, there is only one tabpage. - If there is only one tabpage and last_window() returns FALSE, the one_window() in last_window() must return FALSE, and the ONE_WINDOW in close_last_window_tabpage() must also be FALSE. - So close_last_window_tabpage() doesn't do anything and returns FALSE. Then the curtab != prev_curtab check also doesn't make much sense, and the only_one_window() can be replaced with a check for popup and a call to last_window() since this is a stricter check than only_one_window(). closes: #14166 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-09 15:39:27 +01:00
/**/
159,
patch 9.1.0158: 'shortmess' "F" flag doesn't work properly with 'autoread' Problem: 'shortmess' "F" flag doesn't work properly with 'autoread' (after 9.1.0154) Solution: Hide the file info message instead of the warning dialog (zeertzjq) closes: #14159 closes: #14158 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-07 21:48:33 +01:00
/**/
158,
patch 9.1.0157: Duplicate assignment in f_getregion() Problem: Duplicate assignment in f_getregion(). Solution: Remove the duplicate assignment. Also improve getregion() docs wording and fix an unrelated typo (zeertzjq) closes: #14154 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-07 21:40:53 +01:00
/**/
157,
patch 9.1.0156: Make 'wfb' failing to split still report E1513 Problem: may not be clear why failing to split causes an ":Xdo" command to abort if 'wfb' is set. Solution: do not return immediately if win_split fails, so E1513 is still given. Expect both errors in the test. Also fix tests to pass CI. (Sean Dewar) closes: #14152 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-07 21:37:50 +01:00
/**/
156,
patch 9.1.0155: can only get getregion() from current buffer Problem: can only call getregion() for current buffer Solution: Allow to retrieve selections from different buffers (Shougo Matsushita) closes: #14131 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-06 21:10:18 +01:00
/**/
155,
patch 9.1.0154: shm=F not respected when reloading buffer with 'autoread' Problem: shm=F not respected when reloading buffer with 'autoread' Solution: Check SHM_FILEINFO in buf_check_timestamp() (Shougo Matsushita) closes: #14144 Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-06 20:58:41 +01:00
/**/
154,
patch 9.1.0153: Text properties corrupted with fo+=aw and backspace Problem: Text properties corrupted with fo+=aw and backspace Solution: Allocate line and move text properties (zeertzjq) closes: #14147 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-06 20:54:22 +01:00
/**/
153,
patch 9.1.0152: Coverity complains about ignoring return value Problem: Coverity complains about ignoring return value of win_split() (after v9.1.150) Solution: Check if win_split() failed, add winfixbuf.res to Makefile
2024-03-06 19:31:39 +01:00
/**/
152,
patch 9.1.0151: ml_get_buf_len() does not consider text properties Problem: ml_get_buf_len() does not consider text properties (zeertzj) Solution: Store text length excluding text properties length in addition in the memline related #14123 closes: #14133 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-05 20:43:25 +01:00
/**/
151,
patch 9.1.0150: Several minor 'winfixbuf' issues Problem: several minor 'winfixbuf' issues exist, mostly relating to the quickfix list Solution: address them and adjust tests. Retab and reflow a few things too. (Sean Dewar) Things touched include: - Replace the semsgs with gettext'd emsgs. - Handle window switching in ex_listdo properly, so curbuf and curwin are kept in-sync and trigger autocommands; handle those properly. - Don't change the list entry index in qf_jump_edit_buffer if we fail due to 'wfb' (achieved by returning FAIL; QF_ABORT should only be used if the list was changed). - Make qf_jump_edit_buffer actually switch to prevwin when using `:cXX` commands **outside** of the list window if 'wfb' is set in curwin. Handle autocommands properly in case they mess with the list. NOTE: previously, it seemed to split if 'wfb' was set, but do nothing and fail if prevwin is *valid*. This behaviour seemed strange, and maybe unintentional? Now it aligns more with what's described for the `:cXX` commands in the original PR description when used outside a list window, I think. - In both functions, only consider prevwin if 'wfb' isn't set for it; fallback to splitting otherwise. - Use win_split to split. Not sure if there was a specific reason for using ex_splitview. win_split is simpler and respects modifiers like :vertical that may have been used. Plus, its return value can be checked for setting opened_window in qf code (technically win_split_ins autocmds could immediately close it or change windows, in which the qf code might close some other window on failure; it's already the case elsewhere, though). closes: #14142 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-05 20:39:07 +01:00
/**/
150,
patch 9.1.0149: null pointer member access when accessing 'winfixbuf' property Problem: qf_goto_win_with_qfl_file may check if prevwin has 'winfixbuf' set without checking if it's valid first. Solution: Reverse the condition. Add a test, a modeline, and a missing CheckFeature. (Searn Dewar) closes: #14140 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-04 19:09:26 +01:00
/**/
149,
patch 9.1.0148: Vim9: can't call internal methods with objects Problem: Vim9: can't call internal methods with objects Solution: Add support for empty(), len() and string() function calls for objects (Yegappan Lakshmanan) closes: #14129 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-03 16:26:58 +01:00
/**/
148,
patch 9.1.0147: Cannot keep a buffer focused in a window Problem: Cannot keep a buffer focused in a window (Amit Levy) Solution: Add the 'winfixbuf' window-local option (Colin Kennedy) fixes: #6445 closes: #13903 Signed-off-by: Colin Kennedy <colinvfx@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-03 16:16:47 +01:00
/**/
147,
patch 9.1.0146: v:echospace wrong with invalid value of 'showcmdloc' Problem: v:echospace wrong after setting invalid value to 'showcmdloc'. Solution: Only call comp_col() if value is valid. (zeertzjq) closes: #14119 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-01 23:01:43 +01:00
/**/
146,
patch 9.1.0145: v:echospace not correct when 'showcmdloc' != last Problem: the amount of available space (v:echospace) on the command line is not correct when showcmdloc is drawn into the statusline or tabline. Solution: only add SHOWCMD_COLS to the shown command column when 'showcmdloc' is set to last (Sam-programs) closes: #14108 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Sam-programs <130783534+Sam-programs@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-29 17:40:29 +01:00
/**/
145,
patch 9.1.0144: getregion() needs more tests Problem: getregion() needs more tests Solution: Run the getregion() test in both the legacy and Vim9 contexts (Yegappan Lakshmanan) closes: #14114 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-29 17:30:43 +01:00
/**/
144,
patch 9.1.0143: [security]: autocmd causes use-after-free in set_curbuf() Problem: [security]: autocmd cause use-after-free in set_curbuf() (kawarimidoll) Solution: check side-effect of BufLeave autocommand, when the number of windows changed, close windows containing buffers that will be wiped, if curbuf changed unexpectedly make sure b_nwindows is decremented otherwise it cannot be wiped set_curbuf() already makes some efforts to ensure the BufLeave autocommands do not cause issues. However there are still 2 issues that are not taken care of: 1) If a BufLeave autocommand opens a new window containing the same buffer as that is going got be closed in close_buffer() a bit later, we suddenly have another window open, containing a free'd buffer. So we must check if the number of windows changed and if it does (and the current buffer is going to be wiped (according to the 'bufhidden' setting), let's immediately close all windows containing the current buffer using close_windows() 2) If a BufLeave autocommand changes our current buffer (displays it in the current window), buf->b_nwindow will be incremented. As part of set_curbuf() we will however enter another buffer soon, which means, the newly created curbuf will have b_nwindows still have set, even so the buffer is no longer displayed in a window. This causes later problems, because it will no longer be possible to wipe such a buffer. So just before entering the final buffer, check if the curbuf changed when calling the BufLeave autocommand and if it does (and curbuf is still valid), decrement curbuf->b_nwindows. Both issues can be verified using the provided test (however the second issue only because such an impacted buffer won't be wiped, causing futher issues in later tests). fixes: #13839 closes: #14104 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-28 23:32:00 +01:00
/**/
143,
patch 9.1.0142: getregion() can be improved Problem: getregion() can be improved (after v9.1.120) Solution: change getregion() implementation to use pos as lists and one optional {opt} dictionary (Shougo Matsushita) Note: The following is a breaking change! Currently, the getregion() function (included as of patch v9.1.120) takes 3 arguments: the first 2 arguments are strings, describing a position, arg3 is the type string. However, that is slightly inflexible, there is no way to specify additional arguments. So let's instead change the function signature to: getregion(pos1, pos2 [, {Dict}]) where both pos1 and pos2 are lists. This is slightly cleaner, and gives us the flexibility to specify additional arguments as key/value pairs to the optional Dict arg. Now it supports the "type" key to specify the selection type (characterwise, blockwise or linewise) and now in addition one can also define the selection type, independently of what the 'selection' option actually is. Technically, this is a breaking change, but since the getregion() Vimscript function is still quite new, this should be fine. closes: #14090 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-28 22:48:12 +01:00
/**/
142,
patch 9.1.0141: Put in Visual mode wrong if it replaces fold marker Problem: Put in Visual mode wrong if it replaces fold marker. Solution: Temporarily disable folding during put in Visual mode. (zeertzjq) fixes: #14097 closes: #14100 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-28 21:49:51 +01:00
/**/
141,
patch 9.1.0140: cursor on wrong row after 1 char 'below' virtual text when EOL is shown Problem: The cursor screen row was incorrectly being calculated when the cursor follows a 1 character text_align 'below' virtual text line, resulting in the cursor being shown on the wrong line. This was caused by a cell size of 2 instead of 1 being used for the EOL character, which propagated to the calculation of space for putting the 'below' virtual text on its own line. (rickhowe) Solution: Fix the size used for the EOL character in calculating the cursor's screen position (Dylan Thacker-Smith) fixes: #11959 related: #12028 closes: #14096 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-27 20:25:10 +01:00
/**/
140,
patch 9.1.0139: MS-Windows: ligatures map cleared on startup Problem: MS-Windows: ligatures map cleared on startup Solution: Don't clear the ligatures_map, if the guiligatures option has already been set (Erik S. V. Jansson) If guiligatures is set from a .vimrc it's possible that it will be cleared on start-up (e.g. in Win32 that's what happens). So don't clear the ligatures map if gui_set_ligatures() has already been called (e.g. after setting 'ligatures' from .vimrc) closes: #14094 Signed-off-by: Erik S. V. Jansson <caffeineviking@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-26 22:23:05 +01:00
/**/
139,
patch 9.1.0138: too many STRLEN calls when getting a memline Problem: too many STRLEN calls when getting a memline Solution: Optimize calls to STRLEN(), add a few functions in memline.c that return the byte length instead of relying on STRLEN() (John Marriott) closes: #14052 Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-26 21:21:17 +01:00
/**/
138,
patch 9.1.0137: <Del> in cmdline mode doesn't delete composing chars Problem: <Del> in cmdline mode doesn't delete composing chars Solution: Use mb_head_off() and mb_ptr2len() (zeertzjq) closes: #14095 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-26 20:38:36 +01:00
/**/
137,
patch 9.1.0136: Vim9: need more test for exists() methods Problem: Vim9: need more test for exists() Solution: Add test for exists() with class/objct variables and methods (Yegappan Lakshmanan) closes: #14088 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-25 08:40:10 +01:00
/**/
136,
patch 9.1.0135: Insufficient testing for 'delcombine' Problem: Insufficient testing for 'delcombine'. Solution: Add test for both Normal and Insert modes without Arabic. (zeertzjq) closes: #14086 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-24 16:51:32 +01:00
/**/
135,
patch 9.1.0134: CI: Test_term_gettitle() is flaky on MacOS 14 Problem: Test_term_gettitle() is flaky on MacOS 14 and Github runners Solution: Skip the test on Github CI closes: #14085 It fails with this: '^\\[No Name\\] - VIM\\d*$' does not match 'e] - VIM' It is not clear why term_gettitle() only get's the last part of the expected title (perhaps there is a Carriage return in there or the terminal window is too small?) So let's just skip this test for now. Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-24 15:56:34 +01:00
/**/
134,
patch 9.1.0133: MS-Windows: ligatures not rendering correctly Problem: font ligatures don't render correctly in the Win32 GUI-version of gvim even when set rop=type:directx is used. Setting guiligatures also doesn't make any difference. This leads to broken font ligatures when the cursor passes through them. It does not recover from this, and they remain broken until you re-render the whole buffer (e.g. by using Ctrl+L). Solution: the problem is that we only re-draw the current and previous character in gui_undraw_cursor() and only have the special case for GTK when it comes to rendering ligatures. So let's enable gui_adjust_undraw_cursor_for_ligatures() to also happen for Win32 GUI if guiligatures is setup correctly (all this does is expand the range of gui_undraw_cursor() with ligature characters). related: #9181 related: #12901 closes: #14084 Signed-off-by: Erik S. V. Jansson <caffeineviking@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-24 14:26:52 +01:00
/**/
133,
patch 9.1.0132: "C" doesn't include composing chars with 'virtualedit' Problem: using "C" and 've=all' set, doesn't include composing chars when changing a line, keeps the composing chars for whatever is typed afterwards. Solution: Use mb_head_off() and mb_ptr2len() instead of mb_tail_off(). (zeertzjq) closes: #14083 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-24 14:21:39 +01:00
/**/
132,
patch 9.1.0131: buffer-completion may not always find all matches Problem: buffer-completion code too complicated and does not always find all matches (irisjae) Solution: do not try to anchor pattern to beginning of line or directory-separator, always return all matches Note: we are considering the non-fuzzy buffer-matching here. Currently, the buffer-completion code makes 2 attempts to match a pattern against the list of available patterns. First try is to match the pattern and anchor it to either the beginning of the file name or at a directory-separator (// or \\). When a match is found, Vim returns the matching buffers and does not try to find a match anywhere within a buffer name. So if you have opened two buffers like /tmp/Foobar.c and /tmp/MyFoobar.c using `:b Foo` will only complete to the first filename, but not the second (the same happens with `getcompletion('Foo', 'buffer')`). It may make sense, that completion priorities buffer names at directory boundaries, but it inconsistent, may cause confusion why a certain buffer name is not completed when typing `:b Foo<C-D>` which returns only a single file name and then pressing Enter (to switch to that buffer), Vim will error with 'E93: More than one match for Foo'). Similar things may happen when wiping the /tmp/Foobar.c pattern and afterwards the completion starts completing other buffers. So let's simplify the code and always match the pattern anywhere in the buffer name, do not try to favor matches at directory boundaries. This is also simplifies the code a bit, we do not need to run over the list of buffers several times, but only twice. fixes #13894 closes: #14082 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-24 14:12:13 +01:00
/**/
131,
patch 9.1.0130: [security]: UAF if win_split_ins autocommands delete "wp" Problem: heap-use-after-free in win_splitmove if Enter/Leave autocommands from win_split_ins immediately closes "wp". Solution: check that "wp" is valid after win_split_ins. (Sean Dewar) closes: #14078 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-24 10:20:24 +01:00
/**/
130,
patch 9.1.0129: Fix truncation of text_wrap 'wrap' virt text after EOL list char Problem: Virtual text with text_wrap 'wrap' was effectively being truncated by a break conditional on the EOL list character being added to the screen line. (BigPeet) Solution: Remove the condition that was leading to the early break and instead fix a similar but incorrectly written outer condition that checks if there is more to add at the end of the screen line. (Dylan Thacker-Smith) Also, related: - update comment in win_line() - remove no longer necessary at_end_str variable in win_line() fixes: #12725 closes: #14079 Co-authored-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-24 10:17:11 +01:00
/**/
129,
patch 9.1.0128: win_gotoid() may abort even when not switching a window Problem: win_gotoid() checks for textlock and other things when switching to a window that is already current (after v9.1.0119) Solution: return early with success when attempting to switch to curwin (Sean Dewar) Other potential causes of E565 from win_gotoid after v9.1.0119 should be correct. Plugins can consider using win_execute() instead if they wish to temporarily switch windows during textlock. fixes: #14073 closes: #14074 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-22 19:53:33 +01:00
/**/
128,
patch 9.1.0127: Naming a non-pointer variable "oap" is strange Problem: Naming a non-pointer variable "oap" is strange. Solution: Rename it to "oa". Also prevent using freed memory in case of memory allocation failure. (zeertzjq) closes: #14075 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-22 19:51:34 +01:00
/**/
127,
patch 9.1.0126: Internal error when using upper-case mark in getregion() Problem: Internal error when passing mark in another buffer to getregion(). Solution: Don't allow marks in another buffer (zeertzjq) closes: #14076 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Internal error when passing mark in another buffer to getregion()
2024-02-22 19:48:06 +01:00
/**/
126,
patch 9.1.0125: unused init of text_prop_idxs in win_line() Problem: unused init of text_prop_idxs in win_line Solution: Remove it, fix typo (Dylan Thacker-Smith) Later use of text_prop_idxs treats it as empty, incrementing text_props_active as new elements are added to this array, so remove this unused conditional initialization when text_props_active is 0. closes: #14063 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-21 21:03:10 +01:00
/**/
125,
patch 9.1.0124: display of below/right virtual text with non-virtual text overlap Problem: Virtual text with text_align 'right'/'below' wasn't being used when a non-virtual text property overlaps with the end of the line. This was because the non-virtual text property had a higher priority, preventing the virtual text from being used. Solution: Fix the sorting of text properties so virtual text properties have a higher priority than non-virtual text properties. (Dylan Thacker-Smith) related: #14063 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-21 21:00:59 +01:00
/**/
124,
patch 9.1.0123: MS-Windows: system() may deadlock Problem: MS-Windows: system() may deadlock when calling binaries that expect stdin Solution: Ignore the SHELL_EXPAND flag (GuyBrush) This happens on binaries that expect stdin. For example: :echo system("xxd") will cause a deadlock. SHELL_EXPAND is a flag devoted to support the linux implementation of the backtick-expansion mechanism. On linux backtic-expansion relies in the function mch_expand_wildchars() (os_unix.c) that delegates on each specific shell (bash, sh, csh, zsh) the expansion. Basically it composes a shell command that does the expansion and redirects the output to a file and call_shell() it. On windows backtick-expansion is performed by Vim itself. On linux SHELL_EXPAND modifies how mch_call_shell_fork() (os_unix.c) works. This function: - relies on posix fork() to spawn a child process to execute a external command. - Child and parent process communicate using pipes (or pseudoterminal if available). User input (type ahead content) is processed in a loop only if !(SHELL_EXPAND || SHELL_COOKED). Though signals are used to detect Ctrl-C in all cases (the input loop is not necessary to interrupt the function). In the backtick-expansion the external command is the shell command that provides the expansion. For the child redirection: - SHELL_EXPAND replaces stdin, stdout & stderr to /dev/null. This is why the shell command composed includes redirection (otherwise output would be lost). - !SHELL_EXPAND replaces stdin, stdout & stderr with the parent created pipes (or pseudoterminal). Note that the use of SIGINT signal prevents mch_call_shell_fork() from hanging vim. On Windows mch_system_piped() (os_win32.c) (which is only used when the GUI is running) mimics mch_call_shell_fork() (os_unix.c). Win32 lacks fork() and relies on CreateProcessW() and only has pipe support (not pseudoterminal) which makes the implementation much different. But, the key idea is that windows lacks signals, the OS provides support for console apps but gvim is not one. The only way of detecting a Ctrl-C is actually processing user input (type ahead content). By ignoring the user input under SHELL_EXPAND the function can hang gvim. Ignoring SHELL_EXPAND flag has no consequence in Windows because as mentioned above it is only meaningful in linux. closes: #13988 Signed-off-by: GuyBrush <miguel.barro@live.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-21 20:16:38 +01:00
/**/
123,
patch 9.1.0122: Some minor issues with the getregion() function Problem: Some minor issues with the getregion() function Solution: Fix examples in the help, use OP_NOP op_type and MBLOCK as motion_type in f_getreg(), update vim syntax to for getregion() (Maxim Kim) ``` :xnoremap <CR> \ <Cmd>echow getregion('v', '.', mode())<CR> ``` `echo` while in visual mode has no visible effect, thus people trying example might be frustrated as it looks like nothing happens. So the option is to change it to `echow` or `echom`. With `echom` it is again has no visible effect but one can at least inspect `:messages`. On the other hand `echow` showes selected text in a popup window. ``` Can also be used as a |method|: > '.'->getregion("'a', 'v') ``` Here is the typo, which makes example invalid, should be `("'a", ...` closes: #14064 Signed-off-by: Maxim Kim <habamax@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-21 19:48:37 +01:00
/**/
122,
patch 9.1.0121: Infinite loop or signed overflow with 'smoothscroll' Problem: infinite loop in win_update with 'smoothscroll' set when window width is equal to textoff, or signed integer overflow if smaller. Solution: don't revalidate wp->w_skipcol in that case, as no buffer text is being shown. (Sean Dewar) Don't instead reset w_skipcol; that would lose the scroll position within the line, which may be undesirable if the window is made wider later. Also include changes from the splitmove PR #14042 that I (in my infinite Git wisdom) forgot to commit. This includes a change to Test_window_split_no_room to ensure it doesn't fail for some screen sizes. Move Test_smoothscroll_in_zero_width_window to test_scroll_opt.vim, as that file feels more appropriate. closes: #14068 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-21 19:40:44 +01:00
/**/
121,
patch 9.1.0120: hard to get visual region using Vim script Problem: hard to get visual region using Vim script Solution: Add getregion() Vim script function (Shougo Matsushita, Jakub Łuczyński) closes: #13998 closes: #11579 Co-authored-by: =?UTF-8?q?Jakub=20=C5=81uczy=C5=84ski?= <doubleloop@o2.pl> Co-authored-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Shougo Matsushita <Shougo.Matsu@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-21 00:02:45 +01:00
/**/
120,
patch 9.1.0119: can move away from cmdwin using win_splitmove() Problem: can switch windows while textlocked via f_win_gotoid and f_win_splitmove (which also allows switching in the cmdwin). Solution: Check text_or_buf_locked in f_win_splitmove() (Sean Dewar) While at it, call text_or_buf_locked() in f_win_gotoid() instead of testing for cmdwin_type() (which text_buf_locked() does and in addition will also verify that the buffer is not locked). closes: #14042 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-20 22:05:10 +01:00
/**/
119,
patch 9.1.0118: Use different restoration strategy in win_splitmove Problem: saving and restoring all frames to split-move is overkill now that WinNewPre is not fired when split-moving. Solution: defer the flattening of frames until win_split_ins begins reorganising them, and attempt to restore the layout by undoing our changes. (Sean Dewar) This also means we no longer must allocate. related: #14042 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-20 22:00:33 +01:00
/**/
118,
patch 9.1.0117: Stop split-moving from firing WinNew and WinNewPre autocommands Problem: win_splitmove fires WinNewPre and possibly WinNew when moving windows, even though no new windows are created. Solution: don't fire WinNew and WinNewPre when inserting an existing window, even if it isn't the current window. Improve the accuracy of related documentation. (Sean Dewar) Likewise, before this patch, WinClosed was not fired anyway (even for :wincmd H/J/K/L, which also didn't fire WinNew, but did still fire WinNewPre), despite documentation saying windows are "closed". Note that :wincmd T actually indeed works by creating a new window (and closing the old one), unlike the others. This also fixes issues where WinNewPre is fired when split-moving while curwin doesn't yet have a frame or entry in the window list, causing many things to not work (it's not considered valid at that point). This was guaranteed when using :wincmd H/J/K/L. Because WinNewPre is no longer fired when split-moving, this makes restoring the previous window layout on failure easier, as we can be sure that frames are not resized from WinNewPre autocommands if win_split_ins fails. This allows us to use a different strategy in the following commit. -- In my opinion, this leaves questions about the current usefulness of WinNewPre. A motivation described in #10635 states how creating a new window can steal room from other windows, and how WinNewPre will be useful for detecting that, but this is also true when inserting an existing window, which now doesn't fire it. Maybe the autocommand should be changed to have a better name? There are also other issues I found with the current implementation of WinNewPre that need addressing: - it allows switching windows and tabpages, which can cause incorrect windows to be split/moved, and big problems when switching tabpages. - it fires before win_split_ins checks for room, before it makes any changes to window sizes or before it considers allocating a new window. This should be changed or documented. I hope to address some of this stuff in a different PR, if possible. related: #14038 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-20 21:52:31 +01:00
/**/
117,
patch 9.1.0116: win_split_ins may not check available room Problem: win_split_ins has no check for E36 when moving an existing window Solution: check for room and fix the issues in f_win_splitmove() (Sean Dewar) win_split_ins has no check for E36 when moving an existing window, allowing for layouts with many overlapping zero-sized windows to be created (which may also cause drawing issues with tablines and such). f_win_splitmove also has some bugs. So check for room and fix the issues in f_win_splitmove. Handle failure in the two relevant win_split_ins callers by restoring the original layout, and factor the common logic into win_splitmove. Don't check for room when opening an autocommand window, as it's a temporary window that's rarely interacted with or drawn anyhow, and is rather important for some autocommands. Issues fixed in f_win_splitmove: - Error if splitting is disallowed. - Fix heap-use-after-frees if autocommands fired from switching to "targetwin" close "wp" or "oldwin". - Fix splitting the wrong window if autocommands fired from switching to "targetwin" switch to a different window. - Ensure -1 is returned for all errors. Also handle allocation failure a bit earlier in make_snapshot (callers, except win_splitmove, don't really care if a snapshot can't be made, so just ignore the return value). Note: Test_smoothscroll_in_zero_width_window failed after these changes with E36, as it was using the previous behaviour to create a zero-width window. I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is reverted (and simplified it too). related: #14042 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-20 20:28:15 +01:00
/**/
116,
patch 9.1.0115: Using freed memory with full tag stack and user data Problem: Using freed memory with full tag stack and user data (Konstantin Khlebnikov) Solution: Clear the user data pointer of the newest entry. (zeertzjq, Konstantin Khlebnikov) fixes: neovim/neovim#27498 closes: #14053 Co-authored-by: Konstantin Khlebnikov koct9i@gmail.com Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Konstantin Khlebnikov koct9i@gmail.com Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-18 18:53:08 +01:00
/**/
115,
patch 9.1.0114: Setting some options may change curswant Problem: Setting some options changes curswant unnecessarily. Solution: Add a P_HLONLY flag that prevents changing curswant. (zeertzjq) closes: #14044 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-18 09:33:54 +01:00
/**/
114,
patch 9.1.0113: duplicate code when cleaning undo stack Problem: duplicate code when cleaning undo stack Solution: refactor undo cleanup into a single public function related: #13928 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-15 20:17:37 +01:00
/**/
113,
patch 9.1.0112: Remove undo information, when cleaning quickfix buffer Problem: When the quickfix buffer has been modified an autocommand may invalidate the undo stack (kawarimidoll) Solution: When clearing the quickfix buffer, also wipe the undo stack fixes: #13905 closes: #13928 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-15 20:15:04 +01:00
/**/
112,
patch 9.1.0111: filetype: no support for bats files The '*.bats' file type is for Bash Automated Testing System (BATS) scripts. BATS scripts are Bash with a special '@test' extension but they otherwise work with Vim's bash filetype. See https://github.com/bats-core/bats-core closes: #14039 Signed-off-by: Brandon Maier <brandon.maier@collins.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-15 00:16:02 +01:00
/**/
111,
patch 9.1.0110: filetype: add 'Config.in' filetype detection The 'Config.in' file type is for Buildroot configuration files. Buildroot Config.in files use the same Kconfig backend as the Linux kernel's Kconfig files. Buildroot also has other filename variants that follow "Config.in.*", they are used to distinguish multiple Config.in files in the same directory. See https://buildroot.org/downloads/manual/manual.html#_literal_config_in_literal_file closes: #14038 Signed-off-by: Brandon Maier <brandon.maier@collins.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-14 22:30:06 +01:00
/**/
110,
patch 9.1.0109: filetype: no support for its files Problem: filetype: no support for its files Solution: Add detection for *.its files as dts file type (Brandon Maier) The '*.its' file type is for U-Boot Flattened Image Trees (FIT) which use the flattened devicetree format. See https://github.com/u-boot/u-boot/blob/master/doc/usage/fit/source_file_format.rst#terminology closes: #14037 Signed-off-by: Brandon Maier <brandon.maier@collins.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-14 21:31:47 +01:00
/**/
109,
patch 9.1.0108: filetype: no support for dtso files Problem: filetype: no support for dtso files Solution: Add detection for *.dtso files as dts file type (Markus Schneider-Pargmann) *.dtso files are devicetree overlay files which have the same syntax as dts or dtsi files. closes: #14026 Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-14 20:44:28 +01:00
/**/
108,
patch 9.1.0107: CI: Fix MacOS-14 tests Problem: CI: Fix MacOS-14 tests (after 9.1.0070) Solution: Re-enable sound tests by granting Mic access, disable Test_diff_screen because of buggy MacOS diff (non GNU version), re-enable Test_term_gettitle() (Yee Cheng Chin) macos-14 runner was turned on in #13943, but it had to turn off a few tests in order for CI to run. Re-enable them and fix the underlying issues. * `Test_diff_screen`: The test failure is due to a bug in Apple's diff utility. Apple introduced a new diff tool based on FreeBSD in macOS 13 and it has buggy behaviors when using unified diff (`-U0`) and the diff is on the first line of the file. Simply disable this test for now if we detect Apple diff (instead of the old GNU diff). Can re-enable this in the future if Apple fixes the issue. * `Test_play_event` / `Test_play_silent`: GitHub Actions currently has an issue with playing sound in CI in macos-14 runners. It for some reason triggers a microphone permission dialog popup which blocks the CI action (see https://github.com/actions/runner-images/issues/9330). To fix this, add a temporary step in macos-14 to manually allow microphone permissions in the runner. * `Test_term_gettitle`: I could not reproduce the failure, so I just turned it on and it seems to run just fine. Maybe it's a timing issue and whatnot but either way that should be fixed when we can reproduce the issue. closes: #14032 Signed-off-by: Yee Cheng Chin <ychin.git@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-14 20:34:58 +01:00
/**/
107,
patch 9.1.0106: Visual highlight hard to read with 'termguicolors' Problem: Visual highlight hard to read with 'termguicolors' (Maxim Kim) Solution: Set Visual GUI foreground to black (with background=light) and lightgrey (with background=dark) (Maxim Kim) fixes: #14024 closes: #14025 Signed-off-by: Maxim Kim <habamax@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-14 20:28:17 +01:00
/**/
106,
patch 9.1.0105: Style: typos found Problem: Style: typos found Solution: correct them (zeertzjq) closes: #14023 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-13 20:32:04 +01:00
/**/
105,
patch 9.1.0104: Linking fails with -lto because of PERL_CFLAGS Problem: Linking fails with -lto because of PERL_CFLAGS (Zoltan Toth) Solution: Filter out -flto argument from Perl CFLAGS. fixes: #14012 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-12 23:12:26 +01:00
/**/
104,
patch 9.1.0103: 'breakindentopt' "min" not correct with 'signcolumn' Problem: 'breakindentopt' "min" works incorrectly with 'signcolumn'. Solution: Use win_col_off() and win_col_off2(). (zeertzjq) closes: #14014 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-12 22:53:20 +01:00
/**/
103,
patch 9.1.0102: settabvar() may change the last accessed tabpage Problem: settabvar() may change the last accessed tabpage. Solution: Save and restore lastused_tabpage. (zeertzjq) closes: #14017 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-12 22:50:26 +01:00
/**/
102,
patch 9.1.0101: upper-case of German sharp s should be U+1E9E Problem: upper-case of ß should be U+1E9E (CAPITAL LETTER SHARP S) (fenuks) Solution: Make gU, ~ and g~ convert the U+00DF LATIN SMALL LETTER SHARP S (ß) to U+1E9E LATIN CAPITAL LETTER SHARP S (ẞ), update tests (glepnir) This is part of Unicode 5.1.0 from April 2008, so should be fairly safe to use now and since 2017 is part of the German standard orthography, according to Wikipedia: https://en.wikipedia.org/wiki/Capital_%E1%BA%9E#cite_note-auto-12 There is however one exception: UnicodeData.txt for U+00DF LATIN SMALL LETTER SHARP S does NOT define U+1E9E LATIN CAPITAL LETTER SHARP S as its upper case version. Therefore, toupper() won't be able to convert from lower sharp s to upper case sharp s (the other way around however works, since U+00DF is considered the lower case character of U+1E9E and therefore tolower() works correctly for the upper case version). fixes: #5573 closes: #14018 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-12 22:14:53 +01:00
/**/
101,
patch 9.1.0100: Redrawing can be improved with undo and 'spell' Problem: When undoing with 'spell', redrawWinline() is called after changed_lines(), while later win_update() sets redraw type to UPD_NOT_VALID, even though w_redraw_top and w_redraw_bot are still valid. Solution: Only set redraw type to UPD_NOT_VALID when inserting/deleting lines after parts of window has pending redraw, i.e., when changed_lines() is called after redrawWinline(). (zeertzjq) closes: #14019 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-12 20:28:01 +01:00
/**/
100,
patch 9.1.0099: Not able to use diff() with 'diffexpr' Problem: Not able to use diff() with 'diffexpr' (rickhowe, after v9.1.0096) Solution: Use a default context length of 0, update diff() help text, add a test for using diff() with 'diffexpr' (Yegappan Lakshmanan) closes: #14013 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-12 20:21:26 +01:00
/**/
99,
patch 9.1.0098: CompletionChanged not triggered when new leader added without matches Problem: CompletionChanged not triggered when new leader added causing no matching item in the completion menu Solution: When completion is active but no items matched still trigger CompletChanged event (glepnir) closes: #13982 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-11 17:52:40 +01:00
/**/
98,
patch 9.1.0097: 'breakindent' behaves inconsistently with 'list' and splits Problem: 'breakindent' behaves inconsistently with 'list' and splits. Solution: Use 'listchars' from the correct window and handle caching properly. Move cheaper comparisons to the top. (zeertzjq) closes: #14008 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-11 17:16:19 +01:00
/**/
97,
patch 9.1.0096: diff() function uses 'diffexpr' Problem: diff() function uses 'diffexpr' (rickhowe) Solution: Make diff() always use internal diff(), add support for unified diff context length, sort diff() options in help (Yegappan Lakshmanan) fixes: #13989 closes: #14010 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-11 17:08:29 +01:00
/**/
96,
patch 9.1.0095: tests: test_restricted() fails Problem: tests: test_restricted() fails (after: v9.1.0091) Solution: Add a space before the pipecmd and the actual Vim command to run Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-10 13:50:54 +01:00
/**/
95,
patch 9.1.0094: xxd: buffer-overflow when writing color output Problem: xxd: buffer-overflow when writing color output Solution: properly account for the color escape sequences and adjust LLEN macro (Goffredo Baroncelli) xxd: crash with higer number of column xxd writes the data into a buffer before printing. Unfortunately the buffer doesn't consider the space consumed by the escape sequences used to change the color of the character. BEFORE: $ xxd -Ralways -c 256 /etc/passwd Segmentation fault (core dumped) AFTER: $ ./xxd -Ralways -c 256 /etc/passwd 00000000: 726f 6f74 3a78 3a30 3a30 3a72 6f6f 743a 2f72 [...] To solve this issue I had to increase the size of the buffer considering for each byte of data 11 further characters for the color escape sequence. closes: #14003 Signed-off-by: Goffredo Baroncelli <kreijack@libero.it> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-10 13:31:06 +01:00
/**/
94,
patch 9.1.0093: Still a qsort() comparison function that returns result of subtraction Problem: Still a qsort() comparison function fuzzy_match_item_compare() that returns result of subtraction (after 9.1.0089). Solution: Use an explicit comparison instead of subtraction. (zeertzjq) closes: #14004 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-10 13:24:03 +01:00
/**/
93,
patch 9.1.0092: Compiler warning for missing type in scroll_event() Problem: Compiler warning for missing type in scroll_event() (chdiza) Solution: Declare display_type explicitly as integer fixes: #14005 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-10 13:17:16 +01:00
/**/
92,
patch 9.1.0091: Syntax test fails when run with non C locale Problem: Syntax test fails when run with non C locale Solution: Run syntax tests with C locale, clean up Xtestscript file, strip environment variables from GetVimCommand() (h-east) closes: #14007 Co-authored-by: h-east <h.east.727@gmail.com> Signed-off-by: h-east <h.east.727@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-10 13:02:17 +01:00
/**/
91,
patch 9.1.0090: Assigning wrong colors when parsing terminal OSC response Problem: Assigning wrong colors when parsing terminal OSC response Solution: Correctly assign Green and Blue from the terminal response (Maxim Kim) closes: #13981 Signed-off-by: Maxim Kim <habamax@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-09 23:11:54 +01:00
/**/
90,
patch 9.1.0089: qsort() comparison functions should be transitive Problem: qsort() comparison functions should be transitive Solution: Do not subtract values, but rather use explicit comparisons Improve qsort() comparison functions There has been a recent report on qsort() causing out-of-bounds read & write in glibc for non transitive comparison functions https://www.qualys.com/2024/01/30/qsort.txt Even so the bug is in glibc's implementation of the qsort() algorithm, it's bad style to just use substraction for the comparison functions, which may cause overflow issues and as hinted at in OpenBSD's manual page for qsort(): "It is almost always an error to use subtraction to compute the return value of the comparison function." So check the qsort() comparison functions and change them to be safe. closes: #13980 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-09 19:39:14 +01:00
/**/
89,
patch 9.1.0088: TextChanged not triggered for :norm! commands Problem: TextChanged not triggered for :norm! commands (machakann, after v9.0.2031) Solution: Only reset curbuf->b_last_changedtick if TextChangedI was triggered in insert mode (and not blocked) Note: for unknown reasons, the test fails on Windows (but seems to work fine when running interactively) fixes: #13967 closes: #13984 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-09 19:34:36 +01:00
/**/
88,
patch 9.1.0087: Restoring lastused_tabpage too early in do_arg_all() Problem: Restore lastused_tabpage too early in do_arg_all() function it will change later in the function. Solution: Restore lastused_tabpage a bit later, when being done with tabpages (glepnir) closes: #13992 Signed-off-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-09 19:30:26 +01:00
/**/
87,
patch 9.1.0086: Problem when scrolling using slow touchpads scroll event Problem: Problem when scrolling using slow touchpads scroll event Solution: better ways to determine if a smooth scroll has ended (when available) (lilydjwg) related: #13997 Signed-off-by: lilydjwg <lilydjwg@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-09 19:24:23 +01:00
/**/
86,
patch 9.1.0085: X11 scroll size changes after accessing clipboard Problem: X11 scroll size changes after accessing clipboard (Ernie Rael) Solution: use GDK_SCROLL_MASK for X11 and GDK_SMOOTH_SCROLL_MASK for Wayland (lilydjwg) because GDK_SCROLL_SMOOTH events don't work well for x11 (see comments). fixes #13994 closes: #13997 Signed-off-by: lilydjwg <lilydjwg@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-09 19:13:12 +01:00
/**/
85,
patch 9.1.0084: Visual hl wrong when it ends before multibyte 'showbreak' Problem: Visual hl wrong when it ends before multibyte 'showbreak'. (lacygoil) Solution: Use vcol_sbr instead of adding n_extra. (zeertzjq) fixes: #11272 closes: #13996 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-09 18:14:12 +01:00
/**/
84,
patch 9.1.0083: Redrawing can be improved when deleting lines with 'number' Problem: Redrawing can be improved when inserting/deleting lines with 'number'. Solution: Only redraw the number column of lines below changed lines. Add a test as this wasn't previously tested. (zeertzjq) closes: #13985 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-08 11:37:40 +01:00
/**/
83,
patch 9.1.0082: Redrawing can be improved when deleting lines with 'cursorline' Problem: Redrawing can be improved when deleting lines with 'cursorline'. Solution: Use smarter invalidation and adjustment. Remove unnecessary UPD_VALID as it is already set at the top of the loop. Make the test for #4862 fail without the fix. (zeertzjq) closes: #13986 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-08 11:34:55 +01:00
/**/
82,
patch 9.1.0081: X11 mouse-scrolling stutters Problem: X11 mouse-scrolling stutters (Ron Aaron, after 9.1.0064) Solution: Handle GDK_SCROLL_SMOOTH fractional distance events (lilydjwg) I don't know why, but with GDK_SMOOTH_SCROLL_MASK we get wheel events as GDK_SCROLL_SMOOTH. What's more, one wheel scroll is counted as 1.5 distance in Wayland but 1.0 in X11. I failed to find any docs on gtk.org about this. fixes: #13987 closes: #13991 Signed-off-by: lilydjwg <lilydjwg@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-08 11:04:21 +01:00
/**/
81,
patch 9.1.0080: unexpected error for modifying final list using += Problem: unexpected error for modifying final list using += operator (Ernie Rael) Solution: Allow List value modification of a final variable using += operator (Yegappan Lakshmanan) fixes: #13745 fixes: #13959 closes: #13962 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-06 11:03:36 +01:00
/**/
80,
patch 9.1.0079: LineNrAbove/Below highlighting wrong on wrapped lines Problem: LineNrAbove and LineNrBelow background wrong on wrapped lines. Solution: Update number column also for wrapped part of a line. (zeertzjq) closes: #13974 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-06 10:59:03 +01:00
/**/
79,
patch 9.1.0078: GTK3: using wrong style for pre-edit area Problem: GTK3: using wrong style for pre-edit area Solution: remove the widget name, adjust css (lilydjwg) closes: #13972 Signed-off-by: lilydjwg <lilydjwg@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-06 10:49:14 +01:00
/**/
78,
patch 9.1.0077: Unnecessary call to redraw_for_cursorline() in nv_mousescroll() Problem: The call to redraw_for_cursorline() in nv_mousescroll() is unnecessary because redraw_for_cursorline() only sets redraw type to UPD_VALID, and all code paths in do_mousescroll() already set redraw type to at least UPD_VALID. Solution: Remove call to redraw_for_cursorline() in nv_mousescroll(). (zeertzjq) closes: #13979 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-06 10:43:36 +01:00
/**/
77,
patch 9.1.0076: luau config file not detected Problem: luau config file not detected (lopy) Solution: Detect it as jsonc (lopy) fixes: #13960 closes: #13970 Signed-off-by: lopy <70210066+lopi-py@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-04 10:27:33 +01:00
/**/
76,
patch 9.1.0075: insert completion not correct when adding new leader Problem: insert completion not correct when adding new leader Solution: Reset compl_curr_match to compl_shown_match (glepnir) closes: #13957 Co-authored-by: glepnir <glephunter@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-03 18:11:13 +01:00
/**/
75,
patch 9.1.0074: did_set_breakat() should be in optionstr.c Problem: did_set_breakat() should be in optionstr.c as 'breakat' is a string option. Solution: Move did_set_breakat() to optionstr.c. (zeertzjq) closes: #13958 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-03 18:08:09 +01:00
/**/
74,
patch 9.1.0073: Looping over modifier_keys_table unnecessarily Problem: Looping over modifier_keys_table[] unnecessarily with only MOD_MASK_ALT or MOD_MASK_CMD, as modifier_keys_table[] only contains MOD_MASK_SHIFT and MOD_MASK_CTRL, and the loop won't do anything. Solution: Remove MOD_MASK_ALT and MOD_MASK_CMD from the condition. (zeertzjq) closes: #13963 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-03 18:04:05 +01:00
/**/
73,
patch 9.1.0072: Not able to build without FEAT_DIFF Problem: Not able to build without FEAT_DIFF (John Marriott, after 9.1.0071) Solution: Adjust #ifdefs (Yegappan Lakshmanan) closes: #13964 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-03 17:41:54 +01:00
/**/
72,
patch 9.1.0071: Need a diff() Vim script function Problem: Need a diff() Vim script function Solution: Add the diff() Vim script function using the xdiff internal diff library, add support for "unified" and "indices" mode. (Yegappan Lakshmanan) fixes: #4241 closes: #12321 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-01 22:05:27 +01:00
/**/
71,
patch 9.1.0070: CI: testsuite not run on M1 Mac Problem: CI: testsuite not run on M1 Mac Solution: Make it run on gh runners for M1, disable failing tests for now, until we figure the problem with the failings tests out (rhysd) closes: #13943 Signed-off-by: rhysd <lin90162@yahoo.co.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-01 21:22:14 +01:00
/**/
70,
patch 9.1.0069: ScreenLines may not be correctly initialized, causing hang Problem: ScreenLines may not be correctly initialized, causing hang (Olaf Seibert, after 9.0.0220) Solution: always initialize ScreneLines when allocating a screen (Olaf Seibert) ScreenLines and related structures could be left uninitialized causing a screen update to run into an infinite loop when using latin1 encoding. Partly caused because by patch 9.0.0220, which makes mb_ptr2len return zero for NUL related: #12671 closes: #13946 Signed-off-by: Olaf Seibert <rhialto@falu.nl> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-01 21:11:16 +01:00
/**/
69,
patch 9.1.0068: Visual highlighting can still be improved Problem: Visual highlighting can still be improved Solution: Update Visual highlighting for 8 color terminals, use uniform grey highlighting for dark and light bg (Maxim Kim) Update terminal Visual 1. Use `ctermbg=Grey ctermfg=Black` for both dark and light This uniforms Visual highlighting between default dark and light colors And should work for vim usually detecting light background for terminals with black/dark background colors. Previously used `ctermfg=White` leaks `cterm=bold` if available colors are less than 16. 2. Use `term=reverse cterm=reverse ctermbg=NONE ctermfg=NONE` for terminals reporting less than 8 colors available If the terminal has less than 8 colors, grey just doesn't work right closes: #13940 Signed-off-by: Maxim Kim <habamax@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-02-01 21:07:51 +01:00
/**/
68,
patch 9.1.0067: gcc still complains about use of uninitialized var Problem: gcc still complains about use of uninitialized var ((Tony Mechelynck, after 9.1.0064/9.1.0066)) Solution: This time init the correct variable Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-31 22:10:50 +01:00
/**/
67,
patch 9.1.0066: gcc complains about use of uninitialized var Problem: gcc complains about use of uninitialized var (Tony Mechelynck, after 9.1.0064) Solution: initialize button to silence gcc Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-31 20:29:07 +01:00
/**/
66,
patch 9.1.0065: Segfault with CompleteChanged autocommand Problem: Segfault with CompleteChanged autocommand (markonm ) Solution: Test match->cp_prev for being NULL before accessing it closes: #13929 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-29 21:46:58 +01:00
/**/
65,
patch 9.1.0064: No Wayland support Problem: No Wayland support Solution: Add Wayland UI support (lilydjwg) closes: #9639 Signed-off-by: lilydjwg <lilydjwg@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-29 20:54:28 +01:00
/**/
64,
patch 9.1.0063: GTK code can be improved Problem: GTK code can be improved Solution: Improve GTK code for initial Wayland support (lilydjwg) related: #9639 Signed-off-by: lilydjwg <lilydjwg@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-29 20:14:01 +01:00
/**/
63,
patch 9.1.0062: Internal error when :luado/perldo/pydo etc delete lines Problem: Internal error when :luado/perldo/pydo etc delete lines Solution: Test that the line is still valid line number (zeertzjq) closes: #13931 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-29 19:32:39 +01:00
/**/
62,
patch 9.1.0061: UX of visual highlighting can be improved Problem: UX of visual highlighting can be improved Solution: Improve readibility of visual highlighting, by setting better foreground and background colors The default visual highlighting currently is nice in that it overlays the actual syntax highlighting by using a separate distinct background color. However, this can cause hard to read text, because the contrast between the actual syntax element and the background color is way too low. That is an issue, that has been bothering colorschemes authors for quite some time so much, that they are defining the Visual highlighting group to use a separate foreground and background color, so that the syntax highlighting vanishes, but the text remains readable (ref: vim/colorschemes#250) So this is an attempt to perform the same fix for the default Visual highlighting and just use a default foreground and background color instead of using reverse. I also removed the hard-coded changes to the Visual highlighting in init_highlight. It's not quite clear to me, why those were there and not added directly to the highlighting_init_<dark|light> struct. closes: #13663 related: vim/colorschemes#250 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-28 23:33:29 +01:00
/**/
61,
patch 9.1.0060: Recorded register cannot be translated using keytrans() Problem: Recorded register cannot be translated using keytrans() when it involves character search (iddqd505) Solution: Record a K_IGNORE instead of a K_NOP (zeertzjq) related: #13916 closes: #13925 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-28 19:03:00 +01:00
/**/
60,
patch 9.1.0059: No event triggered before creating a window Problem: No event is triggered before creating a window. (Sergey Vlasov) Solution: Add the WinNewPre event (Sergey Vlasov) fixes: #10635 closes: #12761 Signed-off-by: Sergey Vlasov <sergey@vlasov.me> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 23:07:00 +01:00
/**/
59,
patch 9.1.0058: Cannot map Super Keys in GTK UI Problem: Cannot map Super Keys in GTK UI (Casey Tucker) Solution: Enable Super Key mappings in GTK using <D-Key> (Casey Tucker) As a developer who works in both Mac and Linux using the same keyboard, it can be frustrating having to remember different key combinations or having to rely on system utilities to remap keys. This change allows `<D-z>` `<D-x>` `<D-c>` `<D-v>` etc. to be recognized by the `map` commands, along with the `<D-S-...>` shifted variants. ```vimrc if has('gui_gtk') nnoremap <D-z> u nnoremap <D-S-Z> <C-r> vnoremap <D-x> "+d vnoremap <D-c> "+y cnoremap <D-v> <C-R>+ inoremap <D-v> <C-o>"+gP nnoremap <D-v> "+P vnoremap <D-v> "-d"+P nnoremap <D-s> :w<CR> inoremap <D-s> <C-o>:w<CR> nnoremap <D-w> :q<CR> nnoremap <D-q> :qa<CR> nnoremap <D-t> :tabe<CR> nnoremap <D-S-T> :vs#<CR><C-w>T nnoremap <D-a> ggVG vnoremap <D-a> <ESC>ggVG inoremap <D-a> <ESC>ggVG nnoremap <D-f> / nnoremap <D-g> n nnoremap <D-S-G> N vnoremap <D-x> "+x endif ``` closes: #12698 Signed-off-by: Casey Tucker <dctucker@hotmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 22:44:00 +01:00
/**/
58,
patch 9.1.0057: MS-Windows: Key event test still fails Problem: MS-Windows: Key event test still fails Solution: Skip testing CTRL-C, since it causes an Interrupt which causes a test failure (after 9.1.0053) Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 22:28:37 +01:00
/**/
57,
patch 9.1.0056: wrong number of trailing spaces inserted after blockwise put Problem: Incorrect number of trailing spaces inserted for multibyte characters when pasting a blockwise register in blockwise visual mode (VanaIgr) Solution: Skip over trailing UTF-8 bytes when computing the number of trailing spaces (VanaIgr) When pasting in blockwise visual mode, and the register type is <CTRL-V>, Vim aligns the text after the replaced area by inserting spaces after pasted lines that are shorter than the longest line. When a shorter line contains multibyte characters, each trailing UTF-8 byte's width is counted in addition to the width of the character itself. Each trailing byte counts as being 4 cells wide (since it would be displayed as <xx>). closes: #13909 Signed-off-by: VanaIgr <vanaigranov@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 21:50:41 +01:00
/**/
56,
patch 9.1.0055: formatting long lines is slow Problem: formatting long lines is slow (kawaii-Code) Solution: optimize gq (internal_format) for long lines (kawaii-Code) Implemented two workarounds that significantly reduce the amount of pointless calls. Ideally the algorithm would be rewritten not to be n^2, but it's too complicated with too many corner cases. closes: #13914 Signed-off-by: kawaii-Code <nia.personal.0@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 21:40:05 +01:00
/**/
55,
patch 9.1.0054: 'linebreak' may still apply to leading whitespace Problem: 'linebreak' may still apply to leading whitespace (VanaIgr) Solution: Compare pointers instead of virtual columns. (zeertzjq) related: neovim/neovim#27180 closes: #13915 Co-authored-by: VanaIgr <vanaigranov@gmail.com> Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 21:27:13 +01:00
/**/
54,
patch 9.1.0053: MS-Windows: Key event test still fails Problem: MS-Windows: Key event test still fails Solution: Catch more interrupts (after 9.1.0051) Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 21:23:22 +01:00
/**/
53,
patch 9.1.0052: Patch 9.1.0041 causes regressions for users Problem: Patch 9.1.0041 causes regressions for users (Gleb Fotengauer-Malinovskiy) Solution: Revert 9.1.0041 and restore old behaviour Revert "patch 9.1.0041: xxd -i may generate incorrect C statements" This reverts commit 7062be13129985fe297b9a8e59c57b8f0db61b8f. Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 20:50:49 +01:00
/**/
52,
patch 9.1.0051: MS-Windows: Key event test fail Problem: MS-Windows: Key event test fail (after 9.1.0050) Solution: Catch Interrupt and return Ctrl-C Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-25 20:44:49 +01:00
/**/
51,
patch 9.1.0050: Win32 Keyboard handling is sub-optimal Problem: Win32 Keyboard handling is sub-optimal and has many issues with international keyboards (risa2000) (after v8.2.4807) Solution: soft-rollback the change, allow the user to select a suitable key-translation strategy (Anton Sharonov) Read about the details in the help: :h w32-experimental-keycode-trans-strategy fixes: #10615 fixes: #12595 closes: #12752 Signed-off-by: Anton Sharonov <anton.sharonov@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-23 23:19:02 +01:00
/**/
50,
patch 9.1.0049: Make "[Command Line]" a special buffer name Problem: E95 is possible if a buffer called "[Command Line]" already exists when opening the cmdwin. This can also happen if the cmdwin's buffer could not be deleted when closing. Solution: Un-name the cmdwin buffer, and give it a special name instead, similar to what's done for quickfix buffers and for unnamed prompt and scratch buffers. As a result, BufFilePre/Post are no longer fired when opening the cmdwin. Add a "command" key to the dictionary returned by getbufinfo() to differentiate the cmdwin buffer instead. (Sean Dewar) NOTE: This is technically a breaking change... maybe this needs a different solution? (Or maybe this issue can be ignored...) A GitHub search reveals some plugins expect the old behaviour. However, many of those plugins also do not seem to account for the string being translated, so they are subtly broken anyway (not withstanding the fact that you can call any old buffer "[Command Line]" too...) closes: #12819 Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-08-16 17:15:05 +01:00
/**/
49,
patch 9.1.0048: Abort opening cmdwin if autocmds screw things up Problem: Autocmds triggered from opening the cmdwin (in win_split and do_ecmd) can cause issues such as E199, as the current checks are insufficient. Solution: Commands executed from the cmdwin apply to the old curwin/buf, so they should be kept in a "suspended" state; abort if they've changed. Also abort if cmdwin/buf was tampered with, and check that curwin is correct. Try to clean up the cmdwin buffer (only if hidden and non-current to simplify things; the same approach is used when closing cmdwin normally), and add a beep. (Sean Dewar) It'd be nice to also check that curwin was *really* created by win_split, as autocommands can change curwin before it returns (so it can't be assumed to be that of the split); for now, this means that the cmdwin may not be the botwin in that case, which is probably OK. closes: #12819 Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-08-16 16:17:31 +01:00
/**/
48,
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open Problem: Things that temporarily change/restore curwin/buf (e.g: win_execute, some autocmds) may break assumptions that curwin/buf is the cmdwin when "cmdwin_type != 0", causing issues. Solution: Expose the cmdwin's real win/buf and check that instead. Also try to ensure these variables are NULL if "cmdwin_type == 0", allowing them to be used directly in most cases without checking cmdwin_type. (Sean Dewar) Alternatively, we could ban win_execute in the cmdwin and audit all places that temporarily change/restore curwin/buf, but I didn't notice any problems arising from allowing this (standard cmdwin restrictions still apply, so things that may actually break the cmdwin are still forbidden). closes: #12819 Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-08-16 14:17:36 +01:00
/**/
47,
patch 9.1.0046: :drop does not re-use empty buffer Problem: :drop does not re-use empty buffer (Rocco Mao) Solution: Make :drop re-use an empty buffer (Rocco Mao) fixes: #13851 closes: #13881 Signed-off-by: Rocco Mao <dapeng.mao@qq.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-23 21:27:19 +01:00
/**/
46,
patch 9.1.0045: --remote-* does not ignore `wilidignore` Problem: --remote-silent applies the wildignore option to each argument, which may result in "E479: No match" (hebaronson) Solution: temporarily reset 'wildignore' setting when building the :drop command closes: #13835 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-23 21:13:58 +01:00
/**/
45,
patch 9.1.0044: po Makefiles can be improved Problem: po Makefiles can be improved Solution: Improve the style of the Makefiles, update Makefile variables, update documentation (RestorerZ) closes: #13858 closes: #13857 Signed-off-by: RestorerZ <restorer@mail2k.ru> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-22 20:28:12 +01:00
/**/
44,
patch 9.1.0043: ml_get: invalid lnum when :s replaces visual selection Problem: ml_get: invalid lnum when :s replaces visual selection (@ropery) Solution: substitute may decrement the number of lines in a buffer, so validate, that the bottom lines of the visual selection stays within the max buffer line fixes: #13890 closes: #13892 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-22 20:12:34 +01:00
/**/
43,
patch 9.1.0042: Missing test for Chuck Filetype Problem: Missing test for Chuck filetype after commit 27a4632af6753 (Christian Clason) Solution: Add a filetype test Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-21 09:40:22 +01:00
/**/
42,
patch 9.1.0041: xxd -i may generate incorrect C statements Problem: xxd -i may generate incorrect C statements (Kuratius) Solution: xxd: Make size type returned by -i option compatible with C standard by using type size_t instead of unsigned int (Kuratius) Also change affected tests to now correctly expect size_t's fixes: #13876 closes: #13880 Signed-off-by: Kuratius <Kuratius@gmx.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-17 18:37:32 +01:00
/**/
41,
patch 9.1.0040: issue with prompt buffer and hidden buffer Problem: Modifying a hidden buffer still interferes with prompt buffer mode changes. Solution: Save and restore b_prompt_insert. (zeertzjq) closes: #13875 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org> Modifying hidden buffer still interferes with prompt buffer mode changes
2024-01-17 21:22:59 +01:00
/**/
40,
patch 9.1.0039: too vague errors for 'listchars'/'fillchars' Problem: too vague errors for 'listchars'/'fillchars' Solution: Include the field name in error message. (zeertzjq) related: neovim/neovim#27050 closes: #13877 Co-authored-by: Cole Frankenhoff <cole.nhf@gmail.com> Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-17 20:54:49 +01:00
/**/
39,
patch 9.1.0038: Unnecessary loop in getvcol() Problem: Unnecessary loop in getvcol(). Solution: Compare next char position with pos->col directly. (zeertzjq) The loop below already handles end of line before checking for posptr, and the next char is after pos->col whether pos->col is at the start or in the middle of the char in question, so neither the NUL check nor the mb_head_off() are needed when comparing the position of the next char with pos->col directly. closes: #13878 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-17 20:52:13 +01:00
/**/
38,
patch 9.1.0037: Calling get_breakindent_win() repeatedly when computing virtcol Problem: Calling get_breakindent_win() repeatedly when computing virtual column, and get_breakindent_win() does a STRCMP() on the whole line since patch 9.0.0016. Solution: Cache the result, since the line doesn't change. (zeertzjq) closes: #13879 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-17 20:42:53 +01:00
/**/
37,
patch 9.1.0036: MS-Windows: Warning about unused variable Problem: MS-Windows: Warning about unused variable (after 9.1.0030, John Marriott) Solution: Adjust #ifdef and test for HAVE_TGETENT (John Marriott) Signed-off-by: John Marriott <basilisk@internode.on.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-17 20:16:05 +01:00
/**/
36,
patch 9.1.0035: i_CTRL-] triggers InsertCharPre Problem: i_CTRL-] triggers InsertCharPre Solution: Return if CTRL-] is received. InsertCharPre is supposed to be only used for chars to be inserted but i_CTRL-] triggers expansion and is not inserted into the buffer (altermo) closes: #13853 closes: #13864 Signed-off-by: altermo Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-16 17:25:17 +01:00
/**/
35,
patch 9.1.0034: Window scrolls unexpectedly when 'scrollbind' is set Problem: Window may unexpectedly scroll when 'scrollbind' is set and setting a buffer-local option using setbufvar() (Boris Staletic) Solution: Save and restore the windows topline before opening the popup window. fixes: #13863 closes: #13869 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-16 17:22:38 +01:00
/**/
34,
patch 9.1.0033: Insert mode not stopped if closing prompt buffer modifies hidden buffer Problem: Insert mode not stopped if an autocommand modifies a hidden buffer while closing a prompt buffer. Solution: Don't set b_prompt_insert if stop_insert_mode is already set. (zeertzjq) closes: #13872 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-16 17:19:59 +01:00
/**/
33,
patch 9.1.0032: MS-Windows installer misses keymaps Problem: MS-Windows installer misses keymaps (Maxim Kim) Solution: Include keymaps in the installer archive (Ken Takata) fixes: vim/vim-win32-installer#331 closes: #13871 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-16 17:14:29 +01:00
/**/
32,
patch 9.1.0031: Link Error on Windows Problem: Link Error on Windows Solution: Add ifdef HAVE_TGETENT for term_strings_not_set() Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-15 22:51:22 +01:00
/**/
31,
patch 9.1.0030: Cannot use terminal alternate font Problem: Cannot use terminal alternate fonts (PMunch) Solution: Support terminal alternate fonts using CSI SGR 10-20 and t_CF code (PMunch) Add support for alternate font highlighting This adds support for alternate font highlighting using CSI SGR 10-20. Few terminals currently support this, but with added tool support this should improve over time. The change here is more or less taken from how colors are configured and applied, but there might be some parts I missed while implementing it. Changing fonts is done through the new `:hi ctermfont` attribute which takes a number, 0 is the normal font, and the numbers 1-9 select an "alternative" font. Which fonts are in use is up to the terminal. fixes: #13513 closes: #13537 Signed-off-by: PMunch <peterme@peterme.net> Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-11-15 15:35:49 +01:00
/**/
30,
patch 9.1.0029: Cannot act on various terminal response codes Problem: Cannot act on various terminal response codes Solution: Add the TerminalResponseAll autocommand (Danek Duvall) closes: #13829 Signed-off-by: Danek Duvall <duvall@comfychair.org> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-14 20:19:59 +01:00
/**/
29,
patch 9.1.0028: win32: Ctrl-D cannot be used to close a pipe Problem: win32: Ctrl-D cannot be used to close a pipe Solution: Properly detect Ctrl-D when reading from a pipe (GuyBrush) Enabling Ctrl-D for gvim pipeline input and apply defensive programming on account of PR #12752 so that once PR 12752 is merged, CTRL-D will keep on working closes: #13849 Signed-off-by: GuyBrush <miguel.barro@live.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-14 20:08:40 +01:00
/**/
28,
patch 9.1.0027: Vim is missing a foreach() func Problem: Vim is missing a foreach() func Solution: Implement foreach({expr1}, {expr2}) function, which applies {expr2} for each item in {expr1} without changing it (Ernie Rael) closes: #12166 Signed-off-by: Ernie Rael <errael@raelity.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-13 11:47:33 +01:00
/**/
27,
patch 9.1.0026: win32: Windows default font lacking Problem: win32: Windows default font lacking (@clach04) Solution: Improve default font (Ken Takata) win32: Improve default font Currently, Fixedsys is the default font on Windows. It is not suitable for recent High DPI environments. * Change the default font to Consolas. * Allow to change the default font by the translation message. E.g.: ``` msgid "DefaultFontNameForWindows" msgstr "Courier New" ``` fixes: #12919 closes: #13266 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 18:09:43 +01:00
/**/
26,
patch 9.1.0025: A few typos in tests and justify.vim Problem: A few typos in tests and justify.vim Solution: fix them closes: #13848 Signed-off-by: dundargoc <gocdundar@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 18:02:10 +01:00
/**/
25,
patch 9.1.0024: z/OS (MVS) support can be improved Problem: z/OS (MVS) support can be improved Solution: set UTF-8 as the default encoding for z/OS closes: #13821 Signed-off-by: Igor Todorovski <itodorov@ca.ibm.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 17:59:18 +01:00
/**/
24,
patch 9.1.0023: xxd: few problems with EBCDIC for z/OS (MVS) Problem: xxd: few problems with EBCDIC for z/OS (MVS) Solution: Fix xxd build and support ASCII and UTF-8 on z/OS (MVS) natively, add MVS guard checks with __CHARSET_LIB, support $LIBS in the Makefile (Igor Todorovski) related: #13821 Signed-off-by: Igor Todorovski <itodorov@ca.ibm.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-09 21:05:48 +00:00
/**/
23,
patch 9.1.0022: Coverity complains about improper use of negative value Problem: Coverity complains about improper use of negative value Solution: Add a condition to validate that keytyped is larger or equal to 0 Apparently patch 9.1.0006 made it more explicit for Coverity, that the TOLOWER_LOC() macros do not handle negative values properly. However, that condition has always been there even before that, so add a condition to verify that keytyped is indeed at least 0 closes: #13824 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 17:48:08 +01:00
/**/
22,
patch 9.1.0021: i_CTRL-R- doesn't work for multibyte chars in Replace mode Problem: i_CTRL-R- doesn't work for multibyte chars in Replace mode, Coverity complains missing return value for u_save_cursor() Solution: Use mb_charlen() and del_chars() instead, handle failure mode for u_save_cursor() correctly (@zeertzjq) closes: #13846 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 17:43:05 +01:00
/**/
21,
patch 9.1.0020: Vim9: cannot compile all methods in a class Problem: Vim9: cannot compile all methods in a class Solution: Support compiling all the methods in a class using :defcompile (Yegappan Lakshmanan) closes: #13844 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 17:36:40 +01:00
/**/
20,
patch 9.1.0019: cmdline may disappear when changing 'cmdheight' Problem: cmdline may disappear when changing 'cmdheight' (after Patch 9.0.0190, @markonm) Solution: always re-calculate the old_p_ch value, not only when cmdline_row was higher than expected fixes: #13822 closes: #13826 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 17:34:40 +01:00
/**/
19,
patch 9.1.0018: use of #if instead of #ifdef Problem: use of #if instead of #ifdef Solution: use correct form of #ifdef `#if FEAT_GUI_HAIKU` was used mistakenly. Use the correct form `#ifdef FEAT_GUI_HAIKU` instead. closes: #13843 Signed-off-by: Ken Takata <kentkt@csc.jp> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 17:31:07 +01:00
/**/
18,
patch 9.1.0017: [security]: use-after-free in eval1_emsg() Problem: use-after-free in eval1_emsg() when an empty line follows a lambda (by @yu3s) Solution: only set evalarg->eval_using_cmdline = FALSE when the *arg pointer is not null fixes: #13833 closes: #13841 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-12 17:21:55 +01:00
/**/
17,
patch 9.1.0016: default diff highlighting is too noisy Problem: default diff highlighting is too noisy Solution: Link diff highlighting groups to new Added/Removed/Changed, revert previous change (Romain Lafourcade) Remove diff* links added in #13776 and doc added in commit b1392be The links added in #13776 are way too noisy for the contexts in which the `diff` syntax is applied (git commits, patches, etc.). This commit: - removes those links - adds new default highlighting groups Added, Changed and Removed - links the diff highlighting groups to those new defaults - removes the doc changes - adjusts the syntax_completion test for those newly added group names Note: Changes to the default color schemes will be handled separately, by adding links to those newly created Added/Removed/Changed highlighting groups. related: #13776 closes #13825 Signed-off-by: Romain Lafourcade <romain.lafourcade@razorfish.fr> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-07 15:08:31 +01:00
/**/
16,
patch 9.1.0015: i_CTRL-R- no longer works in replace mode Problem: i_CTRL-R- no longer works in replace mode Solution: delete characters in replace mode before putting, add a test, add a bit warning into the documentation, that i_CTRL-R-P/O is not supported in Replace mode for now fixes: #13792 closes: #13816 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-05 18:19:52 +01:00
/**/
15,
patch 9.1.0014: incorrect use of W_WINROW in edit.c Problem: incorrect use of W_WINROW in edit.c Solution: compare against curwin->w_height instead Remove incorrect use of W_WINROW In structs.h it is mentioned that w_wrow is relative to w_winrow, so using W_WINROW doesn't make sense when comparing with window height. This change won't lead to any observable behavior change: The condition intends to check if there are 'scrolloff' lines between the current cursor when the bottom of the window. When W_WINROW(curwin) is added to curwin->w_height - 1 - get_scrolloff_value(), the condition is instead satisfied when the cursor is on some screen line below that position. However, - If 'scrolloff' is smaller than half the window height, this condition can only be satisfied when W_WINROW(curwin) == 0. And if it is not satisfied, update_topline() does the actual scrolling. - If 'scrolloff' is larger than half the window height, update_topline() will put the cursor at the center of the window soon afterwards anyway, because set_topline() now unsets VALID_TOPLINE flag starting from https://github.com/vim/vim-history/commit/7db7bb45b0f919ff0615d463ebd4fde881c69d1f. To put it in another way, https://github.com/vim/vim-history/commit/7db7bb45b0f919ff0615d463ebd4fde881c69d1f makes the update_topline() just below correct the mistakes made in this block, so this incorrect use of W_WINROW() no longer affects observable behavior. closes: #12331 Signed-off-by: zeertzjq <zeertzjq@outlook.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-05 18:11:43 +01:00
/**/
14,
patch 9.1.0013: Modula2 filetype support lacking Problem: Modula2 filetype support lacking Solution: Improve the Modula-2 runtime support, add additional modula2 dialects, add compiler plugin, update syntax highlighting, include syntax tests, update Makefiles (Doug Kearns) closes: #6796 closes: #8115 Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Benjamin Kowarsch <trijezdci@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-05 17:59:04 +01:00
/**/
13,
patch 9.1.0012: regression with empty inner blocks introduced Problem: regression with empty inner blocks introduced (after v9.1.0007) Solution: Set correct cursor position, Check for visual mode being active (Maxim Kim) relates: #13514 closes: #13819 Signed-off-by: Maxim Kim <habamax@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-05 17:52:49 +01:00
/**/
12,
patch 9.1.0011: regexp cannot match combining chars in collection Problem: regexp cannot match combining chars in collection Solution: Check for combining characters in regex collections for the NFA and BT Regex Engine Also, while at it, make debug mode work again. fixes #10286 closes: #12871 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 22:54:08 +01:00
/**/
11,
patch 9.1.0010: Keymap completion is not available Problem: Keymap completion is not available Solution: Add keymap completion (Doug Kearns) Add keymap completion to the 'keymap' option, user commands and builtin completion functions. closes: #13692 Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 22:37:44 +01:00
/**/
10,
patch 9.1.0009: Cannot easily get the list of matches Problem: Cannot easily get the list of matches Solution: Add the matchstrlist() and matchbufline() Vim script functions (Yegappan Lakshmanan) closes: #13766 Signed-off-by: Yegappan Lakshmanan <yegappan@yahoo.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 22:28:46 +01:00
/**/
9,
patch 9.1.0008: NSIS installer includes syntax testdir Problem: NSIS installer includes syntax test dumps (Yegappan Lakshmanan) Solution: Exclude syntax/testdir when creating the NSIS installer fixes: vim/vim-win32-installer#328 closes: #13814 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 22:14:28 +01:00
/**/
8,
patch 9.1.0007: can select empty inner text blocks Problem: can select empty inner text blocks (laurentalacoque) Solution: make selecting empty inner text blocks an error textobjects: Make selecting inner empty blocks an error fixes: #13514 closes: #13523 Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 21:43:36 +01:00
/**/
7,
patch 9.1.0006: is*() and to*() function may be unsafe Problem: is*() and to*() function may be unsafe Solution: Add SAFE_* macros and start using those instead (Keith Thompson) Use SAFE_() macros for is*() and to*() functions The standard is*() and to*() functions declared in <ctype.h> have undefined behavior for negative arguments other than EOF. If plain char is signed, passing an unchecked value from argv for from user input to one of these functions has undefined behavior. Solution: Add SAFE_*() macros that cast the argument to unsigned char. Most implementations behave sanely for negative arguments, and most character values in practice are non-negative, but it's still best to avoid undefined behavior. The change from #13347 has been omitted, as this has already been separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a (v9.0.2054) fixes: #13332 closes: #13347 Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 21:19:04 +01:00
/**/
6,
patch 9.1.0005: OpenVMS does not support python3 and xterm_save Problem: OpenVMS build does not support python3 and xterm_save Solution: Enable python3 + xterm_save feature, fix style issues (Zoltan Arpadffy) closes: #13812 Signed-off-by: Zoltan Arpadffy <zoltan.arpadffy@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 21:01:13 +01:00
/**/
5,
patch 9.1.0004: reloading colorscheme when not changing 'background' Problem: reloading colorscheme when not changing 'background' Solution: Check, if the background option value actually changed, if not, return early. Only reload colorscheme when bg is changed Currently the highlight groups are re-initialized and the colorscheme (if any) is reloaded anytime 'background' is set, even if it is not changed. This is unnecessary, because if the value was not changed then there is no need to change highlight groups or do anything with the colorscheme. Instead, only reload the colorscheme if the value of 'background' was actually changed. closes: #13700 Signed-off-by: Gregory Anders <greg@gpanders.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-03 19:48:51 +01:00
/**/
4,
patch 9.1.0003: Cannot build against Ruby 33 dynamically Problem: Cannot build against Ruby 33 dynamically Solution: Ruby 33 removed transient heap, so do not use rb_ary_transient anymore, NoMethodError format changed, so update test for expected error message (Isao Sato) - ruby-3.3 removed transient heap for ruby/dyn when +ruby/dyn with ruby-3.3 do command :ruby, E448 occur. ruby-3.3 has no transient heap anymore, so disable rb_ary_transient etc. $ LC_ALL=C VIMRUNTIME=runtime ./src/vim -u NONE -c 'ruby puts RUBY_VERSION' "=> Error detected while processing command line: "=> E448: Could not load library function rb_ary_detransient "=> E266: Sorry, this command is disabled, the Ruby library could not be loaded. - ruby-3.3 changed NoMethodError format: $ rvm 3.2.2, 3.3.0-rc1 do ruby -e 'begin; nil.name; rescue => e; puts "%s : %s"%[RUBY_VERSION, e.message]; end ' => 3.2.2 : undefined method `name' for nil:NilClass => 3.3.0 : undefined method `name' for nil so loose pattern in Test_ruby_Vim_buffer_get() closes: #13741 Signed-off-by: Isao Sato <svardew@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-03 19:31:05 +01:00
/**/
3,
patch 9.1.0002: a closing fold expr, may start a new fold Problem: a closing fold expression may unexpectedly start a new fold when it should end a fold (reported by Shota Nozaki) Solution: if a fold hasn't started yet, do not immediately start a new fold with level 1 (Shota Nozaki) fixes: #12768 closes: #13748 Signed-off-by: Shota Nozaki <emonkak@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-03 19:18:43 +01:00
/**/
2,
patch 9.1.0001: when closing window, wincmd p may fail Avoid `prevwin == curwin` when closing `curwin` Problem: When closing the current window (or when moving it to a tabpage), the previous window may refer to the new current window (`winnr() == winnr('#')`) if that window is selected as the new current window. Solution: Set `prevwin = NULL` when switching away from an invalid `curwin` and the target window was the `prevwin`. (Sean Dewar) related: #4537 closes: #13762 Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-03 18:52:52 +01:00
/**/
1,
updated for version 7.0001
2004-06-13 20:20:40 +00:00
/**/
0
};
updated for version 7.2-058
2008-11-30 11:15:09 +00:00
/*
* Place to put a short description when adding a feature with a patch.
* Keep it short, e.g.,: "relative numbers", "persistent undo".
* Also add a comment marker to separate the lines.
* See the official Vim patches for the diff format: It must use a context of
updated for version 7.2-075
2008-12-24 13:25:14 +00:00
* one line only. Create it by hand or use "diff -C2" and edit the patch.
updated for version 7.2-058
2008-11-30 11:15:09 +00:00
*/
static char *(extra_patches[]) =
{ /* Add your patch description below this line */
/**/
NULL
};
updated for version 7.0001
2004-06-13 20:20:40 +00:00
int
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
highest_patch(void)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
patch 8.1.1526: no numerical value for the patchlevel Problem: No numerical value for the patchlevel. Solution: Add v:versionlong.
2019-06-14 14:39:51 +02:00
// this relies on the highest patch number to be the first entry
return included_patches[0];
updated for version 7.0001
2004-06-13 20:20:40 +00:00
}
#if defined(FEAT_EVAL) || defined(PROTO)
/*
* Return TRUE if patch "n" has been included.
*/
int
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
has_patch(int n)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
patch 8.2.1973: finding a patch number can be a bit slow Problem: Finding a patch number can be a bit slow. Solution: Use binary search. (closes #7279)
2020-11-10 20:54:29 +01:00
int h, m, l;
updated for version 7.0001
2004-06-13 20:20:40 +00:00
patch 8.2.1973: finding a patch number can be a bit slow Problem: Finding a patch number can be a bit slow. Solution: Use binary search. (closes #7279)
2020-11-10 20:54:29 +01:00
// Perform a binary search.
l = 0;
patch 8.2.2922: computing array length is done in various ways Problem: Computing array length is done in various ways. Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305)
2021-06-02 13:28:16 +02:00
h = (int)ARRAY_LENGTH(included_patches) - 1;
patch 9.0.0010: returning 0 for has('patch-9.0.0') is inconsistent Problem: Returning 0 for has('patch-9.0.0') is inconsistent. Solution: Make it return 1. (closes #10640)
2022-06-30 11:03:39 +01:00
for (;;)
patch 8.2.1973: finding a patch number can be a bit slow Problem: Finding a patch number can be a bit slow. Solution: Use binary search. (closes #7279)
2020-11-10 20:54:29 +01:00
{
m = (l + h) / 2;
if (included_patches[m] == n)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
return TRUE;
patch 9.0.0010: returning 0 for has('patch-9.0.0') is inconsistent Problem: Returning 0 for has('patch-9.0.0') is inconsistent. Solution: Make it return 1. (closes #10640)
2022-06-30 11:03:39 +01:00
if (l == h)
break;
patch 8.2.1973: finding a patch number can be a bit slow Problem: Finding a patch number can be a bit slow. Solution: Use binary search. (closes #7279)
2020-11-10 20:54:29 +01:00
if (included_patches[m] < n)
h = m;
else
l = m + 1;
}
updated for version 7.0001
2004-06-13 20:20:40 +00:00
return FALSE;
}
#endif
void
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
ex_version(exarg_T *eap)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
/*
* Ignore a ":version 9.99" command.
*/
if (*eap->arg == NUL)
{
msg_putchar('\n');
list_version();
}
}
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
/*
* Output a string for the version message. If it's going to wrap, output a
* newline, unless the message is too long to fit on the screen anyway.
* When "wrap" is TRUE wrap the string in [].
*/
static void
version_msg_wrap(char_u *s, int wrap)
{
patch 8.2.3460: some type casts are not needed Problem: Some type casts are not needed. Solution: Remove unnecessary type casts. (closes #8934)
2021-10-02 11:26:51 +01:00
int len = vim_strsize(s) + (wrap ? 2 : 0);
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
if (!got_int && len < (int)Columns && msg_col + len >= (int)Columns
&& *s != '\n')
msg_putchar('\n');
if (!got_int)
{
if (wrap)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts("[");
msg_puts((char *)s);
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
if (wrap)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts("]");
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
}
}
static void
version_msg(char *s)
{
version_msg_wrap((char_u *)s, FALSE);
}
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
/*
* List all features aligned in columns, dictionary style.
*/
static void
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
list_features(void)
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
{
list_in_columns((char_u **)features, -1, -1);
}
/*
* List string items nicely aligned in columns.
* When "size" is < 0 then the last entry is marked with NULL.
* The entry with index "current" is inclosed in [].
*/
void
list_in_columns(char_u **items, int size, int current)
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
{
int i;
int ncol;
int nrow;
patch 8.1.1737: :args command that outputs one line gives more prompt Problem: :args command that outputs one line gives more prompt. Solution: Only output line break if needed. (Daniel Hahler, closes #4715)
2019-07-23 23:00:08 +02:00
int cur_row = 1;
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
int item_count = 0;
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
int width = 0;
patch 8.1.0680: not easy to see what features are unavailable Problem: Not easy to see what features are unavailable. Solution: Highlight disabled features in the :version output. (Nazri Ramliy, closes #3756)
2019-01-02 17:26:35 +01:00
#ifdef FEAT_SYN_HL
int use_highlight = (items == (char_u **)features);
#endif
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Find the length of the longest item, use that + 1 as the column
// width.
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
for (i = 0; size < 0 ? items[i] != NULL : i < size; ++i)
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
{
patch 8.2.3460: some type casts are not needed Problem: Some type casts are not needed. Solution: Remove unnecessary type casts. (closes #8934)
2021-10-02 11:26:51 +01:00
int l = vim_strsize(items[i]) + (i == current ? 2 : 0);
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
if (l > width)
width = l;
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
++item_count;
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
}
width += 1;
if (Columns < width)
{
patch 8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes #4737)
2019-07-27 21:23:45 +02:00
// Not enough screen columns - show one per line
patch 8.1.0404: accessing invalid memory with long argument name Problem: Accessing invalid memory with long argument name. Solution: Use item_count instead of checking for a terminating NULL. (Dominique Pelle, closes #3444)
2018-09-18 21:51:47 +02:00
for (i = 0; i < item_count; ++i)
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
{
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
version_msg_wrap(items[i], i == current);
patch 8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes #4737)
2019-07-27 21:23:45 +02:00
if (msg_col > 0 && i < item_count - 1)
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
msg_putchar('\n');
}
return;
}
patch 8.1.1737: :args command that outputs one line gives more prompt Problem: :args command that outputs one line gives more prompt. Solution: Only output line break if needed. (Daniel Hahler, closes #4715)
2019-07-23 23:00:08 +02:00
// The rightmost column doesn't need a separator.
// Sacrifice it to fit in one more column if possible.
updated for version 7.3.837 Problem: Empty lines in :version output when 'columns' is 320. Solution: Simplify the logic of making columns. (Nazri Ramliy, Roland Eggner)
2013-02-26 15:27:23 +01:00
ncol = (int) (Columns + 1) / width;
patch 8.2.4289: warnings reported by MSVC Problem: Warnings reported by MSVC. Solution: Rename variables and other fixes. (Ken Takata, closes #9689)
2022-02-03 13:33:03 +00:00
nrow = item_count / ncol + ((item_count % ncol) ? 1 : 0);
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
patch 8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes #4737)
2019-07-27 21:23:45 +02:00
// "i" counts columns then rows. "idx" counts rows then columns.
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
for (i = 0; !got_int && i < nrow * ncol; ++i)
{
int idx = (i / ncol) + (i % ncol) * nrow;
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
if (idx < item_count)
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
{
int last_col = (i + 1) % ncol == 0;
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
if (idx == current)
msg_putchar('[');
patch 8.1.0680: not easy to see what features are unavailable Problem: Not easy to see what features are unavailable. Solution: Highlight disabled features in the :version output. (Nazri Ramliy, closes #3756)
2019-01-02 17:26:35 +01:00
#ifdef FEAT_SYN_HL
if (use_highlight && items[idx][0] == '-')
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts_attr((char *)items[idx], HL_ATTR(HLF_W));
patch 8.1.0680: not easy to see what features are unavailable Problem: Not easy to see what features are unavailable. Solution: Highlight disabled features in the :version output. (Nazri Ramliy, closes #3756)
2019-01-02 17:26:35 +01:00
else
#endif
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts((char *)items[idx]);
patch 8.0.1738: ":args" output is hard to read Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line.
2018-04-20 22:01:41 +02:00
if (idx == current)
msg_putchar(']');
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
if (last_col)
{
patch 8.1.1737: :args command that outputs one line gives more prompt Problem: :args command that outputs one line gives more prompt. Solution: Only output line break if needed. (Daniel Hahler, closes #4715)
2019-07-23 23:00:08 +02:00
if (msg_col > 0 && cur_row < nrow)
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
msg_putchar('\n');
patch 8.1.1737: :args command that outputs one line gives more prompt Problem: :args command that outputs one line gives more prompt. Solution: Only output line break if needed. (Daniel Hahler, closes #4715)
2019-07-23 23:00:08 +02:00
++cur_row;
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
}
else
{
while (msg_col % width)
msg_putchar(' ');
}
}
patch 8.1.1748: :args output is not aligned Problem: :args output is not aligned. Solution: Output a line break after the last item in a row.
2019-07-25 21:52:39 +02:00
else
{
// this row is out of items, thus at the end of the row
patch 8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes #4737)
2019-07-27 21:23:45 +02:00
if (msg_col > 0)
{
if (cur_row < nrow)
msg_putchar('\n');
++cur_row;
}
patch 8.1.1748: :args output is not aligned Problem: :args output is not aligned. Solution: Output a line break after the last item in a row.
2019-07-25 21:52:39 +02:00
}
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
}
}
updated for version 7.3.832 Problem: Compiler warning. Solution: Add type cast. (Mike Williams)
2013-02-26 11:25:33 +01:00
updated for version 7.0001
2004-06-13 20:20:40 +00:00
void
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
list_version(void)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
int i;
int first;
char *s = "";
/*
* When adding features here, don't forget to update the list of
* internal variables in eval.c!
*/
patch 8.1.0103: long version string cannot be translated Problem: Long version string cannot be translated. Solution: Build the string in init_longVersion().
2018-06-23 16:12:21 +02:00
init_longVersion();
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg(longVersion);
patch 8.1.0941: macros for MS-Windows are inconsistent Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and others. Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the GUI build. (Hirohito Higashi, closes #3932)
2019-02-17 17:44:42 +01:00
#ifdef MSWIN
# ifdef FEAT_GUI_MSWIN
patch 8.1.1230: a lot of code is shared between vim.exe and gvim.exe Problem: A lot of code is shared between vim.exe and gvim.exe. Solution: Optionally put the shared code in vim.dll. (Ken Takata, closes #4287)
2019-04-28 19:46:49 +02:00
# ifdef VIMDLL
# ifdef _WIN64
msg_puts(_("\nMS-Windows 64-bit GUI/console version"));
# else
msg_puts(_("\nMS-Windows 32-bit GUI/console version"));
# endif
patch 8.0.0029 Problem: Code for MS-Windows is complicated because of the exceptions for old systems. Solution: Drop support for MS-Windows older than Windows XP. (Ken Takata)
2016-10-12 14:20:24 +02:00
# else
patch 8.1.1230: a lot of code is shared between vim.exe and gvim.exe Problem: A lot of code is shared between vim.exe and gvim.exe. Solution: Optionally put the shared code in vim.dll. (Ken Takata, closes #4287)
2019-04-28 19:46:49 +02:00
# ifdef _WIN64
msg_puts(_("\nMS-Windows 64-bit GUI version"));
# else
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nMS-Windows 32-bit GUI version"));
patch 8.1.1230: a lot of code is shared between vim.exe and gvim.exe Problem: A lot of code is shared between vim.exe and gvim.exe. Solution: Optionally put the shared code in vim.dll. (Ken Takata, closes #4287)
2019-04-28 19:46:49 +02:00
# endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# endif
patch 8.1.0941: macros for MS-Windows are inconsistent Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and others. Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the GUI build. (Hirohito Higashi, closes #3932)
2019-02-17 17:44:42 +01:00
# ifdef FEAT_OLE
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_(" with OLE support"));
patch 8.1.0941: macros for MS-Windows are inconsistent Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and others. Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the GUI build. (Hirohito Higashi, closes #3932)
2019-02-17 17:44:42 +01:00
# endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# else
updated for version 7.1-320
2008-06-20 14:32:41 +00:00
# ifdef _WIN64
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nMS-Windows 64-bit console version"));
updated for version 7.1-320
2008-06-20 14:32:41 +00:00
# else
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nMS-Windows 32-bit console version"));
updated for version 7.1-320
2008-06-20 14:32:41 +00:00
# endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# endif
#endif
patch 8.0.1236: Mac features are confusing Problem: Mac features are confusing. Solution: Make feature names more consistent, add "osxdarwin". Rename feature flags, cleanup Mac code. (Kazunobu Kuriyama, closes #2178)
2017-10-28 21:11:06 +02:00
#if defined(MACOS_X)
# if defined(MACOS_X_DARWIN)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nmacOS version"));
patch 8.0.1236: Mac features are confusing Problem: Mac features are confusing. Solution: Make feature names more consistent, add "osxdarwin". Rename feature flags, cleanup Mac code. (Kazunobu Kuriyama, closes #2178)
2017-10-28 21:11:06 +02:00
# else
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nmacOS version w/o darwin feat."));
updated for version 7.0001
2004-06-13 20:20:40 +00:00
# endif
patch 8.2.2174: Mac version doesn't specify the CPU architecture Problem: Mac version doesn't specify the CPU architecture. Solution: Add "arm64" or "x86_64". (Yee Cheng Chin, closes #7519)
2020-12-21 13:05:57 +01:00
# if defined(__arm64__)
msg_puts(" - arm64");
# elif defined(__x86_64__)
msg_puts(" - x86_64");
# endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
#ifdef VMS
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nOpenVMS version"));
updated for version 7.0-171
2006-11-28 16:43:58 +00:00
# ifdef HAVE_PATHDEF
if (*compiled_arch != NUL)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(" - ");
msg_puts((char *)compiled_arch);
updated for version 7.0-171
2006-11-28 16:43:58 +00:00
}
# endif
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Print the list of patch numbers if there is at least one.
// Print a range when patches are consecutive: "1-10, 12, 15-40, 42-45"
updated for version 7.0001
2004-06-13 20:20:40 +00:00
if (included_patches[0] != 0)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nIncluded patches: "));
updated for version 7.0001
2004-06-13 20:20:40 +00:00
first = -1;
patch 8.2.2922: computing array length is done in various ways Problem: Computing array length is done in various ways. Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305)
2021-06-02 13:28:16 +02:00
i = (int)ARRAY_LENGTH(included_patches) - 1;
updated for version 7.0001
2004-06-13 20:20:40 +00:00
while (--i >= 0)
{
if (first < 0)
first = included_patches[i];
if (i == 0 || included_patches[i - 1] != included_patches[i] + 1)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(s);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
s = ", ";
msg_outnum((long)first);
if (first != included_patches[i])
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts("-");
updated for version 7.0001
2004-06-13 20:20:40 +00:00
msg_outnum((long)included_patches[i]);
}
first = -1;
}
}
}
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Print the list of extra patch descriptions if there is at least one.
updated for version 7.2-058
2008-11-30 11:15:09 +00:00
if (extra_patches[0] != NULL)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nExtra patches: "));
updated for version 7.2-058
2008-11-30 11:15:09 +00:00
s = "";
for (i = 0; extra_patches[i] != NULL; ++i)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(s);
updated for version 7.2-058
2008-11-30 11:15:09 +00:00
s = ", ";
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(extra_patches[i]);
updated for version 7.2-058
2008-11-30 11:15:09 +00:00
}
}
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef MODIFIED_BY
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts("\n");
msg_puts(_("Modified by "));
msg_puts(MODIFIED_BY);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
#ifdef HAVE_PATHDEF
if (*compiled_user != NUL || *compiled_sys != NUL)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nCompiled "));
updated for version 7.0001
2004-06-13 20:20:40 +00:00
if (*compiled_user != NUL)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("by "));
msg_puts((char *)compiled_user);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
}
if (*compiled_sys != NUL)
{
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts("@");
msg_puts((char *)compiled_sys);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
}
}
#endif
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#if defined(FEAT_HUGE)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nHuge version "));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#elif defined(FEAT_NORMAL)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nNormal version "));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#else
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("\nTiny version "));
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#if !defined(FEAT_GUI)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("without GUI."));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#elif defined(FEAT_GUI_GTK)
# if defined(USE_GTK3)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("with GTK3 GUI."));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
# elif defined(FEAT_GUI_GNOME)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("with GTK2-GNOME GUI."));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
# else
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("with GTK2 GUI."));
patch 7.4.1402 Problem: GTK 3 is not supported. Solution: Add GTK 3 support. (Kazunobu Kuriyama)
2016-02-23 17:14:37 +01:00
# endif
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#elif defined(FEAT_GUI_MOTIF)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("with X11-Motif GUI."));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#elif defined(FEAT_GUI_HAIKU)
patch 8.2.0320: no Haiku support Problem: No Haiku support. Solution: Add support for Haiku. (Emir Sari, closes #5605)
2020-02-26 16:16:53 +01:00
msg_puts(_("with Haiku GUI."));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#elif defined(FEAT_GUI_PHOTON)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("with Photon GUI."));
patch 8.2.4694: avoidance of #elif causes more preproc nesting Problem: Avoidance of #elif causes more preproc nesting. Solution: Use #elif where it is useful. (Ozaki Kiichi, closes #10081)
2022-04-05 14:18:44 +01:00
#elif defined(MSWIN)
patch 8.1.0779: argument for message functions is inconsistent Problem: Argument for message functions is inconsistent. Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
msg_puts(_("with GUI."));
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
version_msg(_(" Features included (+) or not (-):\n"));
updated for version 7.3.826 Problem: List of features in :version output is hard to read. Solution: Make columns. (Nazri Ramliy)
2013-02-20 16:47:36 +01:00
list_features();
patch 8.1.1750: depending on the terminal width :version may miss a line break Problem: Depending on the terminal width :version may miss a line break. Solution: Add a line break when needed.
2019-07-26 19:48:19 +02:00
if (msg_col > 0)
msg_putchar('\n');
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef SYS_VIMRC_FILE
version_msg(_(" system vimrc file: \""));
version_msg(SYS_VIMRC_FILE);
version_msg("\"\n");
#endif
#ifdef USR_VIMRC_FILE
version_msg(_(" user vimrc file: \""));
version_msg(USR_VIMRC_FILE);
version_msg("\"\n");
#endif
#ifdef USR_VIMRC_FILE2
version_msg(_(" 2nd user vimrc file: \""));
version_msg(USR_VIMRC_FILE2);
version_msg("\"\n");
#endif
patch 9.1.0337: Missing entry for XDG vimrc file in :version Problem: Missing entry for XDG vimrc file in :version Solution: Add 4th user vimrc entry to :version output (Diego Viola) related: #14182 closes: #14569 Signed-off-by: Diego Viola <diego.viola@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 20:58:45 +02:00
#if defined(USR_VIMRC_FILE3) && defined(XDG_VIMRC_FILE)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
version_msg(_(" 3rd user vimrc file: \""));
version_msg(USR_VIMRC_FILE3);
version_msg("\"\n");
patch 9.1.0337: Missing entry for XDG vimrc file in :version Problem: Missing entry for XDG vimrc file in :version Solution: Add 4th user vimrc entry to :version output (Diego Viola) related: #14182 closes: #14569 Signed-off-by: Diego Viola <diego.viola@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-04-16 20:58:45 +02:00
version_msg(_(" 4th user vimrc file: \""));
version_msg((char *)(XDG_VIMRC_FILE));
version_msg("\"\n");
#elif defined(USR_VIMRC_FILE3)
version_msg(_(" 3rd user vimrc file: \""));
version_msg(USR_VIMRC_FILE3);
version_msg("\"\n");
#elif defined(XDG_VIMRC_FILE)
version_msg(_(" 3rd user vimrc file: \""));
version_msg((char *)(XDG_VIMRC_FILE));
version_msg("\"\n");
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#endif
#ifdef USR_EXRC_FILE
version_msg(_(" user exrc file: \""));
version_msg(USR_EXRC_FILE);
version_msg("\"\n");
#endif
#ifdef USR_EXRC_FILE2
version_msg(_(" 2nd user exrc file: \""));
version_msg(USR_EXRC_FILE2);
version_msg("\"\n");
#endif
#ifdef FEAT_GUI
# ifdef SYS_GVIMRC_FILE
version_msg(_(" system gvimrc file: \""));
version_msg(SYS_GVIMRC_FILE);
version_msg("\"\n");
# endif
version_msg(_(" user gvimrc file: \""));
version_msg(USR_GVIMRC_FILE);
version_msg("\"\n");
# ifdef USR_GVIMRC_FILE2
version_msg(_("2nd user gvimrc file: \""));
version_msg(USR_GVIMRC_FILE2);
version_msg("\"\n");
# endif
# ifdef USR_GVIMRC_FILE3
version_msg(_("3rd user gvimrc file: \""));
version_msg(USR_GVIMRC_FILE3);
version_msg("\"\n");
# endif
#endif
patch 7.4.2111 Problem: Defaults are very conservative. Solution: Move settings from vimrc_example.vim to defaults.vim. Load defaults.vim if no .vimrc was found.
2016-07-28 22:24:15 +02:00
version_msg(_(" defaults file: \""));
version_msg(VIM_DEFAULTS_FILE);
version_msg("\"\n");
updated for version 7.0001
2004-06-13 20:20:40 +00:00
#ifdef FEAT_GUI
# ifdef SYS_MENU_FILE
version_msg(_(" system menu file: \""));
version_msg(SYS_MENU_FILE);
version_msg("\"\n");
# endif
#endif
#ifdef HAVE_PATHDEF
if (*default_vim_dir != NUL)
{
version_msg(_(" fall-back for $VIM: \""));
version_msg((char *)default_vim_dir);
version_msg("\"\n");
}
if (*default_vimruntime_dir != NUL)
{
version_msg(_(" f-b for $VIMRUNTIME: \""));
version_msg((char *)default_vimruntime_dir);
version_msg("\"\n");
}
version_msg(_("Compilation: "));
version_msg((char *)all_cflags);
version_msg("\n");
#ifdef VMS
if (*compiler_version != NUL)
{
version_msg(_("Compiler: "));
version_msg((char *)compiler_version);
version_msg("\n");
}
#endif
version_msg(_("Linking: "));
version_msg((char *)all_lflags);
#endif
#ifdef DEBUG
version_msg("\n");
version_msg(_(" DEBUG BUILD"));
#endif
}
patch 7.4.1199 Problem: Still using __ARGS. Solution: Remove __ARGS in several files. (script by Hirohito Higashi)
2016-01-29 22:47:03 +01:00
static void do_intro_line(int row, char_u *mesg, int add_version, int attr);
patch 8.2.0514: several global functions are used in only one file Problem: Several global functions are used in only one file. Solution: Make the functions static. (Yegappan Lakshmanan, closes #5884)
2020-04-05 18:56:05 +02:00
static void intro_message(int colon);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
updated for version 7.3.1306 Problem: When redrawing the screen during startup the intro message may be cleared. Solution: Redisplay the intro message when appropriate.
2013-07-04 22:31:03 +02:00
/*
* Show the intro message when not editing a file.
*/
void
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
maybe_intro_message(void)
updated for version 7.3.1306 Problem: When redrawing the screen during startup the intro message may be cleared. Solution: Redisplay the intro message when appropriate.
2013-07-04 22:31:03 +02:00
{
patch 8.0.0448: some macros are in lower case Problem: Some macros are in lower case, which can be confusing. Solution: Make a few lower case macros upper case.
2017-03-12 18:23:53 +01:00
if (BUFEMPTY()
updated for version 7.3.1306 Problem: When redrawing the screen during startup the intro message may be cleared. Solution: Redisplay the intro message when appropriate.
2013-07-04 22:31:03 +02:00
&& curbuf->b_fname == NULL
&& firstwin->w_next == NULL
&& vim_strchr(p_shm, SHM_INTRO) == NULL)
intro_message(FALSE);
}
updated for version 7.0001
2004-06-13 20:20:40 +00:00
/*
* Give an introductory message about Vim.
* Only used when starting Vim on an empty file, without a file name.
* Or with the ":intro" command (for Sven :-).
*/
patch 8.2.0514: several global functions are used in only one file Problem: Several global functions are used in only one file. Solution: Make the functions static. (Yegappan Lakshmanan, closes #5884)
2020-04-05 18:56:05 +02:00
static void
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
intro_message(
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
int colon) // TRUE for ":intro"
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
int i;
int row;
int blanklines;
int sponsor;
char *p;
static char *(lines[]) =
{
N_("VIM - Vi IMproved"),
"",
N_("version "),
N_("by Bram Moolenaar et al."),
#ifdef MODIFIED_BY
" ",
#endif
N_("Vim is open source and freely distributable"),
"",
N_("Help poor children in Uganda!"),
N_("type :help iccf<Enter> for information "),
"",
N_("type :q<Enter> to exit "),
N_("type :help<Enter> or <F1> for on-line help"),
patch 8.2.5154: still mentioning version8, some cosmetic issues Problem: Still mentioning version8, some cosmetic issues. Solution: Prefer mentioning version9, cosmetic improvements.
2022-06-23 20:46:27 +01:00
N_("type :help version9<Enter> for version info"),
updated for version 7.0001
2004-06-13 20:20:40 +00:00
NULL,
"",
N_("Running in Vi compatible mode"),
N_("type :set nocp<Enter> for Vim defaults"),
N_("type :help cp-default<Enter> for info on this"),
};
#ifdef FEAT_GUI
static char *(gui_lines[]) =
{
NULL,
NULL,
NULL,
NULL,
#ifdef MODIFIED_BY
NULL,
#endif
NULL,
NULL,
NULL,
N_("menu Help->Orphans for information "),
NULL,
N_("Running modeless, typed text is inserted"),
N_("menu Edit->Global Settings->Toggle Insert Mode "),
N_(" for two modes "),
NULL,
NULL,
NULL,
N_("menu Edit->Global Settings->Toggle Vi Compatible"),
N_(" for Vim defaults "),
};
#endif
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// blanklines = screen height - # message lines
patch 8.2.2922: computing array length is done in various ways Problem: Computing array length is done in various ways. Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305)
2021-06-02 13:28:16 +02:00
blanklines = (int)Rows - (ARRAY_LENGTH(lines) - 1);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
if (!p_cp)
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
blanklines += 4; // add 4 for not showing "Vi compatible" message
updated for version 7.0001
2004-06-13 20:20:40 +00:00
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Don't overwrite a statusline. Depends on 'cmdheight'.
updated for version 7.0001
2004-06-13 20:20:40 +00:00
if (p_ls > 1)
blanklines -= Rows - topframe->fr_height;
if (blanklines < 0)
blanklines = 0;
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Show the sponsor and register message one out of four times, the Uganda
// message two out of four times.
updated for version 7.0175
2005-12-22 22:47:02 +00:00
sponsor = (int)time(NULL);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
sponsor = ((sponsor & 2) == 0) - ((sponsor & 4) == 0);
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// start displaying the message lines after half of the blank lines
updated for version 7.0001
2004-06-13 20:20:40 +00:00
row = blanklines / 2;
if ((row >= 2 && Columns >= 50) || colon)
{
patch 8.2.2922: computing array length is done in various ways Problem: Computing array length is done in various ways. Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305)
2021-06-02 13:28:16 +02:00
for (i = 0; i < (int)ARRAY_LENGTH(lines); ++i)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
p = lines[i];
#ifdef FEAT_GUI
if (p_im && gui.in_use && gui_lines[i] != NULL)
p = gui_lines[i];
#endif
if (p == NULL)
{
if (!p_cp)
break;
continue;
}
if (sponsor != 0)
{
if (strstr(p, "children") != NULL)
p = sponsor < 0
? N_("Sponsor Vim development!")
: N_("Become a registered Vim user!");
else if (strstr(p, "iccf") != NULL)
p = sponsor < 0
? N_("type :help sponsor<Enter> for information ")
: N_("type :help register<Enter> for information ");
else if (strstr(p, "Orphans") != NULL)
p = N_("menu Help->Sponsor/Register for information ");
}
if (*p != NUL)
do_intro_line(row, (char_u *)_(p), i == 2, 0);
++row;
}
}
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Make the wait-return message appear just below the text.
updated for version 7.0001
2004-06-13 20:20:40 +00:00
if (colon)
msg_row = row;
}
static void
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
do_intro_line(
int row,
char_u *mesg,
int add_version,
int attr)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
char_u vers[20];
int col;
char_u *p;
int l;
int clen;
#ifdef MODIFIED_BY
# define MODBY_LEN 150
char_u modby[MODBY_LEN];
if (*mesg == ' ')
{
updated for version 7.1-206
2008-01-05 12:59:22 +00:00
vim_strncpy(modby, (char_u *)_("Modified by "), MODBY_LEN - 1);
patch 7.4.1863 Problem: Compiler warnings on Win64. Solution: Adjust types, add type casts. (Ken Takata)
2016-06-01 20:31:43 +02:00
l = (int)STRLEN(modby);
updated for version 7.1-206
2008-01-05 12:59:22 +00:00
vim_strncpy(modby + l, (char_u *)MODIFIED_BY, MODBY_LEN - l - 1);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
mesg = modby;
}
#endif
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Center the message horizontally.
updated for version 7.0001
2004-06-13 20:20:40 +00:00
col = vim_strsize(mesg);
if (add_version)
{
STRCPY(vers, mediumVersion);
if (highest_patch())
{
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Check for 9.9x or 9.9xx, alpha/beta version
patch 9.1.0006: is*() and to*() function may be unsafe Problem: is*() and to*() function may be unsafe Solution: Add SAFE_* macros and start using those instead (Keith Thompson) Use SAFE_() macros for is*() and to*() functions The standard is*() and to*() functions declared in <ctype.h> have undefined behavior for negative arguments other than EOF. If plain char is signed, passing an unchecked value from argv for from user input to one of these functions has undefined behavior. Solution: Add SAFE_*() macros that cast the argument to unsigned char. Most implementations behave sanely for negative arguments, and most character values in practice are non-negative, but it's still best to avoid undefined behavior. The change from #13347 has been omitted, as this has already been separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a (v9.0.2054) fixes: #13332 closes: #13347 Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 21:19:04 +01:00
if (SAFE_isalpha((int)vers[3]))
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
patch 9.1.0006: is*() and to*() function may be unsafe Problem: is*() and to*() function may be unsafe Solution: Add SAFE_* macros and start using those instead (Keith Thompson) Use SAFE_() macros for is*() and to*() functions The standard is*() and to*() functions declared in <ctype.h> have undefined behavior for negative arguments other than EOF. If plain char is signed, passing an unchecked value from argv for from user input to one of these functions has undefined behavior. Solution: Add SAFE_*() macros that cast the argument to unsigned char. Most implementations behave sanely for negative arguments, and most character values in practice are non-negative, but it's still best to avoid undefined behavior. The change from #13347 has been omitted, as this has already been separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a (v9.0.2054) fixes: #13332 closes: #13347 Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-04 21:19:04 +01:00
int len = (SAFE_isalpha((int)vers[4])) ? 5 : 4;
updated for version 7.3.464 Problem: Compiler warning for sprintf. Solution: Put the length in a variable. (Dominique Pelle)
2012-03-07 18:03:10 +01:00
sprintf((char *)vers + len, ".%d%s", highest_patch(),
mediumVersion + len);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
}
else
sprintf((char *)vers + 3, ".%d", highest_patch());
}
col += (int)STRLEN(vers);
}
col = (Columns - col) / 2;
if (col < 0)
col = 0;
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Split up in parts to highlight <> items differently.
updated for version 7.0001
2004-06-13 20:20:40 +00:00
for (p = mesg; *p != NUL; p += l)
{
clen = 0;
for (l = 0; p[l] != NUL
&& (l == 0 || (p[l] != '<' && p[l - 1] != '>')); ++l)
{
if (has_mbyte)
{
clen += ptr2cells(p + l);
updated for version 7.0127
2005-08-10 21:07:57 +00:00
l += (*mb_ptr2len)(p + l) - 1;
updated for version 7.0001
2004-06-13 20:20:40 +00:00
}
else
clen += byte2cells(p[l]);
}
patch 8.0.0466: still macros that should be all-caps Problem: There are still a few macros that should be all-caps. Solution: Make a few more macros all-caps.
2017-03-16 17:23:31 +01:00
screen_puts_len(p, l, row, col, *p == '<' ? HL_ATTR(HLF_8) : attr);
updated for version 7.0001
2004-06-13 20:20:40 +00:00
col += clen;
}
patch 8.2.0027: still some /* */ comments Problem: Still some /* */ comments. Solution: Convert to // comments.
2019-12-21 18:47:26 +01:00
// Add the version number to the version line.
updated for version 7.0001
2004-06-13 20:20:40 +00:00
if (add_version)
screen_puts(vers, row, col, 0);
}
/*
* ":intro": clear screen, display intro screen and wait for return.
*/
void
patch 7.4.1215 Problem: Using old style function declarations. Solution: Change to new style function declarations. (script by Hirohito Higashi)
2016-01-30 21:29:58 +01:00
ex_intro(exarg_T *eap UNUSED)
updated for version 7.0001
2004-06-13 20:20:40 +00:00
{
screenclear();
intro_message(TRUE);
wait_return(TRUE);
}
Copy Permalink