mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-30 06:38:37 -04:00 
			
		
		
		
	- Change CreateVariable API response status from 204 No Content to 201 Created - Update related integration tests to expect 201 Created instead of 204 No Content ## ⚠️ BREAKING ⚠️ Change the response status code of the Create Variable API under both Org and Repo levels to `201` instead of 204. API SDK: https://gitea.com/gitea/go-sdk/pulls/713 --------- Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> Signed-off-by: appleboy <appleboy.tw@gmail.com> Co-authored-by: delvh <dev.lh@web.de>
		
			
				
	
	
		
			144 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			144 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2024 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package integration
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"testing"
 | |
| 
 | |
| 	auth_model "code.gitea.io/gitea/models/auth"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/tests"
 | |
| )
 | |
| 
 | |
| func TestAPIUserVariables(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	session := loginUser(t, "user1")
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteUser)
 | |
| 
 | |
| 	t.Run("CreateUserVariable", func(t *testing.T) {
 | |
| 		cases := []struct {
 | |
| 			Name           string
 | |
| 			ExpectedStatus int
 | |
| 		}{
 | |
| 			{
 | |
| 				Name:           "-",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "_",
 | |
| 				ExpectedStatus: http.StatusCreated,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "TEST_VAR",
 | |
| 				ExpectedStatus: http.StatusCreated,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "test_var",
 | |
| 				ExpectedStatus: http.StatusConflict,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "ci",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "123var",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "var@test",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "github_var",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "gitea_var",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 		}
 | |
| 
 | |
| 		for _, c := range cases {
 | |
| 			req := NewRequestWithJSON(t, "POST", "/api/v1/user/actions/variables/"+c.Name, api.CreateVariableOption{
 | |
| 				Value: "value",
 | |
| 			}).AddTokenAuth(token)
 | |
| 			MakeRequest(t, req, c.ExpectedStatus)
 | |
| 		}
 | |
| 	})
 | |
| 
 | |
| 	t.Run("UpdateUserVariable", func(t *testing.T) {
 | |
| 		variableName := "test_update_var"
 | |
| 		url := "/api/v1/user/actions/variables/" + variableName
 | |
| 		req := NewRequestWithJSON(t, "POST", url, api.CreateVariableOption{
 | |
| 			Value: "initial_val",
 | |
| 		}).AddTokenAuth(token)
 | |
| 		MakeRequest(t, req, http.StatusCreated)
 | |
| 
 | |
| 		cases := []struct {
 | |
| 			Name           string
 | |
| 			UpdateName     string
 | |
| 			ExpectedStatus int
 | |
| 		}{
 | |
| 			{
 | |
| 				Name:           "not_found_var",
 | |
| 				ExpectedStatus: http.StatusNotFound,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           variableName,
 | |
| 				UpdateName:     "1invalid",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           variableName,
 | |
| 				UpdateName:     "invalid@name",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           variableName,
 | |
| 				UpdateName:     "ci",
 | |
| 				ExpectedStatus: http.StatusBadRequest,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           variableName,
 | |
| 				UpdateName:     "updated_var_name",
 | |
| 				ExpectedStatus: http.StatusNoContent,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           variableName,
 | |
| 				ExpectedStatus: http.StatusNotFound,
 | |
| 			},
 | |
| 			{
 | |
| 				Name:           "updated_var_name",
 | |
| 				ExpectedStatus: http.StatusNoContent,
 | |
| 			},
 | |
| 		}
 | |
| 
 | |
| 		for _, c := range cases {
 | |
| 			req := NewRequestWithJSON(t, "PUT", "/api/v1/user/actions/variables/"+c.Name, api.UpdateVariableOption{
 | |
| 				Name:  c.UpdateName,
 | |
| 				Value: "updated_val",
 | |
| 			}).AddTokenAuth(token)
 | |
| 			MakeRequest(t, req, c.ExpectedStatus)
 | |
| 		}
 | |
| 	})
 | |
| 
 | |
| 	t.Run("DeleteRepoVariable", func(t *testing.T) {
 | |
| 		variableName := "test_delete_var"
 | |
| 		url := "/api/v1/user/actions/variables/" + variableName
 | |
| 
 | |
| 		req := NewRequestWithJSON(t, "POST", url, api.CreateVariableOption{
 | |
| 			Value: "initial_val",
 | |
| 		}).AddTokenAuth(token)
 | |
| 		MakeRequest(t, req, http.StatusCreated)
 | |
| 
 | |
| 		req = NewRequest(t, "DELETE", url).AddTokenAuth(token)
 | |
| 		MakeRequest(t, req, http.StatusNoContent)
 | |
| 
 | |
| 		req = NewRequest(t, "DELETE", url).AddTokenAuth(token)
 | |
| 		MakeRequest(t, req, http.StatusNotFound)
 | |
| 	})
 | |
| }
 |