aniani/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-10-31 11:07:18 -04:00
Code Activity

Add missing transaction when set merge (#33113)

Browse Source 
backport from #33079 

`SetMerged` should be in a database transaction otherwise it's possible
to have dirty data.
This commit is contained in:
Lunny Xiao
2025-01-06 10:21:14 -08:00
committed by GitHub
parent 0fad40dd8c
commit 9899989ece
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
services/pull/check.go
View File

@@ -301,10 +301,15 @@ func manuallyMerged(ctx context.Context, pr *issues_model.PullRequest) bool {
pr.Merger = merger pr.Merger = merger
pr.MergerID = merger.ID pr.MergerID = merger.ID
if err := db.WithTx(ctx, func(ctx context.Context) error {
if merged, err := pr.SetMerged(ctx); err != nil { if merged, err := pr.SetMerged(ctx); err != nil {
log.Error("%-v setMerged : %v", pr, err) return err
return false
} else if !merged { } else if !merged {
return errors.New("setMerged failed")
}
return nil
}); err != nil {
log.Error("%-v setMerged : %v", pr, err)
return false return false
} }