Remove optionality from session socket

Co-Authored-By: Nicola Thouliss <53867736+nthouliss@users.noreply.github.com>

src/network/NetworkedMapAndTokens.tsx

@@ -202,12 +202,12 @@ function NetworkedMapAndTokens({ session }: { session: Session }) {
   ) {
     // Clear map before sending new one
     setCurrentMap(null);
-    session.socket?.emit("map", null);
+    session.socket.emit("map", null);
 
     setCurrentMapState(newMapState, true, true);
     setCurrentMap(newMap);
 
-    session.socket?.emit("map", newMap);
+    session.socket.emit("map", newMap);
 
     if (!newMap || !newMapState) {
       setAssetManifest(null, true, true);
@@ -395,12 +395,12 @@ function NetworkedMapAndTokens({ session }: { session: Session }) {
 
     session.on("peerData", handlePeerData);
     session.on("peerDataProgress", handlePeerDataProgress);
-    session.socket?.on("map", handleSocketMap);
+    session.socket.on("map", handleSocketMap);
 
     return () => {
       session.off("peerData", handlePeerData);
       session.off("peerDataProgress", handlePeerDataProgress);
-      session.socket?.off("map", handleSocketMap);
+      session.socket.off("map", handleSocketMap);
     };
   });
 

src/network/NetworkedMapPointer.tsx

@@ -152,10 +152,10 @@ function NetworkedMapPointer({ session, active }: NetworkedMapPointerProps) {
       }
     }
 
-    session.socket?.on("player_pointer", handleSocketPlayerPointer);
+    session.socket.on("player_pointer", handleSocketPlayerPointer);
 
     return () => {
-      session.socket?.off("player_pointer", handleSocketPlayerPointer);
+      session.socket.off("player_pointer", handleSocketPlayerPointer);
     };
   }, [session]);
 

src/network/Session.ts

@@ -1,4 +1,4 @@
-import io, { Socket } from "socket.io-client";
+import io from "socket.io-client";
 import msgParser from "socket.io-msgpack-parser";
 import { EventEmitter } from "events";
 
@@ -32,10 +32,11 @@ export type PeerReply = (id: string, data: PeerData, chunkId?: string) => void;
 class Session extends EventEmitter {
   /**
    * The socket io connection
-   *
-   * @type {io.Socket}
    */
-  socket?: Socket;
+  socket = io(process.env.REACT_APP_BROKER_URL!, {
+    withCredentials: true,
+    parser: msgParser,
+  });
 
   /**
    * A mapping of socket ids to session peers
@@ -45,7 +46,7 @@ class Session extends EventEmitter {
   peers: Record<string, SessionPeer>;
 
   get id() {
-    return this.socket?.id || "";
+    return this.socket.id;
   }
 
   _iceServers: RTCIceServer[] = [];
@@ -76,14 +77,6 @@ class Session extends EventEmitter {
       const data = await response.json();
       this._iceServers = data.iceServers;
 
-      if (!process.env.REACT_APP_BROKER_URL) {
-        return;
-      }
-      this.socket = io(process.env.REACT_APP_BROKER_URL, {
-        withCredentials: true,
-        parser: msgParser,
-      });
-
       this.socket.on("player_joined", this._handlePlayerJoined.bind(this));
       this.socket.on("player_left", this._handlePlayerLeft.bind(this));
       this.socket.on("joined_game", this._handleJoinedGame.bind(this));
@@ -102,7 +95,7 @@ class Session extends EventEmitter {
   }
 
   disconnect() {
-    this.socket?.disconnect();
+    this.socket.disconnect();
   }
 
   /**
@@ -191,7 +184,7 @@ class Session extends EventEmitter {
 
     this._gameId = gameId;
     this._password = password;
-    this.socket?.emit(
+    this.socket.emit(
       "join_game",
       gameId,
       password,
@@ -224,7 +217,7 @@ class Session extends EventEmitter {
       };
 
       const handleSignal = (signal: SignalData) => {
-        this.socket?.emit("signal", JSON.stringify({ to: peer.id, signal }));
+        this.socket.emit("signal", JSON.stringify({ to: peer.id, signal }));
       };
 
       const handleConnect = () => {
@@ -373,7 +366,7 @@ class Session extends EventEmitter {
   }
 
   _handleForceUpdate() {
-    this.socket?.disconnect();
+    this.socket.disconnect();
     this.emit("status", "needs_update");
   }
 }